[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev updated this revision to Diff 108533. v.g.vassilev marked 6 inline comments as done. v.g.vassilev added a comment. Address some of the comments. https://reviews.llvm.org/D35056 Files: include/clang/AST/DeclCXX.h lib/AST/ASTImporter.cpp lib/AST/DeclCXX.cpp

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev updated this revision to Diff 108505. v.g.vassilev added a comment. Move the checks in Sema. https://reviews.llvm.org/D35056 Files: include/clang/AST/DeclCXX.h lib/AST/ASTImporter.cpp lib/AST/DeclCXX.cpp lib/CodeGen/CGCXXABI.cpp lib/CodeGen/ItaniumCXXABI.cpp

[PATCH] D34444: Teach codegen to work in incremental processing mode.

v.g.vassilev added a comment. In https://reviews.llvm.org/D3#818030, @rjmccall wrote: > In https://reviews.llvm.org/D3#812836, @v.g.vassilev wrote: > > > In https://reviews.llvm.org/D3#812418, @rjmccall wrote: > > > > > In https://reviews.llvm.org/D3#795175, @v.g.vassilev wrote:

[PATCH] D34444: Teach codegen to work in incremental processing mode.

v.g.vassilev added a comment. In https://reviews.llvm.org/D3#812418, @rjmccall wrote: > In https://reviews.llvm.org/D3#795175, @v.g.vassilev wrote: > > > @rjmccall, thanks for the prompt and thorough reply. > > > > In https://reviews.llvm.org/D3#793311, @rjmccall wrote: > > > > >

[PATCH] D35536: Don't set TUScope to null when generating a module in incremental processing mode.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. I think we can rely on a post-commit review here. LGTM! https://reviews.llvm.org/D35536 ___ cfe-commits mailing list

[PATCH] D35527: [CMake] Move CLANG_ENABLE_(ARCMT|OBJC_REWRITER|STATIC_ANALYZER) into clang/Config/config.h.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! Repository: rL LLVM https://reviews.llvm.org/D35527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev updated this revision to Diff 105776. v.g.vassilev added a comment. Remove accidentally added change in SemaDecl.cpp https://reviews.llvm.org/D35056 Files: include/clang/AST/DeclCXX.h lib/AST/ASTImporter.cpp lib/AST/DeclCXX.cpp lib/CodeGen/CGCXXABI.cpp

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev updated this revision to Diff 105775. v.g.vassilev added a comment. Compute only once if there is a non-deleted move or copy constructor and store them in the `DefinitionData` of the `CXXRecordDecl`. https://reviews.llvm.org/D35056 Files: include/clang/AST/DeclCXX.h

[PATCH] D33275: Keep into account if files were virtual.

v.g.vassilev added a comment. @rsmith suggested to move this one interface layer down, that is `ContentCache::getBuffer`. Moving it there might fix more issues. I will try to improve it and land the new version if that's not urgent for you. https://reviews.llvm.org/D33275

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev created this revision. Patch by Bernd Schmidt! Fixes PR19668 and PR23034. Repository: rL LLVM https://reviews.llvm.org/D35056 Files: lib/CodeGen/CGCXXABI.cpp lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/uncopyable-args.cpp Index: test/CodeGenCXX/uncopyable-args.cpp

[PATCH] D34927: [Bash-autocompletion] Fix a bug that -foo=bar doesn't handled properly

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D34927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34985: Do not read the file to determine its name.

v.g.vassilev added a comment. The test case could be shared from PR33688: echo 'void* func(char* p) __attribute__((annotate("blah"))); void* func(char* p){return p;}' > HEADER.h clang++ -std=c++14 -x c++-header -o HEADER.h.pch HEADER.h chmod a-r HEADER.h echo 'char i;

[PATCH] D34985: Do not read the file to determine its name.

v.g.vassilev created this revision. Patch by Axel Naumann! Repository: rL LLVM https://reviews.llvm.org/D34985 Files: lib/Basic/SourceManager.cpp Index: lib/Basic/SourceManager.cpp === --- lib/Basic/SourceManager.cpp +++

[PATCH] D34984: Store token literal data in PCH. Avoids disk read on PreProc expansion.

v.g.vassilev added a subscriber: karies. v.g.vassilev added a comment. What would be the best way to test this. Shall we put: echo '#define LITERAL 42' > HEADER.h clang++ -std=c++14 -x c++-header -o HEADER.h.pch HEADER.h chmod a-r HEADER.h echo 'void f(int); void g() { f(12); }'

[PATCH] D34984: Store token literal data in PCH. Avoids disk read on PreProc expansion.

v.g.vassilev created this revision. Patch by Axel Naumann! Repository: rL LLVM https://reviews.llvm.org/D34984 Files: include/clang/Serialization/ASTReader.h lib/Serialization/ASTReader.cpp lib/Serialization/ASTWriter.cpp Index: lib/Serialization/ASTWriter.cpp

[PATCH] D34444: Teach codegen to work in incremental processing mode.

v.g.vassilev added a comment. ping... Repository: rL LLVM https://reviews.llvm.org/D3 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34912: Handle cases where the value is too large to fit into the underlying type.

v.g.vassilev updated this revision to Diff 105172. v.g.vassilev added a comment. Add test case. https://reviews.llvm.org/D34912 Files: lib/AST/TemplateBase.cpp test/SemaTemplate/temp_arg_nontype.cpp Index: test/SemaTemplate/temp_arg_nontype.cpp

[PATCH] D34510: Teach clang how to merge typedef over anonymous structs in C mode.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r306964. Repository: rL LLVM https://reviews.llvm.org/D34510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. It looks like this works with bash 3.2. I've tested this on mac and it works well. https://reviews.llvm.org/D34924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34925: [Bash-completion] Fixed a bug that ~ doesn't expanded to $HOME

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. That fixes my issue. LGTM. https://reviews.llvm.org/D34925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34891: Replace assert(0) with llvm_unreachable.

v.g.vassilev added a comment. Sure, I can do this, as long as this semantic change is ok. Repository: rL LLVM https://reviews.llvm.org/D34891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34891: Replace assert(0) with llvm_unreachable.

v.g.vassilev added a comment. Ok, thanks! I was hesitant for the changes in libclang, because of the return statements. Repository: rL LLVM https://reviews.llvm.org/D34891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34912: Handle cases where the value is too large to fit into the underlying type.

v.g.vassilev planned changes to this revision. v.g.vassilev added a comment. Waiting for @karies for a test case. Repository: rL LLVM https://reviews.llvm.org/D34912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34912: Handle cases where the value is too large to fit into the underlying type.

v.g.vassilev created this revision. Patch by Axel Naumann! Repository: rL LLVM https://reviews.llvm.org/D34912 Files: lib/AST/TemplateBase.cpp Index: lib/AST/TemplateBase.cpp === --- lib/AST/TemplateBase.cpp +++

[PATCH] D34891: Replace assert(0) with llvm_unreachable.

v.g.vassilev created this revision. Repository: rL LLVM https://reviews.llvm.org/D34891 Files: include/clang/AST/Redeclarable.h lib/AST/ExprConstant.cpp lib/Basic/SourceManager.cpp lib/Lex/PreprocessingRecord.cpp lib/Sema/SemaType.cpp lib/Serialization/ASTReader.cpp

[PATCH] D34444: Teach codegen to work in incremental processing mode.

v.g.vassilev added a subscriber: karies. v.g.vassilev added a comment. @rjmccall, thanks for the prompt and thorough reply. In https://reviews.llvm.org/D3#793311, @rjmccall wrote: > Okay. In that case, I see two problems, one major and one potentially major. This is a very accurate

[PATCH] D34510: Teach clang how to merge typedef over anonymous structs in C mode.

v.g.vassilev added a comment. @bruno ping... Repository: rL LLVM https://reviews.llvm.org/D34510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34761: [Bash-autocompletion] Invoke clang where user called

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D34761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34444: Teach codegen to work in incremental processing mode.

v.g.vassilev added a comment. We use them as separate translation units due to the fact that we need to survive multiple calls to `HandleEndOfTranslationUnit`. This 'finalizes' the module, and we cannot write to it anymore. Even though we could write to it (this was the case when we were using

[PATCH] D34059: Get the file name for the symbol from the Module, not the SourceManager.

v.g.vassilev updated this revision to Diff 103572. v.g.vassilev added a comment. Update test file comment. https://reviews.llvm.org/D34059 Files: lib/CodeGen/CGDeclCXX.cpp unittests/CodeGen/CMakeLists.txt unittests/CodeGen/IncrementalProcessingTest.cpp Index:

[PATCH] D34059: Get the file name for the symbol from the Module, not the SourceManager.

v.g.vassilev updated this revision to Diff 103566. v.g.vassilev added a comment. Herald added a subscriber: mgorny. Add a test case. https://reviews.llvm.org/D34059 Files: lib/CodeGen/CGDeclCXX.cpp unittests/CodeGen/CMakeLists.txt unittests/CodeGen/IncrementalProcessingTest.cpp Index:

[PATCH] D34444: Teach codegen to work in incremental processing mode.

v.g.vassilev updated this revision to Diff 103565. v.g.vassilev added a comment. Bring back the initial state of this patch. I accidentally uploaded a wrong patch here, instead of its dependee... https://reviews.llvm.org/D3 Files: include/clang/CodeGen/ModuleBuilder.h

[PATCH] D34510: Teach clang how to merge typedef over anonymous structs in C mode.

v.g.vassilev created this revision. empty.h makes module A available. textual.h brings the definition of __fsid_t and a.h imports again the definition of __fsid_t. In C mode clang fails to merge the textually included definition with the one imported from a module. The C lookup rules fail to

[PATCH] D34444: Teach codegen to work in incremental processing mode.

v.g.vassilev updated this revision to Diff 103560. v.g.vassilev added a comment. Herald added a subscriber: mgorny. Add a test. Patch by Axel Naumann! https://reviews.llvm.org/D3 Files: lib/CodeGen/CGDeclCXX.cpp unittests/CodeGen/CMakeLists.txt

[PATCH] D34444: Teach codegen to work in incremental processing mode.

v.g.vassilev updated this revision to Diff 103360. v.g.vassilev added a comment. Fix compilation issue. https://reviews.llvm.org/D3 Files: include/clang/CodeGen/ModuleBuilder.h lib/CodeGen/ModuleBuilder.cpp Index: lib/CodeGen/ModuleBuilder.cpp

[PATCH] D34444: Teach codegen to work in incremental processing mode.

v.g.vassilev created this revision. When `isIncrementalProcessingEnabled` is on we might call multiple times `HandleEndOfTranslationUnit`. This would complete the `llvm::Module` CodeGen is writing to. This patch allows the clients to start a new `llvm::Module`, allowing CodeGen to continue

[PATCH] D31187: Fix removal of out-of-line definitions.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r305799. I would like to test it and I think that should be possible as soon as I land some interpreter infrastructure which is on my TODO list. https://reviews.llvm.org/D31187

[PATCH] D33383: [GSoC] Flag value completion for clang

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM. My comments can be addressed in a separate patch. Comment at: clang/include/clang/Driver/Options.td:496 def cl_std_EQ : Joined<["-"], "cl-std=">, Group,

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

v.g.vassilev added inline comments. Comment at: cfe/trunk/include/clang/Analysis/CloneDetection.h:324 +struct AutoGeneratedCloneConstraint { + StringRef IgnoredFilesPattern; Shouldn't the name be more generic. What this essentially does is to filter out

[PATCH] D33383: [GSoC] Flag value completion for clang

v.g.vassilev added inline comments. Comment at: clang/include/clang/Driver/Options.td:2198 def stdlib_EQ : Joined<["-", "--"], "stdlib=">, Flags<[CC1Option]>, - HelpText<"C++ standard library to use">; + HelpText<"C++ standard library to use">,

[PATCH] D29951: Load lazily the template specialization in multi-module setups.

v.g.vassilev added a comment. Reverted in r305460 because broke libcxx modules builds. https://reviews.llvm.org/D29951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

v.g.vassilev added a comment. I agree with Raphael. If you need to have more fine grained control over the translation unit (TU) I think we can have suppressing false positives via comments (@Noq would know more). Eg. // File.h defining moc_* yields a lot of false positives //

[PATCH] D34182: [analyzer] Performance optimizations for the CloneChecker

v.g.vassilev added inline comments. Comment at: include/clang/Analysis/CloneDetection.h:263 +public: + void constrain(std::vector ); +}; Could we typedef `std::vector` into `CloneDetector::CloneGroups`? https://reviews.llvm.org/D34182

[PATCH] D33467: Fix LLVM build errors if necent build of GCC 7 is used

v.g.vassilev added a comment. Waiting on resolution to: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79162 Repository: rL LLVM https://reviews.llvm.org/D33467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33930: Do not pick up by default the LLVM style if passing -format

v.g.vassilev closed this revision. v.g.vassilev added a comment. Changing the default of clang-apply-replacements makes sense to me. This one landed in r305125. https://reviews.llvm.org/D33930 ___ cfe-commits mailing list

[PATCH] D29951: Load lazily the template specialization in multi-module setups.

v.g.vassilev closed this revision. v.g.vassilev added a comment. r305120. https://reviews.llvm.org/D29951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33366: Fix that global delete operator get's assigned to a submodule.

v.g.vassilev closed this revision. v.g.vassilev added a comment. r305118. https://reviews.llvm.org/D33366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34022: Repair 2010-05-31-palignr.c test

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r305089. https://reviews.llvm.org/D34022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34059: Get the file name for the symbol from the Module, not the SourceManager.

v.g.vassilev created this revision. This allows multi-module / incremental compilation environments to have unique initializer symbols. Patch by Axel Naumann! Repository: rL LLVM https://reviews.llvm.org/D34059 Files: lib/CodeGen/CGDeclCXX.cpp Index: lib/CodeGen/CGDeclCXX.cpp

[PATCH] D29951: Load lazily the template specialization in multi-module setups.

v.g.vassilev updated this revision to Diff 102045. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. Address comments. https://reviews.llvm.org/D29951 Files: include/clang/Serialization/ASTReader.h lib/Serialization/ASTReaderDecl.cpp Index:

[PATCH] D33467: Fix LLVM build errors if necent build of GCC 7 is used

v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a subscriber: rsmith. v.g.vassilev added a comment. @rsmith, what's the right way to proceed here? Repository: rL LLVM https://reviews.llvm.org/D33467 ___ cfe-commits mailing list

[PATCH] D34022: Repair 2010-05-31-palignr.c test

v.g.vassilev added a comment. Raphael and I work together I can take care of it... https://reviews.llvm.org/D34022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33930: Do not pick up by default the LLVM style if passing -format

v.g.vassilev updated this revision to Diff 101540. v.g.vassilev added a comment. Use string. https://reviews.llvm.org/D33930 Files: clang-tidy/tool/run-clang-tidy.py Index: clang-tidy/tool/run-clang-tidy.py === ---

[PATCH] D33930: Do not pick up by default the LLVM style if passing -format

v.g.vassilev created this revision. This adds a new flag `-style` which is passed to `clang-apply-replacements` and defaults to `file` meaning it would pick up the closest `.clang-format` file in tree. Repository: rL LLVM https://reviews.llvm.org/D33930 Files:

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev added a comment. In https://reviews.llvm.org/D29877#766301, @rsmith wrote: > In https://reviews.llvm.org/D29877#766196, @EricWF wrote: > > > No. But I can point you to `range-v3` which uses this pattern and I think > > the idiom is somewhat appealing, but that's orthogonal to Clang

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:631 // UnusedParameter, (matches GCC's behavior) +// UnusedTemplate, (clean-up libc++ before enabling) //

[PATCH] D32499: Further delay calling DeclMustBeEmitted until it's safe.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r303432. https://reviews.llvm.org/D32499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32499: Further delay calling DeclMustBeEmitted until it's safe.

v.g.vassilev added a comment. We were trying to come up with a test case. So far we are unsuccessful. I will check it in as is. https://reviews.llvm.org/D32499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33275: Keep into account if files were virtual.

v.g.vassilev added a comment. We have this pattern: FileID FID; const clang::FileEntry* FE = SM.getFileManager().getVirtualFile(source_name.str(), InputSize, 0 /* mod time*/); SM.overrideFileContents(FE, std::move(MB)); // MB is a

[PATCH] D33275: Keep into account if files were virtual.

v.g.vassilev created this revision. In some cases we do not have files on disk. They are only available in the FileManager as virtual files and the SourceManager overrides their content. https://reviews.llvm.org/D33275 Files: lib/Basic/SourceManager.cpp

[PATCH] D29951: Load lazily the template specialization in multi-module setups.

v.g.vassilev updated this revision to Diff 98445. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. Reduce the amount of calls to AddLazySpecializations. Remove assert. In order to create a reasonable test I need to use `-error-on-deserialized-decl` and I hit a bug:

[PATCH] D29951: Load lazily the template specialization in multi-module setups.

v.g.vassilev updated this revision to Diff 98333. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Reduce code duplication. Use llvm_unreachable. https://reviews.llvm.org/D29951 Files: lib/Serialization/ASTReaderDecl.cpp Index: lib/Serialization/ASTReaderDecl.cpp

[PATCH] D31867: Fix documentation for TargetOptions.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r302521. https://reviews.llvm.org/D31867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Relanded in r302518. https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31867: Fix documentation for TargetOptions.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Sorry, ignore my previous comment. LGTM! https://reviews.llvm.org/D31867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31867: Fix documentation for TargetOptions.

v.g.vassilev added a comment. I think the second sentence is important. https://reviews.llvm.org/D31867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

v.g.vassilev added a comment. Did you incorporate the comment from here: https://bugs.llvm.org/show_bug.cgi?id=24007#c2 https://reviews.llvm.org/D32646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

v.g.vassilev added a comment. I don't think we should worry about that. Please also see: http://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code https://reviews.llvm.org/D32646 ___ cfe-commits mailing list

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

v.g.vassilev added inline comments. Comment at: lib/Sema/SemaInit.cpp:892 + SpellingLoc = SemaRef.getSourceManager().getSpellingLoc(SpellingLoc); + if (!(SpellingLoc.isValid() && +SemaRef.getSourceManager().isInSystemHeader(SpellingLoc))) {

[PATCH] D25051: Fix PR 10758: Infinite recursion when dealing with copy-initialization

v.g.vassilev added a comment. I am not very familiar with this code here. This seems a reasonable fix to me. Unless @rsmith and @ahatanak have objections, please go ahead and land it some time next week. Repository: rL LLVM https://reviews.llvm.org/D25051

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

v.g.vassilev added a comment. @teemperor, is this ok with you? https://reviews.llvm.org/D32341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31495: Fix a bug that -isysroot is completely ignored on Unix

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D31495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

v.g.vassilev added a comment. LGTM, modulo the comment. Comment at: lib/Sema/SemaInit.cpp:892 + SpellingLoc = SemaRef.getSourceManager().getSpellingLoc(SpellingLoc); + if (!(SpellingLoc.isValid() && +

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev added a comment. @rsmith, @mclow.lists, @arphaman, I am planning to reland that soon. Let me know if you have any objections. https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev updated this revision to Diff 97098. v.g.vassilev added a comment. This revision is now accepted and ready to land. Implement a special diagnostic switch for the warning. https://reviews.llvm.org/D29877 Files: include/clang/Basic/DiagnosticGroups.td

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

v.g.vassilev added a comment. In general, I think we should support such use-cases. It seems cleaner to me if we provide some sort of callbacks where the users can specify their custom false positive filters. I've discussed this in brief with Raphael and we were planning to write this up.

[PATCH] D25113: [Sema] Don't display an invalid redefinition error when dealing with a redefinition of a function whose previous definition was typo-corrected

v.g.vassilev added a comment. LGTM! Repository: rL LLVM https://reviews.llvm.org/D25113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32342: Changed llvm/CMakeLists.txt and added relative path to llvm doxygen

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r301569. https://reviews.llvm.org/D32342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32486: Cleanup pragma handlers after DoPrintPreprocessedInput

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r301563. https://reviews.llvm.org/D32486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

v.g.vassilev added a comment. I think you will see the issue if you add a negative test case, too. I.e. as Raphael said in `-MD` and `-MMD` mode we should be able to see warnings. https://reviews.llvm.org/D32341 ___ cfe-commits mailing list

[PATCH] D32486: Cleanup pragma handlers after DoPrintPreprocessedInput

v.g.vassilev added a comment. Yaron, I can take care of this. Thanks for asking. Raphael and I are working together. https://reviews.llvm.org/D32486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32342: Changed llvm/CMakeLists.txt and added relative path to llvm doxygen

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D32342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

v.g.vassilev added a comment. LGTM modulo the comments. Comment at: test/Driver/m_and_mm.c:7 +// RUN: not grep "warning" %t +#warning "This warning shouldn't shop up with -M and -MM" Typo. https://reviews.llvm.org/D32341

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

v.g.vassilev added a comment. Could you add a test case? https://reviews.llvm.org/D32341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32113: Add path from clang to doxygen document include header

v.g.vassilev added a comment. Landed in r300825. Maybe we should do something like that for LLVM documentation, too. https://reviews.llvm.org/D32113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32113: Add path from clang to doxygen document include header

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D32113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32119: Emit warning when umbrella directory does not exists

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r300594. https://reviews.llvm.org/D32119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32119: Emit warning when umbrella directory does not exists

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D32119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32113: Add path from clang to doxygen document include header

v.g.vassilev added inline comments. Comment at: docs/doxygen.cfg.in:158 +STRIP_FROM_INC_PATH+= @abs_srcdir@/../include/clang +STRIP_FROM_INC_PATH+= @abs_srcdir@/../include/clang-c We should be stripping `@abs_srcdir@/../include` because in reality the

[PATCH] D28832: Improve redefinition errors pointing to the same header.

v.g.vassilev added a comment. @bruno, ok, sounds good. https://reviews.llvm.org/D28832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31591: Fix a bug which access nullptr and cause segmentation fault

v.g.vassilev added a comment. Landed in r300313. https://reviews.llvm.org/D31591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31591: Fix a bug which access nullptr and cause segmentation fault

v.g.vassilev accepted this revision. v.g.vassilev added a comment. LGTM. https://reviews.llvm.org/D31591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev planned changes to this revision. v.g.vassilev added a comment. We agreed to implement a special switch for this, eg. `-Wunused-template` https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31591: Fix a bug which access nullptr and cause segmentation fault

v.g.vassilev added a comment. ping... https://reviews.llvm.org/D31591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28832: Improve redefinition errors pointing to the same header.

v.g.vassilev added a comment. Here is an example that we recently had where we would be very happy to see better diagnostics: MessageTypes.h: #ifndef ROOT_MessageTypes #define ROOT_MessageTypes enum EMessageTypes { kROOTD_OPEN = 2004, //filename follows +

[PATCH] D31702: Append -w when LLVM_ENABLE_WARNINGS is Off.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r300100. https://reviews.llvm.org/D31702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

v.g.vassilev added a comment. LGTM! https://reviews.llvm.org/D31540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev added a comment. Reverted in r299956, due to failures like: template static int __test(...); template auto v = __test<_Tp>(0); https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev added a comment. @mclow.lists, hm... it seems that I cannot reproduce it. It'd really help if you could paste a standalone reproducer. https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev added a comment. @chapuni, the LLVM warnings should be fixed in r299947. @mclow.lists, sorry for not giving heads up :( I am working on the false positive that you reported. https://reviews.llvm.org/D29877 ___ cfe-commits mailing

<    1   2   3   4   5   6   7   >