[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev added a comment. @arphaman, it seems they are marked as static and this seemed like a bug to @rsmith. https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev added a comment. Thanks for pinging us. Yeah, I knew them but I was hesitant whether I should fix them or they should be fixed by the code owners. Shall I commit the fixes? https://reviews.llvm.org/D29877 ___ cfe-commits mailing list

[PATCH] D22638: Module: add debug_type to dump debugging messages related to modules being out of date

v.g.vassilev added a comment. How do we proceed with this. Shall we close it? https://reviews.llvm.org/D22638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev closed this revision. v.g.vassilev marked 5 inline comments as done. v.g.vassilev added a comment. Landed in r299930. https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev updated this revision to Diff 94352. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Improve comment. https://reviews.llvm.org/D29877 Files: lib/Sema/Sema.cpp lib/Sema/SemaDecl.cpp test/SemaCXX/warn-unused-filescoped.cpp Index:

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev updated this revision to Diff 94350. v.g.vassilev added a comment. Found out which is the right place to avoid the linkage computation issues. https://reviews.llvm.org/D29877 Files: lib/Sema/Sema.cpp lib/Sema/SemaDecl.cpp test/SemaCXX/warn-unused-filescoped.cpp Index:

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev added inline comments. Comment at: lib/Sema/SemaDecl.cpp:1496 return false; + // 'static operator' functions are defined in headers; don't warn. + if (FD->isOverloadedOperator() && rsmith wrote: > Why? Defining a static operator

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev updated this revision to Diff 94294. v.g.vassilev added a comment. Attach the right diff. https://reviews.llvm.org/D29877 Files: lib/Sema/Sema.cpp lib/Sema/SemaDecl.cpp test/SemaCXX/warn-unused-filescoped.cpp Index: test/SemaCXX/warn-unused-filescoped.cpp

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev updated this revision to Diff 94293. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. Iterate over the specs. Diagnose unused variable templates. https://reviews.llvm.org/D29877 Files: include/clang/Sema/Sema.h lib/Sema/Sema.cpp

[PATCH] D31591: Fix a bug which access nullptr and cause segmentation fault

v.g.vassilev added a comment. @yamaguchi, I'd support Akira's comment. Could you place the minimal test example in the suggested file? https://reviews.llvm.org/D31591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

v.g.vassilev added a comment. Could you also add the testcase where the friend declaration has some attributes? Repository: rL LLVM https://reviews.llvm.org/D31540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31702: Append -w when LLVM_ENABLE_WARNINGS is Off.

v.g.vassilev updated this revision to Diff 94180. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Ah good point. Thanks! https://reviews.llvm.org/D31702 Files: cmake/modules/HandleLLVMOptions.cmake Index: cmake/modules/HandleLLVMOptions.cmake

[PATCH] D31702: Append -w when LLVM_ENABLE_WARNINGS is Off.

v.g.vassilev created this revision. Herald added a subscriber: mgorny. This is very useful for projects which embed LLVM in their codebases. Repository: rL LLVM https://reviews.llvm.org/D31702 Files: cmake/modules/HandleLLVMOptions.cmake Index: cmake/modules/HandleLLVMOptions.cmake

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. I am very happy to see this converging! Thanks for the work and perseverance! LGTM. https://reviews.llvm.org/D23418 ___ cfe-commits

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

v.g.vassilev added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CloneChecker.cpp:147 +// different algorithm). +// TODO: In very big clones even multiple variables can be unintended, +// so replacing this number with a percentage could better

[PATCH] D31190: Publish RAIIObjectsForParser.h for external usage

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r298606. Repository: rL LLVM https://reviews.llvm.org/D31190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31190: Publish RAIIObjectsForParser.h for external usage

v.g.vassilev created this revision. In the context of cling, we need to recover the parser from errors. This patch is essential for us and we would like to move it from our fork to clang proper. Repository: rL LLVM https://reviews.llvm.org/D31190 Files:

[PATCH] D31187: Fix removal of out-of-line definitions.

v.g.vassilev added a comment. Not sure, this code is used by external tools. Maybe I could craft an example but it would be very complex, bringing half of the third party tool codebase... https://reviews.llvm.org/D31187 ___ cfe-commits mailing

[PATCH] D31187: Fix removal of out-of-line definitions.

v.g.vassilev updated this revision to Diff 92481. v.g.vassilev edited the summary of this revision. v.g.vassilev added a comment. U https://reviews.llvm.org/D31187 Files: lib/AST/DeclBase.cpp Index: lib/AST/DeclBase.cpp

[PATCH] D31187: Fix removal of out-of-line definitions.

v.g.vassilev created this revision. Consider: ` struct MyClass { void f() {} } MyClass::f(){} // expected error redefinition of f. ` The routine fails to remove the lookup entry is registered in the semantic decl context and not in the primary decl context of the lexical decl context where

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev added a comment. @rsmith ping... https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

v.g.vassilev added a comment. We were planning adding some extra unittests, too... https://reviews.llvm.org/D23418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev updated this revision to Diff 90360. v.g.vassilev added a comment. Rebase + ping. https://reviews.llvm.org/D29877 Files: lib/Sema/Sema.cpp lib/Sema/SemaDecl.cpp test/SemaCXX/warn-unused-filescoped.cpp Index: test/SemaCXX/warn-unused-filescoped.cpp

[PATCH] D26030: Add shebang.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r296781. Repository: rL LLVM https://reviews.llvm.org/D26030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25604: Add support for Mageia Linux

v.g.vassilev abandoned this revision. v.g.vassilev added a comment. Thanks for following this up. I will close it. https://reviews.llvm.org/D25604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29951: Load lazily the template specialization in multi-module setups.

v.g.vassilev created this revision. Currently, we load all template specialization if we have more than one module attached and we touch anything around the template definition. This patch registers the template specializations as a lazily-loadable entities. This reduces the amount of

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev created this revision. Repository: rL LLVM https://reviews.llvm.org/D29877 Files: lib/Sema/Sema.cpp lib/Sema/SemaDecl.cpp lib/Serialization/ASTReader.cpp test/SemaCXX/warn-unused-filescoped.cpp Index: test/SemaCXX/warn-unused-filescoped.cpp

[PATCH] D29676: Enable -dump-deserialized-decls and -error-on-deserialized-decl for modules

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r294359. Repository: rL LLVM https://reviews.llvm.org/D29676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29676: Enable -dump-deserialized-decls and -error-on-deserialized-decl for modules

v.g.vassilev created this revision. Enable the useful -dump-deserialized-decls and -error-on-deserialized-decl flags for modules builds, too. Repository: rL LLVM https://reviews.llvm.org/D29676 Files: lib/Frontend/FrontendAction.cpp Index: lib/Frontend/FrontendAction.cpp

[PATCH] D27604: [Driver] Add compiler option to generate a reproducer

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. My questions were answered. LGTM! https://reviews.llvm.org/D27604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28832: Improve redefinition errors pointing to the same header.

v.g.vassilev added a comment. This looks good to me. https://reviews.llvm.org/D28832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28399: PR31469: Don't add friend template class decls to redecl chain in dependent contexts.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r291753. https://reviews.llvm.org/D28399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28399: PR31469: Don't add friend template class decls to redecl chain in dependent contexts.

v.g.vassilev added a comment. @yaron.keren, it seems that http://llvm.org/pr30994 concerns friend function declarations. My current patch focuses on friend class templates. Perhaps we should open another review item for a fix of http://llvm.org/pr30994. https://reviews.llvm.org/D28399

[PATCH] D28399: PR31469: Don't add friend template class decls to redecl chain in dependent contexts.

v.g.vassilev removed rL LLVM as the repository for this revision. v.g.vassilev updated this revision to Diff 83936. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Address comments. https://reviews.llvm.org/D28399 Files: include/clang/AST/DeclTemplate.h

[PATCH] D28306: Remove fixme, use ASTContext::getCanonicalTemplateSpecializationType

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r291552. Repository: rL LLVM https://reviews.llvm.org/D28306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28399: PR31469: Don't add friend template class decls to redecl chain in dependent contexts.

v.g.vassilev added a comment. @kimgr, here is the discussion about the change in r283207 https://reviews.llvm.org/D16989 Repository: rL LLVM https://reviews.llvm.org/D28399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28399: PR31469: Don't add friend template class decls to redecl chain in dependent contexts.

v.g.vassilev created this revision. v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a subscriber: cfe-commits. v.g.vassilev set the repository for this revision to rL LLVM. Fixes a crash in modules where the template class decl becomes the most recent decl in the redeclaration chain

[PATCH] D28306: Remove fixme, use ASTContext::getCanonicalTemplateSpecializationType

v.g.vassilev created this revision. v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a subscriber: cfe-commits. v.g.vassilev set the repository for this revision to rL LLVM. Repository: rL LLVM https://reviews.llvm.org/D28306 Files: lib/Sema/SemaTemplate.cpp Index:

[PATCH] D27180: Testbed and skeleton of a new expression parser

v.g.vassilev added a comment. Could you move the Build* functions in a utility class/namespace. I need something very similar for my ongoing work on the libInterpreter patch and I'd like to reuse that part of the patch. Repository: rL LLVM https://reviews.llvm.org/D27180

[PATCH] D27604: [Driver] Add compiler option to generate a reproducer

v.g.vassilev added a comment. Thanks for working on this, Bruno! This would be a useful feature to us, too. I am wondering if there is clearer name than `-gen-reproducer`. IIUC, the goal is to extract all environment (system) dependent pieces, copying them to a folder where the compiler can

[PATCH] D27180: Testbed and skeleton of a new expression parser

v.g.vassilev added a comment. Thanks for working on this Sean! Since long time we are planning to propose a patch moving some parts of cling (eg. libInterpreter) mainline. Now I should have a little more time to do this and it'd be great if we can share some code between cling and lldb. This

<    2   3   4   5   6   7