[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo added a comment. Thanks! Comment at: clang-tools-extra/clangd/unittests/tweaks/OrganizeImportsTests.cpp:35-41 + { + R"cpp( +#include "Te^stTU.h" +)cpp", + true, + {}}, + {"void foo(^)

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo updated this revision to Diff 557771. VitaNuo marked 10 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153769/new/ https://reviews.llvm.org/D153769 Files:

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Respond to comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/OrganizeImports.cpp:56 +return false; + Range PreambleRange; + PreambleRange.start = kadircet wrote: > VitaNuo

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo added a comment. I think I also managed to update the wrong patch. Not sure how an alternative patch got created in the first place :( Sorry for the mess, should be fine now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153769/new/

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo updated this revision to Diff 556532. VitaNuo marked an inline comment as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153769/new/ https://reviews.llvm.org/D153769 Files:

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo marked 2 inline comments as done. VitaNuo added a comment. I'm sorry I think the upload failed because I tried to upload without a message or something, and I didn't notice that it failed :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159498: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo updated this revision to Diff 556531. VitaNuo added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159498/new/ https://reviews.llvm.org/D159498 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D159498: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo marked 10 inline comments as done. VitaNuo added a comment. Thank you for the comments! Comment at: clang-tools-extra/clangd/ClangdServer.cpp:752 auto Action = [File = File.str(), Sel, TweakID = TweakID.str(), - CB = std::move(CB), +

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

This revision was automatically updated to reflect the committed changes. Closed by commit rG64366d4935d3: [clangd] Rollforward include-cleaner library usage in symbol collector. (authored by VitaNuo). Changed prior to commit: https://reviews.llvm.org/D156659?vs=556135=556396#toc Repository:

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

VitaNuo updated this revision to Diff 556135. VitaNuo marked an inline comment as done. VitaNuo added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156659/new/ https://reviews.llvm.org/D156659 Files:

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

VitaNuo marked 2 inline comments as done. VitaNuo added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:919 + if (IncludeHeader.empty()) +HeaderFileURIs->getIncludeHeader(FID); + kadircet wrote: > i guess LHS of the

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

VitaNuo added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156659/new/ https://reviews.llvm.org/D156659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

VitaNuo updated this revision to Diff 556130. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Address the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156659/new/ https://reviews.llvm.org/D156659 Files:

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

VitaNuo added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:912 +if (Directives & Symbol::Import) { + if (auto IncludeHeader = HeaderFileURIs->getIncludeHeader(FID); + !IncludeHeader.empty()) { kadircet wrote:

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43c20367f417: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include… (authored by VitaNuo). Repository: rG LLVM Github

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

VitaNuo added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157610/new/ https://reviews.llvm.org/D157610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

VitaNuo updated this revision to Diff 556127. VitaNuo marked 3 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157610/new/ https://reviews.llvm.org/D157610 Files:

[PATCH] D159462: [clangd][clang-tidy] Add missing symbols to the symbol map.

This revision was automatically updated to reflect the committed changes. Closed by commit rG625891288087: [clangd][clang-tidy] Add missing symbols to the symbol map. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159462/new/

[PATCH] D159463: [include-cleaner] Map the 4-argument move overload to the algorithm header.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd71adebb9fb8: [include-cleaner] Map the 4-argument move overload to the algorithm header. (authored by VitaNuo). Repository: rG LLVM Github

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

VitaNuo updated this revision to Diff 556004. VitaNuo marked 5 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156659/new/ https://reviews.llvm.org/D156659 Files:

[PATCH] D159463: [include-cleaner] Map the 4-argument move overload to the algorithm header.

VitaNuo created this revision. Herald added a subscriber: kadircet. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D159463

[PATCH] D159462: [clangd][clang-tidy] Add missing symbols to the symbol map.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman, xazax.hun. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

VitaNuo updated this revision to Diff 555995. VitaNuo added a comment. Rebase to current main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157610/new/ https://reviews.llvm.org/D157610 Files:

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks for the help in resolving the resource dir issues! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157610/new/ https://reviews.llvm.org/D157610

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

VitaNuo updated this revision to Diff 555985. VitaNuo added a comment. Fix analysis test to properly recognize the resource directory. Use HeaderSearch->getModuleMap().BuiltinDir to find out the resource directory. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:122 llvm::DenseSet SeenSymbols; + std::string ResourceDir = HS->getHeaderSearchOpts().ResourceDir; // FIXME: Find a way to have less code duplication

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

VitaNuo updated this revision to Diff 549443. VitaNuo marked 4 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157610/new/ https://reviews.llvm.org/D157610 Files:

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

VitaNuo created this revision. Herald added subscribers: PiotrZSL, kadircet, carlosgalvezp, arphaman, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3ad4b763602: [include-cleaner] Follow `IWYU pragma: export` links transitively. (authored by VitaNuo). Changed prior to commit:

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

VitaNuo updated this revision to Diff 548546. VitaNuo added a comment. Add a test with private headers involved. Order of exporters is from outermost to innermost. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157395/new/

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

VitaNuo updated this revision to Diff 548540. VitaNuo added a comment. Address the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157395/new/ https://reviews.llvm.org/D157395 Files: clang-tools-extra/include-cleaner/lib/FindHeaders.cpp

[PATCH] D157400: [include-cleaner] Dont boost private headers beyond public ones

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. Thanks. Comment at: clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp:474 + Inputs.ExtraFiles["bar.h"] = + guard(R"cpp(#include "foo.h" // IWYU pragma:

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

VitaNuo updated this revision to Diff 548217. VitaNuo added a comment. Remove the preferred header hint for exporters. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157395/new/ https://reviews.llvm.org/D157395 Files:

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

VitaNuo updated this revision to Diff 548204. VitaNuo added a comment. Remove accidental comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157395/new/ https://reviews.llvm.org/D157395 Files: clang-tools-extra/include-cleaner/lib/Record.cpp

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

VitaNuo created this revision. Herald added a subscriber: kadircet. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157395

[PATCH] D157390: [clang-tidy][include-cleaner] Add option to control deduplication of findings per symbol

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. Thanks. Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.h:48 + // Whether emit only one finding per usage of a symbol. + const bool EmitOnce;

[PATCH] D157256: [clangd][clang-tidy][std_symbol_map] Add missing symbol.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a5c0ccee293: [clangd][clang-tidy][std_symbol_map] Add missing symbol. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D157256: [clangd][clang-tidy][std_symbol_map] Add missing symbol.

VitaNuo created this revision. VitaNuo added a reviewer: kadircet. Herald added subscribers: carlosgalvezp, arphaman, xazax.hun. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang.

[PATCH] D157093: [clangd][clang-tidy][stdlib] Add a missing symbol to the mapping.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d492766a8fb: [clangd][clang-tidy][stdlib] Add a missing symbol to the mapping. (authored by VitaNuo). Repository: rG LLVM Github Monorepo

[PATCH] D157093: [clangd][clang-tidy][stdlib] Add a missing symbol to the mapping.

VitaNuo created this revision. Herald added subscribers: carlosgalvezp, kadircet, arphaman, xazax.hun. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D156123: [include-cleaner] Unify always_keep with rest of the keep logic

VitaNuo added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156123/new/ https://reviews.llvm.org/D156123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156122: [include-cleaner] Introduce support for always_keep pragma

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156122/new/ https://reviews.llvm.org/D156122

[PATCH] D156123: [include-cleaner] Unify always_keep with rest of the keep logic

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:248 + if (Top.SeenAtFile == SM.getMainFileID() && IncludedFile) +Out->ShouldKeep.insert(IncludedFile->getUniqueID()); } If I understand correctly, you

[PATCH] D156122: [include-cleaner] Introduce support for always_keep pragma

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:63 + bool shouldKeep(unsigned HashLineNumber) const; + bool shouldKeep(const FileEntry *FE) const; Why wouldn't you actually inline the

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. Repository: rG LLVM Github

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/refactor/tweaks/OrganizeImports.cpp:62 + const auto = Inputs.AST->getSourceManager(); + std::set Spellings; + for (const auto : Findings.MissingIncludes) kadircet

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo updated this revision to Diff 544751. VitaNuo marked 8 inline comments as done. VitaNuo added a comment. Address review comments. Update the action to trigger when source action is requested explicitly or from the preamble range. Add unit test. Repository: rG LLVM Github Monorepo

[PATCH] D156403: [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c6a7b0045af: [clangd] Revert the symbol collector behavior to old pre-include-cleaner… (authored by VitaNuo). Repository: rG LLVM Github

[PATCH] D156403: [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression.

VitaNuo updated this revision to Diff 544689. VitaNuo marked an inline comment as done. VitaNuo added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156403/new/ https://reviews.llvm.org/D156403 Files:

[PATCH] D156403: [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression.

VitaNuo updated this revision to Diff 544684. VitaNuo marked 6 inline comments as done. VitaNuo added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156403/new/ https://reviews.llvm.org/D156403 Files:

[PATCH] D156403: [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f7c7d4bdd7b: [clangd] Update symbol collector to use include-cleaner. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo updated this revision to Diff 542000. VitaNuo marked 9 inline comments as done. VitaNuo added a comment. Address the latest comment batch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152900/new/ https://reviews.llvm.org/D152900 Files:

[PATCH] D155614: [clangd] Remove redundant emptiness check in cross ref calculation for includes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG22605f5f1bf8: [clangd] Make an include always refer to itself. Background: clang-review… (authored by VitaNuo). Repository: rG LLVM Github

[PATCH] D155614: [clangd] Remove redundant emptiness check in cross ref calculation for includes.

VitaNuo accepted this revision. VitaNuo added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/XRefs.cpp:1361-1362 }); - if (Results.References.empty()) -return std::nullopt; - usaxena95 wrote: >

[PATCH] D155614: [clangd] Remove redundant emptiness check in cross ref calculation for includes.

VitaNuo updated this revision to Diff 541882. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Remove only one of the checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155614/new/ https://reviews.llvm.org/D155614 Files:

[PATCH] D155614: [clangd] Make an include always refer to itself. Background: clang-review expects all referents to have definition, declaration or reference(s).

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D155215: [clangd] Fix the range for include reference to itself.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96e50797d6ea: [clangd] Fix the range for include reference to itself. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D155215: [clangd] Fix the range for include reference to itself.

VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Thanks for the comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155215/new/ https://reviews.llvm.org/D155215 ___ cfe-commits

[PATCH] D155215: [clangd] Fix the range for include reference to itself.

VitaNuo updated this revision to Diff 540385. VitaNuo added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155215/new/ https://reviews.llvm.org/D155215 Files: clang-tools-extra/clangd/IncludeCleaner.cpp

[PATCH] D155215: [clangd] Fix the range for include reference to itself.

VitaNuo updated this revision to Diff 540321. VitaNuo added a comment. Re-use the logic from include cleaner in clangd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155215/new/ https://reviews.llvm.org/D155215 Files:

[PATCH] D155217: [clang-tidy][include-cleaner] Don't warn for the same symbol twice

VitaNuo added a comment. Hi Alex, Thank you for the patch. We are aware that issuing one diagnostic per symbol reference might be overwhelming. However, we have decided to choose it over other options after considering the use cases that we'd like to cover. This check is intended to be used in

[PATCH] D155215: [clangd] Fix the range for include reference to itself.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo updated this revision to Diff 539908. VitaNuo marked 3 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152900/new/ https://reviews.llvm.org/D152900 Files:

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo marked 19 inline comments as done. VitaNuo added a comment. Thank you! Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:839 + if (!Headers.empty()) +SymbolProviders.insert({S.ID, Headers[0]}); } kadircet wrote: > once we have the

[PATCH] D154962: [clangd] Use canonical path as resolved path for includes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7322f2d5ed54: [clangd] Use canonical path as resolved path for includes. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D154962: [clangd] Use canonical path as resolved path for includes.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154962/new/ https://reviews.llvm.org/D154962 ___ cfe-commits mailing list

[PATCH] D154962: [clangd] Use canonical path as resolved path for includes.

VitaNuo updated this revision to Diff 539121. VitaNuo added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154962/new/ https://reviews.llvm.org/D154962 Files: clang-tools-extra/clangd/Headers.cpp Index:

[PATCH] D154962: [clangd] Use canonical path as resolved path for includes.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D154068: [clangd] Don't show header for namespace decl in Hover

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154068/new/ https://reviews.llvm.org/D154068

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo added a comment. Thanks for comments! Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.h:40 /// Adds a file-to-string mapping from \p ID to \p CanonicalPath. void addMapping(FileEntryRef Header, llvm::StringRef CanonicalPath);

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo updated this revision to Diff 535740. VitaNuo marked 27 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152900/new/ https://reviews.llvm.org/D152900 Files:

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:393-395 +const auto *FileEntry = SM.getFileEntryForID(FID); +for (const auto *Export : PI.getExporters(FileEntry, SM.getFileManager())) + return

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo updated this revision to Diff 532964. VitaNuo marked 8 inline comments as done. VitaNuo added a comment. Herald added a subscriber: javed.absar. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152900/new/

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo added a comment. Thanks! Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:3726 +TEST(Hover, FunctionParameterDefaulValueNotEvaluatedOnInvalidDecls) { + struct { hokein wrote: > nit: instead of creating a completely-new TEST, it seems

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

This revision was automatically updated to reflect the committed changes. VitaNuo marked an inline comment as done. Closed by commit rGc9888dce4474: [clangd] Skip function parameter decls when evaluating variables on hover. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:663 + const auto *Var = dyn_cast(D); + if (Var && !llvm::isa(Var)) { if (const Expr *Init = Var->getInit()) VitaNuo wrote: > hokein wrote: > > We're ignoring all `ParmVarDecl`

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo added a comment. Thanks for the review! Comment at: clang-tools-extra/clangd/Hover.cpp:663 + const auto *Var = dyn_cast(D); + if (Var && !llvm::isa(Var)) { if (const Expr *Init = Var->getInit()) hokein wrote: > We're ignoring all `ParmVarDecl`

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo updated this revision to Diff 532044. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Simplify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153015/new/ https://reviews.llvm.org/D153015 Files:

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo updated this revision to Diff 532042. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153015/new/ https://reviews.llvm.org/D153015 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D153018: [include-cleaner] Reorder SymbolReference fields to avoid padding space, NFC

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153018/new/ https://reviews.llvm.org/D153018

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo added a comment. thanks! Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:3726 +TEST(Hover, FunctionParameterDefaulValueNotEvaluated) { + Annotations T("void foo(int p^aram = 5);"); + TestTU TU = TestTU::withCode(T.code()); hokein wrote:

[PATCH] D152542: [clangd] Use include_cleaner spelling strategies in clangd.

VitaNuo added a comment. Duplicate of https://reviews.llvm.org/D152913. Landed the other one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152542/new/ https://reviews.llvm.org/D152542 ___ cfe-commits

[PATCH] D153013: [clang-tidy] Correct the include-cleaner-check diagnostic message for missing-includes.

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:49 SourceLocation SymRefLocation; + include_cleaner::Symbol Sym;

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo updated this revision to Diff 531718. VitaNuo added a comment. Simplify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153015/new/ https://reviews.llvm.org/D153015 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D152913: [clangd] Use include_cleaner spelling strategies in clangd.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG6a6c7ed5cd8d: [clangd] Use include_cleaner spelling strategies in clangd. (authored by VitaNuo). Repository: rG LLVM

[PATCH] D152913: [clangd] Use include_cleaner spelling strategies in clangd.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo updated this revision to Diff 531275. VitaNuo added a comment. VitaNuo updated this revision to Diff 531278. VitaNuo added a reviewer: kadircet. VitaNuo published this revision for

[PATCH] D152542: [clangd] Use include_cleaner spelling strategies in clangd.

VitaNuo updated this revision to Diff 529974. VitaNuo added a comment. Remove unrelated formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152542/new/ https://reviews.llvm.org/D152542 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D152542: [clangd] Use include_cleaner spelling strategies in clangd.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90c5fe98: [include-cleaner] Allow multiple strategies for spelling includes. (authored by VitaNuo). Repository: rG LLVM Github Monorepo

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 528341. VitaNuo marked 4 inline comments as done. VitaNuo added a comment. Address the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files:

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/Hover.cpp:1225 - HI.Provider = spellHeader(AST, SM.getFileEntryForID(SM.getMainFileID()), H); + HI.Provider = include_cleaner::spellHeader( + {H,

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 528315. VitaNuo marked 11 inline comments as done. VitaNuo added a comment. Herald added subscribers: PiotrZSL, carlosgalvezp. Herald added a reviewer: njames93. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc28506ba4b69: [clang-tidy] Implement an include-cleaner check. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo added a comment. Thanks for the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527872. VitaNuo marked 6 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files:

  1   2   3   4   5   >