[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

Endill added a comment. @yronglin We are sorry it takes so much time to get feedback. Richard and Hubert have little bandwidth for reviews. Others, including me, don't feel qualified to provide good feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

Endill added inline comments. Comment at: clang/docs/ReleaseNotes.rst:94-98 +- Implemented `P0847R7: Deducing this `. Some related core issues were also + implemented (`CWG2553 `, `CWG2554 `, +

[PATCH] D64087: [clang] Correct source locations for instantiations of out-of-line defaulted special member functions. (PR25683)

Endill added a comment. @tahonermann Do you mind rebasing this on top of trunk if it's necessary? Might be a good idea to resubmit this as PR. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64087/new/ https://reviews.llvm.org/D64087

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

Endill added inline comments. Comment at: clang/test/SemaCXX/offsetof.cpp:106 +int x3[__builtin_offsetof(struct X2, X2::static_a) == 0 ? 1 : -1]; // expected-error{{no member named 'static_a'}} +int x4[__builtin_offsetof(struct X2, X2::X2) == 0 ? 1 : -1]; // expected-error{{no

[PATCH] D156565: Diagnose use of VLAs in C++ by default

Endill added a comment. In D156565#4547909 , @aaron.ballman wrote: > In D156565#4543503 , @aaron.ballman > wrote: > >> In D156565#4543414 , @jrtc27 wrote: >> >>> Given

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

Endill added a comment. In D156247#4541756 , @ilya-biryukov wrote: > @aaron.ballman the internal -cc1 flag > > - internal `clang -cc1 -fno-coroutines`. I'm sorry, but I find this wording misleading. `-cc1 -fno-coroutines` is not internal in the same

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

Endill added a comment. In D156057#4527787 , @rZhBoYao wrote: > BTW, I am not sure if CWG2571 is implemented by > @cor3ntin? If so, can we mark it as done on > https://clang.llvm.org/cxx_dr_status.html#2571? This patch

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

Endill added a comment. I'm sorry for hand-waving, but I also remember @aaron.ballman saying that code related to `-Wunsequenced` or around it was missing checks for C++17. I can't say whether you addressed that or not, so just leaving it here for you and reviewers. CHANGES SINCE LAST ACTION

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

Endill added a comment. Thank you for working on this! Comment at: clang/test/SemaCXX/warn-unsequenced.cpp:3 // RUN:-Wunsequenced -Wno-c++17-extensions -Wno-c++14-extensions %s -// RUN: %clang_cc1 -fsyntax-only -verify=cxx17 -std=c++17 -Wno-unused

[PATCH] D151697: [clang] Add test for CWG1710 and related issues

This revision was automatically updated to reflect the committed changes. Closed by commit rG1bbaabb90dd7: [clang] Add test for CWG1710 and related issues (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151697/new/

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

Endill added inline comments. Comment at: clang/test/CXX/drs/dr14xx.cpp:491 + float operator ""_E(const char *); + // expected-warning@+1 {{user-defined literal suffixes not starting with '_' are reserved; no literal will invoke this operator}} + float operator ""E(const

[PATCH] D152632: [Clang] Add warnings for CWG2521

Endill accepted this revision as: Endill. Endill added a comment. DR testing side looks good, but you should wait for more approvals. Thank you for addressing all the issues there! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152632/new/ https://reviews.llvm.org/D152632

[PATCH] D151697: [clang] Add test for CWG1710 and related issues

Endill added a comment. Thank you for taking a look! I found a bunch of issues pointing at the same diagnostics, but I'm not sure if they track exactly what I test here: https://github.com/llvm/llvm-project/issues/17775 https://github.com/llvm/llvm-project/issues/36539

[PATCH] D151634: [clang] Add test for CWG253

Endill added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:1022 -namespace dr78 { // dr78: sup +namespace dr78 { // dr78: no // Under DR78, this is valid, because 'k' has static storage duration, so is shafik wrote: > Endill wrote: > >

[PATCH] D151697: [clang] Add test for CWG1710 and related issues

Endill added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151697/new/ https://reviews.llvm.org/D151697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152632: [Clang] Add warnings for CWG2521

Endill added a comment. Thank you for taking care of other tests under `dr25xx.cpp`! In D152632#4412075 , @rZhBoYao wrote: > Overhaul for `dr25xx.cpp`. > > For each test case, tried to support as many language modes as possible. > Not sure what those

[PATCH] D152632: [Clang] Add warnings for CWG2521

Endill added inline comments. Comment at: clang/test/CXX/drs/dr25xx.cpp:2 +// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-unknown %s -verify -Wdeprecated-literal-operator +// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-unknown %s -verify -Wdeprecated

[PATCH] D152632: [Clang] Add warnings for CWG2521

Endill requested changes to this revision. Endill added a comment. This revision now requires changes to proceed. Thank you for working on this! In D152632#4411587 , @rZhBoYao wrote: > Few questions: > I think this applies to all the language modes?

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

Endill added inline comments. Comment at: clang/test/SemaCXX/cxx2b-consteval-propagate.cpp:8 + +namespace examples { + aaron.ballman wrote: > cor3ntin wrote: > > aaron.ballman wrote: > > > Fznamznon wrote: > > > > cor3ntin wrote: > > > > > Fznamznon wrote: > > >

[PATCH] D151634: [clang] Add test for CWG253

Endill added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:1022 -namespace dr78 { // dr78: sup +namespace dr78 { // dr78: no // Under DR78, this is valid, because 'k' has static storage duration, so is shafik wrote: > shafik wrote: > > This

[PATCH] D151634: [clang] Add test for CWG253

Endill updated this revision to Diff 527804. Endill edited the summary of this revision. Endill added a comment. Mark CWG78 as superseded by 2536 Expand CWG253 test @shafik I think rather than leave 78 out, we better mark it as superseded, so that we don't forget about it. Repository: rG

[PATCH] D151634: [clang] Add test for CWG253

Endill added a comment. @shafik Thank you for letting me know! Now I wonder if it was possible to realize by myself without prior knowledge of CWG 2536, because I feel like some cross-references are missing. Can we proceed if I strip CWG 78 out, leaving only CWG 253? Repository: rG LLVM

[PATCH] D151704: [clang] Add test for CWG873

This revision was automatically updated to reflect the committed changes. Closed by commit rG238f15820e71: [clang] Add test for CWG873 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151704/new/ https://reviews.llvm.org/D151704

[PATCH] D151704: [clang] Add test for CWG873

Endill created this revision. Endill added reviewers: clang-language-wg, shafik, erichkeane. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also add missing marking to the test of related issue 621.

[PATCH] D151034: [clang] Add test for CWG1397

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c561e8f3c2e: [clang] Add test for CWG1397 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151034/new/ https://reviews.llvm.org/D151034

[PATCH] D151697: [clang] Add test for CWG1710 and related issues

Endill created this revision. Endill added reviewers: clang-language-wg, shafik. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Those issues focus on `template` keyword being optional in certain

[PATCH] D151661: [clang] [test] Narrow down an MSVC specific behaviour to only not covever MinGW

Endill added a comment. In D151661#4380060 , @mstorsjo wrote: > In D151661#4379958 , @Endill wrote: > >> Thank you! >> I've asked Aaron what is the best way to check for MSVC-like triple before >> relanding this

[PATCH] D151661: [clang] [test] Narrow down an MSVC specific behaviour to only not covever MinGW

Endill accepted this revision. Endill added a comment. This revision is now accepted and ready to land. Thank you! I've asked Aaron what is the best way to check for MSVC-like triple before relanding this test. So today we both learned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D151634: [clang] Add test for CWG253

Endill updated this revision to Diff 526342. Endill added a comment. Update cxx_dr_status.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151634/new/ https://reviews.llvm.org/D151634 Files: clang/test/CXX/drs/dr0xx.cpp

[PATCH] D151634: [clang] Add test for CWG253

Endill created this revision. Endill added reviewers: clang-language-wg, shafik. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also mark CWG78 as "no". CWG253 is the only issue that references 78, and

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill added inline comments. Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:468 +Status = VerifyDiagnosticConsumer::HasExpectedMaybeNoDiagnostics; + continue; +} else if (DToken.endswith(DType="-no-diagnostics")) { jdenny wrote: >

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill updated this revision to Diff 526277. Endill added a comment. Replace A2 test with E1-E3 tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151320/new/ https://reviews.llvm.org/D151320 Files:

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill added a comment. Thank you for your time! Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:468 +Status = VerifyDiagnosticConsumer::HasExpectedMaybeNoDiagnostics; + continue; +} else if (DToken.endswith(DType="-no-diagnostics")) {

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill added inline comments. Comment at: clang/include/clang/Frontend/VerifyDiagnosticConsumer.h:186-202 +/// Additionally, you can use: +/// +/// \code +/// // expected-maybe-no-diagnostics +/// \endcode +/// +/// to specify that a file with no "expected-*" comments should

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill updated this revision to Diff 526101. Endill added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151320/new/ https://reviews.llvm.org/D151320 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill added a comment. Thank you for the review! Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:468 +Status = VerifyDiagnosticConsumer::HasExpectedMaybeNoDiagnostics; + continue; +} else if (DToken.endswith(DType="-no-diagnostics")) {

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill updated this revision to Diff 526013. Endill edited the summary of this revision. Endill added a comment. Address feedback Docs contributed by @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151320/new/

[PATCH] D151426: [Clang][NFC] Prepare C++ DR suite for better test isolation

Endill added a comment. In D151426#4371730 , @aaron.ballman wrote: > The changes LGTM (verified off-list that the regenerated HTML is identical > before and after this change), I've run `make_cxx_dr_status` on top of this patch, and learned that the

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill marked an inline comment as done. Endill added a comment. Thank for for providing a nice explanation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151320/new/ https://reviews.llvm.org/D151320

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill updated this revision to Diff 525216. Endill added a comment. Add missing comma after enum item Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151320/new/ https://reviews.llvm.org/D151320 Files:

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill created this revision. Endill added reviewers: aaron.ballman, hfinkel, dblaikie. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch introduces a `// expected-maybe-not-diagnostic` that

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

Endill added a comment. In D151042#4364149 , @thakis wrote: > In fact, you can probably repro the test failure on your linux box if you > change that test and add locally add -triple=i386-pc-win32 to the RUN line You're right, MSVC-specific triple make

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

Endill added a comment. All tests pass for me on Linux. As far as I understand, diagnostics on Windows are not supposed to be different given the same `-cc1` flags. Reverting for further investigation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

Endill added a comment. In D151042#4364108 , @thakis wrote: > This breaks check-clang on windows: http://45.33.8.238/win/78827/step_7.txt > > Please take a look and revert for now if it takes a while to fix. It's not hard to fix, but is it just windows?

[PATCH] D151166: [clangd] Interactive AST matchers with #pragma clang query

Endill added a comment. This is an interesting feature! There's a related `#pragma clang __debug dump`, that dumps name lookup result or a bit of AST for expression you pass to it (https://clang.llvm.org/docs/LanguageExtensions.html#debugging-the-compiler). I think clangd might be interested

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85452b5f9b5a: [clang] Add tests for CWG issues 977, 1482, 2516 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D151032: [clang] Add test for CWG2213

This revision was automatically updated to reflect the committed changes. Closed by commit rG71bc3dd42e29: [clang] Add test for CWG2213 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151032/new/ https://reviews.llvm.org/D151032

[PATCH] D151034: [clang] Add test for CWG1397

Endill added a comment. Thank you for the review! Comment at: clang/test/CXX/drs/dr13xx.cpp:488 +#if __cplusplus == 201103L + // expected-error@#dr1397-struct-A {{default member initializer for 'p' needed within definition of enclosing class 'A' outside of member functions}}

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

Endill created this revision. Endill added reviewers: clang-language-wg, shafik. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CWG977 focus on point of /completeness/ of enums. Wording provided in

[PATCH] D151034: [clang] Add test for CWG1397

Endill created this revision. Endill added reviewers: clang-language-wg, shafik. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Resolution of this CWG breaks potential dependency loop between

[PATCH] D151032: [clang] Add test for CWG2213

Endill added a comment. If reviewers would prefer this to be simply marked N/A, I'm not going to oppose. I wrote a test for this because it was simple enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151032/new/

[PATCH] D151032: [clang] Add test for CWG2213

Endill created this revision. Endill added reviewers: clang-language-wg, shafik, cor3ntin. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG2213 is resolved by allowing

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

Endill added a comment. Thank you for working on this feature! I can't review this properly, so here's my little help for the feature I'm looking forward to very much. Comment at: clang/test/CXX/drs/dr25xx.cpp:1 -// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-unknown %s

[PATCH] D147920: [clang] Add test for CWG399

Endill added a comment. Should be fixed by https://github.com/llvm/llvm-project/commit/abbb22cc0c9c33dedb8d53c2bd3e703f92baace7. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147920/new/ https://reviews.llvm.org/D147920

[PATCH] D147920: [clang] Add test for CWG399

Endill added a comment. Thank you! I'm going to fix this now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147920/new/ https://reviews.llvm.org/D147920 ___ cfe-commits mailing list

[PATCH] D147920: [clang] Add test for CWG399

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Endill marked an inline comment as not done. Closed by commit rG14f245d01a1e: [clang] Add test for CWG399 (authored by Endill). Changed prior to commit:

[PATCH] D147920: [clang] Add test for CWG399

Endill added a comment. @shafik ping Comment at: clang/test/CXX/drs/dr3xx.cpp:1439 + +namespace dr399 { // dr399: 11 + // NB: reuse dr244 test aaron.ballman wrote: > aaron.ballman wrote: > > shafik wrote: > > > Endill wrote: > > > > shafik

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

Endill added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:51-52 + Diag->getDiags()->getDiagnosticIDs()->getStableName(Diag->getID()).str(); + std::replace(StableName.begin(), StableName.end(), '_', '.'); + SarifRule Rule =

[PATCH] D149003: [clang] Add test for CWG1821

This revision was automatically updated to reflect the committed changes. Closed by commit rG5cda0d165a75: [clang] Add test for CWG1821 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149003/new/ https://reviews.llvm.org/D149003

[PATCH] D148263: [clang] Mark CWG2009 as N/A

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a113c4c50f6: [clang] Mark CWG2009 as N/A (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148263/new/ https://reviews.llvm.org/D148263

[PATCH] D149003: [clang] Add test for CWG1821

Endill created this revision. Endill added reviewers: shafik, clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : My clarification in “Where can

[PATCH] D147920: [clang] Add test for CWG399

Endill added a comment. @aaron.ballman ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147920/new/ https://reviews.llvm.org/D147920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148433: [clang] Add tests for DRs about complete-class context

Endill updated this revision to Diff 514353. Endill added a comment. Weaken the FIXME wording per Shafik's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148433/new/ https://reviews.llvm.org/D148433 Files:

[PATCH] D148433: [clang] Add tests for DRs about complete-class context

Endill added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:42 +namespace dr2335 { // dr2335: no drafting +// FIXME: all of the examples are well-formed. aaron.ballman wrote: > Endill wrote: > > shafik wrote: > > > My comment on 1890 applies here

[PATCH] D148433: [clang] Add tests for DRs about complete-class context

Endill added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:42 +namespace dr2335 { // dr2335: no drafting +// FIXME: all of the examples are well-formed. shafik wrote: > My comment on 1890 applies here as well. > > CC @rsmith @aaron.ballman how

[PATCH] D148433: [clang] Add tests for DRs about complete-class context

Endill created this revision. Endill added reviewers: erichkeane, shafik. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : The intent for CWG2335 (contra those of the

[PATCH] D148260: [clang] Mark CWG2331 as N/A

This revision was automatically updated to reflect the committed changes. Closed by commit rG19ef8e8446df: [clang] Mark CWG2331 as N/A (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148260/new/ https://reviews.llvm.org/D148260

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG576c752410e7: [clang] Add test for CWG1894 and CWG2199 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

Endill updated this revision to Diff 513457. Endill added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148136/new/ https://reviews.llvm.org/D148136 Files: clang/test/CXX/drs/dr18xx.cpp clang/test/CXX/drs/dr21xx.cpp

[PATCH] D148260: [clang] Mark CWG2331 as N/A

Endill added a comment. In D148260#4266802 , @shafik wrote: > The defect report has two examples even though the first one is commented > incorrectly considering the final resolution. I am sure they are covered in > the test suite in other places but

[PATCH] D148263: [clang] Mark CWG2009 as N/A

Endill created this revision. Endill added reviewers: clang-language-wg, shafik. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG2331 is resolved by defining lookup

[PATCH] D148260: [clang] Mark CWG2331 as N/A

Endill created this revision. Endill added reviewers: clang-language-wg, shafik. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG2331 is resolved by defining lookup

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

Endill updated this revision to Diff 512910. Endill edited the summary of this revision. Endill added a comment. Remove parts of CWG1894 and CWG2199 tests that are resolved by CWG407 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148136/new/

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

Endill added inline comments. Comment at: clang/www/cxx_dr_status.html:13004 Typedefs and tags -Unknown +Clang 3.8 erichkeane wrote: > Endill wrote: > > cor3ntin wrote: > > > I would just say "Yes", i think clang 3.8 predates these issues > >

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

Endill added inline comments. Comment at: clang/www/cxx_dr_status.html:13004 Typedefs and tags -Unknown +Clang 3.8 cor3ntin wrote: > I would just say "Yes", i think clang 3.8 predates these issues It's not the case: 2199 was filed 12.11.2015,

[PATCH] D148146: [clang] Make make_cxx_dr_status script runnable from anywhere

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd945b6496ec6: [clang] Make make_cxx_dr_status script runnable from anywhere (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

Endill added a comment. Thank you for taking a look at this. Comment at: clang/test/CXX/drs/dr18xx.cpp:172-227 +namespace dr1894 { // dr1894: 3.8 + // NB: reusing dr407 test + struct S; + typedef struct S S; + void f() { +struct S *p; +{

[PATCH] D148146: [clang] Make make_cxx_dr_status script runnable from anywhere

Endill created this revision. Endill added reviewers: clang-language-wg, cor3ntin. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This script has hardcoded relative paths to `clang/test/CXX/drs`,

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG1894 and its duplicate CWG2199 are resolved

[PATCH] D148035: [clang] Add test for CWG1837

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa7aedd8ea3f: [clang] Add test for CWG1837 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147839: [clang] Add test for CWG2007

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa4beecef8f40: [clang] Add test for CWG2007 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147839: [clang] Add test for CWG2007

Endill updated this revision to Diff 512543. Endill added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147839/new/ https://reviews.llvm.org/D147839 Files: clang/test/CXX/drs/dr20xx.cpp clang/www/cxx_dr_status.html Index:

[PATCH] D147848: [clang] Add test for CWG2370

This revision was automatically updated to reflect the committed changes. Closed by commit rGfeb93d28b02c: [clang] Add test for CWG2370 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147848/new/ https://reviews.llvm.org/D147848

[PATCH] D148035: [clang] Add test for CWG1837

Endill updated this revision to Diff 512538. Endill added a comment. minor fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148035/new/ https://reviews.llvm.org/D148035 Files: clang/test/CXX/drs/dr18xx.cpp clang/www/cxx_dr_status.html

[PATCH] D148035: [clang] Add test for CWG1837

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG1837 is resolved by restricting this to

[PATCH] D147920: [clang] Add test for CWG399

Endill added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:1439 + +namespace dr399 { // dr399: 11 + // NB: reuse dr244 test shafik wrote: > Endill wrote: > > Despite a couple of FIXME in CWG244 test (out of dozens of examples), it

[PATCH] D147920: [clang] Add test for CWG399

Endill added a comment. In D147920#4258680 , @shafik wrote: > In D147920#4257369 , @Endill wrote: > >> I think I haven't stressed it enough, but this whole test is copied from >> dr244, which is written by

[PATCH] D147839: [clang] Add test for CWG2007

Endill added a comment. In D147839#4258681 , @shafik wrote: > In D147839#4257394 , @Endill wrote: > >> Replace unary `&` with `__builtin_addressof()`. It prevents unnecessary >> template instantiation

[PATCH] D147909: [clang] Implement CWG 2397

Endill added a comment. Agree, this test clearly belongs to `clang/test/CXX/drs/dr23xx.cpp`. There is a `clang/www/make_cxx_dr_status` script to update cxx_dr_status page, so you don't have to edit it manually. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147848: [clang] Add test for CWG2370

Endill added a comment. Bug report filed: https://github.com/llvm/llvm-project/issues/62061 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147848/new/ https://reviews.llvm.org/D147848 ___ cfe-commits

[PATCH] D147839: [clang] Add test for CWG2007

Endill updated this revision to Diff 512365. Endill added a comment. Replace unary `&` with `__builtin_addressof()`. It prevents unnecessary template instantiation (presumably to find overloaded unary `&`), and make Clang compliant since 3.4 Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D147920: [clang] Add test for CWG399

Endill added a comment. I think I haven't stressed it enough, but this whole test is copied from dr244, which is written by Richard. Comment at: clang/test/CXX/drs/dr3xx.cpp:1492 +// This is technically ill-formed; G is looked up in 'N::' and is not found. +//

[PATCH] D147848: [clang] Add test for CWG2370

Endill added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:182 + typedef N::type N_type; + // FIXME: `type` should be searched for in N + // friend void N::g(type); shafik wrote: > The implementation seems to all accept this example: >

[PATCH] D147836: [clang] Add test for CWG1822

This revision was automatically updated to reflect the committed changes. Closed by commit rG86946ebb796c: [clang] Add test for CWG1822 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147836/new/ https://reviews.llvm.org/D147836

[PATCH] D147839: [clang] Add test for CWG2007

Endill added inline comments. Comment at: clang/test/CXX/drs/dr20xx.cpp:20 +// FIXME: the following code shouldn't instantiate A. +// int b = ()->foo; +} shafik wrote: > shafik wrote: > > It looks like gcc and MSVC also instantiate `A` for this case: > >

[PATCH] D147564: [clang] Mark CWG536 as N/A

This revision was automatically updated to reflect the committed changes. Closed by commit rG6737a1520900: [clang] Mark CWG536 as N/A (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147564/new/ https://reviews.llvm.org/D147564

[PATCH] D147920: [clang] Add test for CWG399

Endill added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:1439 + +namespace dr399 { // dr399: 11 + // NB: reuse dr244 test Despite a couple of FIXME in CWG244 test (out of dozens of examples), it claims full availability since

[PATCH] D147920: [clang] Add test for CWG399

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG399 is resolved by explicitly appealing to

[PATCH] D147848: [clang] Add test for CWG2370

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG2370 is resolved by performing a search in

[PATCH] D147839: [clang] Add test for CWG2007

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG2007 is resolved by skipping unqualified

  1   2   3   >