Re: [clang] bd87916 - [clang] Add no_builtin attribute

Yup, I didn't follow up to this email but we talked on gchat and sorted it out. On Tue, Oct 29, 2019 at 2:20 PM Vitaly Buka wrote: > Ignoring "slave lost exception" bots are green for a while > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast?numbuilds=100 > >

Re: [clang] ec66603 - [clang-format] Remove the dependency on frontend

I've reverted this commit as it was causing UBSan failures on the ubsan bot. These failures looked like: llvm/lib/Support/SourceMgr.cpp:440:48: runtime error: pointer index expression with base 0x overflowed to 0xfffa Looking at a backtrace, this line was reached from the

[clang] efed314 - Revert "[clang-format] Remove the dependency on frontend"

Author: Vlad Tsyrklevich Date: 2019-10-29T10:48:03-07:00 New Revision: efed314118c7c287a71b8a8d67953a98d8a718d5 URL: https://github.com/llvm/llvm-project/commit/efed314118c7c287a71b8a8d67953a98d8a718d5 DIFF:

Re: [clang] bd87916 - [clang] Add no_builtin attribute

I've reverted this change as it was causing ASan/MSan failures in check-clang, e.g. take a look at the bottom 2 failures here: http://lab.llvm.org:8014/builders/sanitizer-x86_64-linux-bootstrap/builds/124/steps/check-clang%20asan/logs/stdio or here

[clang] ad531ff - Revert "[clang] Add no_builtin attribute"

Author: Vlad Tsyrklevich Date: 2019-10-28T15:21:59-07:00 New Revision: ad531fff81a2a266ffed1d7da778cb59c983 URL: https://github.com/llvm/llvm-project/commit/ad531fff81a2a266ffed1d7da778cb59c983 DIFF:

[clang] 38839d0 - Revert "[Concepts] Constraint Enforcement & Diagnostics"

Author: Vlad Tsyrklevich Date: 2019-10-28T15:00:40-07:00 New Revision: 38839d08b8e165dfaab0fa6acc77e620d6df294c URL: https://github.com/llvm/llvm-project/commit/38839d08b8e165dfaab0fa6acc77e620d6df294c DIFF:

r370142 - Revert "Change the X86 datalayout to add three address spaces for 32 bit signed, "

Author: vlad.tsyrklevich Date: Tue Aug 27 18:08:54 2019 New Revision: 370142 URL: http://llvm.org/viewvc/llvm-project?rev=370142=rev Log: Revert "Change the X86 datalayout to add three address spaces for 32 bit signed," This reverts commit r370083 because it caused check-lld failures on

r362830 - Revert "[CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods."

Author: vlad.tsyrklevich Date: Fri Jun 7 12:18:30 2019 New Revision: 362830 URL: http://llvm.org/viewvc/llvm-project?rev=362830=rev Log: Revert "[CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods." This reverts commit f1f6e0fc2468e9c120b22b939507c527d08b8ee8,

Re: r362785 - [CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods.

This change caused LSan failures and has been reverted in r362830: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/32809 On Fri, Jun 7, 2019 at 2:42 AM Sam McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: sammccall > Date: Fri Jun 7 02:45:17 2019 > New

r355624 - Delete x86_64 ShadowCallStack support

Author: vlad.tsyrklevich Date: Thu Mar 7 10:56:36 2019 New Revision: 355624 URL: http://llvm.org/viewvc/llvm-project?rev=355624=rev Log: Delete x86_64 ShadowCallStack support Summary: ShadowCallStack on x86_64 suffered from the same racy security issues as Return Flow Guard and had performance

Re: r354795 - Make static counters in ASTContext non-static.

I've reverted this commit in r354812, it was causing MSan failures like http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/29886/steps/check-clang%20msan/logs/stdio Though these error reports don't clearly implicate this change, from your change it seems like the failure is

r354812 - Revert "Make static counters in ASTContext non-static."

Author: vlad.tsyrklevich Date: Mon Feb 25 11:53:13 2019 New Revision: 354812 URL: http://llvm.org/viewvc/llvm-project?rev=354812=rev Log: Revert "Make static counters in ASTContext non-static." This reverts commit r354795, I suspect it is causing test failures on MSan sanitizer bots. Modified:

Re: r351514 - [analyzer] Introduce proper diagnostic for freeing unowned object

Hi, I've reverted r351508-351514 as they were causing MSan failures on the sanitizer bots. It looks like isLeak is not initialized by one of the RefCountReport constructors and it is not immediately obvious to me what an appropriate value for it is. You can observe the failures here

r351528 - Fix failing MSan bots

Author: vlad.tsyrklevich Date: Fri Jan 18 00:43:22 2019 New Revision: 351528 URL: http://llvm.org/viewvc/llvm-project?rev=351528=rev Log: Fix failing MSan bots Revert r351508-351514, this block of changes introduced a consistent MSan failure on the sanitizer bots. Removed:

r351457 - TLS: Respect visibility for thread_local variables on Darwin (PR40327)

Author: vlad.tsyrklevich Date: Thu Jan 17 09:53:45 2019 New Revision: 351457 URL: http://llvm.org/viewvc/llvm-project?rev=351457=rev Log: TLS: Respect visibility for thread_local variables on Darwin (PR40327) Summary: Teach clang to mark thread wrappers for thread_local variables with hidden

Re: r351222 - [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

This change was causing MSan/ASan failures on the sanitizer bots: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/28272 I reverted it in r351282. On Tue, Jan 15, 2019 at 11:09 AM Haojian Wu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hokein > Date: Tue

r351282 - Revert "[Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database."

Author: vlad.tsyrklevich Date: Tue Jan 15 16:37:39 2019 New Revision: 351282 URL: http://llvm.org/viewvc/llvm-project?rev=351282=rev Log: Revert "[Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database." This reverts commits r351222 and r351229, they

r351159 - Revert alignment assumptions changes

Author: vlad.tsyrklevich Date: Mon Jan 14 19:38:02 2019 New Revision: 351159 URL: http://llvm.org/viewvc/llvm-project?rev=351159=rev Log: Revert alignment assumptions changes Revert r351104-6, r351109, r351110, r351119, r351134, and r351153. These changes fail on the sanitizer bots. Removed:

Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

This change appears to have broken a number of compiler-rt coverage tests, e.g. in this run . The source of the error appears to be that llvm-cov is now trying to use a relative

Re: r344915 - Ensure sanitizer check function calls have a !dbg location

This change causes build failures on the UBSan bot, like so : 3. /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm/include/llvm/Support/Allocator.h:98:40:

r344961 - Revert "Ensure sanitizer check function calls have a !dbg location"

Author: vlad.tsyrklevich Date: Mon Oct 22 14:51:58 2018 New Revision: 344961 URL: http://llvm.org/viewvc/llvm-project?rev=344961=rev Log: Revert "Ensure sanitizer check function calls have a !dbg location" This reverts commit r344915. It was causing exceptions on the x86_64-linux-ubsan bot.

r339720 - SafeStack: Disable Darwin support

Author: vlad.tsyrklevich Date: Tue Aug 14 12:50:41 2018 New Revision: 339720 URL: http://llvm.org/viewvc/llvm-project?rev=339720=rev Log: SafeStack: Disable Darwin support Summary: Darwin support does not appear to be used as evidenced by the fact that the runtime has never supported non-trivial

Re: r338899 - [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin

Have you tried setting detect_stack_use_after_return in ASAN_OPTIONS? The ASan buildbot sets the following ASAN_OPTIONS prior to running tests: export ASAN_OPTIONS="check_initialization_order=true:detect_stack_use_after_return=1:detect_leaks=1" On Mon, Aug 6, 2018 at 7:34 AM wrote: > I can't

Re: r338899 - [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin

This change is causing ASan failures on the sanitizer bots: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/21898/steps/check-clang%20asan/logs/stdio I've reverted it in r338904. On Fri, Aug 3, 2018 at 8:51 AM Scott Linder via cfe-commits < cfe-commits@lists.llvm.org> wrote:

r338904 - Revert "[OpenCL] Always emit alloca in entry block for enqueue_kernel builtin"

Author: vlad.tsyrklevich Date: Fri Aug 3 10:47:58 2018 New Revision: 338904 URL: http://llvm.org/viewvc/llvm-project?rev=338904=rev Log: Revert "[OpenCL] Always emit alloca in entry block for enqueue_kernel builtin" This reverts commit r338899, it was causing ASan test failures on

r338648 - [AST] Remove the static_assert check in ObjCMethodDecl::ObjCMethodDecl

Author: vlad.tsyrklevich Date: Wed Aug 1 15:41:03 2018 New Revision: 338648 URL: http://llvm.org/viewvc/llvm-project?rev=338648=rev Log: [AST] Remove the static_assert check in ObjCMethodDecl::ObjCMethodDecl Summary: This check was introduced by r338641 but this broke some builds. For now

r337037 - SafeStack: Add builtins to read unsafe stack top/bottom

Author: vlad.tsyrklevich Date: Fri Jul 13 12:48:35 2018 New Revision: 337037 URL: http://llvm.org/viewvc/llvm-project?rev=337037=rev Log: SafeStack: Add builtins to read unsafe stack top/bottom Summary: Introduce built-ins to read the unsafe stack top and bottom. The unsafe stack top is required

Re: r336590 - [libclang] evalute compound statement cursors before trying to evaluate

The ASan bot is failing with a LeakSanitizer failure that appears related to one of your libclang changes: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/6282/steps/check-clang%20asan/logs/stdio Direct leak of 24 byte(s) in 1 object(s) allocated from: #0 0x52c638 in

r334067 - [Analyzer][Z3] Test fixes for Z3 constraint manager

Author: vlad.tsyrklevich Date: Tue Jun 5 23:25:51 2018 New Revision: 334067 URL: http://llvm.org/viewvc/llvm-project?rev=334067=rev Log: [Analyzer][Z3] Test fixes for Z3 constraint manager Summary: Since Z3 tests have been not been running [1] some tests needed to be updated. I also added a

r334065 - [Analyzer] Fix Z3ConstraintManager crash (PR37646)

Author: vlad.tsyrklevich Date: Tue Jun 5 23:09:02 2018 New Revision: 334065 URL: http://llvm.org/viewvc/llvm-project?rev=334065=rev Log: [Analyzer] Fix Z3ConstraintManager crash (PR37646) Summary: Fix another Z3ConstraintManager crash, use fixAPSInt() to extend a boolean APSInt. Reviewers:

r329942 - Fix doc typo

Author: vlad.tsyrklevich Date: Thu Apr 12 12:35:39 2018 New Revision: 329942 URL: http://llvm.org/viewvc/llvm-project?rev=329942=rev Log: Fix doc typo Modified: cfe/trunk/docs/ControlFlowIntegrity.rst Modified: cfe/trunk/docs/ControlFlowIntegrity.rst URL:

[libcxxabi] r329629 - [CFI] Disable CFI checks for __cxa_decrement_exception_refcount

Author: vlad.tsyrklevich Date: Mon Apr 9 15:11:28 2018 New Revision: 329629 URL: http://llvm.org/viewvc/llvm-project?rev=329629=rev Log: [CFI] Disable CFI checks for __cxa_decrement_exception_refcount Summary: exception_header->exceptionDestructor is a void(*)(void*) function pointer; however,

r329122 - Add the -fsanitize=shadow-call-stack flag

Author: vlad.tsyrklevich Date: Tue Apr 3 15:33:53 2018 New Revision: 329122 URL: http://llvm.org/viewvc/llvm-project?rev=329122=rev Log: Add the -fsanitize=shadow-call-stack flag Summary: Add support for the -fsanitize=shadow-call-stack flag which causes clang to add ShadowCallStack attribute

Re: r327547 - Attempt to fix failure of deep-ast-tree.cpp on atom and s390

Hi Yaxun, the test continues to be broken on the sanitizer buildbots: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/4639 http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-msan/builds/3298

Re: r323528 - [AST] Use bit packing to reduce sizeof(TypedefNameDecl) from 88 to 80.

This change has broken a number of buildbots, e.g. http://lab.llvm.org:8011/builders/sanitizer-windows/builds/23163 On Fri, Jan 26, 2018 at 6:15 AM Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Fri Jan 26 06:14:11 2018 > New Revision: 323528 > > URL:

r317044 - [CFI] Add CFI-icall pointer type generalization

Author: vlad.tsyrklevich Date: Tue Oct 31 15:39:44 2017 New Revision: 317044 URL: http://llvm.org/viewvc/llvm-project?rev=317044=rev Log: [CFI] Add CFI-icall pointer type generalization Summary: This change allows generalizing pointers in type signatures used for cfi-icall by enabling the

r314171 - Allow specifying sanitizers in blacklists

Author: vlad.tsyrklevich Date: Mon Sep 25 15:11:12 2017 New Revision: 314171 URL: http://llvm.org/viewvc/llvm-project?rev=314171=rev Log: Allow specifying sanitizers in blacklists Summary: This is the follow-up patch to D37924. This change refactors clang to use the the newly added section

r312986 - Fix broken links to the Itanium CXX ABI

Author: vlad.tsyrklevich Date: Mon Sep 11 17:21:17 2017 New Revision: 312986 URL: http://llvm.org/viewvc/llvm-project?rev=312986=rev Log: Fix broken links to the Itanium CXX ABI Modified: cfe/trunk/docs/ControlFlowIntegrityDesign.rst cfe/trunk/docs/Toolchain.rst

r311211 - Revert "[clang-diff] Move the JSON export function to clang-diff"

Author: vlad.tsyrklevich Date: Fri Aug 18 16:21:11 2017 New Revision: 311211 URL: http://llvm.org/viewvc/llvm-project?rev=311211=rev Log: Revert "[clang-diff] Move the JSON export function to clang-diff" This reverts commit r311199, it was causing widespread build failures. Removed:

r310132 - Reland "CFI: blacklist STL allocate() from unrelated-casts"

Author: vlad.tsyrklevich Date: Fri Aug 4 14:21:00 2017 New Revision: 310132 URL: http://llvm.org/viewvc/llvm-project?rev=310132=rev Log: Reland "CFI: blacklist STL allocate() from unrelated-casts" Reland r310097 with a fix for a debug assertion in NamedDecl.getName() Differential Revision:

r310121 - Revert "Reland "CFI: blacklist STL allocate() from unrelated-casts""

Author: vlad.tsyrklevich Date: Fri Aug 4 13:37:49 2017 New Revision: 310121 URL: http://llvm.org/viewvc/llvm-project?rev=310121=rev Log: Revert "Reland "CFI: blacklist STL allocate() from unrelated-casts"" This reverts commit r310105. Removed: cfe/trunk/test/CodeGen/cfi-unrelated-cast.cpp

r310105 - Reland "CFI: blacklist STL allocate() from unrelated-casts"

Author: vlad.tsyrklevich Date: Fri Aug 4 12:50:39 2017 New Revision: 310105 URL: http://llvm.org/viewvc/llvm-project?rev=310105=rev Log: Reland "CFI: blacklist STL allocate() from unrelated-casts" Reland r310097 with a unit test fix for MS ABI build bots. Differential Revision:

r310099 - Revert "CFI: blacklist STL allocate() from unrelated-casts"

Author: vlad.tsyrklevich Date: Fri Aug 4 12:17:16 2017 New Revision: 310099 URL: http://llvm.org/viewvc/llvm-project?rev=310099=rev Log: Revert "CFI: blacklist STL allocate() from unrelated-casts" This reverts commit r310097. Removed: cfe/trunk/test/CodeGen/cfi-unrelated-cast.cpp Modified:

r310097 - CFI: blacklist STL allocate() from unrelated-casts

Author: vlad.tsyrklevich Date: Fri Aug 4 12:10:11 2017 New Revision: 310097 URL: http://llvm.org/viewvc/llvm-project?rev=310097=rev Log: CFI: blacklist STL allocate() from unrelated-casts Summary: Previously, STL allocators were blacklisted in compiler_rt's cfi_blacklist.txt because they