[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev added a comment. In D144006#4656399 , @aeubanks wrote: > In D144006#4656383 , @dzhidzhoev > wrote: > >> In D144006#4656371 , @aeubanks >> wrote: >> >>> Is

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev added a comment. In D144006#4656728 , @jmorse wrote: > Hi, > > Just to note that we've been seeing LTO crashes as a result of > rG3b449bd46a11a > (now > reverted on

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev added a comment. In D144006#4656371 , @aeubanks wrote: > Is there any issue with mixing IR built with > `LLVMContext::enableDebugTypeODRUniquing()` and without? I'm suspecting that > ThinLTO is mixing Rust and Clang IR which set that

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev added a comment. In D144006#4656350 , @aeubanks wrote: > Heads up, we're seeing issues from this in Chrome again, will try to post a > reduced repro (https://crbug.com/1500022) > > The reduced repro I found crashed very far back, so I'm

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev added a comment. In D144006#4651955 , @hans wrote: > We're hitting an assert after this change: > > llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:2331: > virtual void llvm::DwarfDebug::endFunctionImpl(const llvm::MachineFunction > *): >

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf8aab289b554: [DebugMetadata][DwarfDebug] Support function-local types in lexical block… (authored by dzhidzhoev). Changed prior to commit:

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev updated this revision to Diff 555845. dzhidzhoev added a comment. Rebased on top of https://reviews.llvm.org/D158730. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 Files:

[PATCH] D158730: [DebugMetadata][DwarfDebug] Don't retain local types with -fno-eliminate-unused-debug-types

dzhidzhoev updated this revision to Diff 555844. dzhidzhoev added a comment. Rebased on top of https://reviews.llvm.org/D155818. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158730/new/ https://reviews.llvm.org/D158730 Files:

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG38c92c1ee2f0: [AArch64] Add patterns for FMADD, FMSUB (authored by overmighty, committed by dzhidzhoev). Repository: rG LLVM Github Monorepo

[PATCH] D158730: [DebugMetadata][DwarfDebug] Don't retain local types with -fno-eliminate-unused-debug-types

dzhidzhoev added a comment. In D158730#4614172 , @nickdesaulniers wrote: > Seems fine to me, but please triple check as the presubmit tests are failing. > > Perhaps you meant to mark this as a parent or child revision in phab with > your other change,

[PATCH] D158730: [DebugMetadata][DwarfDebug] Don't retain local types with -fno-eliminate-unused-debug-types

dzhidzhoev created this revision. dzhidzhoev added reviewers: aprantl, dblaikie, jdoerfert, dexonsmith, rnk, nickdesaulniers. Herald added a subscriber: hiraditya. Herald added a project: All. dzhidzhoev requested review of this revision. Herald added projects: clang, LLVM. Herald added

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

dzhidzhoev accepted this revision. dzhidzhoev added a subscriber: arsenm. dzhidzhoev added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:5393 + (EXTRACT_SUBREG V128:$Rn, hsub), FPR16:$Rm, FPR16:$Ra)>; + } + overmighty

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

dzhidzhoev added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:5418 + (EXTRACT_SUBREG V128:$Rn, dsub), FPR64:$Rm, FPR64:$Ra)>; } Is it possible to use extractelt here? Since vector_extract is marked as deprecated in

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

dzhidzhoev added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:5393 + (EXTRACT_SUBREG V128:$Rn, hsub), FPR16:$Rm, FPR16:$Ra)>; + } + BTW, these lines add some patterns for fnmadd. Could you add some tests for them? Or

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

dzhidzhoev added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:5381-5393 + let Predicates = [HasFullFP16] in { + def : Pat<(f16 (node (f16 FPR16:$Rn), + (f16 (vector_extract (v8f16 V128:$Rm), (i64 0))), +

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev updated this revision to Diff 550270. dzhidzhoev added a comment. Rebased (on top of https://reviews.llvm.org/D155818). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 Files:

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev updated this revision to Diff 544711. dzhidzhoev added a comment. Rebased on top of https://reviews.llvm.org/D155818. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 Files:

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev added a comment. In D144006#4435677 , @hoy wrote: > Hello, I'm seeing a build failure that seems related to this patch. I'm > seeing the patch has been relanded and reverted a couple times and not sure > where it is right now. Can you please

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev added a comment. Thank you for reports! I've reverted it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 ___ cfe-commits mailing list

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66511b401042: [DebugMetadata][DwarfDebug] Support function-local types in lexical block… (authored by dzhidzhoev). Repository: rG LLVM Github

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev updated this revision to Diff 532642. dzhidzhoev added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 Files: clang/test/CodeGen/debug-info-codeview-unnamed.c

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd04452d54829: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported… (authored by dzhidzhoev). Changed prior to commit:

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev added a comment. Updated DebugInfo test of OCaml binding. In D143984#4409015 , @dblaikie wrote: > When we migrated to github we gained higher fidelity for attributing authors > (we can now commit on someone's behalf but have the commit

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev added a comment. In D143984#4405875 , @steakhal wrote: > I think this patch broke two build bots, and now the CI is red. > https://lab.llvm.org/buildbot/#/builders/16/builds/49282 > https://lab.llvm.org/buildbot/#/builders/109/builds/65904 > >

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4418434c6de7: [DebugMetadata] Simplify handling subprograms retainedNodes field. NFCI (1/7) (authored by krisb, committed by dzhidzhoev).

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev updated this revision to Diff 529100. dzhidzhoev added a comment. Added AutoUpdater, moving function-local types belonging to DICompileUnit to a corresponding DISubprogram. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

dzhidzhoev updated this revision to Diff 529098. dzhidzhoev added a comment. Added AutoUpdater, moving function-local imported entities belonging to DICompileUnit to a corresponding DISubprogram. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev updated this revision to Diff 529096. dzhidzhoev added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143984/new/ https://reviews.llvm.org/D143984 Files: clang/test/CodeGen/attr-btf_tag-disubprogram-callsite.c

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev added a comment. In D143984#4362988 , @dblaikie wrote: > In D143984#4358115 , @dzhidzhoev > wrote: > >> In D143984#4357517 , @dblaikie >> wrote: >> >>> Looks

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev added a comment. In D143984#4357517 , @dblaikie wrote: > Looks like this series got approved - is it waiting on any particular > feedback, or do you need someone to commit it for you? I had been waiting for approval for the change of

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

dzhidzhoev updated this revision to Diff 522257. dzhidzhoev added a comment. Fixed split-dwarf-local-import*.ll tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144004/new/ https://reviews.llvm.org/D144004 Files:

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

dzhidzhoev updated this revision to Diff 522254. dzhidzhoev added a comment. Herald added subscribers: mattd, gchakrabarti, asavonic, kerbowa, jvesely, jholewinski. Fixed split-dwarf-local-import*.ll tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (5/7)

dzhidzhoev updated this revision to Diff 522140. dzhidzhoev added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 Files: clang/test/CodeGen/debug-info-codeview-unnamed.c

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

dzhidzhoev updated this revision to Diff 522138. dzhidzhoev added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144004/new/ https://reviews.llvm.org/D144004 Files: clang/test/CodeGenCXX/debug-info-namespace.cpp

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev updated this revision to Diff 522136. dzhidzhoev added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143984/new/ https://reviews.llvm.org/D143984 Files: clang/test/CodeGen/attr-btf_tag-disubprogram-callsite.c

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (5/7)

dzhidzhoev commandeered this revision. dzhidzhoev added a reviewer: krisb. dzhidzhoev added a comment. See https://reviews.llvm.org/D143984#4341780 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

dzhidzhoev commandeered this revision. dzhidzhoev added a reviewer: krisb. dzhidzhoev added a comment. See https://reviews.llvm.org/D143984#4341780 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144004/new/ https://reviews.llvm.org/D144004

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev commandeered this revision. dzhidzhoev added a reviewer: krisb. dzhidzhoev added a comment. @krisb is out of office for some time, so she asked to retake and wrap up this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf6c0b6d8c9d: [clang][CodeGen] Use base subobject type layout for potentially-overlapping… (authored by dzhidzhoev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev added inline comments. Comment at: clang/lib/CodeGen/CGRecordLayoutBuilder.cpp:370 + const auto StorageAlignment = getAlignment(StorageType); + if (LayoutSize % StorageAlignment || Layout.getDataSize() % StorageAlignment) Packed = true;

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev updated this revision to Diff 497847. dzhidzhoev added a comment. Simplified condition in lowerUnion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139741/new/ https://reviews.llvm.org/D139741 Files: clang/include/clang/AST/Decl.h

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev marked an inline comment as not done. dzhidzhoev added a comment. Existing code creating base subobject layout of classes is reused for unions * Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139741/new/ https://reviews.llvm.org/D139741

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev added inline comments. Comment at: clang/lib/CodeGen/CGRecordLayoutBuilder.cpp:370 + const auto StorageAlignment = getAlignment(StorageType); + if (LayoutSize % StorageAlignment || Layout.getDataSize() % StorageAlignment) Packed = true;

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev updated this revision to Diff 491807. dzhidzhoev added a comment. Fixed crash for 'struct C' in no-unique-address-3.cpp. Without the fix, packedness for regular union layout in provided test and for [[no_unique_address]] union layout turns out to be different. This causes assertion on

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev updated this revision to Diff 489215. dzhidzhoev added a comment. Clang-format'ted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139741/new/ https://reviews.llvm.org/D139741 Files: clang/include/clang/AST/Decl.h

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev updated this revision to Diff 489160. dzhidzhoev added a comment. Fixed crashes reported by @efriedma and @rupprecht. "Base subobject type" layout (e.g. type layout without suffix padding) is calculated for unions and final classes too here, in order to lay out fields with

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev added a comment. In D139741#4002244 , @efriedma wrote: > Does the following work with the updated patch? > > class Empty {}; > class UnionClass : Empty { > [[no_unique_address]] union X { > private: > Empty x; >

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev updated this revision to Diff 483519. dzhidzhoev added a comment. Ignore union fields. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139741/new/ https://reviews.llvm.org/D139741 Files: clang/include/clang/AST/Decl.h

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev reopened this revision. dzhidzhoev added a comment. This revision is now accepted and ready to land. In D139741#4000201 , @rupprecht wrote: > I'm not sure what the libcxx failure was that caused you to revert this, but > we also saw a clang

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG731abdfdcc33: [clang][CodeGen] Use base subobject type layout for potentially-overlapping… (authored by dzhidzhoev). Repository: rG LLVM Github

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev updated this revision to Diff 483121. dzhidzhoev added a comment. clang-format'ed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139741/new/ https://reviews.llvm.org/D139741 Files: clang/include/clang/AST/Decl.h

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev updated this revision to Diff 482874. dzhidzhoev added a comment. Addressed @efriedma comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139741/new/ https://reviews.llvm.org/D139741 Files: clang/include/clang/AST/Decl.h

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev created this revision. dzhidzhoev added reviewers: kjdyck, rjmccall, efriedma, majnemer, aaron.ballman, rsmith. Herald added a project: All. dzhidzhoev requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. RecordLayoutBuilder assumes