yota9 added a comment.
Also please keep in mind that despite of different behaviour in gcc/clang not
implying outline atomics won't result in any problems, but implying them in
cases where we don't want them might result in some problems.
Offtopic: Outlining atomics seems to be very CPU
yota9 added a comment.
Great! I've add MaskRay to the reviewers list as known expert in both clang and
gcc, maybe he have some thoughts on this proposal :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159398/new/
https://reviews.llvm.org/D159398
yota9 added a comment.
>> Outline atomics are dependent on runtime library availability ( libgcc or
>> compler-rt ).
I understand that, but we can use compiler that have runtime library, but in
freestanding mode usually we don't want it to be used.
I understand that you could disable it with
yota9 added a comment.
The problem here is that if you would remove the freestanding condition and run
this test it would fail since "-target-feature" "+outline-atomics" would be
passed to the clang. And usually we don't want the compiler to use any
external symbols in freestanding mode, this
yota9 added a comment.
The build failure has nothing to do with the patch and it caused by
https://reviews.llvm.org/D140612
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159398/new/
https://reviews.llvm.org/D159398
yota9 created this revision.
Herald added a subscriber: kristof.beyls.
Herald added a project: All.
yota9 requested review of this revision.
Herald added subscribers: cfe-commits, wangpc, MaskRay.
Herald added a project: clang.
In freestanding environment we don't want extra dependencies on the
