[PATCH] D156933: [HLSL] Add reversebits library function

python3kgae accepted this revision. python3kgae added a comment. This revision is now accepted and ready to land. Don't need -fnative-half-type in the RUN line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156933/new/

[PATCH] D156933: [HLSL] Add reversebits library function

python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/bitreverse.hlsl:32 +// CHECK: call <4 x i16> @llvm.bitreverse.v4i16 +// NO_HALF: define noundef <4 x i16> @"?test_bitreverse_short4@@YAT?$__vector@F$03@__clang@@T12@@Z"( +// NO_HALF: call <4 x i16>

[PATCH] D155729: [OptTable] Make explicitly included options override excluded ones

python3kgae accepted this revision. python3kgae added a comment. This revision is now accepted and ready to land. This is much cleaner. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155729/new/ https://reviews.llvm.org/D155729

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

python3kgae updated this revision to Diff 511795. python3kgae added a comment. Update the comment done by rjmccall. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146897/new/ https://reviews.llvm.org/D146897 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

python3kgae updated this revision to Diff 511697. python3kgae added a comment. Revert change for self-assign-field which deserve its own pull request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146897/new/ https://reviews.llvm.org/D146897

[PATCH] D147657: [Sema] Fix reporting of invalid shader attribute on HLSL entry function

python3kgae accepted this revision. python3kgae added a comment. This revision is now accepted and ready to land. Thanks for fix the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147657/new/ https://reviews.llvm.org/D147657

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

python3kgae updated this revision to Diff 510976. python3kgae added a comment. skip warning on field for compound assignment when isImplicitCXXThis matches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146897/new/ https://reviews.llvm.org/D146897

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

python3kgae added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15656 case BO_XorAssign: -DiagnoseSelfAssignment(S, LHS, RHS, OpLoc, false); CheckIdentityFieldAssignment(LHS, RHS, OpLoc, S); break; rsmith wrote: > This is the same

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

python3kgae created this revision. python3kgae added reviewers: rjmccall, Quuxplusone, riccibruno. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes 42469

[PATCH] D144309: [HLSL] add max/min library functions

python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/max.hlsl:12 +// NO_HALF: call i16 @llvm.smax.i16( +int16_t test_max_short ( int16_t p0, int16_t p1 ) { + return max ( p0, p1 ); Just guard 16bit integer tests with #ifdef

[PATCH] D144309: [HLSL] add max/min library functions

python3kgae added a comment. In D144309#4159431 , @bob80905 wrote: > - ushort is now unsigned Use uint16_t/int16_t/uint64_t/int64_t for 16/64 bit integers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144309: [HLSL] add max/min library functions

python3kgae added a comment. In D144309#4156971 , @bob80905 wrote: > add int support for max/min. Sorry didn't check more :(. Now i16/u16/i32/u32/i64/u64/f16/f32/f64 are all supported for min/max in hlsl. Repository: rG LLVM Github Monorepo

[PATCH] D144309: [HLSL] add max/min library functions

python3kgae added a comment. max/min does work on integers in HLSL. And __builtin_elementwise_max/min support both integers and floats. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144309/new/ https://reviews.llvm.org/D144309

[PATCH] D144802: clang: Add __builtin_elementwise_round

python3kgae added inline comments. Comment at: clang/docs/LanguageExtensions.rst:646 direction. + T __builtin_elementwise_round(T x) round x to the nearest integer value in floating point format, floating point types +

[PATCH] D144120: [HLSL] add log library functions

python3kgae accepted this revision. python3kgae added a comment. This revision is now accepted and ready to land. LGTM. Just fix the newline at end of file for the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144120/new/

[PATCH] D143207: Add codegen for llvm log10 elementwise builtin

python3kgae added a comment. Add log2 together? They're in same category. Comment at: clang/test/Sema/aarch64-sve-vector-log-ops.c:19 +} \ No newline at end of file newline. Comment at: clang/test/SemaCXX/builtins-elementwise-math.cpp:90 +}

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5a7439e220c: [HLSL] [Dirver] add dxv as a VerifyDebug Job (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:687 +def warn_drv_dxc_missing_dxv : Warning<"dxv not found." +" Resulting DXIL will not be signed for use in release environments.">; MaskRay wrote: >

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 493149. python3kgae marked 2 inline comments as done. python3kgae added a comment. add space for warning message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https://reviews.llvm.org/D141705

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/test/Driver/dxc_dxv_path.hlsl:7 +// RUN: echo "dxv" > %T/dxv && chmod 754 %T/dxv && %clang_dxc --dxv-path=%T %s -Tlib_6_3 -### 2>&1 | FileCheck %s --check-prefix=DXV_PATH +//

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492941. python3kgae marked 2 inline comments as done. python3kgae added a comment. Fix windows test fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https://reviews.llvm.org/D141705 Files:

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:170 + +Tool *clang::driver::toolchains::HLSLToolChain::getTool( +Action::ActionClass AC) const { jhuber6 wrote: > python3kgae

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492931. python3kgae marked an inline comment as done. python3kgae added a comment. rename to requiresValidation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https://reviews.llvm.org/D141705

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4226 +Args.ClaimAllArgs(options::OPT_cl_ignored_Group); + } jhuber6 wrote: > nit. remember to `clang-format` arc did find some

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4217-4218 +// Only add action when needValidation. +const auto = getToolChain(Args, C.getDefaultToolChain().getTriple()); +const auto *HLSLTC = static_cast(); +if

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492912. python3kgae marked 2 inline comments as done. python3kgae added a comment. switch to getDefaultToolChain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https://reviews.llvm.org/D141705

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492894. python3kgae marked 2 inline comments as done. python3kgae added a comment. cast ToolChain to HLSLToolChain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked 6 inline comments as done. python3kgae added inline comments. Comment at: clang/include/clang/Driver/Types.def:110 TYPE("api-information", API_INFO, INVALID, "json", phases::Precompile) +TYPE("dx-container", DX_CONTAINER,

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4218 +// Only add action when needValidation. +if (toolchains::HLSLToolChain::needValidation(Args, *this, +

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4216 + llvm::Triple T(getTargetTriple()); + if (T.getArch() == llvm::Triple::dxil && !Args.getLastArg(options::OPT_dxc_disable_validation)) { +// Only

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492878. python3kgae marked 9 inline comments as done. python3kgae added a comment. add DX_CONTAINER Driver type. Code cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked 2 inline comments as done. python3kgae added a comment. In D141705#4082935 , @jhuber6 wrote: > I'm not overly familiar with HLSL or DirectX here. Most of the changes are > purely mechanical, but I don't see anywhere we create the

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492559. python3kgae marked an inline comment as done. python3kgae added a comment. Only create dxv job when 'dxv' exist. Test ccc-print-bindings. Code cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136913: [HLSL] support RWByteAddressBuffer.

python3kgae updated this revision to Diff 490274. python3kgae added a comment. Rebase and update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136913/new/ https://reviews.llvm.org/D136913 Files:

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae added a comment. In D136031#4062756 , @beanz wrote: > @python3kgae, this change introduced a bunch of warning spew because it is > using an API that was deprecated shortly before the change merged. Can you > please address this? Sure. I'll

[PATCH] D141705: [HLSL] [Dirver] add dxv as a VerifyDebug Job

python3kgae added a comment. In D141705#4059162 , @beanz wrote: > Re-using the `VerifyDebug` action really doesn't make sense. That's not what > the DXIL validator does, and it will be a source of confusion forever. Added BinaryAnalyzeJobClass.

[PATCH] D141705: [HLSL] [Dirver] add dxv as a VerifyDebug Job

python3kgae updated this revision to Diff 489935. python3kgae marked 2 inline comments as done. python3kgae added a comment. Add BinaryAnalyzeJobClass. Add -Vd to disable validation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/

[PATCH] D141705: [HLSL] [Dirver] add dxv as a VerifyDebug Job

python3kgae created this revision. python3kgae added reviewers: beanz, pow2clk, bogner, bob80905. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. New

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG944f4b280585: [DirectX backend] add support ConstantBuffer to DXILResource.h (authored by python3kgae). Repository: rG LLVM Github Monorepo

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 488707. python3kgae added a comment. Fix test fail after rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 Files:

[PATCH] D140489: Add builtin_elementwise_log

python3kgae added inline comments. Comment at: clang/docs/LanguageExtensions.rst:638 T __builtin_elementwise_floor(T x) return the largest integral value less than or equal to xfloating point types + T __builtin_elementwise_log(T x)return the

[PATCH] D139935: [NFC] [Doc] Fix example for AnnotateTypeDocs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad48e9669a80: [NFC] [Doc] Fix example for AnnotateTypeDocs (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 486390. python3kgae added a comment. Add unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 Files: llvm/lib/Target/DirectX/CBufferDataLayout.cpp

[PATCH] D140992: clang: Add __builtin_elementwise_fma

python3kgae added a comment. Need update clang/docs/ReleaseNotes.rst for new intrinsic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140992/new/ https://reviews.llvm.org/D140992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 486070. python3kgae added a comment. Use llvm::TypeSize and uint32_t instead of unsigned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 Files:

[PATCH] D139935: [NFC] [Doc] Fix example for AnnotateTypeDocs

python3kgae added a comment. Happy new year and ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139935/new/ https://reviews.llvm.org/D139935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 485747. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 Files: llvm/lib/Target/DirectX/CBufferDataLayout.cpp

[PATCH] D139935: [NFC] [Doc] Fix example for AnnotateTypeDocs

python3kgae added a comment. Merry Christmas and ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139935/new/ https://reviews.llvm.org/D139935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D136743: [HLSL] support ConstantBuffer

python3kgae updated this revision to Diff 483171. python3kgae added a comment. Herald added a reviewer: aaron.ballman. Change CBV implementation to template using ConstantBuffer = T; Added new internal attribute HLSLConstantBufferView to mark CBV with AttributedType. Repository: rG LLVM

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 482620. python3kgae added a comment. Rebase and remove the counter in resource metadata to match clang change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031

[PATCH] D139935: [NFC] [Doc] Fix example for AnnotateTypeDocs

python3kgae created this revision. python3kgae added reviewers: mboehme, aaron.ballman, erichkeane. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Change clang::annotate into clang::annotate_type.

[PATCH] D136743: [HLSL] support ConstantBuffer

python3kgae updated this revision to Diff 481861. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136743/new/ https://reviews.llvm.org/D136743 Files: clang/lib/Sema/HLSLExternalSemaSource.cpp

[PATCH] D136913: [HLSL] support RWByteAddressBuffer.

python3kgae updated this revision to Diff 481858. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136913/new/ https://reviews.llvm.org/D136913 Files: clang/include/clang/Sema/HLSLExternalSemaSource.h

[PATCH] D139742: [HLSL] Add trunc library function

python3kgae accepted this revision. python3kgae added a comment. This revision is now accepted and ready to land. LGTM. Remember to double check the commit message updated to trunc too. Just noticed we don't have double trunc(double) for hlsl now (hlsl 2021). Need make sure to generate float

[PATCH] D139742: [HLSL] Add acos library function

python3kgae added a comment. The PR title is acos but trunc is added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139742/new/ https://reviews.llvm.org/D139742 ___ cfe-commits mailing list

[PATCH] D138161: [HLSL] add sin library function

This revision was automatically updated to reflect the committed changes. Closed by commit rG083d949f3800: [HLSL] add sin library function (authored by bob80905, committed by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138161/new/

[PATCH] D134921: [HLSL] add cos library function

This revision was automatically updated to reflect the committed changes. Closed by commit rG9777e98a610f: [HLSL] add cos library function (authored by bob80905, committed by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134921/new/

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5d14f757bb1: Add builtin_elementwise_sin and builtin_elementwise_cos (authored by bob80905, committed by python3kgae). Changed prior to commit: https://reviews.llvm.org/D135011?vs=474628=474667#toc

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

python3kgae added inline comments. Comment at: clang/test/Sema/aarch64-sve-vector-trig-ops.c:4 +// RUN: -disable-O0-optnone -o - -fsyntax-only %s -verify + +#include Need limit to aarch64 enabled with // REQUIRES: aarch64-registered-target

[PATCH] D135721: [HLSL] Added HLSL this as a reference

This revision was automatically updated to reflect the committed changes. Closed by commit rG86674f66cc78: [HLSL] Added HLSL this as a reference (authored by gracejennings, committed by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136913: [HLSL] support RWByteAddressBuffer.

python3kgae created this revision. python3kgae added reviewers: pow2clk, beanz, bogner. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Only

[PATCH] D136743: [HLSL] support ConstantBuffer

python3kgae updated this revision to Diff 470870. python3kgae edited the summary of this revision. python3kgae added a comment. Fix windows test fail caused by dead ptr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136743/new/

[PATCH] D136743: [HLSL] support ConstantBuffer

python3kgae created this revision. python3kgae added reviewers: pow2clk, beanz, bogner. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Support ConstantBuffer

[PATCH] D136482: [HLSL] support unbounded global resource array.

python3kgae created this revision. python3kgae added reviewers: pow2clk, beanz, bogner. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. unbounded resource array

[PATCH] D133668: [HLSL] Disable integer promotion to avoid int16_t being promoted to int for HLSL.

This revision was automatically updated to reflect the committed changes. Closed by commit rG464926ef4484: [HLSL] Disable integer promotion to avoid int16_t being promoted to int for… (authored by python3kgae). Changed prior to commit: https://reviews.llvm.org/D133668?vs=469373=469387#toc

[PATCH] D133668: [HLSL] Disable integer promotion to avoid int16_t being promoted to int for HLSL.

python3kgae updated this revision to Diff 469373. python3kgae added a comment. Fix clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7183a158d68: [NFC] [DirectX backend] move ResourceClass into llvm. (authored by python3kgae). Changed prior to commit:

[PATCH] D133668: [HLSL] Disable integer promotion to avoid int16_t being promoted to int for HLSL.

python3kgae updated this revision to Diff 469334. python3kgae added a comment. Update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:20 #include "clang/Sema/Sema.h" +#include "llvm/Frontend/HLSL/HLSLResource.h" beanz wrote: > python3kgae wrote: > > python3kgae wrote: > > > beanz wrote: > > > > You need

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

python3kgae updated this revision to Diff 469302. python3kgae marked an inline comment as done. python3kgae added a comment. Add FrontendHLSL to Sema link Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136134/new/ https://reviews.llvm.org/D136134

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:20 #include "clang/Sema/Sema.h" +#include "llvm/Frontend/HLSL/HLSLResource.h" python3kgae wrote: > beanz wrote: > > You need

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:20 #include "clang/Sema/Sema.h" +#include "llvm/Frontend/HLSL/HLSLResource.h" beanz wrote: > You need to add FrontendHLSL to

[PATCH] D135060: [HLSL] Add groupshare address space.

This revision was automatically updated to reflect the committed changes. python3kgae marked an inline comment as done. Closed by commit rG7e04c0ad6325: [HLSL] Add groupshare address space. (authored by python3kgae). Changed prior to commit:

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

python3kgae updated this revision to Diff 469074. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136134/new/ https://reviews.llvm.org/D136134 Files: clang/include/clang/Basic/HLSLRuntime.h

[PATCH] D135721: [HLSL] Added HLSL this as a reference

python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +This->setValueKind(ExprValueKind::VK_LValue);

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae marked 3 inline comments as done. python3kgae added inline comments. Comment at: clang/test/ParserHLSL/group_shared_202x.hlsl:5-6 + +// expected-error@+1 {{return type cannot be qualified with address space}} +auto l = []() -> groupshared void {}; +//

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae updated this revision to Diff 469048. python3kgae added a comment. Update comments and add more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135060/new/ https://reviews.llvm.org/D135060 Files:

[PATCH] D133668: [HLSL] Disable integer promotion to avoid int16_t being promoted to int for HLSL.

python3kgae updated this revision to Diff 468993. python3kgae marked an inline comment as done. python3kgae added a comment. Herald added a subscriber: steakhal. Herald added a reviewer: NoQ. Move isPromotableIntegerType to ASTContext so it can access LangOpts. Repository: rG LLVM Github

[PATCH] D135429: [HLSL] [DirectX backend] Move generateGlobalCtorDtorCalls into DirectX backend.

python3kgae added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135429/new/ https://reviews.llvm.org/D135429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

This revision was automatically updated to reflect the committed changes. Closed by commit rG14ae5d2b745f: [HLSL] Add SV_DispatchThreadID (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/

[PATCH] D133668: [HLSL] Disable int16_t to avoid promote to int for HLSL.

python3kgae updated this revision to Diff 468731. python3kgae marked an inline comment as done. python3kgae added a comment. Update comment and fix tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 468706. python3kgae added a comment. More check on the ir. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 Files: clang/include/clang/Basic/Attr.td

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 468700. python3kgae added a comment. Check sret parameter exist. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 Files: clang/include/clang/Basic/Attr.td

[PATCH] D133668: [HLSL] Disable int16_t to avoid promote to int for HLSL.

python3kgae added a comment. In D133668#3847999 , @rjmccall wrote: > If you have `char`, would you want it to promote? Because turning `char` to > `_BitInt(8)` is breaking with C on other grounds (like aliasing), for better > or worse. So if you just

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

python3kgae updated this revision to Diff 468617. python3kgae added a comment. Switch back to short and disable integer promote for hlsl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668 Files:

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

python3kgae created this revision. python3kgae added reviewers: pow2clk, beanz, bogner. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Move

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

This revision was automatically updated to reflect the committed changes. Closed by commit rG13163dd8abc5: [HLSL] CodeGen hlsl resource binding. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130951/new/

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

python3kgae added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.h:73 CodeGenModule uint32_t ResourceCounters[static_cast( hlsl::ResourceClass::NumClasses)] = {0}; beanz wrote: > The `ResourceCounters` here was a stand-in for

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 468054. python3kgae added a comment. Rebase to fix stack patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 Files:

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

python3kgae updated this revision to Diff 468053. python3kgae added a comment. Rebase for D136031 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130951/new/ https://reviews.llvm.org/D130951 Files:

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 468047. python3kgae added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. arc diff `git merge-base HEAD origin` --update D136031 to fix the apply patch issue Repository: rG LLVM

[PATCH] D135721: [HLSL] Added HLSL this as a reference

python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +This->setValueKind(ExprValueKind::VK_LValue);

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

python3kgae updated this revision to Diff 467909. python3kgae marked 3 inline comments as done. python3kgae added a comment. Rebase to use FrontendResource. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130951/new/ https://reviews.llvm.org/D130951

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

python3kgae updated this revision to Diff 467812. python3kgae added a comment. Fix clang-format missed by arc lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130951/new/ https://reviews.llvm.org/D130951 Files:

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

python3kgae updated this revision to Diff 467631. python3kgae added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Add resource shape to metadata. Conflict with https://reviews.llvm.org/D135110, will rebase once https://reviews.llvm.org/D135110 is in.

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

python3kgae added inline comments. Comment at: llvm/lib/Target/DirectX/DXILResource.h:46 // can only be added to the end, and not removed. enum class Kinds : uint32_t { Invalid = 0, Could we move ResourceBase::Kinds to Frontend/HLSL/HLSLResource.h so

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae updated this revision to Diff 467383. python3kgae marked an inline comment as done. python3kgae added a comment. Add hlsl202x test for C++ 11 features like lambda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135060/new/

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/test/ParserHLSL/group_shared.hlsl:11 +// expected-warning@+1 {{'auto' type specifier is a C++11 extension}} +auto l = []() groupshared {}; + beanz wrote: > What

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. python3kgae marked an inline comment as done. Closed by commit rGebe9c7f3e2da: [HLSL] CodeGen hlsl cbuffer/tbuffer. (authored by python3kgae). Repository: rG LLVM

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:131 case Decl::RequiresExprBody: + case Decl::HLSLBuffer: // None of these decls require codegen support. efriedma wrote: > I'm a

  1   2   3   4   5   >