[PATCH] D125338: [HLSL] add -D option for dxc mode.

python3kgae added a comment. In D125338#3507063 , @thakis wrote: > Looks like this breaks tests on Mac: http://45.33.8.238/macm1/35103/step_7.txt > > Please take a look and revert for now if it takes a while to fix. I'll revert it. Thanks. Repository:

[PATCH] D125338: [HLSL] add -D option for dxc mode.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4dae38ebfba0: [HLSL] add -D option for dxc mode. (authored by python3kgae). Changed prior to commit:

[PATCH] D125338: [HLSL] add -D option for dxc mode.

python3kgae updated this revision to Diff 428698. python3kgae added a comment. Add check for macro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125338/new/ https://reviews.llvm.org/D125338 Files: clang/include/clang/Driver/Options.td

[PATCH] D125338: [HLSL] add -D option for dxc mode.

python3kgae created this revision. python3kgae added reviewers: amccarth, craig.topper, hans, rnk, stefan_reinalter, beanz, pow2clk, aaron.ballman. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added

[PATCH] D124751: [HLSL] Support -E option for HLSL.

python3kgae updated this revision to Diff 428209. python3kgae added a comment. Rebase to main for fix merge conflict. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124751/new/ https://reviews.llvm.org/D124751 Files:

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae updated this revision to Diff 428153. python3kgae added a comment. Add Sema test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124790/new/ https://reviews.llvm.org/D124790 Files: clang/include/clang/Driver/Options.td

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae updated this revision to Diff 427711. python3kgae added a comment. Rebase for fcgl change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124790/new/ https://reviews.llvm.org/D124790 Files: clang/include/clang/Driver/Options.td

[PATCH] D124983: [HLSL] add -fcgl option flag.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3fa5eb4cfc06: [HLSL] add -fcgl option flag. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124983: [HLSL] add -fcgl option flag.

python3kgae updated this revision to Diff 427656. python3kgae added a comment. Remove HelpText for alias option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124983/new/ https://reviews.llvm.org/D124983 Files:

[PATCH] D124983: [HLSL} add -fcgl option flag.

python3kgae updated this revision to Diff 427544. python3kgae marked 2 inline comments as done. python3kgae added a comment. Add emit_pristine_llvm to make fcgl easier to understand. Also change unit test to lib test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

python3kgae created this revision. python3kgae added reviewers: svenvh, asavonic, beanz, pow2clk. Herald added subscribers: Anastasia, mgorny. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Vector

[PATCH] D124983: [HLSL} add -fcgl option flag.

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/include/clang/Driver/Options.td:6765 "as_6_5, as_6_6, as_6_7">; +def fcgl : DXCFlag<"fcgl">, + HelpText<"Generate high-level code only. Without any dxil related

[PATCH] D124983: [HLSL} add -fcgl option flag.

python3kgae created this revision. python3kgae added reviewers: amccarth, craig.topper, hans, rnk, stefan_reinalter, beanz, pow2clk. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:197 - // OpenCL has half keyword - Opts.Half = Opts.OpenCL; + // OpenCL and HLSL have half keyword + Opts.Half = Opts.OpenCL || Opts.HLSL; python3kgae wrote: > aaron.ballman

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae updated this revision to Diff 426854. python3kgae added a comment. Add option -fcgl which output clang codeGen result to avoid test dependent on build DirectX backend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124790/new/

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:197 - // OpenCL has half keyword - Opts.Half = Opts.OpenCL; + // OpenCL and HLSL have half keyword + Opts.Half = Opts.OpenCL || Opts.HLSL;

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae marked 3 inline comments as done. python3kgae added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:197 - // OpenCL has half keyword - Opts.Half = Opts.OpenCL; + // OpenCL and HLSL have half keyword + Opts.Half = Opts.OpenCL || Opts.HLSL;

[PATCH] D124813: [HLSL] Add clang builtin for HLSL.

python3kgae created this revision. python3kgae added reviewers: anakryiko, ast, yonghong-song, beanz, pow2clk. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae created this revision. python3kgae added reviewers: Anastasia, aaron.ballman, beanz, pow2clk. Herald added a subscriber: dexonsmith. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project:

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae created this revision. python3kgae added reviewers: beanz, steven_wu, JonChesterfield, sscalpone, pow2clk, rnk, bogner, MaskRay, dexonsmith. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added a

[PATCH] D124752: [HLSL] clang codeGen for HLSLShaderAttr.

python3kgae created this revision. python3kgae added reviewers: dblaikie, MaskRay, hoy, lebedev.ri. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D124751: Support -E option for HLSL.

python3kgae created this revision. python3kgae added reviewers: beanz, steven_wu, JonChesterfield, sscalpone, pow2clk, rnk, bogner, MaskRay, dexonsmith. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added a

[PATCH] D123884: [HLSL][clang][Driver] Support validator version command line option.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73417c517644: [HLSL][clang][Driver] Support validator version command line option. (authored by python3kgae). Repository: rG LLVM Github Monorepo

[PATCH] D123884: [HLSL][clang][Driver] Support validator version command line option.

python3kgae updated this revision to Diff 426191. python3kgae added a comment. NO change, fix UNKNOWN REVISION when arc land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123884/new/ https://reviews.llvm.org/D123884 Files:

[PATCH] D124593: [HLSL][clang] Add clang builtin for HLSL.

python3kgae abandoned this revision. python3kgae added a comment. Change to different implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124593/new/ https://reviews.llvm.org/D124593 ___

[PATCH] D124595: [HLSL] Add llvm intrinsic for HLSL.

python3kgae abandoned this revision. python3kgae added a comment. Change to different implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124595/new/ https://reviews.llvm.org/D124595 ___

[PATCH] D124595: [HLSL] Add llvm intrinsic for HLSL.

python3kgae updated this revision to Diff 425697. python3kgae added a comment. Remove clang part change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124595/new/ https://reviews.llvm.org/D124595 Files:

[PATCH] D124595: [HLSL] Add llvm intrinsic for HLSL.

python3kgae created this revision. python3kgae added reviewers: simoll, k-ishizaka, kaz7. Herald added subscribers: Anastasia, dexonsmith, hiraditya, mgorny. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert.

[PATCH] D124593: [HLSL][clang] Add clang builtin for HLSL.

python3kgae created this revision. python3kgae added reviewers: anakryiko, ast, yonghong-song. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A directx

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 425322. python3kgae added a comment. Remove useless brackets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123884/new/ https://reviews.llvm.org/D123884 Files:

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 425315. python3kgae added a comment. Fix issues mentioned in comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123884/new/ https://reviews.llvm.org/D123884 Files:

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 424810. python3kgae marked an inline comment as done. python3kgae added a comment. Herald added a subscriber: Anastasia. Use c_str instead of data to avoid test fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 424105. python3kgae added a comment. Committed. Updated line number check for test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 Files:

[PATCH] D123907: [HLSL] Add shader attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb02d88d5afb5: [HLSL] Add shader attribute (authored by python3kgae). Changed prior to commit:

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 424093. python3kgae added a comment. Add comment for test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 Files: clang/include/clang/Basic/Attr.td

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 424019. python3kgae added a comment. Fix doc again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 Files: clang/include/clang/Basic/Attr.td

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6390 + ``[shader(string-literal)]`` +where the string literal is one of: . +Normally the shader type is set by shader target with the ``-T`` option like bogner wrote: > I'm

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6389-6391 +Normally the shader type is set by shader target with the -T option like +-Tps_6_1. +When compiling to a library target like lib_6_3, the shader type attribute can

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 423448. python3kgae added a comment. Fix doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 Files: clang/include/clang/Basic/Attr.td

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 423428. python3kgae added a comment. Add more detail to the doc. Update the attribute name according to the doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3978 +"compute", "raygeneration", "intersection", +"anyhit", "closestHit", "miss", "callable", "mesh", +

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae created this revision. python3kgae added reviewers: aaron.ballman, rnk, jdoerfert, MaskRay, rsmith. Herald added a subscriber: StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D123887: [HLSL][clang][Driver] Fix test error for use SmallString::data instead SmallString::c_str.

python3kgae abandoned this revision. python3kgae added a comment. Thanks. Close this RP then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123887/new/ https://reviews.llvm.org/D123887 ___ cfe-commits

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae added a comment. Created new patch to fix the test fail at https://reviews.llvm.org/D123887 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 ___

[PATCH] D123887: [HLSL][clang][Driver] Fix test error for use SmallString::data instead SmallString::c_str.

python3kgae created this revision. python3kgae added a reviewer: wolfgangp. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D123887

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 423190. python3kgae added a comment. Fix format in Options.td. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123884/new/ https://reviews.llvm.org/D123884 Files:

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 423189. python3kgae edited reviewers, added: steven_wu, JonChesterfield, sscalpone, rnk, bogner, MaskRay, dexonsmith, nikic; removed: jdoerfert, sstefan1, baziotis. python3kgae edited subscribers, added: beanz; removed: mgorny, arphaman, kuter,

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

python3kgae created this revision. python3kgae added a project: clang. Herald added subscribers: ormris, dexonsmith, okura, jdoerfert, kuter, arphaman, mgorny. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits,

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 422677. python3kgae added a comment. Code cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 422377. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Driver.h

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 422365. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Driver.h

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 422350. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Driver.h

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 422272. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Driver.h

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 422128. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Driver.h

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae added inline comments. Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:43 +return false; + if (!Version.getMinor()) +return false; beanz wrote: > Do we need to verify this or can we just assume if there is no minor version > specified that

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 419991. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Driver.h

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 419954. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Driver.h

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 419893. python3kgae added a comment. Herald added a subscriber: ormris. Change lit test to unit test to avoid require build DirectX target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/

[PATCH] D122699: [HLSL] Add Semantic syntax, and SV_GroupIndex

python3kgae added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6916 + Triple Target = S.Context.getTargetInfo().getTriple(); + if (Target.getEnvironment() != Triple::Compute) { +uint32_t Pipeline = It is OK to have SV_GroupIndex on a

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae created this revision. python3kgae added reviewers: beanz, steven_wu, JonChesterfield. python3kgae added a project: clang. Herald added a subscriber: mgorny. Herald added a reviewer: sscalpone. Herald added a project: All. python3kgae requested review of this revision. Herald added

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

python3kgae added a comment. Thanks for the review, the PR is committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D09/new/ https://reviews.llvm.org/D09 ___ cfe-commits mailing list

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

python3kgae added a comment. Updated summary. Tried to debug the linux fail with Hyper-V VM, cannot repro. Restarted Buildkite build to see if it still happens. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D09/new/

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

python3kgae updated this revision to Diff 377323. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D09/new/ https://reviews.llvm.org/D09 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/CodeGen/annotations-global.c

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

python3kgae created this revision. python3kgae added a reviewer: clang. python3kgae added a project: clang. python3kgae requested review of this revision. Herald added a subscriber: cfe-commits. When AnnotateAttr is on a function, AddGlobalAnnotations is only called in

<    1   2   3   4   5