[clang] 10d78a0 - [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir

Author: Yaron Keren Date: 2021-08-31T18:57:47+03:00 New Revision: 10d78a06baa217b8a4b853eff962e9ae719a8a45 URL: https://github.com/llvm/llvm-project/commit/10d78a06baa217b8a4b853eff962e9ae719a8a45 DIFF: https://github.com/llvm/llvm-project/commit/10d78a06baa217b8a4b853eff962e9ae719a8a45.diff

[clang] 5aa0f9c - Use installed llvm-lit.py instead of lit.py PR-51072

Author: Yaron Keren Date: 2021-08-18T09:06:06+03:00 New Revision: 5aa0f9cc9ab267803ad7bcfd14c8fd8bbffd82cb URL: https://github.com/llvm/llvm-project/commit/5aa0f9cc9ab267803ad7bcfd14c8fd8bbffd82cb DIFF: https://github.com/llvm/llvm-project/commit/5aa0f9cc9ab267803ad7bcfd14c8fd8bbffd82cb.diff

r336047 - Add expected fail triple x86_64-pc-windows-gnu to test as x86_64-w64-mingw32 is already there

Author: yrnkrn Date: Sat Jun 30 04:18:44 2018 New Revision: 336047 URL: http://llvm.org/viewvc/llvm-project?rev=336047=rev Log: Add expected fail triple x86_64-pc-windows-gnu to test as x86_64-w64-mingw32 is already there Modified: cfe/trunk/test/CodeGen/2007-06-18-SextAttrAggregate.c

r328447 - Remove reference to stale (2009) python version.

Author: yrnkrn Date: Sun Mar 25 06:12:05 2018 New Revision: 328447 URL: http://llvm.org/viewvc/llvm-project?rev=328447=rev Log: Remove reference to stale (2009) python version. Modified: cfe/trunk/www/hacking.html Modified: cfe/trunk/www/hacking.html URL:

Re: r305213 - Add regression test for r305179.

12 ביוני 2017 ב-21:21 מאת ‪David Blaikie‬‏ <‪ > dblai...@gmail.com‬‏>:‬ > >> Prefer FileCheck over grep, generally? >> >> On Mon, Jun 12, 2017 at 11:05 AM Yaron Keren via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: yrnkrn

Re: r305213 - Add regression test for r305179.

Sure, r305215. ‫בתאריך יום ב׳, 12 ביוני 2017 ב-21:21 מאת ‪David Blaikie‬‏ <‪ dblai...@gmail.com‬‏>:‬ > Prefer FileCheck over grep, generally? > > On Mon, Jun 12, 2017 at 11:05 AM Yaron Keren via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: yr

r305215 - Address David Blaikie comment by replacing grep with FileCheck.

Author: yrnkrn Date: Mon Jun 12 13:29:37 2017 New Revision: 305215 URL: http://llvm.org/viewvc/llvm-project?rev=305215=rev Log: Address David Blaikie comment by replacing grep with FileCheck. Modified: cfe/trunk/test/Misc/pr32207.c Modified: cfe/trunk/test/Misc/pr32207.c URL:

r305213 - Add regression test for r305179.

Author: yrnkrn Date: Mon Jun 12 13:05:13 2017 New Revision: 305213 URL: http://llvm.org/viewvc/llvm-project?rev=305213=rev Log: Add regression test for r305179. Added: cfe/trunk/test/Misc/pr32207.c Added: cfe/trunk/test/Misc/pr32207.c URL:

r304411 - Increase the limit for the number of DiagnosticLexKinds.td diags.

Author: yrnkrn Date: Thu Jun 1 07:46:59 2017 New Revision: 304411 URL: http://llvm.org/viewvc/llvm-project?rev=304411=rev Log: Increase the limit for the number of DiagnosticLexKinds.td diags. 300 was reached in r304190, 400 should be enough for a while. Modified:

Re: r304346 - [modules] When compiling a preprocessed module map, look for headers relative

Hi Richard, This broke the tests on the Windows bot: http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/5266 1. FAIL: Clang::preprocess-nested.cpp

Re: r301815 - Adapt to LLVM's rename of WeakVH to WeakTrackingVH; NFC

out-of-tree code that uses WeakVH will continue to compile OK but may not perform OK with WeakVH not tracking anymore. May be better not to reuse WeakVH yet so such code will fail compilation. ‫בתאריך יום ב׳, 1 במאי 2017 ב-20:21 מאת ‪Sanjoy Das via cfe-commits‬‏ <‪

r301526 - Constify SourceManager input to MacroInfo::getDefinitionLengthSlow, NFC.

Author: yrnkrn Date: Thu Apr 27 04:56:39 2017 New Revision: 301526 URL: http://llvm.org/viewvc/llvm-project?rev=301526=rev Log: Constify SourceManager input to MacroInfo::getDefinitionLengthSlow, NFC. Modified: cfe/trunk/include/clang/Lex/MacroInfo.h cfe/trunk/lib/Lex/MacroInfo.cpp

Re: r300443 - Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse, and definitions

nition is here > template inline void f() {} > > > I reverted this change in r300497. > > On Mon, Apr 17, 2017 at 10:51 AM, Yaron Keren via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Author: yrnkrn > > Date: Mon Apr 17 03:51:20 2017 > > New Revi

r300443 - Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse, and definitions are

Author: yrnkrn Date: Mon Apr 17 03:51:20 2017 New Revision: 300443 URL: http://llvm.org/viewvc/llvm-project?rev=300443=rev Log: Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice

r300423 - Use setUsedForHeaderGuard() accessor function instead of direcly accessing UsedForHeaderGuard.

Author: yrnkrn Date: Sun Apr 16 10:53:19 2017 New Revision: 300423 URL: http://llvm.org/viewvc/llvm-project?rev=300423=rev Log: Use setUsedForHeaderGuard() accessor function instead of direcly accessing UsedForHeaderGuard. Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp Modified:

r300036 - Remove Sema::addOverloadedOperatorToUnresolvedSet declaration. Its definition was removed in r206436.

Author: yrnkrn Date: Wed Apr 12 03:17:44 2017 New Revision: 300036 URL: http://llvm.org/viewvc/llvm-project?rev=300036=rev Log: Remove Sema::addOverloadedOperatorToUnresolvedSet declaration. Its definition was removed in r206436. Modified: cfe/trunk/include/clang/Sema/Sema.h Modified:

Re: r299079 - Move NumRegParameters Module Flag. NFCI.

Thanks! If you like, might make sense now to move all these addModuleFlag() into a new helper function, addModuleFlags(). ‫בתאריך יום ה׳, 30 במרץ 2017 ב-16:54 מאת ‪Nirav Dave via cfe-commits‬‏ <‪ cfe-commits@lists.llvm.org‬‏>:‬ > Author: niravd > Date: Thu Mar 30 08:41:44 2017 > New Revision:

r295839 - Remove superfluous initializer.

Author: yrnkrn Date: Wed Feb 22 08:32:39 2017 New Revision: 295839 URL: http://llvm.org/viewvc/llvm-project?rev=295839=rev Log: Remove superfluous initializer. The following fully-covered switch either sets value to External or exits the function. Modified:

r292032 - Fix PR31644 introduced by r287138 and add a regression test.

Author: yrnkrn Date: Sat Jan 14 15:12:08 2017 New Revision: 292032 URL: http://llvm.org/viewvc/llvm-project?rev=292032=rev Log: Fix PR31644 introduced by r287138 and add a regression test. Thanks Dimitry Andric for the report and fix! Modified: cfe/trunk/lib/Frontend/DependencyFile.cpp

r291230 - Constify UsingPackDecl::getInstantiatedFromUsingDecl(), NFC.

Author: yrnkrn Date: Fri Jan 6 05:15:57 2017 New Revision: 291230 URL: http://llvm.org/viewvc/llvm-project?rev=291230=rev Log: Constify UsingPackDecl::getInstantiatedFromUsingDecl(), NFC. Modified: cfe/trunk/include/clang/AST/DeclCXX.h Modified: cfe/trunk/include/clang/AST/DeclCXX.h URL:

r290495 - Deduplicate several GD.getDecl() calls into Decl * local variable.

Author: yrnkrn Date: Sat Dec 24 09:32:39 2016 New Revision: 290495 URL: http://llvm.org/viewvc/llvm-project?rev=290495=rev Log: Deduplicate several GD.getDecl() calls into Decl * local variable. Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp Modified:

r289328 - Simplify parseShowColorsArgs logic, NFC.

Author: yrnkrn Date: Sat Dec 10 08:55:14 2016 New Revision: 289328 URL: http://llvm.org/viewvc/llvm-project?rev=289328=rev Log: Simplify parseShowColorsArgs logic, NFC. Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp URL:

r288124 - Correct comment: we are creating a canonicla decltypetype.

Author: yrnkrn Date: Tue Nov 29 04:08:20 2016 New Revision: 288124 URL: http://llvm.org/viewvc/llvm-project?rev=288124=rev Log: Correct comment: we are creating a canonicla decltypetype. Modified: cfe/trunk/lib/AST/ASTContext.cpp Modified: cfe/trunk/lib/AST/ASTContext.cpp URL:

Re: r287343 - [OpenCL] Introduce ReadPipeType and WritePipeType.

Hi Joey, In order for ReadPipeType and WritePipeType to work with LLVM type system (isa, dyn_cast), you need to modify the existing TypeClass::Pipe kind into TypeClass::ReadPipe and TypeClass::WritePipe, have Pipe::classof recognize both kinds and have ReadPipe::classof and WritePipe::classof

r287138 - Rangify for loops, NFC.

Author: yrnkrn Date: Wed Nov 16 13:24:10 2016 New Revision: 287138 URL: http://llvm.org/viewvc/llvm-project?rev=287138=rev Log: Rangify for loops, NFC. Modified: cfe/trunk/lib/Frontend/DependencyFile.cpp Modified: cfe/trunk/lib/Frontend/DependencyFile.cpp URL:

r287102 - Rangify for loop, NFC.

Author: yrnkrn Date: Wed Nov 16 07:45:34 2016 New Revision: 287102 URL: http://llvm.org/viewvc/llvm-project?rev=287102=rev Log: Rangify for loop, NFC. Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp URL:

Re: r285258 - Refactor call emission to package the function pointer together with

Hi John, clang warns on this: /llvm/tools/zapccs/../clang/include/../lib/CodeGen/CGCall.h:79:7: warning: anonymous types declared in an anonymous union are an extension [-Wnested-anon-types] struct { ^ /llvm/tools/zapccs/../clang/include/../lib/CodeGen/CGCall.h:83:7: warning:

r283657 - Un-tabify source files, NFC.

Author: yrnkrn Date: Sat Oct 8 01:45:10 2016 New Revision: 283657 URL: http://llvm.org/viewvc/llvm-project?rev=283657=rev Log: Un-tabify source files, NFC. Modified: cfe/trunk/lib/AST/ASTContext.cpp cfe/trunk/lib/AST/ExprConstant.cpp cfe/trunk/lib/AST/NestedNameSpecifier.cpp

Re: r283063 - Alias must point to a definition

yes, it works, thanks! 2016-10-03 18:19 GMT+03:00 Aditya K : > Thanks for poining that out. I have updated the test case, please see if > that works. > > > http://llvm.org/viewvc/llvm-project?view=revision=283085 > > > > -Aditya > > > -- > *From:*

Re: r283063 - Alias must point to a definition

The mangling is different when targeting MSVC ABI, see failure at http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/29889/steps/test_all/logs/Clang%20%3A%3A%20CodeGenCXX__alias-available-externally.cpp maybe -triple x86_64-pc-linux ? 2016-10-02 6:06 GMT+03:00 Aditya Kumar via

Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

yaron.keren added a subscriber: yaron.keren. yaron.keren added a comment. also, gcc warns if order of field initializators is different than the order of fields. Repository: rL LLVM https://reviews.llvm.org/D24754 ___ cfe-commits mailing list

Re: r278984 - Add test missed from r278983.

Thanks! 2016-08-25 0:39 GMT+03:00 Richard Smith : > As of r279668, we shouldn't run this test for ASan builds any more. > Perhaps we should increase Clang's minimum stack allocation when built with > ASan to compensate for it making stack frames larger. > On Wed, Aug 24,

Re: r278984 - Add test missed from r278983.

I see the same stack overflow asan error in a local buildbot. 2016-08-22 20:30 GMT+03:00 Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org>: > Hi Richard, > > This test has been failing since it was committed. > > http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/2277/

r277334 - Allow .exe extension to ld to fix test with mingw.

Author: yrnkrn Date: Mon Aug 1 05:14:54 2016 New Revision: 277334 URL: http://llvm.org/viewvc/llvm-project?rev=277334=rev Log: Allow .exe extension to ld to fix test with mingw. Modified: cfe/trunk/test/Driver/offloading-interoperability.c Modified:

r276252 - Provide __GLIBCXX_TYPE_INT_N_0 and __GLIBCXX_BITSIZE_INT_N_0 when in C++ gnu language extensions.

Author: yrnkrn Date: Thu Jul 21 02:44:41 2016 New Revision: 276252 URL: http://llvm.org/viewvc/llvm-project?rev=276252=rev Log: Provide __GLIBCXX_TYPE_INT_N_0 and __GLIBCXX_BITSIZE_INT_N_0 when in C++ gnu language extensions. These are used by libstdc++ for is_integral<__int128>. Addresses

r275303 - Implement FunctionDecl::getDefinition() to be consistent with

Author: yrnkrn Date: Wed Jul 13 14:04:51 2016 New Revision: 275303 URL: http://llvm.org/viewvc/llvm-project?rev=275303=rev Log: Implement FunctionDecl::getDefinition() to be consistent with VarDecl, TagDecl, EnumDecl, RecordDecl, CXXRecordDecl. Use getDefinition in two locations to make the code

Re: r274257 - Don't instantiate a full host toolchain in ASTMatchersTest.

Seems this commit broke a builder, http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6 http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/26133 http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/26134 TEST 'Clang-Unit ::

r274149 - Add CapturedDecl::parameters() ArrayRef accessors following r273647.

Author: yrnkrn Date: Wed Jun 29 13:55:53 2016 New Revision: 274149 URL: http://llvm.org/viewvc/llvm-project?rev=274149=rev Log: Add CapturedDecl::parameters() ArrayRef accessors following r273647. Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h

Re: [PATCH] D21117: Specify target in lifetime-asan test.

yaron.keren added a subscriber: yaron.keren. yaron.keren accepted this revision. yaron.keren added a reviewer: yaron.keren. yaron.keren added a comment. This revision is now accepted and ready to land. You mean Some target platforms do not support -fsanitize=address.

Re: r271399 - It seems we need to add SemaExpr.cpp to the /bigobj list; I am getting consistent failures of hitting the section count limit.

Thanks! I've just noticed this today locally. It happens with unoptimized builds only so the bots are not catching it. 2016-06-01 18:17 GMT+03:00 Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org>: > Author: aaronballman > Date: Wed Jun 1 10:17:54 2016 > New Revision: 271399 > >

r271392 - Fix the CLANG_ENABLE_STATIC_ANALYZER=OFF build.

Author: yrnkrn Date: Wed Jun 1 08:47:26 2016 New Revision: 271392 URL: http://llvm.org/viewvc/llvm-project?rev=271392=rev Log: Fix the CLANG_ENABLE_STATIC_ANALYZER=OFF build. tools/clang/tools/CMakeLists.txt does not create the clang-check target when CLANG_ENABLE_STATIC_ANALYZER=OFF.

r269801 - Teach clang to look for libcxx in /usr/local/include/c++ on Linux

Author: yrnkrn Date: Tue May 17 14:01:16 2016 New Revision: 269801 URL: http://llvm.org/viewvc/llvm-project?rev=269801=rev Log: Teach clang to look for libcxx in /usr/local/include/c++ on Linux As The default CMAKE install prefix is /usr/local (

Re: [PATCH] D20240: [clang-rename] Fix broken dependency on shared build.

yaron.keren added a subscriber: yaron.keren. yaron.keren accepted this revision. yaron.keren added a reviewer: yaron.keren. yaron.keren added a comment. This revision is now accepted and ready to land. result of r269402, LGTM http://reviews.llvm.org/D20240

r269423 - Prune four superfluous ExternalSemaSource.h includes and one forward declaration in Sema.h

Author: yrnkrn Date: Fri May 13 09:53:19 2016 New Revision: 269423 URL: http://llvm.org/viewvc/llvm-project?rev=269423=rev Log: Prune four superfluous ExternalSemaSource.h includes and one forward declaration in Sema.h where ExternalSemaSource.h was already included due to ExternalSemaSource::

Re: r268797 - Fix sysroot-prefix.c on Windows (/ vs \).

Hi Nico, In other tests, {{/|}} or {{/|\\}} are used match the forward or backward slash(es). clang escapes \ so we get two of them in output and four in the LIT test. It would be nice to have more elegant construct for this general problem, to avoid tests like:

Re: r259734 - Fix predefine for __NSConstantString struct type

If used only for Darwin, could this depend on Target.getTriple().isOSDarwin() ? 2016-04-11 17:18 GMT+03:00 Ben Langmuir : > > On Apr 3, 2016, at 10:57 AM, Yaron Keren wrote: > > I look at many AST dumps for small reduced code so it's mostly weird to

Re: r259734 - Fix predefine for __NSConstantString struct type

I look at many AST dumps for small reduced code so it's mostly weird to see this in the AST (and takes a bit of screen real estate) as it's not something that originated in the code. By now I'm used to ignoring it but would expect NSConstantString would baffle new clang programmers. It would be

Re: r259734 - Fix predefine for __NSConstantString struct type

+1, if possible. There is a if (getLangOpts().ObjC1) block just before this. 2016-04-03 14:21 GMT+03:00 Vassil Vassilev via cfe-commits < cfe-commits@lists.llvm.org>: > On 04/02/16 01:55, Ben Langmuir via cfe-commits wrote: > >> Author: benlangmuir >> Date: Wed Feb 3 18:55:24 2016 >> New

r263635 - Directly get the canonical Type instead of going around through a CanQualType temporary, NFC.

Author: yrnkrn Date: Wed Mar 16 07:14:43 2016 New Revision: 263635 URL: http://llvm.org/viewvc/llvm-project?rev=263635=rev Log: Directly get the canonical Type instead of going around through a CanQualType temporary, NFC. Modified: cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp Modified:

Re: [PATCH] D15450: Avoid double deletion in Clang driver.

yaron.keren accepted this revision. yaron.keren added a reviewer: yaron.keren. yaron.keren added a comment. This revision is now accepted and ready to land. Would be nice to have CodeGenAction::TheModule redirect to CodeGeneratorImpl::M if possible, but that's for another patch. LGTM.

Re: [PATCH] D15450: Avoid double deletion in Clang driver.

yaron.keren added a comment. It certainly makes sense to redirect the module request to its owner instead of duplicating it in a local copy. There may be a change in behaviour here, pre-patch CodeGenAction::EndSourceFileAction() would take the BackendConsumer Module, keeping CodeGen Module

Re: [PATCH] D17183: Make TargetInfo store an actual DataLayout instead of a string.

yaron.keren added a subscriber: yaron.keren. yaron.keren added a comment. We have tried to keep one copy of http://reviews.llvm.org/D11103 Can it share the Module->getDataLayout() ? http://reviews.llvm.org/D17183 ___ cfe-commits mailing list

r260028 - Use CodeGenModule::addReplacement() instead of directly accessing Replacements[].

Author: yrnkrn Date: Sun Feb 7 06:44:35 2016 New Revision: 260028 URL: http://llvm.org/viewvc/llvm-project?rev=260028=rev Log: Use CodeGenModule::addReplacement() instead of directly accessing Replacements[]. This helps when trying to debug who inserted into Replacements. Modified:

r259192 - Implement TemplateArgument::dump() method for debugging, patterned after TemplateName::dump().

Author: yrnkrn Date: Fri Jan 29 07:46:15 2016 New Revision: 259192 URL: http://llvm.org/viewvc/llvm-project?rev=259192=rev Log: Implement TemplateArgument::dump() method for debugging, patterned after TemplateName::dump(). Modified: cfe/trunk/include/clang/AST/TemplateBase.h

Re: r259192 - Implement TemplateArgument::dump() method for debugging, patterned after TemplateName::dump().

On 29 Jan 2016 5:50 a.m., "Yaron Keren via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > > > > Author: yrnkrn > > Date: Fri Jan 29 07:46:15 2016 > > New Revision: 259192 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=259192=rev >

r259232 - Annotate dump() methods with LLVM_DUMP_METHOD, addressing Richard Smith r259192 post commit comment.

Author: yrnkrn Date: Fri Jan 29 13:38:18 2016 New Revision: 259232 URL: http://llvm.org/viewvc/llvm-project?rev=259232=rev Log: Annotate dump() methods with LLVM_DUMP_METHOD, addressing Richard Smith r259192 post commit comment. Modified: cfe/trunk/lib/AST/APValue.cpp

Re: r259192 - Implement TemplateArgument::dump() method for debugging, patterned after TemplateName::dump().

s > > TemplateName::dump(), NestedNameSpecifier::dump(), ASTReader::dump(), > > ModuleMap::dump(), MacroInfo::dump(), ... > > > > Annotate all dump() methods LLVM_DUMP_METHOD ? > > SGTM > > > 2016-01-29 19:37 GMT+02:00 Richard Smith <rich...@metafoo.co.uk>: > &

Re: [PATCH] D16478: Always build a new TypeSourceInfo for function templates with parameters

The instantiated does get a new collection of ParmVarDecls while getting the pattern Type which points to the pattern ParmVarDecls. So the ParmVarDecls pointed in the instantiated are not the same as those pointed by its Type. Traversing by Type or by the Decl finds a different set of

r256472 - Constify NestedNameSpecifier::dump and add a no-argument dump function suitable for calling from a debugger.

Author: yrnkrn Date: Sun Dec 27 08:34:22 2015 New Revision: 256472 URL: http://llvm.org/viewvc/llvm-project?rev=256472=rev Log: Constify NestedNameSpecifier::dump and add a no-argument dump function suitable for calling from a debugger. Modified:

r256349 - Replace isa+cast with dyn_cast and obey the no else after return rule.

Author: yrnkrn Date: Wed Dec 23 14:38:13 2015 New Revision: 256349 URL: http://llvm.org/viewvc/llvm-project?rev=256349=rev Log: Replace isa+cast with dyn_cast and obey the no else after return rule. Modified: cfe/trunk/lib/Sema/SemaExpr.cpp Modified: cfe/trunk/lib/Sema/SemaExpr.cpp URL:

r255993 - Replace SM.getFileEntryForID(Lexer->getFileID()) with Lexer->getFileEntry().

Author: yrnkrn Date: Fri Dec 18 04:30:12 2015 New Revision: 255993 URL: http://llvm.org/viewvc/llvm-project?rev=255993=rev Log: Replace SM.getFileEntryForID(Lexer->getFileID()) with Lexer->getFileEntry(). Modified: cfe/trunk/lib/Lex/PPDirectives.cpp cfe/trunk/lib/Lex/PPLexerChange.cpp

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

yaron.keren accepted this revision. yaron.keren added a comment. This revision is now accepted and ready to land. LGTM with some tests cases. http://reviews.llvm.org/D15006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15579: Fix the failing windows clang unit tests. NFC

yaron.keren added a comment. http://bb.pgr.jp/grid http://reviews.llvm.org/D15579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15506: [ASTMatchers] Allow hasName() to look through inline namespaces

MSVC 2013 Update 5 accepts for (bool SkipUnwritten : {false, true}). Possibly changed in one of the Updates? 2015-12-14 23:35 GMT+02:00 Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org>: > aaron.ballman added a subscriber: aaron.ballman. > > > Comment at:

Re: [PATCH] D15506: [ASTMatchers] Allow hasName() to look through inline namespaces

That's odd. I'm using the same update 5 exactly, added " for (bool SkipUnwritten : {false, true});" inside a LLVM source file and re-compiled. MSVC complained about the unused SkipUnwritten but was therwise OK with the code. 2015-12-14 23:43 GMT+02:00 Aaron Ballman : >

Re: [PATCH] D15506: [ASTMatchers] Allow hasName() to look through inline namespaces

yaron.keren added inline comments. Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:322 @@ +321,3 @@ + for (bool SkipUnwritten : SkipUnwrittenCases) { +llvm::SmallString<128> NodeName = StringRef("::"); +llvm::raw_svector_ostream OS(NodeName);

Re: [PATCH] D7718: Itanium ABI: Properly mangle extern "C" template arguments

yaron.keren added a subscriber: yaron.keren. yaron.keren added a comment. There is another copy of getEffectiveDeclContext in MicrosoftMangle.cpp which pre-commit was identical to this one. Should it get this commit as well to keep both identical? If so, could both copies of

r254392 - Remove superfluous StringRef casts, NFC.

Author: yrnkrn Date: Tue Dec 1 02:14:39 2015 New Revision: 254392 URL: http://llvm.org/viewvc/llvm-project?rev=254392=rev Log: Remove superfluous StringRef casts, NFC. Modified: cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp Modified: cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp URL:

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

yaron.keren added a comment. findGccDir() can return llvm::ErrorOr and then all Base assignments happen at the same if-elseif-else: if (getDriver().SysRoot.size()) Base = getDriver().SysRoot; else if (llvm::ErrorOr GPPName = findGccDir()) Base = llvm::sys::path::parent_path(

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

yaron.keren added a comment. This always searches for something-gcc and then discards the result if sysroot was provided, which is a waste. Move the searching to a helper function and then it can be done only if sysroot was not provided, as it is now. The break is needed to avoid looking for

Re: r253898 - Driver: fallback to the location of clang if no sysroot,

Searching for gcc on Linux is not a good idea, you'll find the system one not the mingw one. Searching for i686-w64-mingw32-gcc or x86_64-w64-mingw32-gcc should work better, that is searching for: getTriple().getArchName()) + "-w64-mingw32-gcc" Moreover, this should work on Windows as well,

Re: r242121 - Add support for -fuse-ld= in the mingw toolchain driver.

r253161 2015-11-14 22:45 GMT+02:00 Martell Malone : > The reason why I didn't use -fuse-ld=lld2 was because on Windows we don't > have symlinks. > I figured passing flavor gets over this hurdle and the installation takes > up less space. > If you want to change it I have

r253161 - Make the mingw toolchain accept 'ld' and 'lld' only as values to -fuse-ld.

Author: yrnkrn Date: Sun Nov 15 02:06:27 2015 New Revision: 253161 URL: http://llvm.org/viewvc/llvm-project?rev=253161=rev Log: Make the mingw toolchain accept 'ld' and 'lld' only as values to -fuse-ld. Post-commit suggestion by Filipe Cabecinhas. Modified: cfe/trunk/lib/Driver/Tools.cpp

r253066 - Add test case for mingw -fuse-ld= support introduced in r242121.

Author: yrnkrn Date: Fri Nov 13 13:46:02 2015 New Revision: 253066 URL: http://llvm.org/viewvc/llvm-project?rev=253066=rev Log: Add test case for mingw -fuse-ld= support introduced in r242121. Added: cfe/trunk/test/Driver/mingw-useld.c Added: cfe/trunk/test/Driver/mingw-useld.c URL:

r253069 - Relax mingw-useld test to fix bot failures.

Author: yrnkrn Date: Fri Nov 13 14:02:08 2015 New Revision: 253069 URL: http://llvm.org/viewvc/llvm-project?rev=253069=rev Log: Relax mingw-useld test to fix bot failures. Modified: cfe/trunk/test/Driver/mingw-useld.c Modified: cfe/trunk/test/Driver/mingw-useld.c URL:

Re: r242121 - Add support for -fuse-ld= in the mingw toolchain driver.

Sure, r253066. 2015-11-13 19:40 GMT+02:00 Rafael Espíndola : > This needs a testcase. Nothing is checking the linker invocation. > > On 14 July 2015 at 01:23, Yaron Keren wrote: > > Author: yrnkrn > > Date: Tue Jul 14 00:23:34 2015 > > New

r252426 - Replace tab with 8 spaces, NFC.

Author: yrnkrn Date: Sun Nov 8 16:01:45 2015 New Revision: 252426 URL: http://llvm.org/viewvc/llvm-project?rev=252426=rev Log: Replace tab with 8 spaces, NFC. Modified: cfe/trunk/lib/CodeGen/CGCall.cpp Modified: cfe/trunk/lib/CodeGen/CGCall.cpp URL:

r252404 - Remove spaces at start of line, NFC.

Author: yrnkrn Date: Sat Nov 7 10:24:52 2015 New Revision: 252404 URL: http://llvm.org/viewvc/llvm-project?rev=252404=rev Log: Remove spaces at start of line, NFC. Modified: cfe/trunk/include/clang/Frontend/CompilerInvocation.h Modified:

r252405 - Remove spaces in empty line, NFC.

Author: yrnkrn Date: Sat Nov 7 10:35:07 2015 New Revision: 252405 URL: http://llvm.org/viewvc/llvm-project?rev=252405=rev Log: Remove spaces in empty line, NFC. Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp URL:

Re: [PATCH] D14164: Driver: fallback to parent directory of clang if no sysroot for mingw-w64 target

yaron.keren accepted this revision. yaron.keren added a reviewer: yaron.keren. yaron.keren added a comment. This revision is now accepted and ready to land. The formatting is wrong, aligned to the right, clang-format the new code. Can we control getInstalledDir() when running under LIT so this

Re: [PATCH] D14164: Driver: fallback to parent directory of clang if no sysroot for mingw-w64 target

yaron.keren added a subscriber: cfe-commits. yaron.keren added a comment. We did not have cfe-commits as subscriber so I'm adding it now (this is a clang commit), see if someone would like to further comment. http://reviews.llvm.org/D14164 ___

Re: r251567 - Fix the calling convention of Mingw64 long double values

Thanks! 2015-10-29 0:29 GMT+02:00 Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org>: > Author: rnk > Date: Wed Oct 28 17:29:52 2015 > New Revision: 251567 > > URL: http://llvm.org/viewvc/llvm-project?rev=251567=rev > Log: > Fix the calling convention of Mingw64 long double values > >

r250921 - Rename clang config.h include guard from CONFIG_H to CLANG_CONFIG_H

Author: yrnkrn Date: Wed Oct 21 13:16:01 2015 New Revision: 250921 URL: http://llvm.org/viewvc/llvm-project?rev=250921=rev Log: Rename clang config.h include guard from CONFIG_H to CLANG_CONFIG_H to make it different from LLVM config.h include guard. Modified:

r249235 - Replace double negation of !FileID.isInvalid() with FileID.isValid().

Author: yrnkrn Date: Sat Oct 3 05:46:20 2015 New Revision: 249235 URL: http://llvm.org/viewvc/llvm-project?rev=249235=rev Log: Replace double negation of !FileID.isInvalid() with FileID.isValid(). +couple more of double-negated !SourceLocation.isInvalid() unfixed in r249228. Modified:

[clang-tools-extra] r249235 - Replace double negation of !FileID.isInvalid() with FileID.isValid().

Author: yrnkrn Date: Sat Oct 3 05:46:20 2015 New Revision: 249235 URL: http://llvm.org/viewvc/llvm-project?rev=249235=rev Log: Replace double negation of !FileID.isInvalid() with FileID.isValid(). +couple more of double-negated !SourceLocation.isInvalid() unfixed in r249228. Modified:

Re: r249141 - Revert "Add support for the new mips-mti-linux toolchain."

The regular expression should match match clang.exe on Windows. 2015-10-02 18:00 GMT+03:00 Vasileios Kalintiris via cfe-commits < cfe-commits@lists.llvm.org>: > Author: vkalintiris > Date: Fri Oct 2 10:00:55 2015 > New Revision: 249141 > > URL:

r249152 - constify ClassTemplatePartialSpecializationDecl::getInstantiatedFromMember and VarTemplatePartialSpecializationDecl::getInstantiatedFromMember.

Author: yrnkrn Date: Fri Oct 2 11:40:48 2015 New Revision: 249152 URL: http://llvm.org/viewvc/llvm-project?rev=249152=rev Log: constify ClassTemplatePartialSpecializationDecl::getInstantiatedFromMember and VarTemplatePartialSpecializationDecl::getInstantiatedFromMember. Modified:

r249159 - constify four getInstantiatedFromMemberTemplate() in DeclTemplate.h.

Author: yrnkrn Date: Fri Oct 2 12:38:57 2015 New Revision: 249159 URL: http://llvm.org/viewvc/llvm-project?rev=249159=rev Log: constify four getInstantiatedFromMemberTemplate() in DeclTemplate.h. Modified: cfe/trunk/include/clang/AST/DeclTemplate.h Modified:

r249228 - Replace double-negated !SourceLocation.isInvalid() with SourceLocation.isValid().

Author: yrnkrn Date: Sat Oct 3 00:15:57 2015 New Revision: 249228 URL: http://llvm.org/viewvc/llvm-project?rev=249228=rev Log: Replace double-negated !SourceLocation.isInvalid() with SourceLocation.isValid(). Modified: cfe/trunk/lib/ARCMigrate/ObjCMT.cpp cfe/trunk/lib/AST/TypeLoc.cpp

r249001 - C++11 rangify for loops, NFC.

Author: yrnkrn Date: Thu Oct 1 06:19:28 2015 New Revision: 249001 URL: http://llvm.org/viewvc/llvm-project?rev=249001=rev Log: C++11 rangify for loops, NFC. Modified: cfe/trunk/lib/Frontend/InitHeaderSearch.cpp Modified: cfe/trunk/lib/Frontend/InitHeaderSearch.cpp URL:

Re: [PATCH] D13203: [Clang] - Massaging code to fix MSVS 2015 win32-release configuration

yaron.keren added a subscriber: yaron.keren. yaron.keren added a comment. clang can't generate Visual C++ debug info except line numbers yet, so building with VC is essential to development on Windows. While most people and our bots are still using VC 2013 going forward supporting VC 2015 (even

Re: [PATCH] D13128: Fix backend crash on multiple close of stdout.

yaron.keren added a comment. Hi Dan, it makes sense that output streams should not usually be mixed together, especially if one is binary as you write. This may or may not be a problem depending on what the user really wants. He may want to mix the outputs for whatever purposes or it may

r248626 - Relax test to allow for __attribute__((thiscall)). Under Win32 c-index-test output is

Author: yrnkrn Date: Fri Sep 25 17:09:07 2015 New Revision: 248626 URL: http://llvm.org/viewvc/llvm-project?rev=248626=rev Log: Relax test to allow for __attribute__((thiscall)). Under Win32 c-index-test output is CXXMethod=foo:4:7 (unavailable) [type=int () __attribute__((thiscall))]

Re: [PATCH] D13128: Fix backend crash on multiple close of stdout.

yaron.keren added a subscriber: yaron.keren. yaron.keren added a comment. When stdout goes elsewhere the console, the shell creates the the output file (pipe) and will close it when clang terminates so so why clang should close it at all ? it did not open it. Practically, we have been

Re: [PATCH] D13128: Fix backend crash on multiple close of stdout.

yaron.keren added a subscriber: sunfish. yaron.keren added a comment. The original commit http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20100816/106268.html by Dan Ghoman says: "Make raw_fd_ostream consider itself the owner of STDOUT_FILENO when constructed with an output filename

Re: [libcxxabi] r248129 - Let cxa_demangle.cpp compile with gcc/libstdc++ 4.8 and clang-cl/MSVC2013's STL.

Ah, OK. Maybe it would compile with VC 2013 by using LLVM_CONSTEXPR instead of constexpr. It's not available now in libcxx but the definition from Compiler.h is trivial. 2015-09-24 19:28 GMT+03:00 Nico Weber <tha...@chromium.org>: > On Thu, Sep 24, 2015 at 4:20 AM, Yaron Keren via cf

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

Thanks, I have replied there. 2015-09-19 13:33 GMT+03:00 Hal Finkel <hfin...@anl.gov>: > FYI: https://llvm.org/bugs/show_bug.cgi?id=24398 was just reopened > pointing to a lack of resolution here. > > -Hal > > - Original Message - > > From: "Yaron

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

gt;> FYI: https://llvm.org/bugs/show_bug.cgi?id=24398 was just reopened >>> pointing to a lack of resolution here. >>> >>> -Hal >>> >>> - Original Message - >>> > From: "Yaron Keren via cfe-commits" <cfe-commits@lists.llvm.

Re: r247410 - This test requires UTF-8 output to print the UT-8 characters.

right way to fix it was. > :-) > > ~Aaron > > On Fri, Sep 11, 2015 at 9:29 AM, Yaron Keren via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Author: yrnkrn > > Date: Fri Sep 11 08:29:12 2015 > > New Revision: 247410 > > > > URL: http://llv

Patch for PR23472

http://llvm.org/pr23472 As suggested by Reid, OK to commit? Index: tools/clang/lib/CodeGen/ItaniumCXXABI.cpp === --- tools/clang/lib/CodeGen/ItaniumCXXABI.cpp (revision 246575) +++ tools/clang/lib/CodeGen/ItaniumCXXABI.cpp

  1   2   >