[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

ychen added a comment. In D72404#1820628 , @tycho wrote: > In D72404#1820461 , > @merge_guards_bot wrote: > > > {icon times-circle color=red} Unit tests: fail. 61858 tests passed, 1 > > failed and 781 were

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

ychen updated this revision to Diff 238071. ychen added a comment. - rebase & clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72404/new/ https://reviews.llvm.org/D72404 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D72404: [WIP][ThinLTO] Support Os and Oz

ychen updated this revision to Diff 238042. ychen added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72404/new/ https://reviews.llvm.org/D72404 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D72404: [WIP][ThinLTO] Support Os and Oz

ychen updated this revision to Diff 238034. ychen added a comment. - fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72404/new/ https://reviews.llvm.org/D72404 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D72404: [WIP][ThinLTO] Support Os and Oz

ychen updated this revision to Diff 238028. ychen added a comment. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. - when optnone is not present, add `optsize` for Os and `minsize` for Oz - add Os Oz function attribute test. - add Os Oz pipeline test Repository: rG

[PATCH] D69406: [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver -fthinlto_link_bitcode

This revision was automatically updated to reflect the committed changes. Closed by commit rGef7a154d17f2: [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver… (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69406/new/

[PATCH] D69406: [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver -fthinlto_link_bitcode

ychen updated this revision to Diff 226347. ychen added a comment. Address reviewer's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69406/new/ https://reviews.llvm.org/D69406 Files: clang/include/clang/Driver/CC1Options.td

[PATCH] D69406: [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver -fthinlto_link_bitcode

ychen created this revision. ychen added reviewers: tejohnson, steven_wu. Herald added subscribers: cfe-commits, dexonsmith, inglorion, mehdi_amini. Herald added a project: clang. A necessary step to let build system caching work for its output. I renamed it to match existing driver options for

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

ychen added a comment. Thank you @steven_wu @tejohnson. I created D69406 to promote the flag to the driver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69327/new/ https://reviews.llvm.org/D69327

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

ychen added a comment. Sorry for the confusion @steven_wu. By `stable` I mean the probability that the `-fthin-link-bitcode` option is replaced with some other thinlink mechanism under the distributed build environment. Since at least for ccache, the compilation output caching depends on the

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

ychen added a comment. In D69327#1719419 , @steven_wu wrote: > In D69327#1719411 , @ychen wrote: > > > Thanks for the inputs @steven_wu @tejohnson. Totally agree with the points > > you brought up. One last thing

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

ychen added a comment. Thanks for the inputs @steven_wu @tejohnson. Totally agree with the points you brought up. One last thing I'm not quite sure is the caching of `-fthin-link-bitcode`. It is a `-cc1` option since it is a kind of implementation of ThinLTO, right? I'm a little hesitant to

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

ychen added a comment. In D69327#1719109 , @tejohnson wrote: > I haven't read through the patch in detail yet, but from the description it > sounds like a cache is being added for the compile step outputs, e.g. the > bitcode output object of the "clang

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

ychen created this revision. ychen added reviewers: mehdi_amini, pcc, tejohnson. Herald added subscribers: llvm-commits, cfe-commits, dang, dexonsmith, steven_wu, aheejin, hiraditya, inglorion. Herald added projects: clang, LLVM. Currently the link phase has a object file cache whereas the

[PATCH] D68482: [clang] fix a typo from r372531

ychen created this revision. ychen added a reviewer: xbolva00. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68482 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D67847: [Support] make report_fatal_error `abort` instead of `exit`

ychen added a comment. In D67847#1691898 , @jyknight wrote: > The `abort()` function raises SIGABRT, for which the default behavior is to > trigger a coredump. Do we actually want that behavior? > > Either `_exit()` (long available extension, which lld

[PATCH] D67141: [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator.

ychen added a comment. In D67141#1658238 , @rnk wrote: > lgtm, thanks! Thank you! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67141/new/ https://reviews.llvm.org/D67141

[PATCH] D67141: [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator.

ychen updated this revision to Diff 218769. ychen added a comment. - address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67141/new/ https://reviews.llvm.org/D67141 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/enum2.c

[PATCH] D65527: Avoid assemble step in verbose-output-quoting.c

ychen updated this revision to Diff 218588. ychen added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65527/new/ https://reviews.llvm.org/D65527 Files: clang/test/Driver/verbose-output-quoting.c Index:

[PATCH] D65527: Avoid assemble step in verbose-output-quoting.c

ychen added a comment. > Would that work for this test also? Yes, that sounds good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65527/new/ https://reviews.llvm.org/D65527 ___ cfe-commits mailing

[PATCH] D67141: [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator.

ychen created this revision. ychen added reviewers: akhuang, rnk, probinson. Herald added a project: clang. Herald added a subscriber: cfe-commits. This essentially reverts changes from r361400. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67141 Files:

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

ychen added a comment. Since Charlie has completed his internship before LGTM, I'll commit this on his behalf. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62829/new/ https://reviews.llvm.org/D62829 ___ cfe-commits mailing list

[PATCH] D65527: Avoid assemble step in verbose-output-quoting.c

ychen created this revision. ychen added a reviewer: hans. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65527 Files: clang/test/Driver/verbose-output-quoting.c Index:

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer'

ychen added a comment. @chandlerc ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56353/new/ https://reviews.llvm.org/D56353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer'

ychen updated this revision to Diff 210014. ychen marked an inline comment as done. ychen added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56353/new/ https://reviews.llvm.org/D56353 Files:

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer'

ychen updated this revision to Diff 209973. ychen marked an inline comment as not done. ychen edited the summary of this revision. ychen added a comment. - Make `FramePointerKind` enum class. - Replace two if-else-if blocks to switch statements. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer'

ychen marked an inline comment as done and an inline comment as not done. ychen added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:845 + if (Args.hasArg(OPT_pg)) +Opts.setFramePointer(CodeGenOptions::FP_All); + MaskRay wrote: > I

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='

ychen updated this revision to Diff 209550. ychen added a comment. - rebase after D64294 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56353/new/ https://reviews.llvm.org/D56353 Files:

[PATCH] D64294: [Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64294/new/ https://reviews.llvm.org/D64294 ___ cfe-commits

[PATCH] D64294: [Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()

ychen added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:585 + (A && A->getOption().matches(options::OPT_fno_omit_frame_pointer)) || + (!(A && A->getOption().matches(options::OPT_fomit_frame_pointer)) && + (Args.hasArg(options::OPT_pg) ||

[PATCH] D64294: [Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()

ychen added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:579 -static bool shouldUseFramePointer(const ArgList , - const llvm::Triple ) { - if (Arg *A = Args.getLastArg(options::OPT_fno_omit_frame_pointer, -

[PATCH] D64294: [Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()

ychen added a comment. In D56353 , I remember @chandlerc thought `-f(no-)omit-frame-pointer` should win over `-m(no-)omit-leaf-frame-pointer`. I'm not sure what his thoughts on this now. @chandlerc ? Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='

tabloid.adroit added a comment. Herald added a project: clang. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56353/new/ https://reviews.llvm.org/D56353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='

tabloid.adroit marked 2 inline comments as done. tabloid.adroit added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:576-579 + Arg *FP = Args.getLastArg(options::OPT_fno_omit_frame_pointer, +options::OPT_fomit_frame_pointer); + Arg

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='

tabloid.adroit updated this revision to Diff 182213. tabloid.adroit marked an inline comment as done. tabloid.adroit added a comment. Thanks for the review! - address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56353/new/

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='

tabloid.adroit added a comment. gentle ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56353/new/ https://reviews.llvm.org/D56353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55915: [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer

tabloid.adroit added a comment. https://reviews.llvm.org/D56351 https://reviews.llvm.org/D56353 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55915/new/ https://reviews.llvm.org/D55915 ___ cfe-commits mailing list

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='

tabloid.adroit created this revision. tabloid.adroit added reviewers: chandlerc, rnk, t.p.northover. Herald added a subscriber: cfe-commits. set cc1 '-mframe-pointer=' according to driver options m(no-)omit-leaf-frame-pointer and f(no-)omit-frame-pointer This makes -fomit-frame-pointer imply

[PATCH] D55915: [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer

tabloid.adroit marked 3 inline comments as done. tabloid.adroit added inline comments. Comment at: lib/CodeGen/CGCall.cpp:1739 FuncAttrs.addAttribute("no-frame-pointer-elim", "true"); - FuncAttrs.addAttribute("no-frame-pointer-elim-non-leaf"); }

[PATCH] D55915: [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer

tabloid.adroit marked 2 inline comments as done. tabloid.adroit added a comment. Thanks for the review! Comments inline. Comment at: lib/CodeGen/CGCall.cpp:1739 FuncAttrs.addAttribute("no-frame-pointer-elim", "true"); -

[PATCH] D55915: [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer

tabloid.adroit updated this revision to Diff 179447. tabloid.adroit marked an inline comment as done. tabloid.adroit added a comment. - update test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55915/new/ https://reviews.llvm.org/D55915 Files:

[PATCH] D55915: [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer

tabloid.adroit updated this revision to Diff 179325. tabloid.adroit added a comment. - [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer - add test - update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55915/new/

[PATCH] D55915: [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointerand make -fomit-frame-pointer imply -momit-leaf-frame-pointer.This matches GCC's behavior.

tabloid.adroit created this revision. Herald added a subscriber: cfe-commits. llvm.org/PR9825 Repository: rC Clang https://reviews.llvm.org/D55915 Files: lib/CodeGen/CGCall.cpp lib/Driver/ToolChains/Clang.cpp test/Driver/cl-options.c test/Driver/frame-pointer-elim.c Index:

<    2   3   4   5   6   7