[PATCH] D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`

2022-06-18 Thread Yuki Okushi via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7eb046624f2a: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile` (authored by JohnTitor). Repository: rG LLVM Github Monorepo

[PATCH] D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`

2022-06-18 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor added a comment. Alright, let's go ahead then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127509/new/ https://reviews.llvm.org/D127509 ___ cfe-commits mailing list

[PATCH] D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`

2022-06-17 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor added a comment. I've re-triggered it several times but it shows the same failure, maybe they're valid? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127509/new/ https://reviews.llvm.org/D127509

[PATCH] D126599: [docs][clang] Fix a broken link on the APINotes doc

2022-06-12 Thread Yuki Okushi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe43a85a363cf: [docs][clang] Fix a broken link on the APINotes doc (authored by JohnTitor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126599/new/

[PATCH] D126599: [docs][clang] Fix a broken link on the APINotes doc

2022-06-12 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor added a comment. > It seems that other docs are following the GitHub URLs as well. I wish we > could do the relative document link instead of embedding the URL, but if that > is not possible, then this makes sense to do. I couldn't find the URL serving that file and I'm not familiar

[PATCH] D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`

2022-06-10 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor created this revision. Herald added a project: All. JohnTitor requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `getCurrentFile` here causes an assertion on some condition. `getCurrentFileOrBufferName` is preferrable instead.

[PATCH] D127411: [AST Matchers] Make dump_ast_matchers.py work on Python 3

2022-06-09 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor created this revision. Herald added a project: All. JohnTitor requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. ...Also updates the output HTML. Fixes llvm#46446 Repository: rG LLVM

[PATCH] D127407: [ubsan][docs] Clarify `objc-cast` is not part of `-fsanitize=undefined`

2022-06-09 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor created this revision. Herald added a project: All. JohnTitor requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It was missed on https://reviews.llvm.org/D71491. Fixes llvm#54880 Repository: rG LLVM Github Monorepo

[PATCH] D127065: [docs] Update supported language standards list for C++

2022-06-09 Thread Yuki Okushi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcedfb5462cd8: [docs] Update supported language standards list for C++ (authored by JohnTitor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127065/new/

[PATCH] D127066: [clang] Remove some `U+00AD`s in `__cpp_multidimensional_subscript`

2022-06-07 Thread Yuki Okushi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGaa9b3389ffd8: [clang] Remove some `U+C2AD`s in `__cpp_multidimensional_subscript` (authored by JohnTitor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127066: [clang] Remove some `U+00AD`s in `__cpp_multidimensional_subscript`

2022-06-07 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor added a comment. > It took me a moment, but this actually removes a 0xC2AD and not a 0x00AD. > It's still correct, but I was wondering why no character was printed in the > text -- 0xC2AD is not a defined Unicode character. Oh, my editor said it 0x00AD, it's weird. Anyway thanks for

[PATCH] D127066: [clang] Remove some `U+00AD`s in `__cpp_multidimensional_subscript`

2022-06-04 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor created this revision. Herald added a project: All. JohnTitor requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `Builder.defineMacro("__cpp_multidimensional_subscript", "202110L");` line has some `U+00AD`s that shouldn't

[PATCH] D127065: [docs] Update supported language standards list for C++

2022-06-04 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor created this revision. Herald added a project: All. JohnTitor requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D127065 Files: clang/docs/CommandGuide/clang.rst

[PATCH] D126608: [clangd] Remove a test with a duplicate of FileCacheTests

2022-05-31 Thread Yuki Okushi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5c1494039491: [clangd] Remove a test with a duplicate of FileCacheTests (authored by JohnTitor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126608/new/

[PATCH] D126608: [clangd] Remove a test with a duplicate of FileCacheTests

2022-05-28 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. JohnTitor requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. FIXME says it should be

[PATCH] D126607: [docs] Remove some unavailable modindex links

2022-05-28 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor created this revision. Herald added a subscriber: arphaman. Herald added projects: Flang, All. JohnTitor requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. These return 404 and I think it's fine to remove them until we can

[PATCH] D126597: [clang] Remove `rm` script which is no longer necessary

2022-05-28 Thread Yuki Okushi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG41a054ef7885: [clang] Remove `rm` script which is no longer necessary (authored by JohnTitor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126597/new/

[PATCH] D126599: [docs][clang] Fix a broken link on the APINotes doc

2022-05-28 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor created this revision. Herald added a project: All. JohnTitor requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch replaces a link with a GitHub one. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D126599

[PATCH] D126597: [clang] Remove `rm` script which is no longer necessary

2022-05-28 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor created this revision. Herald added a project: All. JohnTitor requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 8b4fa2c98e07997469f53bee30c0d24a61dc7c8c added

[PATCH] D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`

2022-05-27 Thread Yuki Okushi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd3d3e2528e60: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer` (authored by JohnTitor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`

2022-05-27 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor updated this revision to Diff 432527. JohnTitor added a comment. Fix the indention Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126524/new/ https://reviews.llvm.org/D126524 Files: clang/lib/Frontend/CompilerInstance.cpp Index:

[PATCH] D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`

2022-05-27 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor updated this revision to Diff 432526. JohnTitor added a comment. [CompilerInstance] Tweak the condition on `createCodeCompletionConsumer` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126524/new/ https://reviews.llvm.org/D126524 Files:

[PATCH] D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`

2022-05-27 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor created this revision. Herald added a project: All. JohnTitor requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes llvm#53545 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D126524 Files:

[PATCH] D68891: Remove unnecessary triple from test

2021-06-15 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor added a subscriber: rnk. JohnTitor added a comment. ping @rnk Seems you added this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68891/new/ https://reviews.llvm.org/D68891 ___ cfe-commits mailing list

[PATCH] D68891: Remove unnecessary triple from test

2021-04-22 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor added a comment. Ping @cfe-commits Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68891/new/ https://reviews.llvm.org/D68891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68891: Remove unnecessary triple from test

2019-10-18 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor added a comment. ping @rsmith Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68891/new/ https://reviews.llvm.org/D68891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68891: Remove unnecessary triple from test

2019-10-11 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor created this revision. JohnTitor added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. PR27098(https://bugs.llvm.org/show_bug.cgi?id=27098) has been fixed so the avoidance seems unnecessary. Repository: rC Clang