[clang-tools-extra] 64f74bf - [clang-tidy] Rewrite modernize-avoid-bind check.

Author: Zachary Turner Date: 2019-12-02T15:36:26-08:00 New Revision: 64f74bf72eb484aa32e1104050cb54745116decf URL: https://github.com/llvm/llvm-project/commit/64f74bf72eb484aa32e1104050cb54745116decf DIFF:

r374443 - [MSVC] Automatically add atlmfc folder to include and libpath.

Author: zturner Date: Thu Oct 10 13:25:54 2019 New Revision: 374443 URL: http://llvm.org/viewvc/llvm-project?rev=374443=rev Log: [MSVC] Automatically add atlmfc folder to include and libpath. Differential Revision: https://reviews.llvm.org/D68736 Modified:

Re: [PATCH] D56393: [DebugInfo] Don't emit DW_AT_enum_class unless it's actually an 'enum class'.

PDB/CodeView doesn’t doesn’t distinguish between various flavors of enums On Mon, Jan 7, 2019 at 8:14 AM Paul Robinson via Phabricator < revi...@reviews.llvm.org> wrote: > probinson created this revision. > probinson added reviewers: dblaikie, rnk, zturner. > probinson added a project:

[clang-tools-extra] r348176 - Fix compilation failure on Windows.

Author: zturner Date: Mon Dec 3 11:59:00 2018 New Revision: 348176 URL: http://llvm.org/viewvc/llvm-project?rev=348176=rev Log: Fix compilation failure on Windows. This was introduced earlier but apparently used an incorrect class name so it doesn't compile on Windows. Modified:

Re: [PATCH] D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap

I don’t think we really need this. isn’t Ilya’s solution in the other patch already sufficient? On Mon, Dec 3, 2018 at 7:34 AM Ivan Donchevskii via Phabricator < revi...@reviews.llvm.org> wrote: > yvvan added a comment. > > @ilya-biryukov > > Hm. What about another way around? - We have user

Re: [PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

If this is to go in (which I think is still not clear), it definitely should be limited to clangd. Not using mapped files is an order of magnitude performance regression for many use cases. On Thu, Nov 29, 2018 at 3:15 AM Roman Lebedev via Phabricator < revi...@reviews.llvm.org> wrote: >

Re: [PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

Do you all have Windows machines? The easiest thing to do is just write a sample program that mmaps a file and then tries to delete it, iterating over every possible set of flags. On Wed, Nov 28, 2018 at 7:25 AM Ivan Donchevskii via Phabricator < revi...@reviews.llvm.org> wrote: > yvvan added a

Re: [PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

I’m afraid this is going to be too severe a performance regression if we change the default. So I don’t think this should be an LLVM-wide default On Wed, Nov 28, 2018 at 1:38 AM Ivan Donchevskii via Phabricator < revi...@reviews.llvm.org> wrote: > yvvan added a comment. > > @ilya-biryukov > > I

r347216 - Fix some issues with LLDB's lit configuration files.

Author: zturner Date: Mon Nov 19 07:12:34 2018 New Revision: 347216 URL: http://llvm.org/viewvc/llvm-project?rev=347216=rev Log: Fix some issues with LLDB's lit configuration files. Recently I tried to port LLDB's lit configuration files over to use a on the surface, but broke some cases that

Re: [PATCH] D54405: Record whether a AST Matcher constructs a Node

I don’t really have much more to add here except to refer you to the style guide: https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable Specifically this line: “Use auto if and only if it makes the code more readable or easier to maintain.” Given that 2

Re: [PATCH] D53066: [Driver] Use forward slashes in most linker arguments

It seems like some combination of checking the target triple, host triple, and driver mode and putting the conversions behind those checks could work? For paths like resource dir that are going into debug info it should be driver mode. For paths we pass to another tool it should probably be based

[clang-tools-extra] r344362 - Fix one additional test broken by the YAML quoting change.

Author: zturner Date: Fri Oct 12 09:41:37 2018 New Revision: 344362 URL: http://llvm.org/viewvc/llvm-project?rev=344362=rev Log: Fix one additional test broken by the YAML quoting change. Modified: clang-tools-extra/trunk/test/include-fixer/merge.test Modified:

r344359 - Make YAML quote forward slashes.

Author: zturner Date: Fri Oct 12 09:31:20 2018 New Revision: 344359 URL: http://llvm.org/viewvc/llvm-project?rev=344359=rev Log: Make YAML quote forward slashes. If you have the string /usr/bin, prior to this patch it would not be quoted by our YAML serializer. But a string like C:\src would

r344358 - Revert "Make YAML quote forward slashes."

Author: zturner Date: Fri Oct 12 09:31:08 2018 New Revision: 344358 URL: http://llvm.org/viewvc/llvm-project?rev=344358=rev Log: Revert "Make YAML quote forward slashes." This reverts commit b86c16ad8c97dadc1f529da72a5bb74e9eaed344. This is being reverted because I forgot to write a useful

r344357 - Make YAML quote forward slashes.

Author: zturner Date: Fri Oct 12 09:24:09 2018 New Revision: 344357 URL: http://llvm.org/viewvc/llvm-project?rev=344357=rev Log: Make YAML quote forward slashes. Modified: cfe/trunk/unittests/Tooling/DiagnosticsYamlTest.cpp cfe/trunk/unittests/Tooling/ReplacementsYamlTest.cpp Modified:

Re: [clang-tools-extra] r280840 - Add a clang-tidy visual studio extension.

vs suggests it may not even > work. https://bugs.llvm.org/show_bug.cgi?id=34176 > > ~Aaron > > > On Wed, Oct 10, 2018 at 1:52 PM Aaron Ballman > wrote: > >> > >> On Wed, Sep 7, 2016 at 2:37 PM Zachary Turner via cfe-commits > >> wrote: > >>

Re: [clang-tools-extra] r280840 - Add a clang-tidy visual studio extension.

: > On Wed, Sep 7, 2016 at 2:37 PM Zachary Turner via cfe-commits > wrote: > > > > Author: zturner > > Date: Wed Sep 7 13:28:55 2016 > > New Revision: 280840 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=280840=rev > > Log: > > Add

Re: [PATCH] D52193: RFC: [clang] Multithreaded compilation support

I can try to get some timings from my machine. How do we handle crash recovery in the case where we don't spawn a child process? I thought the whole reason for spawning the cc1 driver as a separate process was so that we could collect and report crash information in a nice way. Not having that

Re: [PATCH] D52998: [benchmark] Disable exceptions in Microsoft STL

`_HAS_EXCEPTIONS=0` is an undocumented STL specific thing that the library implementation uses to mean "don't write code that does `throw X;`, do something else instead". On Mon, Oct 8, 2018 at 2:27 PM Elizabeth Andrews via Phabricator < revi...@reviews.llvm.org> wrote: > eandrews added a

Re: [PATCH] D52773: clang-cl: Add /showFilenames option (PR31957)

I agree magic environment variables are bad, but without it we don’t address the only current actual use we have for this, which is making the vs integration print filenames. Detecting compiler version from inside the integration is hard, but with an environment variable it’s very easy to solve.

r343629 - [cl-compat] Change /JMC from unsupported to ignored.

Author: zturner Date: Tue Oct 2 13:42:36 2018 New Revision: 343629 URL: http://llvm.org/viewvc/llvm-project?rev=343629=rev Log: [cl-compat] Change /JMC from unsupported to ignored. A tracking bug for actually implementing this in clang-cl is at https://bugs.llvm.org/show_bug.cgi?id=39156.

Re: r342668 - Add testcases for r342667.

Test removed in r342693. On Thu, Sep 20, 2018 at 3:30 PM Jorge Gorbe Moya wrote: > Zach and I were able to find the cause. > > Clang on Windows manages to find "file.h" when you #include "/file.h" and > that makes the expected diagnostic not appear. MSVC inteprets an #include > with a leading

r342693 - Remove failing test.

Author: zturner Date: Thu Sep 20 15:32:51 2018 New Revision: 342693 URL: http://llvm.org/viewvc/llvm-project?rev=342693=rev Log: Remove failing test. Removing on behalf of Jorge Moya. This test is broken on Windows due to it actually being able to resolve the path. There is an actual

Re: [PATCH] D52193: RFC: [clang] Multithreaded compilation support

In an ideal world yes, but the reality is that many people still use MSBuild, and in that world /MP presumably helps quite a bit. And given that many people already depend on this functionality of cl, it’s a potential showstopper for migrating if we don’t support it. That said, if the benefit

Re: [PATCH] D51847: Print correctly dependency paths on Windows

Lgtm On Wed, Sep 12, 2018 at 3:23 AM Dávid Bolvanský via Phabricator < revi...@reviews.llvm.org> wrote: > xbolva00 updated this revision to Diff 165052. > xbolva00 added a comment. > > - Fixed failing test > > > https://reviews.llvm.org/D51847 > > Files: > lib/Frontend/DependencyFile.cpp >

Re: [PATCH] D51847: Print correctly dependency paths on Windows

I mean in practice. What command do i run to hit this and what will the output look like? Can you paste some terminal output showing the command and output? On Tue, Sep 11, 2018 at 12:55 AM Dávid Bolvanský via Phabricator < revi...@reviews.llvm.org> wrote: > xbolva00 added a comment. > > In

Re: r341117 - [MS ABI] Fix mangling issue with dynamic initializer stubs.

t; >> . . . >> Failing Tests (2): >> LLVM-Unit :: ADT/./ADTTests.exe/HashingTest.HashCombineRangeGoldenTest >> Clang :: CodeGenCXX/catch-undef-behavior.cpp >> >> Please have a look? >> The builder was already red and did not send notifications on t

Re: r341117 - [MS ABI] Fix mangling issue with dynamic initializer stubs.

ior.cpp > > Please have a look? > The builder was already red and did not send notifications on this. > > Thanks > > Galina > > On Thu, Aug 30, 2018 at 1:54 PM Zachary Turner via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: zturner >>

r341117 - [MS ABI] Fix mangling issue with dynamic initializer stubs.

Author: zturner Date: Thu Aug 30 13:53:11 2018 New Revision: 341117 URL: http://llvm.org/viewvc/llvm-project?rev=341117=rev Log: [MS ABI] Fix mangling issue with dynamic initializer stubs. There are two types of dynamic initializer stubs. There's `dynamic initializer for 'x''(void) and

Re: [PATCH] D50877: [MS] Mangle a hash of the main file path into anonymous namespaces

IIRC it’s `?A0xABCDABCD@` where the hex value is some kind of hash On Thu, Aug 16, 2018 at 5:27 PM David Majnemer via Phabricator < revi...@reviews.llvm.org> wrote: > majnemer added a comment. > > How does MSVC handle this case? What mangled name does it generate? > > >

[libcxxabi] r337582 - Merge changes to ItaniumDemangle over to libcxxabi.

Author: zturner Date: Fri Jul 20 10:16:49 2018 New Revision: 337582 URL: http://llvm.org/viewvc/llvm-project?rev=337582=rev Log: Merge changes to ItaniumDemangle over to libcxxabi. ItaniumDemangle had a small NFC refactor to make some of its code reusable by the newly added Microsoft demangler.

r337572 - Rewrite the VS integration scripts.

Author: zturner Date: Fri Jul 20 09:30:02 2018 New Revision: 337572 URL: http://llvm.org/viewvc/llvm-project?rev=337572=rev Log: Rewrite the VS integration scripts. This is a new modernized VS integration installer. It adds a Visual Studio .sln file which, when built, outputs a VSIX that can be

Re: [PATCH] D49398: clang-cl: Postpone Wmsvc-not-found emission until link.exe gets used.

Lgtm. I also have a hard time saying which is best, we’re basically trying to help people who have already strayed from the path, so there’s probably no objectively correct answer On Tue, Jul 17, 2018 at 7:26 AM Nico Weber via Phabricator < revi...@reviews.llvm.org> wrote: > thakis updated this

Re: r336219 - Fix crash in clang.

verage? (guessing it failed on existing tests) > > Also, is the makeArrayRef necessary? Looks like if the original code > compiled (implicitly converting from vector to ArrayRef) then the new code > wouldn't need a makeArrayRef either? > > On Tue, Jul 3, 2018 at 11:17 AM Zachar

r336219 - Fix crash in clang.

Author: zturner Date: Tue Jul 3 11:12:39 2018 New Revision: 336219 URL: http://llvm.org/viewvc/llvm-project?rev=336219=rev Log: Fix crash in clang. This happened during a recent refactor. toStringRefArray() returns a vector, which was being implicitly converted to an ArrayRef, and then the

r335702 - Fix warning about unhandled enumeration in switch.

Author: zturner Date: Tue Jun 26 19:49:22 2018 New Revision: 335702 URL: http://llvm.org/viewvc/llvm-project?rev=335702=rev Log: Fix warning about unhandled enumeration in switch. Modified: cfe/trunk/lib/Driver/ToolChains/FreeBSD.cpp Modified: cfe/trunk/lib/Driver/ToolChains/FreeBSD.cpp

r334518 - Refactor ExecuteAndWait to take StringRefs.

Author: zturner Date: Tue Jun 12 10:43:52 2018 New Revision: 334518 URL: http://llvm.org/viewvc/llvm-project?rev=334518=rev Log: Refactor ExecuteAndWait to take StringRefs. This simplifies some code which had StringRefs to begin with, and makes other code more complicated which had const char*

[clang-tools-extra] r334221 - [FileSystem] Split up the OpenFlags enumeration.

Author: zturner Date: Thu Jun 7 12:58:58 2018 New Revision: 334221 URL: http://llvm.org/viewvc/llvm-project?rev=334221=rev Log: [FileSystem] Split up the OpenFlags enumeration. This breaks the OpenFlags enumeration into two separate enumerations: OpenFlags and CreationDisposition. The first

r334221 - [FileSystem] Split up the OpenFlags enumeration.

Author: zturner Date: Thu Jun 7 12:58:58 2018 New Revision: 334221 URL: http://llvm.org/viewvc/llvm-project?rev=334221=rev Log: [FileSystem] Split up the OpenFlags enumeration. This breaks the OpenFlags enumeration into two separate enumerations: OpenFlags and CreationDisposition. The first

r331786 - [lit] Fix running tests that require 'examples'.

Author: zturner Date: Tue May 8 11:20:10 2018 New Revision: 331786 URL: http://llvm.org/viewvc/llvm-project?rev=331786=rev Log: [lit] Fix running tests that require 'examples'. Differential Revision: https://reviews.llvm.org/D46514 Patch by Nikolai Kosjar. Modified:

Re: [PATCH] D44778: [clang-format] Wildcard expansion on Windows.

Never seen this PURE_WINDOWS CMake variable. How is it different than MSVC? On Thu, Mar 22, 2018 at 5:30 AM Alexander Kornienko via Phabricator < revi...@reviews.llvm.org> wrote: > alexfh created this revision. > alexfh added reviewers: klimek, djasper. > Herald added a subscriber: mgorny. > >

Re: r326168 - Attempt to fix greendragon bot after r326141

So this doesn’t appear to fix the issue that led to my revert earlier. http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/builds/6760 There’s no slashes in the command line that’s failing. However, this bot doesn’t seem to be updating and hasn’t pulled in this cl yet, but I

Re: r326168 - Attempt to fix greendragon bot after r326141

Never mind, I didn’t realize Reid resubmitted my cl after I reverted it. In fact, I reverted it because of this greendragon failure which I wasn’t sure how to fix at the time On Mon, Feb 26, 2018 at 10:12 PM Adam Nemet wrote: > BTW, I think that the LLVM bots have trouble

Re: r326168 - Attempt to fix greendragon bot after r326141

I already reverted this a long time ago, but if Shoaib has a proper fix that would be great On Mon, Feb 26, 2018 at 9:45 PM Adam Nemet wrote: > Ah, that should be sufficient. > > > On Feb 26, 2018, at 9:44 PM, Shoaib Meenai wrote: > > Thanks. I'm building on

r326116 - Revert "Emit proper CodeView when -gcodeview is passed without the cl driver."

Author: zturner Date: Mon Feb 26 11:51:29 2018 New Revision: 326116 URL: http://llvm.org/viewvc/llvm-project?rev=326116=rev Log: Revert "Emit proper CodeView when -gcodeview is passed without the cl driver." This reverts commit e17911006548518634fad66bb8648bcad49a1d64. This is failing on ASAN

r326113 - Emit proper CodeView when -gcodeview is passed without the cl driver.

Author: zturner Date: Mon Feb 26 11:25:39 2018 New Revision: 326113 URL: http://llvm.org/viewvc/llvm-project?rev=326113=rev Log: Emit proper CodeView when -gcodeview is passed without the cl driver. Windows debuggers don't work properly when column info is emitted with lines. We handled this by

Re: [PATCH] D43164: Fix test from failing when the python path has spaces

Lgtm On Sat, Feb 10, 2018 at 12:16 PM Aaron Smith via Phabricator < revi...@reviews.llvm.org> wrote: > asmith created this revision. > asmith added reviewers: zturner, llvm-commits. > Herald added subscribers: cfe-commits, klimek. > > This test would fail if the python path had spaces. Add a

Re: [PATCH] D41444: [ASTImporterTest] Make testing under '-fdelayed-template-parsing' mandatory

On the other hand, it doesn’t hurt anything to run the tests twice does it? I’d feel better if this patch were *adding* test coverage as opposed to changing coverage On Wed, Dec 20, 2017 at 6:50 AM Gábor Horváth via Phabricator < revi...@reviews.llvm.org> wrote: > xazax.hun added a comment. > >

r320750 - Fix many -Wsign-compare and -Wtautological-constant-compare warnings.

Author: zturner Date: Thu Dec 14 14:07:03 2017 New Revision: 320750 URL: http://llvm.org/viewvc/llvm-project?rev=320750=rev Log: Fix many -Wsign-compare and -Wtautological-constant-compare warnings. Most of the -Wsign-compare warnings are due to the fact that enums are signed by default in the

Re: [PATCH] D41081: Fix clang Lexer Windows line-ending bug

I'll let rnk@ weigh in (he's on vacation today though). I don't feel comfortable lgtm'ing any change where "don't use core.autocrlf=true" is an alternative solution, but if other people want to disagree with me and lgtm this, then that suggests I'm in the minority, which is fine. :) On Mon, Dec

Re: [PATCH] D41081: Fix clang Lexer Windows line-ending bug

See my other response. Maybe we don’t even need a substitution at all? On Mon, Dec 11, 2017 at 12:24 PM Benoit Belley via Phabricator < revi...@reviews.llvm.org> wrote: > belleyb added inline comments. > > > > Comment at: test/lit.cfg.py:52-57 > +if platform.system() in

r319505 - Mark all library options as hidden.

Author: zturner Date: Thu Nov 30 16:53:10 2017 New Revision: 319505 URL: http://llvm.org/viewvc/llvm-project?rev=319505=rev Log: Mark all library options as hidden. These command line options are not intended for public use, and often don't even make sense in the context of a particular tool

r318722 - Re-revert "Refactor debuginfo-tests."

Author: zturner Date: Mon Nov 20 17:20:28 2017 New Revision: 318722 URL: http://llvm.org/viewvc/llvm-project?rev=318722=rev Log: Re-revert "Refactor debuginfo-tests." This is still breaking greendragon. At this point I give up until someone can fix the greendragon bots, and I will probably

r318697 - Resubmit "Refactor debuginfo-tests" again.

Author: zturner Date: Mon Nov 20 13:41:36 2017 New Revision: 318697 URL: http://llvm.org/viewvc/llvm-project?rev=318697=rev Log: Resubmit "Refactor debuginfo-tests" again. This was reverted due to the tests being run twice on some build bots. Each run had a slightly different configuration due

Re: [PATCH] D40217: [LIT] Fix testing out-of-tree Clang builds

+mgorny On Sat, Nov 18, 2017 at 2:24 PM Eric Fiselier via Phabricator < revi...@reviews.llvm.org> wrote: > EricWF created this revision. > Herald added a reviewer: modocache. > > Currently, LIT configures the LLVM binary path before the Clang binary > path. However this breaks testing

r318486 - Re-revert "Refactor debuginfo-tests"

Author: zturner Date: Thu Nov 16 16:41:18 2017 New Revision: 318486 URL: http://llvm.org/viewvc/llvm-project?rev=318486=rev Log: Re-revert "Refactor debuginfo-tests" This is still broken because it causes certain tests to be run twice with slightly different configurations, which is wrong in

r318435 - Resubmit "Refactor debuginfo-tests"

Author: zturner Date: Thu Nov 16 10:26:20 2017 New Revision: 318435 URL: http://llvm.org/viewvc/llvm-project?rev=318435=rev Log: Resubmit "Refactor debuginfo-tests" This was reverted due to some failures on specific darwin buildbots, the issue being that the new lit configuration was not setting

r318112 - Revert "Update test_debuginfo.pl script to point to new tree location."

Author: zturner Date: Mon Nov 13 15:33:29 2017 New Revision: 318112 URL: http://llvm.org/viewvc/llvm-project?rev=318112=rev Log: Revert "Update test_debuginfo.pl script to point to new tree location." This reverts the aforementioned patch and 2 subsequent follow-ups, as some buildbots are still

r317931 - Fix for skipped CMake configuration on debuginfo-tests.

Author: zturner Date: Fri Nov 10 14:12:04 2017 New Revision: 317931 URL: http://llvm.org/viewvc/llvm-project?rev=317931=rev Log: Fix for skipped CMake configuration on debuginfo-tests. This should have been part of the change to debuginfo-tests, but it was left out. This should get the

r317925 - [debuginfo-tests] Make debuginfo-tests work in a standard configuration.

Author: zturner Date: Fri Nov 10 12:57:57 2017 New Revision: 317925 URL: http://llvm.org/viewvc/llvm-project?rev=317925=rev Log: [debuginfo-tests] Make debuginfo-tests work in a standard configuration. Previously, debuginfo-tests was expected to be checked out into clang/test and then the tests

Re: [PATCH] D39520: [libcxx][CMake] Fix libc++ build when no LLVM source tree is available.

The reason I ask is because I remember several months ago when I originally made these changes, there was quite a bit of difficulty because some of the Jenkins builders were wanting to run libcxx tests without any llvm source tree on the machine. Does this configuration still exist, or is it

Re: [PATCH] D39520: [libcxx][CMake] Fix libc++ build when no LLVM source tree is available.

No problem. If you don't mind me asking, what was the configuration change you made? Or do you have a link to the patch which fixed it that I can look at? On Thu, Nov 2, 2017 at 4:43 PM Volodymyr Sapsai via Phabricator < revi...@reviews.llvm.org> wrote: > vsapsai abandoned this revision. >

Re: [PATCH] D39520: [libcxx][CMake] Fix libc++ build when no LLVM source tree is available.

Yes that is the reason. But in a way it is more than that, because if those variables aren't available to lit.cfg, then test suite won't work. lit *must* be able to find a site config. There are three ways to get around this: 1) When you run lit.py, pass it a directory to your build tree. Then

Re: [PATCH] D39520: [libcxx][CMake] Fix libc++ build when no LLVM source tree is available.

On Wed, Nov 1, 2017 at 5:13 PM Volodymyr Sapsai wrote: > On Nov 1, 2017, at 16:47, Zachary Turner wrote: > > > This will remove the ability to use llvm-lit script even if source tree is > available. > > Can you please point me to the place where llvm-lit

Re: [PATCH] D39520: [libcxx][CMake] Fix libc++ build when no LLVM source tree is available.

This will remove the ability to use llvm-lit script even if source tree is available. Can you put this behind a check that for standalone build? Also, why was this just found? shouldnt this have been failing on Apple’s libcxx for the past several months? On Wed, Nov 1, 2017 at 4:38 PM Volodymyr

Re: [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

looks good! Feel free to commit whenever, I'd definitely recommend posting a PSA on cfe-dev@ (after you commit) so that people know about it. You might also get some useful ideas for improvements that way too. On Thu, Oct 26, 2017 at 9:52 PM Don Hinton wrote: > On Thu, Oct

Re: [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

On Thu, Oct 26, 2017 at 3:18 PM Don Hinton wrote: > On Thu, Oct 26, 2017 at 2:48 PM, Zachary Turner > wrote: > >> Seems fine, it would be nice if the workflow could be improved a little >> bit so that all you have to do is say `clangdiag break >>

Re: [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

Seems fine, it would be nice if the workflow could be improved a little bit so that all you have to do is say `clangdiag break —error=“-Wcovered-switch”` or something . I think that gives the most intuitive usage for people, even it’s a bit harder to implement. I also think user shouldn’t really

Re: [PATCH] D39162: [test] Fix clang-test for FreeBSD and NetBSD

Because this is not tge only part of ghe library search algorithm, and it’s not necessarily an error if the variable isn’t set On Sun, Oct 22, 2017 at 1:56 PM Zhihao Yuan via Phabricator < revi...@reviews.llvm.org> wrote: > lichray marked an inline comment as done. > lichray added a comment. > >

[clang-tools-extra] r316247 - [clang-tidy] Remove MSVC inline assembly test from cross-plat test.

Author: zturner Date: Fri Oct 20 16:09:20 2017 New Revision: 316247 URL: http://llvm.org/viewvc/llvm-project?rev=316247=rev Log: [clang-tidy] Remove MSVC inline assembly test from cross-plat test. This originally started out here in dev, but I moved it to another file when it became clear this

[clang-tools-extra] r316246 - [clang-tidy] Don't error on MS-style inline assembly.

Author: zturner Date: Fri Oct 20 16:00:51 2017 New Revision: 316246 URL: http://llvm.org/viewvc/llvm-project?rev=316246=rev Log: [clang-tidy] Don't error on MS-style inline assembly. To get MS-style inline assembly, we need to link in the various backends. Some other clang tools already do

Re: [PATCH] D36347: Add new script to launch lldb and set breakpoints for diagnostics all diagnostics seen.

+jingham On Fri, Oct 20, 2017 at 6:57 AM Don Hinton via Phabricator < revi...@reviews.llvm.org> wrote: > hintonda added a comment. > > In https://reviews.llvm.org/D36347#901885, @zturner wrote: > > > One possible reason for why this never got any traction is that > `lldb-commits` wasn't added

r316043 - Resubmit "[lit] Raise the logic for enabling clang & lld substitutions to llvm."

Author: zturner Date: Tue Oct 17 16:43:36 2017 New Revision: 316043 URL: http://llvm.org/viewvc/llvm-project?rev=316043=rev Log: Resubmit "[lit] Raise the logic for enabling clang & lld substitutions to llvm." The substitution for %debuginfo_tests had been inadvertently removed. This adds it

r315627 - [lit] Raise the logic for enabling clang & lld substitutions to llvm.

Author: zturner Date: Thu Oct 12 14:56:05 2017 New Revision: 315627 URL: http://llvm.org/viewvc/llvm-project?rev=315627=rev Log: [lit] Raise the logic for enabling clang & lld substitutions to llvm. This paves the way for other projects which might /use/ clang or lld but not necessarily need to

r315536 - Revert "[ADT] Make Twine's copy constructor private."

Author: zturner Date: Wed Oct 11 16:54:34 2017 New Revision: 315536 URL: http://llvm.org/viewvc/llvm-project?rev=315536=rev Log: Revert "[ADT] Make Twine's copy constructor private." This reverts commit 4e4ee1c507e2707bb3c208e1e1b6551c3015cbf5. This is failing due to some code that isn't built

r315530 - [ADT] Make Twine's copy constructor private.

Author: zturner Date: Wed Oct 11 16:33:06 2017 New Revision: 315530 URL: http://llvm.org/viewvc/llvm-project?rev=315530=rev Log: [ADT] Make Twine's copy constructor private. There's a lot of misuse of Twine scattered around LLVM. This ranges in severity from benign (returning a Twine from a

r315085 - [lit] Improve tool substitution in lit.

Author: zturner Date: Fri Oct 6 10:54:46 2017 New Revision: 315085 URL: http://llvm.org/viewvc/llvm-project?rev=315085=rev Log: [lit] Improve tool substitution in lit. This addresses two sources of inconsistency in test configuration files. 1. Substitution boundaries. Previously you would

r315084 - Run pyformat on lit code.

Author: zturner Date: Fri Oct 6 10:54:27 2017 New Revision: 315084 URL: http://llvm.org/viewvc/llvm-project?rev=315084=rev Log: Run pyformat on lit code. Modified: cfe/trunk/test/lit.cfg.py Modified: cfe/trunk/test/lit.cfg.py URL:

Re: [PATCH] D31363: [libc++] Remove cmake glob for source files

It’s not, but the point is we’re already skirting the line On Wed, Oct 4, 2017 at 9:37 PM Duncan P. N. Exon Smith wrote: > I haven't looked at the patch. If this is guarded behind NOT > LIBCXX_STANDALONE_BUILD checks, then it's probably fine. > > > On Oct 4, 2017, at

Re: [PATCH] D31363: [libc++] Remove cmake glob for source files

This doesn’t match up with what beanz said. While I assume Duncan is the final word, can we get some confirmation from beanz that everyone is on the same page? (Note that libcxx already uses some of LLVM’s cmake, but it’s behind some NOT LIBCXX_STANDALONE_BUILD checks) Assuming the answer

r313928 - Resubmit "[lit] Refactor out some more common lit configuration code."

Author: zturner Date: Thu Sep 21 15:16:40 2017 New Revision: 313928 URL: http://llvm.org/viewvc/llvm-project?rev=313928=rev Log: Resubmit "[lit] Refactor out some more common lit configuration code." There were two issues, one Python 3 specific related to Unicode, and another which is that the

r313922 - Revert "[lit] Refactor out some more common lit configuration code."

Author: zturner Date: Thu Sep 21 14:45:45 2017 New Revision: 313922 URL: http://llvm.org/viewvc/llvm-project?rev=313922=rev Log: Revert "[lit] Refactor out some more common lit configuration code." This is breaking several bots. I have enough information to investigate, so I'm reverting to

r313919 - [lit] Refactor out some more common lit configuration code.

Author: zturner Date: Thu Sep 21 14:27:31 2017 New Revision: 313919 URL: http://llvm.org/viewvc/llvm-project?rev=313919=rev Log: [lit] Refactor out some more common lit configuration code. debuginfo-tests has need to reuse a lot of common configuration from clang and lld, and in general it seems

r313892 - [lit] Rename lld and clang lit configs to end in .py

Author: zturner Date: Thu Sep 21 10:38:13 2017 New Revision: 313892 URL: http://llvm.org/viewvc/llvm-project?rev=313892=rev Log: [lit] Rename lld and clang lit configs to end in .py This follows in line with a previous patch of renaming LLVM's. Working on these files is difficult in certain

[libcxx] r313763 - Make libcxx tests work when llvm sources are not present.

Author: zturner Date: Wed Sep 20 09:01:50 2017 New Revision: 313763 URL: http://llvm.org/viewvc/llvm-project?rev=313763=rev Log: Make libcxx tests work when llvm sources are not present. Despite a strong CMake warning that this is an unsupported libcxx build configuration, some bots still rely

[libcxx] r313643 - Resubmit "Fix llvm-lit script generation in libcxx."

Author: zturner Date: Tue Sep 19 10:19:10 2017 New Revision: 313643 URL: http://llvm.org/viewvc/llvm-project?rev=313643=rev Log: Resubmit "Fix llvm-lit script generation in libcxx." After speaking with the libcxx owners, they agreed that this is a bug in the bot that needs to be fixed by the bot

[libcxx] r313607 - Revert "Fix llvm-lit script generation in libcxx."

Author: zturner Date: Mon Sep 18 20:11:35 2017 New Revision: 313607 URL: http://llvm.org/viewvc/llvm-project?rev=313607=rev Log: Revert "Fix llvm-lit script generation in libcxx." This reverts commit 4ad71811d45268d81b60f27e3b8b2bcbc23bd7b9. There is a bot that is checking out libcxx and lit

[libcxx] r313606 - Fix llvm-lit script generation in libcxx.

Author: zturner Date: Mon Sep 18 19:46:28 2017 New Revision: 313606 URL: http://llvm.org/viewvc/llvm-project?rev=313606=rev Log: Fix llvm-lit script generation in libcxx. Differential Revision: https://reviews.llvm.org/D37997 Modified: libcxx/trunk/CMakeLists.txt

r313579 - [lit] Update clang and lld to use new config helpers.

Author: zturner Date: Mon Sep 18 15:26:48 2017 New Revision: 313579 URL: http://llvm.org/viewvc/llvm-project?rev=313579=rev Log: [lit] Update clang and lld to use new config helpers. NFC intended here, this only updates clang and lld's lit configs to use some helper functionality in the lit.llvm

[clang-tools-extra] r313407 - Resubmit "[lit] Force site configs to run before source-tree configs"

Author: zturner Date: Fri Sep 15 15:10:46 2017 New Revision: 313407 URL: http://llvm.org/viewvc/llvm-project?rev=313407=rev Log: Resubmit "[lit] Force site configs to run before source-tree configs" This is a resubmission of r313270. It broke standalone builds of compiler-rt because we were not

r313407 - Resubmit "[lit] Force site configs to run before source-tree configs"

Author: zturner Date: Fri Sep 15 15:10:46 2017 New Revision: 313407 URL: http://llvm.org/viewvc/llvm-project?rev=313407=rev Log: Resubmit "[lit] Force site configs to run before source-tree configs" This is a resubmission of r313270. It broke standalone builds of compiler-rt because we were not

[clang-tools-extra] r313335 - Revert "[lit] Force site configs to run before source-tree configs"

Author: zturner Date: Thu Sep 14 19:56:40 2017 New Revision: 313335 URL: http://llvm.org/viewvc/llvm-project?rev=313335=rev Log: Revert "[lit] Force site configs to run before source-tree configs" This patch is still breaking several multi-stage compiler-rt bots. I already know what the fix is,

r313335 - Revert "[lit] Force site configs to run before source-tree configs"

Author: zturner Date: Thu Sep 14 19:56:40 2017 New Revision: 313335 URL: http://llvm.org/viewvc/llvm-project?rev=313335=rev Log: Revert "[lit] Force site configs to run before source-tree configs" This patch is still breaking several multi-stage compiler-rt bots. I already know what the fix is,

r313300 - Fix 2 stage build on some apple bots.

Author: zturner Date: Thu Sep 14 14:30:27 2017 New Revision: 313300 URL: http://llvm.org/viewvc/llvm-project?rev=313300=rev Log: Fix 2 stage build on some apple bots. The recent lit refactor changed the location of the lit script run by check targets from /utils/lit/lit.py to /llvm-lit.py. In

r313270 - [lit] Force site configs to be run before source-tree configs

Author: zturner Date: Thu Sep 14 09:47:58 2017 New Revision: 313270 URL: http://llvm.org/viewvc/llvm-project?rev=313270=rev Log: [lit] Force site configs to be run before source-tree configs This patch simplifies LLVM's lit infrastructure by enforcing an ordering that a site config is always run

[clang-tools-extra] r313270 - [lit] Force site configs to be run before source-tree configs

Author: zturner Date: Thu Sep 14 09:47:58 2017 New Revision: 313270 URL: http://llvm.org/viewvc/llvm-project?rev=313270=rev Log: [lit] Force site configs to be run before source-tree configs This patch simplifies LLVM's lit infrastructure by enforcing an ordering that a site config is always run

Re: [PATCH] D37529: [codeview] omit debug locations for nested exprs unless column info enabled

Well, if they worked I wasn't going to say we needed to add tests for them, i just wanted to make sure they work before we move onto something else. In any case, lgtm On Fri, Sep 8, 2017 at 4:43 PM Bob Haarman via Phabricator < revi...@reviews.llvm.org> wrote: > inglorion updated this revision

Re: [PATCH] D31697: Check for null before using TUScope

Might want to ask on cfe-dev or irc for more visibility since this review thread isn't getting much action On Thu, Jun 29, 2017 at 5:12 AM Kim Gräsman via Phabricator < revi...@reviews.llvm.org> wrote: > kimgr added a comment. > > I did some more debugging today. This happens when we attempt to

r298322 - Add a function to MD5 a file's contents.

Author: zturner Date: Mon Mar 20 18:33:18 2017 New Revision: 298322 URL: http://llvm.org/viewvc/llvm-project?rev=298322=rev Log: Add a function to MD5 a file's contents. In doing so, clean up the MD5 interface a little. Most existing users only care about the lower 8 bytes of an MD5, but for

r298098 - [clang-cl] Fix cross-compilation with MSVC 2017.

Author: zturner Date: Fri Mar 17 11:24:34 2017 New Revision: 298098 URL: http://llvm.org/viewvc/llvm-project?rev=298098=rev Log: [clang-cl] Fix cross-compilation with MSVC 2017. clang-cl works best when the user runs vcvarsall to set up an environment before running, but even this is not enough

  1   2   3   >