[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

zahiraam added a comment. Just starting to look at this. Don't we need a RN for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149573/new/ https://reviews.llvm.org/D149573 ___ cfe-commits mailing

[PATCH] D151834: Include math-errno with fast-math

zahiraam added a comment. In D151834#4645866 , @uabelho wrote: > What's the way forward here? Revert if it's unclear what to do? We have a fix for it. By eod a PR will be created. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D151834: Include math-errno with fast-math

zahiraam added a comment. In D151834#4644422 , @zahiraam wrote: > In D151834#4644394 , @aaron.ballman > wrote: > >> In D151834#4644391 , @zahiraam >> wrote: >> >>> In

[PATCH] D151834: Include math-errno with fast-math

zahiraam added a comment. In D151834#4644394 , @aaron.ballman wrote: > In D151834#4644391 , @zahiraam > wrote: > >> In D151834#4644378 , >> @aaron.ballman wrote: >>

[PATCH] D151834: Include math-errno with fast-math

zahiraam added a comment. In D151834#4644378 , @aaron.ballman wrote: > In D151834#4644375 , @zahiraam > wrote: > >> In D151834#4644373 , >> @aaron.ballman wrote: >>

[PATCH] D151834: Include math-errno with fast-math

zahiraam added a comment. In D151834#4644373 , @aaron.ballman wrote: > In D151834#4643925 , @uabelho wrote: > >> Hi @zahiraam , >> >> I have a couple of downstream testcases that fail with this patch. >> Before

[PATCH] D159486: Fix build error in CI.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4ff8f815c21: Fix buildbot failure (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159486: Fix build error in CI.

zahiraam added a comment. In D159486#4642317 , @smeenai wrote: > I don't think pre-merge testing covers Mac, only Linux and Windows (which is > presumably how the original breakage got in). If the test passes for you > locally I'd just push it and

[PATCH] D159486: Fix build error in CI.

zahiraam added a comment. In D159486#4642309 , @smeenai wrote: > The `-triple x86_64-unknown-unknown` shouldn't be required after the regex > change, but I'm fine either way. I'd recommend pushing this to fix the bots, > and Aaron/Nico can do a

[PATCH] D159486: Fix build error in CI.

zahiraam added a comment. In D159486#4642305 , @smeenai wrote: > Generally it's preferred to either push bot failure fixes directly or revert > the original commit (also without review), to get bots unblocked as soon as > possible :) > > From what I

[PATCH] D159486: Fix build error in CI.

zahiraam updated this revision to Diff 556301. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159486/new/ https://reviews.llvm.org/D159486 Files: clang/test/CodeGen/math-errno.c Index: clang/test/CodeGen/math-errno.c ===

[PATCH] D159486: Fix build error in CI.

zahiraam updated this revision to Diff 556297. zahiraam added a reviewer: thakis. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159486/new/ https://reviews.llvm.org/D159486 Files: clang/test/CodeGen/math-errno.c Index: clang/test/CodeGen/math-errno.c

[PATCH] D151834: Include math-errno with fast-math

zahiraam added a comment. In D151834#4642195 , @thakis wrote: > This breaks check-clang on macOS: http://45.33.8.238/macm1/68762/step_7.txt > > Please take a look and revert for now if it takes a while to fix. I have a fix for it here:

[PATCH] D159486: Fix build error in CI.

zahiraam created this revision. zahiraam added a reviewer: aaron.ballman. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Fix buildbot failure https://lab.llvm.org/buildbot/#/builders/38/builds/14427. Repository: rG LLVM Github Monorepo

[PATCH] D151834: Include math-errno with fast-math

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c93e3c1c8ba: Take math-errno into account with #pragma float_control(precise,on) and (authored by zahiraam). Repository: rG LLVM Github Monorepo

[PATCH] D151834: Include math-errno with fast-math

zahiraam updated this revision to Diff 556141. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptions.def

[PATCH] D151834: Include math-errno with fast-math

zahiraam added a comment. @andrew.w.kaylor Would you mind taking a last look at this before I can push this, please? I got the thumbs up from Aaron. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834

[PATCH] D151834: Include math-errno with fast-math

zahiraam updated this revision to Diff 556057. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptions.def

[PATCH] D151834: Include math-errno with fast-math

zahiraam added a comment. In D151834#4639536 , @aaron.ballman wrote: > LGTM, but please add a release note describing the changes when you land them. @aaron.ballman thanks for the reviews. Added some note in the RN, let me know if that is enough.

[PATCH] D151834: Include math-errno with fast-math

zahiraam updated this revision to Diff 556029. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptions.def

[PATCH] D151834: Include math-errno with fast-math

zahiraam added inline comments. Comment at: clang/docs/LanguageExtensions.rst:4702 +optimizations are enabled in the section of code governed by the pragma. +Effectively ``-ffast-math`` is enabled and ``-ffp-contract=fast``. This pragam +disables ``-fmath-errno``.

[PATCH] D151834: Include math-errno with fast-math

zahiraam updated this revision to Diff 546055. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst

[PATCH] D151834: Include math-errno with fast-math

zahiraam updated this revision to Diff 545666. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst

[PATCH] D151834: Include math-errno with fast-math

zahiraam updated this revision to Diff 544893. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/include/clang/Basic/FPOptions.def clang/include/clang/Basic/LangOptions.h clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D151834: Include math-errno with fast-math

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2321-2328 + if ((FD->hasAttr() && !ErrnoOverriden && !OptNone) || ((ConstWithoutErrnoAndExceptions || ConstWithoutExceptions) && - (!ConstWithoutErrnoAndExceptions ||

[PATCH] D151834: Include math-errno with fast-math

zahiraam updated this revision to Diff 544745. zahiraam marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/include/clang/Basic/FPOptions.def clang/include/clang/Basic/LangOptions.h

[PATCH] D151834: Include math-errno with fast-math

zahiraam updated this revision to Diff 544084. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/include/clang/Basic/FPOptions.def clang/include/clang/Basic/LangOptions.h clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D151834: Include math-errno with fast-math

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2321-2328 + if ((FD->hasAttr() && !ErrnoOverriden && !OptNone) || ((ConstWithoutErrnoAndExceptions || ConstWithoutExceptions) && - (!ConstWithoutErrnoAndExceptions ||

[PATCH] D151834: Include math-errno with fast-math

zahiraam marked 2 inline comments as done. zahiraam added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:857 setAllowApproxFuncOverride(!Value); +setMathErrnoOverride(Value); if (Value) aaron.ballman wrote: > zahiraam wrote: >

[PATCH] D151834: Include math-errno with fast-math

zahiraam added inline comments. Comment at: clang/include/clang/Basic/FPOptions.def:29 OPTION(Float16ExcessPrecision, LangOptions::ExcessPrecisionKind, 2, FPEvalMethod) OPTION(BFloat16ExcessPrecision, LangOptions::ExcessPrecisionKind, 2, FPEvalMethod) +OPTION(MathErrno,

[PATCH] D151834: Include math-errno with fast-math

zahiraam added a comment. Review anyone please? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151834: Include math-errno with fast-math

zahiraam added inline comments. Comment at: clang/test/CodeGen/math-errno.c:28 +// FAST-LABEL: define dso_local nofpclass(nan inf) float @f1 +// FAST: call fast nofpclass(nan inf) float @sqrtf(float noundef nofpclass(nan inf) {{.*}}) #[[ATTR3_FAST:[0-9]+]] +//

[PATCH] D151834: Include math-errno with fast-math

zahiraam updated this revision to Diff 542141. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/include/clang/Basic/FPOptions.def clang/include/clang/Basic/LangOptions.h clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D151834: Include math-errno with fast-math

zahiraam updated this revision to Diff 539961. zahiraam marked 6 inline comments as done and an inline comment as not done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/include/clang/Basic/FPOptions.def

[PATCH] D154359: [clang] Reset FP options before template instantiation

zahiraam added a comment. LGTM. Thanks for the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154359/new/ https://reviews.llvm.org/D154359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154359: [clang] Reset FP options before template instantiation

zahiraam added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:5093 +FpPragmaStack.CurrentValue = FPOptionsOverride(); + if (addInstantiatedParametersToScope(Function, PatternDecl, Scope, This seems to be fixing the crash.

[PATCH] D139629: clang: Stop emitting "strictfp"

zahiraam added a comment. In D139629#4481408 , @rjmccall wrote: > In D139629#4481030 , @zahiraam > wrote: > >> According to this comment https://reviews.llvm.org/D87528#2342132, it looks >> like @rjmccall had

[PATCH] D139629: clang: Stop emitting "strictfp"

zahiraam added a subscriber: rjmccall. zahiraam added a comment. According to this comment https://reviews.llvm.org/D87528#2342132, it looks like @rjmccall had proposed the addition of the attribute. @rjmccall Do you recall why it was added? CHANGES SINCE LAST ACTION

[PATCH] D153770: Fix test regression on 32-bit x86.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9fd3321db742: Fix test regression on 32-bit x86. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153770: Fix test regression on 32-bit x86.

zahiraam updated this revision to Diff 535783. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153770/new/ https://reviews.llvm.org/D153770 Files: clang/test/Sema/fp-eval-pragma-with-float-double_t-1.c clang/test/Sema/fp-eval-pragma-with-float-double_t-2.c

[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

zahiraam added a comment. In D152818#4456872 , @aaron.ballman wrote: > In D152818#4456797 , @zahiraam > wrote: > >> In D152818#4456717 , >> @aaron.ballman wrote: >>

[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

zahiraam added a comment. In D152818#4456717 , @aaron.ballman wrote: > In D152818#4456510 , @zahiraam > wrote: > >> In D152818#4456483 , >> @nicolerabjohn wrote: >>

[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

zahiraam added a comment. In D152818#4456483 , @nicolerabjohn wrote: > In D152818#4442116 , @rjmccall > wrote: > >> Does https://reviews.llvm.org/D143241 solve the original problem here, or is >> there

[PATCH] D153770: Fix test regression on 32-bit x86.

zahiraam updated this revision to Diff 535368. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153770/new/ https://reviews.llvm.org/D153770 Files: clang/test/Sema/fp-eval-pragma-with-float-double_t-1.c clang/test/Sema/fp-eval-pragma-with-float-double_t-2.c

[PATCH] D153770: Fix test regression on 32-bit x86.

zahiraam added a comment. In D153770#4449078 , @mgorny wrote: > I think you also need to require `X86` target but I'm not 100% sure. I don't think so. That warning was legal and is related to the option ffp-eval-method. I could have added run lines in

[PATCH] D153770: Fix test regression on 32-bit x86.

zahiraam created this revision. zahiraam added reviewers: rjmccall, mgorny. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Issue found after merging of patch: https://reviews.llvm.org/D153590 Repository: rG LLVM Github Monorepo

[PATCH] D153590: Don't use float_t and double_t with #pragma clang fp eval_method.

zahiraam added a comment. In D153590#4446358 , @mgorny wrote: > This change causes test regressions on 32-bit x86: > > FAIL: Clang :: Sema/fp-eval-pragma-with-float-double_t-3.c (14665 of 17845) > TEST 'Clang :: >

[PATCH] D153590: Don't use float_t and double_t with #pragma clang fp eval_method.

This revision was automatically updated to reflect the committed changes. Closed by commit rG63b0b82fd6be: When float_t and double_t types are used inside a scope with (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153590/new/

[PATCH] D153590: Don't use float_t and double_t with #pragma clang fp eval_method.

zahiraam updated this revision to Diff 533981. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153590/new/ https://reviews.llvm.org/D153590 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D153590: Don't use float_t and double_t with #pragma clang fp eval_method.

zahiraam created this revision. zahiraam added reviewers: rjmccall, andrew.w.kaylor, aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. When float_t and double_t types are used inside a scope

[PATCH] D146148: [clang] Add a namespace for interesting identifiers.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9fc3b4acbc92: [clang] Add a namespace for interesting identifiers. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/

[PATCH] D146148: [clang] Add a namespace for interesting identifiers.

zahiraam updated this revision to Diff 533583. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/include/clang/Basic/IdentifierTable.h clang/include/clang/Basic/TokenKinds.def clang/include/clang/Basic/TokenKinds.h

[PATCH] D146148: [clang] Add a namespace for interesting identifiers.

zahiraam updated this revision to Diff 533360. zahiraam marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/include/clang/Basic/IdentifierTable.h clang/include/clang/Basic/TokenKinds.def

[PATCH] D146148: [clang] Add a namespace for interesting identifiers.

zahiraam marked an inline comment as done. zahiraam added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6784 + if (II->getInterestingIdentifierID() != 0) +NewTD->addAttr(AvailableOnlyInDefaultEvalMethodAttr::Create(Context)); }

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 54. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/include/clang/Basic/IdentifierTable.h clang/include/clang/Basic/TokenKinds.def clang/include/clang/Basic/TokenKinds.h

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6784 + if (II->getInterestingIdentifierID() != 0) +NewTD->addAttr(AvailableOnlyInDefaultEvalMethodAttr::Create(Context)); } rjmccall wrote: > Please switch over the

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 532734. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 532643. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:326 +ObjCOrBuiltinID = FirstBuiltinID + (ID - 1); +assert(getBuiltinID() == ID && "ID too large for field!"); + } Is this the assert you are looking for? CHANGES

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 532293. zahiraam marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:325 void setBuiltinID(unsigned ID) { -ObjCOrBuiltinID = ID + tok::NUM_OBJC_KEYWORDS; -assert(ObjCOrBuiltinID - unsigned(tok::NUM_OBJC_KEYWORDS) == ID - && "ID too large

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:89 +static constexpr int FirstInterestingIdentifierID = LastObjCKeywordID + 1; +static constexpr int LastInterestingIdentifierID = LastObjCKeywordID + tok::NUM_INTERESTING_IDENTIFIERS;

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 531884. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td

[PATCH] D152818: [Clang] Fix assertion when pragma FENV_ACCESS is used with a throw function.

zahiraam added a comment. In D152818#4421064 , @nicolerabjohn wrote: > I've opened an issue (https://github.com/llvm/llvm-project/issues/63063) > where we hit the same assertion. There's a smaller test case, and we've done > enough investigation that

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam marked an inline comment as done. zahiraam added inline comments. Comment at: clang/lib/Basic/Builtins.cpp:33 static constexpr Builtin::Info BuiltinInfo[] = { -{"not a builtin function", nullptr, nullptr, nullptr, HeaderDesc::NO_HEADER, +#define

[PATCH] D152818: [Clang] Fix assertion when pragma FENV_ACCESS is used with a throw function.

zahiraam added a comment. In D152818#4417683 , @tbaeder wrote: > In D152818#4417649 , @zahiraam > wrote: > >> In D152818#4417644 , @tbaeder >> wrote: >> >>> Has the

[PATCH] D152818: [Clang] Fix assertion when pragma FENV_ACCESS is used with a throw function.

zahiraam added a comment. In D152818#4417644 , @tbaeder wrote: > Has the test case been obfuscated on purpose? This is a smaller reproducible from creduce. Didn't know if it would be OK to have an include in a LIT test? Repository: rG LLVM Github

[PATCH] D152818: [Clang] Fix assertion when pragma FENV_ACCESS is used with a throw function.

zahiraam created this revision. zahiraam added a reviewer: aaron.ballman. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. See issue here: https://godbolt.org/z/aYME8KTdn Repository: rG LLVM Github Monorepo

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. @rjmccall any chance we get your feedback on this please? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151834: Include math-errno with fast-math

zahiraam added inline comments. Comment at: clang/include/clang/Basic/FPOptions.def:30 OPTION(BFloat16ExcessPrecision, LangOptions::ExcessPrecisionKind, 2, FPEvalMethod) +OPTION(MathErrno, bool, 1, BFloat16ExcessPrecision) #undef OPTION andrew.w.kaylor wrote:

[PATCH] D151834: Include math-errno with fast-math

zahiraam updated this revision to Diff 530040. zahiraam marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/include/clang/Basic/FPOptions.def clang/include/clang/Basic/LangOptions.h

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D151834: Include math-errno with fast-math

zahiraam updated this revision to Diff 527950. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/include/clang/Basic/FPOptions.def clang/include/clang/Basic/LangOptions.h clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D151834: Include math-errno with fast-math

zahiraam created this revision. zahiraam added reviewers: andrew.w.kaylor, jcranmer-intel. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. MSVC includes math-errno with #pragma float_control(precise,on) at O2

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:316 + unsigned getInterestingIdentifierID() { +if (ObjCOrBuiltinID >= 1341 && ObjCOrBuiltinID < 1343) + return ObjCOrBuiltinID; rjmccall wrote: > This is closer to

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 524882. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td clang/include/clang/Basic/Builtins.def

[PATCH] D150913: [Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

zahiraam added a comment. LGTM. Just a minor comment. Comment at: clang/include/clang/Basic/LangOptions.def:321 ENUM_LANGOPT(Float16ExcessPrecision, ExcessPrecisionKind, 2, FPP_Standard, "Intermediate truncation behavior for floating point arithmetic")

[PATCH] D150913: [Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

zahiraam added inline comments. Comment at: clang/test/CodeGen/X86/bfloat16.cpp:2-3 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 2 +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-feature +fullbf16 -S -emit-llvm

[PATCH] D150913: [Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

zahiraam added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:381 HasBFloat16 = SSELevel >= SSE2; codemzs wrote: > rjmccall wrote: > > pengfei wrote: > > > I'm not sure if I understand the meaning of `HasFullBFloat16`. If it is > > > used

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. @rjmccall Made a bit of progress on this, but still not quite where it should be! Would appreciate your feedback/guidance to see that's moving in the right direction. Not sure about lazily creating the interesting identifiers? There are still some LIT tests failing

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 522800. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. In D146148#4330971 , @rjmccall wrote: > In D146148#4330611 , @zahiraam > wrote: > >> In D146148#4221651 , @rjmccall >> wrote: >> >>> In

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam marked an inline comment as done. zahiraam added a comment. In D146148#4221651 , @rjmccall wrote: > In D146148#4220591 , @zahiraam > wrote: > >> In D146148#4220495

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. (Sorry for taking so long to get to it!) Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 519121. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d3b779792fb: Set rounding_mode to tonearest with #pragma STDC FENV_ACCESS OFF. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

zahiraam updated this revision to Diff 512388. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147733/new/ https://reviews.llvm.org/D147733 Files: clang/lib/Sema/SemaAttr.cpp clang/test/CodeGen/pragma-fenv_access.c Index: clang/test/CodeGen/pragma-fenv_access.c

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

zahiraam added inline comments. Comment at: clang/test/CodeGen/pragma-fenv_access.c:4 // RUN: %clang_cc1 -fexperimental-strict-floating-point -ffp-exception-behavior=strict -triple %itanium_abi_triple -emit-llvm %s -o - -fms-extensions -DMS | FileCheck

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

zahiraam added inline comments. Comment at: clang/test/CodeGen/pragma-fenv_access.c:239 +// CHECK-LABEL: @func_20 +// STRICT: call float @llvm.experimental.constrained.fadd.f32(float {{.*}}, float {{.*}}, metadata !"round.tonearest", metadata !"fpexcept.strict") +// DEFAULT:

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

zahiraam updated this revision to Diff 512203. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147733/new/ https://reviews.llvm.org/D147733 Files: clang/lib/Sema/SemaAttr.cpp clang/test/CodeGen/pragma-fenv_access.c Index: clang/test/CodeGen/pragma-fenv_access.c

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

zahiraam updated this revision to Diff 512108. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147733/new/ https://reviews.llvm.org/D147733 Files: clang/lib/Sema/SemaAttr.cpp clang/test/CodeGen/pragma-fenv_access.c Index:

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

zahiraam updated this revision to Diff 511760. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147733/new/ https://reviews.llvm.org/D147733 Files: clang/lib/Sema/SemaAttr.cpp clang/test/CodeGen/pragma-fenv_access.c Index: clang/test/CodeGen/pragma-fenv_access.c

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

zahiraam added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:1340 + if (!IsEnabled) +NewFPFeatures.setDisallowFenvAccess(IsEnabled); FpPragmaStack.Act(Loc, PSK_Set, StringRef(), NewFPFeatures); andrew.w.kaylor wrote: > Why is this only needed

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

zahiraam updated this revision to Diff 511522. Herald added subscribers: jplehr, sstefan1, aheejin. Herald added a reviewer: jdoerfert. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147733/new/ https://reviews.llvm.org/D147733 Files: clang/include/clang/Basic/LangOptions.h

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

zahiraam created this revision. zahiraam added reviewers: andrew.w.kaylor, pengfei. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. In strict mode the 'roundin_mode' is set to 'dynamic'. Using this pragma to get out of strict mode doesn't

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. In D146148#4224862 , @rjmccall wrote: > In D146148#4224094 , @aaron.ballman > wrote: > >> In D146148#4222306 , @zahiraam >> wrote: >> >>> In

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. In D146148#4221651 , @rjmccall wrote: > In D146148#4220591 , @zahiraam > wrote: > >> In D146148#4220495 , >> @aaron.ballman wrote: >> >>> In

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. In D146148#4220495 , @aaron.ballman wrote: > In D146148#4220433 , @zahiraam > wrote: > >> In D146148#4220268 , @rjmccall >> wrote: >> >>>

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. In D146148#4220268 , @rjmccall wrote: > Okay, so modifying `math.h` to use this attribute is acceptable? That's > great, that's definitely the best outcome for the compiler. > > Just a minor request about the diagnostic name,

  1   2   3   4   5   6   >