[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 508176. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 508114. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. In D146148#4213475 , @rjmccall wrote: > The user isn't modifying the `float_t` type definition, they're using it. I > think the diagnostic should say something like `cannot use type 'float_t' > within '#pragma clang fp

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 507829. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaType.cpp

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 507360. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaType.cpp

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:662-665 +def err_type_definition_cannot_be_modified : Error< + "%0 type definition cannot be modified inside a scope containing " + "'#pragma clang fp eval_method(%1)' when a command

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 507097. zahiraam marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaType.cpp

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam created this revision. zahiraam added reviewers: andrew.w.kaylor, aaron.ballman. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. When float_t and double_t types are used inside a scope with potential ABI breakage. See

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

zahiraam added a comment. In D145704#4184584 , @aaron.ballman wrote: > LGTM! If you don't hear otherwise from @kito-cheng, @bjope, @Wilco1 in the > next ~4 hours, feel free to land. Great! Thanks @aaron.ballman and @tstellar. CHANGES SINCE LAST

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

zahiraam updated this revision to Diff 503865. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145704/new/ https://reviews.llvm.org/D145704 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/PPMacroExpansion.cpp clang/lib/Lex/Preprocessor.cpp clang/lib/Sema/SemaAttr.cpp

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

zahiraam added a comment. In D145704#4182268 , @aaron.ballman wrote: > Thank you for working on this! Because this is fixing an ABI break, if we can > land this in time for the release candidate I think we should try to add this > to 16.0 to limit

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

zahiraam added subscribers: Wilco1, kito-cheng, bjope. zahiraam added a comment. Tagging @davemgreen, @kito-cheng, @bjope and @Wilco1 for awareness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145704/new/ https://reviews.llvm.org/D145704

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

zahiraam created this revision. zahiraam added reviewers: andrew.w.kaylor, aaron.ballman. Herald added a subscriber: pengfei. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Setting __FLT_EVAL_METHOD__ to -1 with fast-math will set

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 502776. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. Would be nice to have feedback on this! So much work was put into it! @rnk, @efriedma CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 ___ cfe-commits mailing list

[PATCH] D144299: [NFC] Added a lit test for the arithmetic fence builtin.

zahiraam created this revision. zahiraam added a reviewer: aaron.ballman. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D144299 Files:

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#4129733 , @dmgreen wrote: > Hi. I created this issue about the use of Ofast and -1: > https://github.com/llvm/llvm-project/issues/60781 Thanks. Will take a look. CHANGES SINCE LAST ACTION

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 494051. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 493726. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 493411. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4b06d8ff826: __arithmetic_fence enforces ordering on expression evaluation when fast-math (authored by zahiraam). Repository: rG LLVM Github

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

zahiraam added a comment. In D142583#4083251 , @bader wrote: > LGTM. Thanks! Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142583/new/ https://reviews.llvm.org/D142583 ___ cfe-commits

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

zahiraam added inline comments. Comment at: clang/test/CodeGen/arithmetic-fence-builtin.c:73 int subit(float a, float b, float *fp) { - // CHECKFAST: define {{.*}}@subit(float noundef %a, float noundef %b{{.*}} + // CHECKPRECISE: define {{.*}}@subit(float noundef %a, float

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

zahiraam updated this revision to Diff 492483. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142583/new/ https://reviews.llvm.org/D142583 Files: clang/lib/Basic/Targets/SPIR.h clang/test/CodeGen/arithmetic-fence-builtin.c clang/test/Sema/arithmetic-fence-builtin.c Index:

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

zahiraam updated this revision to Diff 492410. zahiraam marked 3 inline comments as done. zahiraam edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142583/new/ https://reviews.llvm.org/D142583 Files: clang/lib/Basic/Targets/SPIR.h

[PATCH] D142583: [SPIR-V] Add support for __arithmetic_fence builtin for SYCL targets.

zahiraam created this revision. zahiraam added reviewers: bader, andrew.w.kaylor. Herald added subscribers: Naghasan, Anastasia, ebevhan, yaxunl. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. __arithmetic_fence enforces ordering on

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam marked an inline comment as done. zahiraam added a comment. Thanks. Please see my comments/questions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 ___ cfe-commits mailing list

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam marked an inline comment as done. zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5006 +if (NeedsGlobalCtor || NeedsGlobalDtor) + DelayedCXXInitPosition[D] = ~0U; + } else { efriedma wrote: > zahiraam wrote: > >

[PATCH] D142367: Add support for clang-cl's option -fexcess-precision.

zahiraam added a subscriber: thakis. zahiraam added a comment. @thakis I think this should fix the clang-cl use with the Mac OS compiler. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142367/new/ https://reviews.llvm.org/D142367

[PATCH] D142367: Add support for clang-cl's option -fexcess-precision.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3759ef9e56dc: Add support for clang-cls option `-fexcess-precision`. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D142367: Add support for clang-cl's option -fexcess-precision.

zahiraam created this revision. zahiraam added reviewers: mdtoguchi, andrew.w.kaylor. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. This option is useful for clang and clang-cl. Repository: rG LLVM Github Monorepo

[PATCH] D141929: Add support for clang-cl's option -fexcess-precision.

zahiraam added a comment. In D141929#4069763 , @thakis wrote: > This breaks tests on macOS: http://45.33.8.238/macm1/53215/step_7.txt > > Please take a look and revert for now if it takes a while to fix. @thakis I reverted it. The fast value of the

[PATCH] D141929: Add support for clang-cl's option -fexcess-precision.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47074683c906: Add support for clang-cls option `-fexcess-precision`. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D141929: Add support for clang-cl's option /fexcess-precision.

zahiraam updated this revision to Diff 490183. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141929/new/ https://reviews.llvm.org/D141929 Files: clang/include/clang/Driver/Options.td clang/test/Driver/fexcess-precision.c Index:

[PATCH] D141929: Add support for clang-cl's option /fexcess-precision.

zahiraam updated this revision to Diff 489833. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141929/new/ https://reviews.llvm.org/D141929 Files: clang/include/clang/Driver/Options.td clang/test/Driver/cl-options.c Index: clang/test/Driver/cl-options.c

[PATCH] D141929: Add support for clang-cl's option /Qfexcess-precision.

zahiraam created this revision. zahiraam added reviewers: andrew.w.kaylor, mdtoguchi. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141929 Files:

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D136176: Implement support for option 'fexcess-precision'.

This revision was automatically updated to reflect the committed changes. Closed by commit rG85d049a089d4: Implement support for option fexcess-precision. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5006 +if (NeedsGlobalCtor || NeedsGlobalDtor) + DelayedCXXInitPosition[D] = ~0U; + } else { efriedma wrote: > zahiraam wrote: > > efriedma wrote: > > > zahiraam wrote: > >

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 486274. zahiraam marked 2 inline comments as done. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files:

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 484882. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/docs/UsersManual.rst clang/include/clang/AST/Type.h clang/include/clang/Basic/FPOptions.def

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484840. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484814. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5006 +if (NeedsGlobalCtor || NeedsGlobalDtor) + DelayedCXXInitPosition[D] = ~0U; + } else { efriedma wrote: > zahiraam wrote: > > efriedma wrote: > > > zahiraam wrote: > >

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484665. zahiraam marked an inline comment as done. Herald added a subscriber: aheejin. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam marked 3 inline comments as done. zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5006 +if (NeedsGlobalCtor || NeedsGlobalDtor) + DelayedCXXInitPosition[D] = ~0U; + } else { efriedma wrote: > zahiraam wrote: > >

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/test/CodeGenCXX/PR19955.cpp:20 +// CHECK-64: store ptr @"?var@@3HA", ptr @"?varp@@3PEAHEA" +// CHECK: ret void @rnk was concerned about varp pointing to dllimport var. That does it I think. CHANGES SINCE

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484278. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5006 +if (NeedsGlobalCtor || NeedsGlobalDtor) + DelayedCXXInitPosition[D] = ~0U; + } else { Do you agree this should be done only when one of those flags is on? CHANGES

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484258. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam marked an inline comment as done. zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5009 + if (isStaticInit(D, getLangOpts()) && NeedsGlobalCtor && NeedsGlobalDtor) { +EmitCXXCtorInit(D, GV, true, 201, llvm::StringLiteral("ctor"),

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4852 + if (!CD->isTrivial() && !D->getTLSKind()) +NeedsGlobalCtor = true; +} efriedma wrote: > zahiraam wrote: > > efriedma wrote: > > > I have no idea

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4852 + if (!CD->isTrivial() && !D->getTLSKind()) +NeedsGlobalCtor = true; +} efriedma wrote: > I have no idea what this code is supposed to do. I have

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484062. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484006. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. In D137107#3999681 , @efriedma wrote: > Not sure exactly what code that generates in its current form, but that's > roughly the right idea, yes. Thanks. This is the IR I am getting for this simple case. I think there is still

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. This uploaded patch is a draft (LIT tests fails but are not updated since I am not sure about these changes) that I am part way confident about. There are still a lot of things that I need to look at, but would you mind looking at it to see if this is moving in the

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 483320. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 483167. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/docs/UsersManual.rst clang/include/clang/AST/Type.h

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderGlobalInitsOrStermFinalizers Key(201,

[PATCH] D139629: clang: Stop emitting "strictfp"

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2135 -llvm::AttrBuilder FuncAttrs(F->getContext()); -FuncAttrs.addAttribute("strictfp"); -F->addFnAttrs(FuncAttrs); I think it would better to fix this function instead

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D139629: clang: Stop emitting "strictfp"

zahiraam added a comment. Can you please be more verbose in your summary? This change is related to the use of -ffp-exception-behavior=strict right? This attribute is set here https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CodeGenFunction.cpp#L987 but under a condition. Is

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 481271. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderGlobalInitsOrStermFinalizers Key(201,

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 481029. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderGlobalInitsOrStermFinalizers Key(201,

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a subscriber: eli.friedman. zahiraam added a comment. @eli.friedman Thanks. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 480574. zahiraam marked 3 inline comments as done. zahiraam edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderGlobalInitsOrStermFinalizers Key(201,

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 480198. zahiraam edited the summary of this revision. Herald added subscribers: pcwang-thead, nlopes, abrachet, sstefan1, phosek, s.egerton, ormris, mstorsjo, simoncook, fedor.sergeev, aheejin, dschuff. Herald added a reviewer: jdoerfert. Herald added a

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 479652. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:13896 + Diag(var->getLocation(), diag::err_constexpr_var_requires_const_init) + << var << Init->getSourceRange(); + } efriedma wrote: > rnk wrote: > > zahiraam

[PATCH] D138117: [clang][docs] Correct floating point option explanations

zahiraam accepted this revision. zahiraam added a comment. This revision is now accepted and ready to land. In D138117#3963560 , @kawashima-fj wrote: > Addressed to @zahiraam's comment Looks good. CHANGES SINCE LAST ACTION

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:821 +(Precision == LangOptions::ExcessPrecisionKind::FPP_Standard || + Precision == LangOptions::ExcessPrecisionKind::FPP_Fast)) { if (Ty->isAnyComplexType()) {

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 479264. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptions.def clang/include/clang/Basic/LangOptions.def

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:13896 + Diag(var->getLocation(), diag::err_constexpr_var_requires_const_init) + << var << Init->getSourceRange(); + } efriedma wrote: > zahiraam wrote: > >

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam marked 3 inline comments as done. zahiraam added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:13896 + Diag(var->getLocation(), diag::err_constexpr_var_requires_const_init) + << var << Init->getSourceRange(); + }

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:13896 + Diag(var->getLocation(), diag::err_constexpr_var_requires_const_init) + << var << Init->getSourceRange(); + } efriedma wrote: > I don't understand why this

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam marked 2 inline comments as done. zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:821 +(Precision == LangOptions::ExcessPrecisionKind::FPP_Standard || + Precision == LangOptions::ExcessPrecisionKind::FPP_Fast)) { if

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. In D137107#3931259 , @efriedma wrote: > There are multiple notions of "constant" here: > > - Whether a value is invariant at runtime. > - Whether a value is legal in a "constexpr" expression. > - Whether we can emit a constant

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 478624. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CodeGenModule.cpp clang/lib/Sema/SemaDecl.cpp clang/test/CodeGenCXX/PR19955.cpp

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 478738. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptions.def

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:301 + enum Float16ExcessPrecisionKind { FPP_Standard, FPP_Fast, FPP_None }; + rjmccall wrote: > rjmccall wrote: > > You can leave this named `ExcessPrecisionKind` — if we

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam added a comment. @rjmccall Would you mind looking at this please? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138117: [clang][docs] Correct floating point option explanations

zahiraam added inline comments. Comment at: clang/docs/UsersManual.rst:1435 * ``-fno-honor-nans`` - + * ``-fapprox-func`` * ``-fno-math-errno`` Leave a blank line before and after the bullet. Same below. Comment at:

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 477179. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptions.def clang/include/clang/Basic/LangOptions.def

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam added inline comments. Comment at: clang/docs/UsersManual.rst:1732 +.. option:: -fexcess-precision: + + By default, Clang uses excess precision to calculate ``_Float16`` rjmccall wrote: > >The C and C++ standards allow floating-point expressions

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 476913. zahiraam marked 6 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptions.def

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 476587. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptions.def

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:300 +FPP_Fast, +FPP_None + }; zahiraam wrote: > andrew.w.kaylor wrote: > > Is FPP_None somehow the same as fexcess-precision=16? If not, what does it > > mean? > Yes,

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 476161. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Basic/LangOptions.h clang/include/clang/Driver/Options.td

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

zahiraam added a comment. Looks good to me after the additional RUN line mentioned in my comment for Driver/fp-model.c is added. Thanks. Comment at: clang/test/Driver/fp-model.c:77 +// WARN12-NOT: warning: overriding '-ffp-model=strict' option with '-ffp-model=strict'

[PATCH] D138109: [clang] Fix -fp-model={strict|precise} to disable -fapprox-func

zahiraam added a comment. In D138109#3932691 , @kawashima-fj wrote: > Update a test to include the `ffast-math -ffp-model=fast` pattern. Thanks. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138109/new/

[PATCH] D138117: [clang][docs] Correct floating point option explanations

zahiraam added a comment. In D138117#3932688 , @kawashima-fj wrote: > In D138117#3931109 , @zahiraam > wrote: > >> It would probably be better to make these changes with the appropriate code >> changes you are

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:300 +FPP_Fast, +FPP_None + }; andrew.w.kaylor wrote: > Is FPP_None somehow the same as fexcess-precision=16? If not, what does it > mean? Yes, maybe this is confusing.

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 475902. zahiraam marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Basic/LangOptions.h

[PATCH] D138117: [clang][docs] Correct floating point option explanations

zahiraam added a comment. In D138117#3930423 , @kawashima-fj wrote: > I don't know it is inteded that `-fno-fast-math` does not imply > `-ftrapping-math` and `-frounding-math`. > `-ffast-math` and `-fno-fast-math` is not symmetric in >

[PATCH] D138117: [clang][docs] Correct floating point option explanations

zahiraam added a comment. It would probably be better to make these changes with the appropriate code changes you are making for each semantic mode. And may be keep this patch only for the other changes you are proposing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

<    1   2   3   4   5   6   >