@@ -855,7 +868,17 @@ void DeclPrinter::VisitFunctionDecl(FunctionDecl *D) {
Out << Proto << " -> ";
Proto.clear();
}
- AFT->getReturnType().print(Out, Policy, Proto);
+ if (!Policy.SuppressTagKeyword && Policy.SuppressScope &&
+
@@ -287,9 +288,47 @@ class ComplexExprEmitter
ComplexPairTy EmitComplexBinOpLibCall(StringRef LibCallName,
const BinOpInfo );
- QualType getPromotionType(QualType Ty) {
+ QualType GetHigherPrecisionFPType(QualType ElementType) {
+
@@ -2824,26 +2816,89 @@ static void RenderFloatingPointOptions(const ToolChain
, const Driver ,
switch (optID) {
default:
break;
-case options::OPT_fcx_limited_range: {
- EmitComplexRangeDiag(D, Range,
LangOptions::ComplexRangeKind::CX_Limited);
-
@@ -287,9 +288,47 @@ class ComplexExprEmitter
ComplexPairTy EmitComplexBinOpLibCall(StringRef LibCallName,
const BinOpInfo );
- QualType getPromotionType(QualType Ty) {
+ QualType GetHigherPrecisionFPType(QualType ElementType) {
+
@@ -287,9 +288,47 @@ class ComplexExprEmitter
ComplexPairTy EmitComplexBinOpLibCall(StringRef LibCallName,
const BinOpInfo );
- QualType getPromotionType(QualType Ty) {
+ QualType GetHigherPrecisionFPType(QualType ElementType) {
+
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/81514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -986,13 +1028,17 @@ ComplexPairTy ComplexExprEmitter::EmitBinDiv(const
BinOpInfo ) {
llvm::Value *OrigLHSi = LHSi;
if (!LHSi)
LHSi = llvm::Constant::getNullValue(RHSi->getType());
-if (Op.FPFeatures.getComplexRange() == LangOptions::CX_Fortran)
+
@@ -2824,26 +2816,89 @@ static void RenderFloatingPointOptions(const ToolChain
, const Driver ,
switch (optID) {
default:
break;
-case options::OPT_fcx_limited_range: {
- EmitComplexRangeDiag(D, Range,
LangOptions::ComplexRangeKind::CX_Limited);
-
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/81514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/81514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -794,8 +834,10 @@ ComplexPairTy ComplexExprEmitter::EmitBinMul(const
BinOpInfo ) {
ResR = Builder.CreateFSub(AC, BD, "mul_r");
ResI = Builder.CreateFAdd(AD, BC, "mul_i");
- if (Op.FPFeatures.getComplexRange() == LangOptions::CX_Limited ||
-
@@ -1046,30 +1046,35 @@ defm offload_uniform_block :
BoolFOption<"offload-uniform-block",
NegFlag,
BothFlags<[], [ClangOption], " that kernels are launched with uniform block
sizes (default true for CUDA/HIP and false otherwise)">>;
-def fcx_limited_range :
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/84014
>From bdefe754c14c5e050ebf2b9c82eca458041564a4 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Tue, 5 Mar 2024 05:35:16 -0800
Subject: [PATCH 1/8] [clang-cl] Fix value of __FUNCTION__ in MSVC mode.
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/84014
>From bdefe754c14c5e050ebf2b9c82eca458041564a4 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Tue, 5 Mar 2024 05:35:16 -0800
Subject: [PATCH 1/7] [clang-cl] Fix value of __FUNCTION__ in MSVC mode.
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/84014
>From bdefe754c14c5e050ebf2b9c82eca458041564a4 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Tue, 5 Mar 2024 05:35:16 -0800
Subject: [PATCH 1/6] [clang-cl] Fix value of __FUNCTION__ in MSVC mode.
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/84567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/84567
>From 28f355e0f30660593902165a885acc0182e197cc Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 8 Mar 2024 13:13:11 -0800
Subject: [PATCH 1/2] Fix warning message when using -fno-cx-limited-range
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/84567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/84567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/84567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/84567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/84567
…ran-rules.
>From 28f355e0f30660593902165a885acc0182e197cc Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 8 Mar 2024 13:13:11 -0800
Subject: [PATCH] Fix warning message when using
@@ -1635,6 +1635,17 @@ void TypePrinter::printElaboratedBefore(const
ElaboratedType *T,
if (T->getKeyword() != ElaboratedTypeKeyword::None)
OS << " ";
NestedNameSpecifier *Qualifier = T->getQualifier();
+if (!Policy.SuppressTagKeyword && Policy.SuppressScope
@@ -1635,6 +1635,17 @@ void TypePrinter::printElaboratedBefore(const
ElaboratedType *T,
if (T->getKeyword() != ElaboratedTypeKeyword::None)
OS << " ";
NestedNameSpecifier *Qualifier = T->getQualifier();
+if (!Policy.SuppressTagKeyword && Policy.SuppressScope
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/84014
>From bdefe754c14c5e050ebf2b9c82eca458041564a4 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Tue, 5 Mar 2024 05:35:16 -0800
Subject: [PATCH 1/4] [clang-cl] Fix value of __FUNCTION__ in MSVC mode.
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/84014
>From bdefe754c14c5e050ebf2b9c82eca458041564a4 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Tue, 5 Mar 2024 05:35:16 -0800
Subject: [PATCH 1/2] [clang-cl] Fix value of __FUNCTION__ in MSVC mode.
@@ -463,8 +463,72 @@ void ctor_tests() {
constexpr SL global_sl = SL::current();
static_assert(is_equal(global_sl.function(), ""));
+template
+class TestBI {
+public:
+ TestBI() {
+#ifdef MS
+ static_assert(is_equal(__FUNCTION__, "test_func::TestBI::TestBI"));
+
zahiraam wrote:
> Oh, I just noticed that you’ve tried to land this change before (#66120), but
> it seems it was reverted because of some problems; if those are fixed now,
> then I’d say going forward with this is probably fine, seeing as it was
> approved the first time round.
>
> This
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/84014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
> I’m not entirely sure this change is a good idea: some people might be
> relying on Clang’s behaviour wrt `__FUNCTION__`, especially with how long
> it’s been around; Clang may not be fully MSVC-compatible in this case, but
> that incompatibilty seems unlikely to cause
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/84014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/84014
None
>From bdefe754c14c5e050ebf2b9c82eca458041564a4 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Tue, 5 Mar 2024 05:35:16 -0800
Subject: [PATCH] [clang-cl] Fix value of __FUNCTION__ in MSVC mode.
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 01/20] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
zahiraam wrote:
> > struct struct X
>
> Interesting! The LIT test is passing on a debug build on Windows and
> generating the right output:
>
> `VarDecl:{ResultType struct X}{TypedText f1} (50) (deprecated)`
>
> I will try a release build.
It looks like I can reproduce it with the release
zahiraam wrote:
> struct struct X
Interesting! The LIT test is passing on a debug build on Windows and
generating the right output:
`VarDecl:{ResultType struct X}{TypedText f1} (50) (deprecated)`
I will try a release build.
https://github.com/llvm/llvm-project/pull/67592
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 01/19] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
@@ -1847,19 +1847,51 @@ floating point semantic models: precise (the default),
strict, and fast.
* ``16`` - Forces ``_Float16`` operations to be emitted without using excess
precision arithmetic.
+.. option:: -fcomplex-arithmetic=:
+
+ This option specifies the
zahiraam wrote:
> @AaronBallman I removed the field that I added in the policy and tried to use
> the existing ones. That broke a few LIT tests but before fixing them I want
> to check with you if the combination of policy I have added in the unittest
> is correct. Thanks.
ping?
@@ -1041,28 +1041,15 @@ defm offload_uniform_block :
BoolFOption<"offload-uniform-block",
NegFlag,
BothFlags<[], [ClangOption], " that kernels are launched with uniform block
sizes (default true for CUDA/HIP and false otherwise)">>;
-def fcx_limited_range :
@@ -1041,28 +1041,15 @@ defm offload_uniform_block :
BoolFOption<"offload-uniform-block",
NegFlag,
BothFlags<[], [ClangOption], " that kernels are launched with uniform block
sizes (default true for CUDA/HIP and false otherwise)">>;
-def fcx_limited_range :
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/81514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
@andykaylor I am opening up this for review in order to have other people
chime in.
@AaronBallman what do you think about the warnings (and the rest of course)?
-fcomplex-arithmetic=full -ffast-math generates this warning: "use of nnan or
ninf flags in the presence of
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/81514
>From 13fd73932251843173cbbc31ca93905ca0469277 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 12 Feb 2024 10:58:19 -0800
Subject: [PATCH 1/4] [CLANG] Full support of complex multiplication and
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/81514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1847,19 +1847,33 @@ floating point semantic models: precise (the default),
strict, and fast.
* ``16`` - Forces ``_Float16`` operations to be emitted without using excess
precision arithmetic.
-.. option:: -fcx-limited-range:
-
- This option enables the naive
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/81514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1847,19 +1847,33 @@ floating point semantic models: precise (the default),
strict, and fast.
* ``16`` - Forces ``_Float16`` operations to be emitted without using excess
precision arithmetic.
-.. option:: -fcx-limited-range:
-
- This option enables the naive
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/81514
>From 13fd73932251843173cbbc31ca93905ca0469277 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 12 Feb 2024 10:58:19 -0800
Subject: [PATCH 1/3] [CLANG] Full support of complex multiplication and
zahiraam wrote:
@AaronBallman I removed the field that I added in the policy and tried to use
the existing ones. That broke a few LIT tests but before fixing them I want to
check with you if the combination of policy I have added in the unittest is
correct. Thanks.
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 01/18] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/81514
>From 13fd73932251843173cbbc31ca93905ca0469277 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 12 Feb 2024 10:58:19 -0800
Subject: [PATCH 1/3] [CLANG] Full support of complex multiplication and
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/81514
>From 13fd73932251843173cbbc31ca93905ca0469277 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 12 Feb 2024 10:58:19 -0800
Subject: [PATCH 1/2] [CLANG] Full support of complex multiplication and
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/81514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
This is still WIP in progress, but I would like to get @MaskRay's opinion about
the feasibility of getting this new option approved knowing that the 2 options
being potentially replaced are already merged in clang18 and are probably
already used by some users.
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/81514
>From 13fd73932251843173cbbc31ca93905ca0469277 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 12 Feb 2024 10:58:19 -0800
Subject: [PATCH 1/2] [CLANG] Full support of complex multiplication and
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 01/17] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 01/16] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 01/15] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 01/14] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 01/13] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 01/12] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 01/11] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/81514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/81514
None
>From 13fd73932251843173cbbc31ca93905ca0469277 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 12 Feb 2024 10:58:19 -0800
Subject: [PATCH] [CLANG] Full support of complex multiplication and
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/81316
>From 5cf9dd1073ce6ae72aebbbd8fc4723ec48b39816 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Fri, 9 Feb 2024 12:38:34 -0800
Subject: [PATCH 1/3] Full control of range reduction for complex
multiplication
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/81316
>From 5cf9dd1073ce6ae72aebbbd8fc4723ec48b39816 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Fri, 9 Feb 2024 12:38:34 -0800
Subject: [PATCH 1/3] Full control of range reduction for complex
multiplication
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/81316
>From 5cf9dd1073ce6ae72aebbbd8fc4723ec48b39816 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Fri, 9 Feb 2024 12:38:34 -0800
Subject: [PATCH 1/2] Full control of range reduction for complex
multiplication
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/81316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/81316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/81316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/81316
division.
>From 5cf9dd1073ce6ae72aebbbd8fc4723ec48b39816 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Fri, 9 Feb 2024 12:38:34 -0800
Subject: [PATCH] Full control of range reduction for complex
https://github.com/zahiraam approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/81173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/80290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
Tagging @zeroomega and @mikaelholmen for awareness.
https://github.com/llvm/llvm-project/pull/80290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/80290
>From 529879c78ae4c1bf4d04110b543f37c1d1af20f7 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Thu, 1 Feb 2024 05:26:00 -0800
Subject: [PATCH 1/5] Fix INF/NAN warning.
---
@@ -73,7 +73,7 @@ def warn_pragma_debug_unexpected_argument : Warning<
def warn_fp_nan_inf_when_disabled : Warning<
"use of %select{infinity|NaN}0%select{| via a macro}1 is undefined behavior "
"due to the currently enabled floating-point options">,
- InGroup>;
+
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/80290
>From 529879c78ae4c1bf4d04110b543f37c1d1af20f7 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Thu, 1 Feb 2024 05:26:00 -0800
Subject: [PATCH 1/4] Fix INF/NAN warning.
---
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/80290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/80290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/80290
>From 529879c78ae4c1bf4d04110b543f37c1d1af20f7 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Thu, 1 Feb 2024 05:26:00 -0800
Subject: [PATCH 1/3] Fix INF/NAN warning.
---
@@ -3288,7 +3288,7 @@ void Preprocessor::HandleIfdefDirective(Token ,
return;
}
- emitMacroExpansionWarnings(MacroNameTok);
+ emitMacroExpansionWarnings(MacroNameTok, true);
zahiraam wrote:
The bool argument is not needed since I am removing the 3rd
@@ -9132,7 +9132,7 @@ bool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall,
unsigned BuiltinID) {
if (BuiltinID == Builtin::BI__builtin_isunordered &&
TheCall->getFPFeaturesInEffect(getLangOpts()).getNoHonorNaNs())
Diag(TheCall->getBeginLoc(),
@@ -72,7 +72,9 @@ def warn_pragma_debug_unexpected_argument : Warning<
def warn_fp_nan_inf_when_disabled : Warning<
"use of %select{infinity|NaN}0%select{| via a macro}1 is undefined behavior "
- "due to the currently enabled floating-point options">,
+ "due to the
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/80290
>From 529879c78ae4c1bf4d04110b543f37c1d1af20f7 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Thu, 1 Feb 2024 05:26:00 -0800
Subject: [PATCH 1/2] Fix INF/NAN warning.
---
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/80290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/80290
None
>From 529879c78ae4c1bf4d04110b543f37c1d1af20f7 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Thu, 1 Feb 2024 05:26:00 -0800
Subject: [PATCH] Fix INF/NAN warning.
---
zahiraam wrote:
> Hi, I am seeing breakages on some of our audio code on tip of tree Clang and
> I traced it back to this patch.
>
> We uses `-ffast-math` mode for performance reasons but we also uses
> `-fhonor-infinities`, `-fhonor-nans` and `fno-finite-math-only` to ensure
> that the
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/79821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
@MaskRay, @AaronBallman thanks for the review.
https://github.com/llvm/llvm-project/pull/79821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
@AaronBallman Any more comments?
https://github.com/llvm/llvm-project/pull/79821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/79821
>From c22d670259f1d9fc22b6e01bf19d1f2316b1d617 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 29 Jan 2024 04:56:13 -0800
Subject: [PATCH 1/3] Fix erroneous warning.
---
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/79821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/79821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
> Thank you for the fix! Can you add some more description to the patch summary
> as to what's erroneous (the summary ends up becoming the commit message, so a
> terse summary can be harmful for later code archeology).
>
> Do we need a release note for this? Are you planning
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/79821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/79821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/79821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/79821
This patch is to remove warning. See https://godbolt.org/z/bYP8P8nqY
>From c22d670259f1d9fc22b6e01bf19d1f2316b1d617 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 29 Jan 2024 04:56:13 -0800
Subject:
zahiraam wrote:
> > Is this expected and wanted?
>
> Good catch! I would not expect that diagnostic; we should silence the
> diagnostic if it's used in a `#ifdef`, `#elifdef`, or `defined` because the
> value isn't necessary. Perhaps we should also silence something like
> `sizeof(INFINITY)`
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/78330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 200 of 434 matches
Mail list logo
