[PATCH] D137287: [Test] Fix CHECK typo.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7fa5febaa43: [Test] Fix CHECK typo. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137287/new/ https://reviews.llvm.org/D137287

[PATCH] D137287: [Test] Fix CHECK typo.

zequanwu added a comment. In D137287#3905474 , @probinson wrote: > Nice work! > have you verified that all the modified tests pass? naively it looks like > you'd need at least 3 different targets to run them all (windows, > webassembly, powerpc) Those

[PATCH] D137287: [Test] Fix CHECK typo.

zequanwu updated this revision to Diff 472833. zequanwu added a comment. Herald added subscribers: lldb-commits, nemanjai. Herald added projects: LLDB, clang-tools-extra, Flang. Fix more typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137287: [Test] Fix CHECK typo.

zequanwu created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, pmatos, asb, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, ThomasRaoux, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst,

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu created this revision. zequanwu added reviewers: rnk, tejohnson, mehdi_amini. Herald added subscribers: pmatos, asb, ormris, steven_wu, hiraditya, arichardson, inglorion, sbc100, emaste. Herald added a reviewer: MaskRay. Herald added projects: lld-macho, All. Herald added a reviewer:

[PATCH] D135340: [PGO] Make emitted symbols hidden

zequanwu added a comment. This causing instrprof-darwin-dead-strip.c failed on mac. FAIL: Profile-x86_64 :: instrprof-darwin-dead-strip.c (1 of 238) TEST 'Profile-x86_64 :: instrprof-darwin-dead-strip.c' FAILED Script: -- : 'RUN: at line 4';

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

zequanwu added a comment. It's causing chromium test failure. [ RUN ] PartitionAllocPCScanTest.StackScanning ../../base/allocator/partition_allocator/starscan/pcscan_unittest.cc:682: Failure Value of: IsInFreeList(root().ObjectToSlotStart(dangling_reference)) Actual: true

[PATCH] D130210: [SemaCXX] Set promotion type for enum if its type is promotable to integer type even if it has no definition.

zequanwu added a comment. In D130210#3669464 , @aaron.ballman wrote: > LGTM, though you should add a release note to clang/docs/ReleaseNotes.rst for > the bug fix. Thank you! Added a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D130210: [SemaCXX] Set promotion type for enum if its type is promotable to integer type even if it has no definition.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd870a575631d: [SemaCXX] Set promotion type for enum if its type is promotable to integer type… (authored by zequanwu). Changed prior to commit:

[PATCH] D130210: [SemaCXX] Set promotion type for enum bool to integer type.

zequanwu added a comment. > I am curious that this does not change the test results of > `clang/test/CXX/conv/conv.prom/p4.cpp` The crash only happens when the enum is bool and has no definition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130210: [SemaCXX] Set promotion type for enum bool to integer type.

zequanwu updated this revision to Diff 446551. zequanwu marked 2 inline comments as done. zequanwu added a comment. - Address comment. - Move test to `clang/test/CXX/conv/conv.prom/p4.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130210/new/

[PATCH] D130210: [SemaCXX] Set promotion type for enum bool to integer type.

zequanwu created this revision. zequanwu added reviewers: hans, aaron.ballman. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. EnumDecl's promotion type is set either to the parsed type or calculated

[PATCH] D127338: [Clang][CoverageMapping] Fix compile time explosions by adjusting only appropriated skipped ranges

zequanwu added a comment. Just noticed that 3 test cases failed. Please fix them before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127338/new/ https://reviews.llvm.org/D127338 ___

[PATCH] D127338: [Clang][CoverageMapping] Fix compile time explosions by adjusting only appropriated skipped ranges

zequanwu accepted this revision. zequanwu added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127338/new/ https://reviews.llvm.org/D127338

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

zequanwu added a comment. Herald added a subscriber: pmatos. Hi, this causes crash on Mac building bot. Here is the reduced repro: `opt -lower-global-dtors /tmp/reduced.ll -o /dev/null ` $ cat /tmp/reduced.ll %struct.mach_header = type { i32, i32, i32, i32, i32, i32, i32 }

[PATCH] D121678: [pseudo] Split greatergreater token.

zequanwu added a comment. This fails on windows bot at https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8819402935494502225/+/u/package_clang/stdout?format=raw. C:\b\s\w\ir\cache\builder\src\third_party\llvm\clang-tools-extra\pseudo\unittests\TokenTest.cpp(190): error:

[PATCH] D121269: [clang-format] Fix namespace format when the name is followed by a macro

This revision was automatically updated to reflect the committed changes. Closed by commit rGd54c4df31470: [clang-format] Fix namespace format when the name is followed by a macro (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D121269?vs=414442=414506#toc

[PATCH] D121269: [clang-format] Fix namespace format when the name is followed by a macro

zequanwu updated this revision to Diff 414442. zequanwu marked 7 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121269/new/ https://reviews.llvm.org/D121269 Files:

[PATCH] D121269: [clang-format] Fix namespace format when the name is followed by a macro

zequanwu updated this revision to Diff 414222. zequanwu marked 2 inline comments as done. zequanwu added a comment. Refactor. Add a test for `namespace A __attribute__((availability(macos, introduced=10.15))) {`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121269: [clang-format] Fix namespace format when the name is followed by a macro

zequanwu added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:192 "}")); + EXPECT_EQ("#define M(x) x##x\n" +"namespace A M(x) {\n" zequanwu wrote: > curdeius wrote: > > MyDeveloperDay wrote: >

[PATCH] D121269: [clang-format] Fix namespace format when the name is followed by a macro

zequanwu updated this revision to Diff 414149. zequanwu marked an inline comment as done. zequanwu added a comment. Add a test for `namespace A B {`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121269/new/ https://reviews.llvm.org/D121269

[PATCH] D121269: [clang-format] Fix namepsace format when the name is after by a macro

zequanwu created this revision. zequanwu added reviewers: thakis, MyDeveloperDay, owenpan, klimek, sammccall. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Example: $ cat a.cpp namespace

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe5705767aad: [clang-format] fix namepsace format when the name is macro expansion (authored by zequanwu). Repository: rG LLVM Github Monorepo

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

zequanwu updated this revision to Diff 413139. zequanwu marked 2 inline comments as done. zequanwu added a comment. update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120931/new/ https://reviews.llvm.org/D120931 Files:

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

zequanwu added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:112 + EXPECT_EQ("#define M(x) x##x\n" +"namespace [[deprecated(\"foo\")]] A::inline M(x)::A {\n" +"int i;\n" MyDeveloperDay wrote: >

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

zequanwu added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:112 + EXPECT_EQ("#define M(x) x##x\n" +"namespace [[deprecated(\"foo\")]] A::inline M(x)::A {\n" +"int i;\n" MyDeveloperDay wrote: > Is

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

zequanwu updated this revision to Diff 413109. zequanwu marked 4 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120931/new/ https://reviews.llvm.org/D120931 Files:

[PATCH] D120931: [clang-format] fix namepsace format when the name is macro expansion

zequanwu added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:86 +"int j;\n" +"}// namespace A::M", +fixNamespaceEndComments("#define M(x) x##x\n" MyDeveloperDay wrote: > same here its

[PATCH] D120931: [clang-format] fix namepsace format when the name is macro expansion

zequanwu updated this revision to Diff 412856. zequanwu marked 2 inline comments as done. zequanwu added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120931/new/ https://reviews.llvm.org/D120931 Files:

[PATCH] D120931: [clang-format] fix namepsace format when the name is macro expansion

zequanwu created this revision. zequanwu added reviewers: klimek, sammccall. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Originally filed at crbug.com/1184570. When the name of a namespace is a

[PATCH] D111273: [clang-format-diff] Fix missing formatting for zero length git diff lines

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf93169226a29: [clang-format-diff] Fix missing formatting for zero length git diff lines (authored by zequanwu). Repository: rG LLVM Github

[PATCH] D111273: [clang-format-diff] Fix missing formatting for zero length git diff lines

zequanwu updated this revision to Diff 378291. zequanwu added a comment. Fix the same error in git-clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111273/new/ https://reviews.llvm.org/D111273 Files:

[PATCH] D111273: [clang-format-diff] Fix missing formatting for zero length git diff lines

zequanwu added a comment. In D111273#3047759 , @hans wrote: > Are there no tests for clang-format-diff.py? That seems unfortunate. No test for clang-format-diff.py. > Will this handle more nested cases, for example if the first line here is > deleted,

[PATCH] D111273: [clang-format-diff] Fix missing formatting for zero length git diff lines

zequanwu created this revision. zequanwu added reviewers: rnk, phosek. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If we only delete lines that are outer block statements (if, while, etc), clang-format-diff.py can't format the

[PATCH] D110780: [clang] do not emit note for bad conversion when destination type qualifiers don't compatibly include source type qualifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbaa40833693: [clang] do not emit note for bad conversion when destination type qualifiers… (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110780: [clang] do not emit note for bad conversion when destination type qualifiers don't compatibly include source type qualifiers

zequanwu updated this revision to Diff 376299. zequanwu added a comment. Add a testcase that from and to type are differ and qualification are incompatible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110780/new/

[PATCH] D85390: [Clang] Add note for bad conversion error when expression is of forward-declared type

zequanwu added a comment. In D85390#3031104 , @rsmith wrote: > Please see llvm.org/PR52014 -- this patch is not properly handling > cv-qualifiers. We should not produce the new note if the destination type has > qualifiers that the source type does not

[PATCH] D110780: [clang] do not emit note for bad conversion when destination type qualifiers are not compatibly include source type qualifiers

zequanwu created this revision. zequanwu added reviewers: rsmith, hans. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. llvm.org/PR52014 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110780 Files:

[PATCH] D104871: [Docs] use -fprofile-generate for IR PGO and -fprofile-instr-generate for code coverage

zequanwu updated this revision to Diff 355718. zequanwu marked 4 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104871/new/ https://reviews.llvm.org/D104871 Files:

[PATCH] D104871: [Docs] use -fprofile-generate for IR PGO and -fprofile-instr-generate for code coverage

zequanwu updated this revision to Diff 354615. zequanwu marked an inline comment as done. zequanwu added a comment. Update wording. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104871/new/ https://reviews.llvm.org/D104871 Files:

[PATCH] D104871: [Docs] use -fprofile-generate for IR PGO and -fprofile-instr-generate for code coverage

zequanwu created this revision. zequanwu added reviewers: rnk, vsk, davidxl, arphaman. Herald added a subscriber: wenlei. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add docs to specify `-fprofile-generate` for IR PGO and

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

zequanwu added a comment. Hi, this caused compiler crash: "Assertion `materialized_use_empty() && "Uses remain when a value is destroyed!"'" on chromium build https://ci.chromium.org/ui/p/chromium/builders/try/linux-official/151/overview. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

zequanwu added a comment. In D104082#2835496 , @fhahn wrote: > In D104082#2835080 , @zequanwu > wrote: > >> Hi, this caused compiler crash with error "Assertion >> `cast(Scope)->describes(>getFunction())'

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

zequanwu added a comment. Hi, this caused compiler crash on error "!dbg attachment points at wrong subprogram for function". So, I reverted it. I'm working on a reduced repro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104082/new/

[PATCH] D103293: [clang-cl] Bump default -fms-compatibility-version to 19.14

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59b8afe50274: [clang-cl] Bump default -fms-compatibility-version to 19.14 (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D103293: [clang-cl] Bump default -fms-compatibility-version to 19.14

zequanwu updated this revision to Diff 348438. zequanwu added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103293/new/ https://reviews.llvm.org/D103293 Files: clang/docs/ReleaseNotes.rst

[PATCH] D103293: [clang-cl] Bump default -fms-compatibility-version to 19.14

zequanwu created this revision. zequanwu added reviewers: mstorsjo, rnk. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MSVC required version is 19.14 now (https://reviews.llvm.org/D92515). Update the default

[PATCH] D98295: [Clang] Add addrsig attribute to mark global functions/variables as address significant.

zequanwu abandoned this revision. zequanwu added a comment. This overlaps with the functionality of attribute `used`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98295/new/ https://reviews.llvm.org/D98295

[PATCH] D98887: [clang-cl] make -ffile-compilation-dir a CoreOption.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c740b29fae3: [clang-cl] make -ffile-compilation-dir a CoreOption. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D98887: [clang-cl] make -ffile-compilation-dir a CoreOption.

zequanwu created this revision. zequanwu added reviewers: thakis, phosek. Herald added subscribers: jansvoboda11, dang. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Let clang-cl accepts `-ffile-compilation-dir` flag.

[PATCH] D98295: [Clang] Add addrsig attribute to mark global functions/variables as address significant.

zequanwu updated this revision to Diff 330099. zequanwu added a comment. Split clang change and IR change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98295/new/ https://reviews.llvm.org/D98295 Files: clang/include/clang/Basic/Attr.td

[PATCH] D98295: [Clang] Add addrsig attribute to mark global functions/variables as address significant.

zequanwu created this revision. zequanwu added reviewers: pcc, aaron.ballman, rnk, rsmith. Herald added subscribers: dexonsmith, jdoerfert, hiraditya. zequanwu requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Functions or

[PATCH] D97101: [Coverage] Emit gap region between statements if first statements contains terminate statements.

zequanwu added a comment. In D97101#2603321 , @thakis wrote: > This broke ContinuousSyncMode/basic.c in check-profile on macOS (see e.g. end > of >

[PATCH] D97101: [Coverage] Emit gap region between statements if first statements contains terminate statements.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d7374a0c680: [Coverage] Emit gap region between statements if first statements contains… (authored by zequanwu). Repository: rG LLVM Github

[PATCH] D97101: [Coverage] Emit gap region between statements if first statements contains terminate statements.

zequanwu added a comment. Thanks for reviewing. Comment at: clang/test/CoverageMapping/switch.cpp:62 default: // CHECK-NEXT: File 0, [[@LINE]]:3 -> [[@LINE+1]]:10 = #4 break; // CHECK-NEXT: Branch,File 0, [[@LINE-1]]:3 -> [[@LINE-1]]:10 = #4, (#0 -

[PATCH] D97101: [Coverage] Emit gap region between statements if first statements contains terminate statements.

zequanwu updated this revision to Diff 327859. zequanwu added a comment. use itanium abi in terminate-statements.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97101/new/ https://reviews.llvm.org/D97101 Files:

[PATCH] D97101: [Coverage] Emit zero count gap region between statements if first statements contains return, throw, goto, co_return

zequanwu added inline comments. Comment at: clang/test/CoverageMapping/deferred-region.cpp:43 if (true) -return; // CHECK: Gap,File 0, [[@LINE]]:11 +return; else vsk wrote: > I'm confused by this change. Do we lose the gap here? I assumed it was

[PATCH] D97101: [Coverage] Emit zero count gap region between statements if first statements contains return, throw, goto, co_return

zequanwu updated this revision to Diff 327661. zequanwu marked an inline comment as done. zequanwu added a comment. - Deprecate deferred region. Use the notion of gap region inserted in VisitStmt to replace deferred region. - Emit gap region with OutCounter from last statement if exists. - Move

[PATCH] D97101: [Coverage] Emit zero count gap region between statements if first statements contains return, throw, goto, co_return

zequanwu added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:942 pushRegion(Counter::getZero()); -auto = getRegion(); -ZeroRegion.setDeferred(true); -LastTerminatedRegion = {EndLoc, RegionStack.size()}; +if (!HasTerminateStmt) { +

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. zequanwu marked an inline comment as done. Closed by commit rG4500f0a7321d: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual… (authored by

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

zequanwu updated this revision to Diff 326484. zequanwu added a comment. Adopt Quuxplusone's phrasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96832/new/ https://reviews.llvm.org/D96832 Files: clang/include/clang/Basic/AttrDocs.td

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

zequanwu updated this revision to Diff 326222. zequanwu marked 2 inline comments as done. zequanwu added a comment. Add a doc example and CodeGen testcase about `not_tail_called` being applied to method override in a derived class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D97101: [Coverage] Emit zero count gap region between statements if first statements contains return, throw, goto, co_return

zequanwu added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:593 MostRecentLocation = *StartLoc; - completeDeferred(Count, MostRecentLocation); } vsk wrote: > Does this mean a deferred gap region following a `break;`

[PATCH] D97101: [Coverage] Emit zero count gap region between statements if first statements contains return, throw, goto, co_return

zequanwu updated this revision to Diff 325947. zequanwu marked an inline comment as done. zequanwu added a comment. - Revert the deletion of completeDeferred in pushRegion. - Emit zero gap region only if OutCounter is different from parentCounter in whil, for statements. - Update test cases.

[PATCH] D97098: [Utils] Add an option to specify number of cores to use in creduce-clang-crash.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGb380699416d8: [Utils] Add an option to specify number of cores to use in creduce-clang-crash. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97098: [Utils] Add an option to specify number of cores to use in creduce-clang-crash.py

zequanwu updated this revision to Diff 325520. zequanwu added a comment. Address comment, using `max(4, multiprocessing.cpu_count() / 2)` because `os.cpu_count` is not available in python2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97098/new/

[PATCH] D97101: [Coverage] Emit zero count gap region between statements if first statements contains return, throw, goto, co_return

zequanwu updated this revision to Diff 325516. zequanwu added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Rebase and fix runtime-counter-relocation.c > Do we have to revert D85036 in the same > patch in order to keep

[PATCH] D97101: [Coverage] Emit zero count gap region between statements if first statements contains return, throw, goto, co_return

zequanwu created this revision. zequanwu added reviewers: vsk, efriedma, rnk, pirama. Herald added a subscriber: lxfind. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This solves the problems that D85036

[PATCH] D97098: [Utils] Add an option to specify number of cores to use in creduce-clang-crash.py

zequanwu created this revision. zequanwu added reviewers: akhuang, thakis, rnk. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97098 Files:

[PATCH] D85176: [Coverage] Emit gap region after conditions when macro is present.

zequanwu added a comment. In D85176#2572661 , @saugustine wrote: > This commit introduced an unused variable warning when built without asserts. > (CoverageMappingGen.cpp:984) I have fixed it with rG4544a63b7705 >

[PATCH] D85176: [Coverage] Emit gap region after conditions when macro is present.

zequanwu added a comment. Landed at https://github.com/llvm/llvm-project/commit/d83511dd26ca8d0dd5be6302ad7b55de05cedab2 (forgot to add the differential revision line). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85176/new/

[PATCH] D85176: [Coverage] Emit gap region after conditions when macro is present.

zequanwu added inline comments. Comment at: clang/test/CoverageMapping/if.cpp:10 +void foo() {// CHECK-NEXT: Gap,File 0, [[@LINE+1]]:21 -> [[@LINE+1]]:22 = #2 if (int j = true ? nop() // CHECK-NEXT: [[@LINE]]:22 -> [[@LINE]]:27 = #2

[PATCH] D85176: [Coverage] Emit gap region after conditions when macro is present.

zequanwu updated this revision to Diff 324710. zequanwu marked 2 inline comments as done. zequanwu added a comment. - Added regression test. - Assert `getIncludeOrExpansionLoc(AfterLoc)` is valid. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85176: [Coverage] Enable emitting gap area between macros

zequanwu updated this revision to Diff 324695. zequanwu added a comment. Tested on clange stage2 build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85176/new/ https://reviews.llvm.org/D85176 Files: clang/lib/CodeGen/CoverageMappingGen.cpp

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

zequanwu added a comment. In D96832#2569987 , @ahatanak wrote: > In D96832#2569481 , @zequanwu wrote: > >> In D96832#2568257 , @aaron.ballman >> wrote: >> >>> It was

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

zequanwu added a comment. In D96832#2568257 , @aaron.ballman wrote: > It was explicitly disallowed in the initial patch: > https://reviews.llvm.org/D12922 and the original author said "I'm still > trying to figure out the best way to handle c++ virtual

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

zequanwu created this revision. zequanwu added reviewers: ahatanak, aaron.ballman, rnk. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It would be beneficial to allow not_tail_called attribute to be applied to virtual functions.

[PATCH] D96092: [AST] Update LVal before evaluating lambda decl fields.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96fb49c3ff8e: [AST] Update LVal before evaluating lambda decl fields. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D96092: [AST] Update LVal before evaluating lambda decl fields.

zequanwu added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:10032-10033 + +// FIXME: Diagnostics here should point to the end of the initializer +// list, not the start. +if (!HandleLValueMember(Info, E, Subobject, Field, )) rsmith

[PATCH] D96092: [AST] Update LVal before evaluating lambda decl fields.

zequanwu updated this revision to Diff 321617. zequanwu marked an inline comment as done. zequanwu added a comment. Remove comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96092/new/ https://reviews.llvm.org/D96092 Files:

[PATCH] D96092: [AST] Update LVal before evaluating lambda decl fields.

zequanwu created this revision. zequanwu added reviewers: rsmith, rnk. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. PR48582 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96092 Files:

[PATCH] D95918: [Coverage] Propogate counter to condition of conditional operator

zequanwu added a comment. In D95918#2540367 , @vsk wrote: > How was the issue spotted? If there was a crash or an incorrect coverage bug > that's not triggered by one of the existing frontend tests, it'd be worth > adding a regression test. If the

[PATCH] D95918: [Coverage] Propogate counter to condition of conditional operator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4dc08cc3aa41: [Coverage] Propogate counter to condition of conditional operator (authored by zequanwu). Repository: rG LLVM Github Monorepo

[PATCH] D95918: [Coverage] Propogate counter to condition of conditional operator

zequanwu added a comment. I tested it locally. They are all passed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95918/new/ https://reviews.llvm.org/D95918 ___ cfe-commits mailing list

[PATCH] D95918: [Coverage] Propogate counter to condition of conditional operator

zequanwu created this revision. zequanwu added reviewers: vsk, rnk. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang usually propagates counter mapping region for conditions of `if`, `while`, `for`, etc from parent counter.

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

zequanwu added a comment. In D91913#2520414 , @hvdijk wrote: > In D91913#2520399 , @zequanwu wrote: > >> This change also breaks many chrome ToT bots(not just windows bot), example >> build: >>

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

zequanwu added a comment. This change also breaks many chrome ToT bots(not just windows bot), example build: https://ci.chromium.org/ui/p/chrome/builders/ci/ToTLinuxOfficial/10524/steps?succeeded=true=false Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4fffbc150cca: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization. (authored by zequanwu). Repository: rG LLVM Github Monorepo

[PATCH] D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization.

zequanwu updated this revision to Diff 316695. zequanwu marked an inline comment as done. zequanwu added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94646/new/ https://reviews.llvm.org/D94646 Files:

[PATCH] D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization.

zequanwu added inline comments. Comment at: clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp:151-159 +namespace pr48687 { +template struct A { + T value; + static constexpr auto address = ::value; +}; +extern template class A; +template class A;

[PATCH] D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization.

zequanwu updated this revision to Diff 316694. zequanwu added a comment. Update test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94646/new/ https://reviews.llvm.org/D94646 Files: clang/lib/Sema/SemaTemplate.cpp

[PATCH] D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization.

zequanwu added inline comments. Comment at: clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp:151-159 +namespace pr48687 { +template struct A { + T value; + static constexpr auto address = ::value; +}; +extern template class A; +template class A; I

[PATCH] D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization.

zequanwu created this revision. zequanwu added a reviewer: rnk. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix PR48687. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94646 Files:

[PATCH] D94537: [IR] move nomerge attribute from function declaration/definition to callsites

This revision was automatically updated to reflect the committed changes. zequanwu marked an inline comment as done. Closed by commit rGe53bbd99516f: [IR] move nomerge attribute from function declaration/definition to callsites (authored by zequanwu). Changed prior to commit:

[PATCH] D94537: [IR] move nomerge attribute from function declaration/definition to callsites

zequanwu created this revision. zequanwu added reviewers: aaron.ballman, rnk. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Move nomerge attribute from function declaration/definition to callsites to allow virtual function calls

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb0f7288051e: [Clang] Make nomerge attribute a function attribute as well as a statement… (authored by zequanwu). Repository: rG LLVM Github

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

zequanwu added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:3438-3439 } + if (DeclOrStmt) +DiagList.push_back("statements"); } aaron.ballman wrote: > I think this will do the wrong thing when the subject list

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

zequanwu updated this revision to Diff 312348. zequanwu marked 2 inline comments as done. zequanwu added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92800/new/ https://reviews.llvm.org/D92800 Files:

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

zequanwu added inline comments. Comment at: clang/test/CodeGen/attr-nomerge.cpp:73 +// CHECK-DAG: attributes #[[ATTR2]] = {{{.*}}nomerge{{.*}}} +// CHECK-DAG: attributes #[[ATTR3]] = {{{.*}}nomerge{{.*}}} aaron.ballman wrote: > Can you also add a test case to

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

zequanwu updated this revision to Diff 312078. zequanwu marked 4 inline comments as done. zequanwu added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92800/new/ https://reviews.llvm.org/D92800 Files:

<    1   2   3   4   5   >