[PATCH] D45405: [clang-tidy] [modernize-use-auto] Add a threshold for minimal type name length to be replaced with 'auto'

zinovy.nis created this revision. zinovy.nis added reviewers: angelgarcia, malcolm.parsons, alexfh. zinovy.nis added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. The threshold option is 'MinTypeNameLength' with default value '0' which means 'replace any lengths'

[PATCH] D44295: [clang-tidy] Detect and fix calls to grand-...parent virtual methods instead of calls to parent's virtual methods

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE329448: [clang-tidy] Check if grand-..parent's virtual method was called instead of… (authored by zinovy.nis, committed by ). Changed prior to commit: https://reviews.llvm.org/D44295?vs=141199&id=1414

[PATCH] D44295: [clang-tidy] Detect and fix calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis added a comment. Alexander, thanks for your patience and comments :-) https://reviews.llvm.org/D44295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 141199. zinovy.nis added a comment. - Switched to use 'tooling::fixit::getText' for qualified names. - Shortened test code with {{.*}}. https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.t

[PATCH] D44906: [clang-tidy] Define __clang_analyzer__ macro for clang-tidy for compatibility with clang static analyzer

zinovy.nis added a subscriber: george.karpenkov. zinovy.nis added a comment. Looks like quotes are required. Thanks for pointing! I'll submit a patch for this. пн, 2 апр. 2018 г. в 17:28, Nico Weber via Phabricator < revi...@reviews.llvm.org>: > thakis added a comment. > > Actually, it doesn't

[PATCH] D45160: [clang-apply-replacements] Make clang-apply-replacements installable

zinovy.nis created this revision. Herald added subscribers: cfe-commits, mgorny. Add a new target for install: **install-clang-apply-replacements** So if you need clang-tidy and clang-apply-replacements tools only, you may build and install only these tools: make install-clang-tidy install-cla

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 140579. zinovy.nis added a comment. - Minor cosmetic fix: use lexical representation instead of semanic for printing callee string. It helps to print class names hidden behind 'typedef' and 'using': using A1 = A; typedef A A2; class C2 : publi

[PATCH] D44906: [clang-tidy] Define __clang_analyzer__ macro for clang-tidy for compatibility with clang static analyzer

This revision was automatically updated to reflect the committed changes. Closed by commit rL328932: [clang-tidy] Define __clang_analyzer__ macro for clang-tidy for compatibility… (authored by zinovy.nis, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit: h

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis added a comment. BTW, I've recently found few dozens of issues in the Chromium code with my check. For ex.: browser/src/cc/layers/nine_patch_layer_impl.cc:89:51: warning: qualified name 'cc::LayerImpl::LayerAsJson' refers to a member overridden in subclass; did you mean 'cc::UIRes

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 140475. zinovy.nis marked 3 inline comments as done. zinovy.nis added a comment. - Cosmetic fixes. https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtua

[PATCH] D44906: [clang-tidy] Define __clang_analyzer__ macro for clang-tidy for compatibility with clang static analyzer

zinovy.nis added inline comments. Comment at: clang-tidy/ClangTidy.cpp:490 +CommandLineArguments AdjustedArgs = Args; +AdjustedArgs.emplace_back("-D__clang_analyzer__"); +return AdjustedArgs; alexfh wrote: > I wonder whether we should inst

[PATCH] D44906: [clang-tidy] Define __clang_analyzer__ macro for clang-tidy for compatibility with clang static analyzer

zinovy.nis created this revision. zinovy.nis added a project: clang-tools-extra. Herald added subscribers: cfe-commits, a.sidorin, xazax.hun. Herald added a reviewer: george.karpenkov. This macro is widely used in many well-known projects, ex. Chromium

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 139834. zinovy.nis added a comment. - Updated warning message to > warning: qualified name 'A::foo' refers to a member overridden in subclass; > did you mean 'B'? [bugprone-parent-virtual-call] https://reviews.llvm.org/D44295 Files: clang-tidy/bu

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 139805. zinovy.nis retitled this revision from "[clang-tidy] Detect and fix calls to grand-...parent virtual methods instead of calls to parent's virtual methods" to "[clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 139646. zinovy.nis added a comment. - Rebased. - Added 1 more test for namespaced base clases - Fixed minor issues. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bug

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis marked 9 inline comments as done. zinovy.nis added inline comments. Comment at: docs/clang-tidy/checks/bugprone-parent-virtual-call.rst:6 + +Detects and fixes calls to grand-...parent virtual methods instead of calls +to parent's virtual methods. aaron

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 139499. zinovy.nis marked an inline comment as done. zinovy.nis added a comment. camelCase last minute fix. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CM

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 139496. zinovy.nis added a comment. Aaron, I applied the changes you suggest. I also found and fixed a new case when grandparent method is called via 'typedef'ed or 'using' type. There's also a new test (class C2) for it. Repository: rCTE Clang Tools

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis added a comment. Gentle ping) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis marked 2 inline comments as done. zinovy.nis added a comment. Hope I satisfied all your requests now. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis marked 6 inline comments as done. zinovy.nis added inline comments. Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:128 + diag(Member->getQualifierLoc().getSourceRange().getBegin(), + "'%0' is a grand-parent's method, not parent's. Did you mea

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis marked 5 inline comments as done. zinovy.nis added inline comments. Comment at: test/clang-tidy/bugprone-parent-virtual-call.cpp:113 + int virt_1() override { return A::virt_1(); } + // CHECK-MESSAGES: :[[@LINE-1]]:34: warning: qualified function name A::virt_1 refe

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 138858. zinovy.nis edited the summary of this revision. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCh

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis added inline comments. Comment at: test/clang-tidy/bugprone-parent-virtual-call.cpp:113 + int virt_1() override { return A::virt_1(); } + // CHECK-MESSAGES: :[[@LINE-1]]:34: warning: qualified function name A::virt_1 refers to a function not from a direct base class

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis added inline comments. Comment at: test/clang-tidy/bugprone-parent-virtual-call.cpp:105 + +// Test virtual method is diagnosted although not overridden in parent. +class BI : public A { aaron.ballman wrote: > Typo: diagnosted -> diagnosed oops, thanks.

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 138601. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCheck.cpp clang-tidy/bugprone/ParentVirtualCallC

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis added inline comments. Comment at: test/clang-tidy/bugprone-parent-virtual-call.cpp:127 +// Just to instantiate DF. +int bar() { return (new DF())->virt_1(); } aaron.ballman wrote: > What should happen in this case? > ``` > struct Base { > virtual vo

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 138599. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCheck.cpp clang-tidy/bugprone/ParentVirtualCallC

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 138598. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCheck.cpp clang-tidy/bugprone/ParentVirtualCallC

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis added inline comments. Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:128 + diag(Member->getQualifierLoc().getSourceRange().getBegin(), + "'%0' is a grand-parent's method, not parent's. Did you mean %1?") + << CalleeName << ParentsStr; -

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 138597. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCheck.cpp clang-tidy/bugprone/ParentVirtualCallC

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 138596. zinovy.nis marked 10 inline comments as done. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallChec

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis marked an inline comment as done and an inline comment as not done. zinovy.nis added inline comments. Comment at: test/clang-tidy/bugprone-parent-virtual-call.cpp:115 + int virt_1() override { return A::virt_1(); } + // CHECK-MESSAGES: :[[@LINE-1]]:34: warning: 'A::v

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 138254. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCheck.cpp clang-tidy/bugprone/ParentVirtualCallC

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 137953. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCheck.cpp clang-tidy/bugprone/ParentVirtualCallC

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 137952. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCheck.cpp clang-tidy/bugprone/ParentVirtualCallC

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 137951. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCheck.cpp clang-tidy/bugprone/ParentVirtualCallC

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis marked an inline comment as done. zinovy.nis added inline comments. Comment at: test/clang-tidy/bugprone-parent-virtual-call.cpp:125 + // CHECK-MESSAGES: :[[@LINE-1]]:34: warning: 'A::virt_1' is a grand-parent's method, not parent's. Did you mean 'BF'? + // CHECK-FI

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 137911. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCheck.cpp clang-tidy/bugprone/ParentVirtualCallC

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 137787. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCheck.cpp clang-tidy/bugprone/ParentVirtualCallC

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis added inline comments. Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:152 +Member->getQualifierLoc().getSourceRange(), +GetNameAsString(*(Parents.front())) + "::"); + } malcolm.parsons wrote: > What does this do for templat

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 137781. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCheck.cpp clang-tidy/bugprone/ParentVirtualCallC

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 137783. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCheck.cpp clang-tidy/bugprone/ParentVirtualCallC

[PATCH] D44295: Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis created this revision. zinovy.nis added reviewers: klimek, alexfh. zinovy.nis added a project: clang-tools-extra. Herald added a subscriber: mgorny. Warns if one calls grand-..parent's virtual method in child's virtual method instead of parent's. Can automatically fix such cases by ret

<    1   2   3