This revision was automatically updated to reflect the committed changes.
Closed by commit rL321487: [x86][icelake][vbmi2] (authored by coby, committed
by ).
Changed prior to commit:
https://reviews.llvm.org/D41557?vs=128172=128221#toc
Repository:
rL LLVM
https://reviews.llvm.org/D41557
This revision was automatically updated to reflect the committed changes.
Closed by commit rL321484: [x86][icelake][vnni] (authored by coby, committed by
).
Changed prior to commit:
https://reviews.llvm.org/D41558?vs=128099=128216#toc
Repository:
rL LLVM
https://reviews.llvm.org/D41558
This revision was automatically updated to reflect the committed changes.
Closed by commit rL321483: [x86][icelake][bitalg] (authored by coby, committed
by ).
Changed prior to commit:
https://reviews.llvm.org/D41564?vs=128109=128213#toc
Repository:
rL LLVM
https://reviews.llvm.org/D41564
This revision was automatically updated to reflect the committed changes.
Closed by commit rL321480: [x86][icelake][vpclmulqdq] (authored by coby,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41573?vs=128183=128210#toc
Repository:
rL LLVM
coby closed this revision.
coby added a comment.
closed by commit https://reviews.llvm.org/rC321474
(https://reviews.llvm.org/rL321474)
Repository:
rC Clang
https://reviews.llvm.org/D41583
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rC321477: [x86][icelake][gfni] (authored by coby, committed by
).
Changed prior to commit:
https://reviews.llvm.org/D41582?vs=128168=128207#toc
Repository:
rC Clang
https://reviews.llvm.org/D41582
coby updated this revision to Diff 128185.
coby added a comment.
turning aes off forbids enabling vaes
Repository:
rC Clang
https://reviews.llvm.org/D41583
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
coby updated this revision to Diff 128183.
coby added a comment.
turning off pclmul forbids enabling vpclmulqdq
Repository:
rC Clang
https://reviews.llvm.org/D41573
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
coby added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:577
} else if (Name == "pclmul") {
if (Enabled)
setSSELevel(Features, SSE2, Enabled);
craig.topper wrote:
> I think we should disable vpclmulqdq when pclmul is being disabled.
coby added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:573
setMMXLevel(Features, AMD3DNowAthlon, Enabled);
} else if (Name == "aes") {
if (Enabled)
craig.topper wrote:
> Shouldn't -aes imply -vaes?
how come? perhaps i'm missing here
coby updated this revision to Diff 128172.
coby added a comment.
tests
Repository:
rC Clang
https://reviews.llvm.org/D41557
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
lib/Headers/CMakeLists.txt
coby updated this revision to Diff 128171.
coby added a comment.
addressed comments
Repository:
rC Clang
https://reviews.llvm.org/D41557
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
coby marked 2 inline comments as done.
coby added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:589
+// Enable BWI instruction if VBMI/VBMI2 is being enabled.
+if (Name.startswith("avx512vbmi") && Enabled)
Features["avx512bw"] = true;
coby created this revision.
coby added a reviewer: craig.topper.
Herald added a subscriber: mgorny.
added intrinsics support for vaes instructions, matching a similar work on the
backend (https://reviews.llvm.org/D40078)
Repository:
rC Clang
https://reviews.llvm.org/D41583
Files:
coby updated this revision to Diff 128168.
coby added a comment.
add forgotten undef[s]
Repository:
rC Clang
https://reviews.llvm.org/D41582
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
coby created this revision.
coby added a reviewer: craig.topper.
Herald added a subscriber: mgorny.
added intrinsics support for gfni instructions, matching a similar work on the
backend (https://reviews.llvm.org/D40373)
Repository:
rC Clang
https://reviews.llvm.org/D41582
Files:
coby updated this revision to Diff 128139.
coby added a comment.
removing guards to allow better diags
Repository:
rC Clang
https://reviews.llvm.org/D41573
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
coby created this revision.
coby added a reviewer: craig.topper.
Herald added a subscriber: mgorny.
added intrinsics support for vpclmulqdq instructions, matching a similar work
on the backend (https://reviews.llvm.org/D40101)
Repository:
rC Clang
https://reviews.llvm.org/D41573
Files:
coby created this revision.
coby added a reviewer: craig.topper.
Herald added a subscriber: mgorny.
added intrinsics support for bitalg instructions, matching a similar work on
the backend (https://reviews.llvm.org/D40222)
Repository:
rC Clang
https://reviews.llvm.org/D41564
Files:
coby created this revision.
coby added a reviewer: craig.topper.
Herald added a subscriber: mgorny.
added intrinsics support for VNNI instructions, matching a similar work on the
backend (https://reviews.llvm.org/D40208)
Repository:
rC Clang
https://reviews.llvm.org/D41558
Files:
coby created this revision.
Herald added subscribers: cfe-commits, mgorny.
added intrinsics support for (while of) vbmi2 instructions, matching a similar
work on the backend
Repository:
rC Clang
https://reviews.llvm.org/D41557
Files:
include/clang/Basic/BuiltinsX86.def
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318739: [x86][inline-asm] allow recognition of MPX regs
inside ms inline-asm blob (authored by coby).
Changed prior to commit:
https://reviews.llvm.org/D38445?vs=117278=123730#toc
Repository:
rL
coby added a comment.
Reid,
can you please have a look?
Repository:
rL LLVM
https://reviews.llvm.org/D38445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
coby added inline comments.
Comment at: test/CodeGen/ms-inline-asm.cpp:37-38
- int lvar = 10;
- __asm mov eax, offset Foo::ptr
- __asm mov eax, offset Foo::Bar::ptr
-// CHECK-LABEL: define void @_Z2t2v()
rnk wrote:
> These don't seem tested anywhere now
I've
coby created this revision.
Herald added a subscriber: eraman.
Repository:
rL LLVM
https://reviews.llvm.org/D38445
Files:
lib/Basic/Targets/X86.cpp
test/CodeGen/ms-inline-asm.c
Index: lib/Basic/Targets/X86.cpp
===
---
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314494: [X86][MS-InlineAsm] Extended support for variables /
identifiers on memory /… (authored by coby).
Changed prior to commit:
https://reviews.llvm.org/D37413?vs=115564=117095#toc
Repository:
rL
coby updated this revision to Diff 115564.
coby added a comment.
addressed @rnk 's suggestions:
cuteness out
c++ mischief in
Repository:
rL LLVM
https://reviews.llvm.org/D37413
Files:
include/clang/Parse/Parser.h
include/clang/Sema/Sema.h
lib/Parse/ParseStmtAsm.cpp
coby added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D37466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
coby added inline comments.
Comment at: lib/Sema/SemaStmtAsm.cpp:617
+return;
+ } else if (Res->isRValue()) {
+bool Enum = isa(T) && Res->EvaluateAsRValue(Eval,
Context);
rnk wrote:
> RKSimon wrote:
> > (style) Split these instead of an if-elseif chain
coby updated this revision to Diff 114536.
coby added reviewers: myatsina, m_zuckerman.
Repository:
rL LLVM
https://reviews.llvm.org/D37413
Files:
include/clang/Parse/Parser.h
include/clang/Sema/Sema.h
lib/Parse/ParseStmtAsm.cpp
lib/Sema/SemaStmtAsm.cpp
coby updated this revision to Diff 114520.
coby added a comment.
Herald added a subscriber: eraman.
addressed Simon's comments
Repository:
rL LLVM
https://reviews.llvm.org/D37413
Files:
include/clang/Parse/Parser.h
include/clang/Sema/Sema.h
lib/Parse/ParseStmtAsm.cpp
coby added a comment.
might be a bit unrelated - but do we've got a hint regarding why is this even
an issue?
by all means - it doesn't seems right for an empty ms inline-asm statement to
affect successful compilation, without even mentioning the involvement of the
encapsulating function's
coby created this revision.
Herald added a subscriber: eraman.
Repository:
rL LLVM
https://reviews.llvm.org/D37466
Files:
test/CodeGen/ms-inline-asm-64.c
test/CodeGen/ms-inline-asm-offset-err.cpp
test/CodeGen/ms-inline-asm-offset.c
test/CodeGen/ms-inline-asm.c
coby abandoned this revision.
coby added a comment.
superseded by https://reviews.llvm.org/D37412
Repository:
rL LLVM
https://reviews.llvm.org/D35775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
coby updated this revision to Diff 113659.
Repository:
rL LLVM
https://reviews.llvm.org/D37413
Files:
include/clang/Parse/Parser.h
include/clang/Sema/Sema.h
lib/Parse/ParseStmtAsm.cpp
lib/Sema/SemaStmtAsm.cpp
Index: lib/Parse/ParseStmtAsm.cpp
coby created this revision.
Allow the proper recognition of Enum values and global variables inside ms
inline-asm memory / immediate expressions, as they require some additional
overhead and treated incorrect if doesn't early recognized.
supersedes https://reviews.llvm.org/D33277,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311643: [Clang][x86][Inline Asm] support for GCC style
inline asm - Y constraints (authored by coby).
Changed prior to commit:
https://reviews.llvm.org/D36371?vs=111885=112521#toc
Repository:
rL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311640: Fixups to FE tests affected by D36793 (authored by
coby).
Changed prior to commit:
https://reviews.llvm.org/D36794?vs=111340=112518#toc
Repository:
rL LLVM
https://reviews.llvm.org/D36794
coby updated this revision to Diff 111885.
coby added a comment.
Herald added a subscriber: eraman.
> @rnk: tests?
Add forgotten test.
Repository:
rL LLVM
https://reviews.llvm.org/D36371
Files:
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
lib/CodeGen/TargetInfo.cpp
coby created this revision.
Herald added a subscriber: eraman.
Repository:
rL LLVM
https://reviews.llvm.org/D36794
Files:
test/CodeGen/mozilla-ms-inline-asm.c
test/CodeGen/ms-inline-asm-64.c
test/CodeGen/ms-inline-asm.c
test/CodeGen/ms-inline-asm.cpp
coby abandoned this revision.
coby added a comment.
superseded by https://reviews.llvm.org/D36371
Repository:
rL LLVM
https://reviews.llvm.org/D35205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310529: [X86][Asm] Allow negative immediate to appear before
bracketed expression (authored by coby).
Changed prior to commit:
https://reviews.llvm.org/D36230?vs=109374=110485#toc
Repository:
rL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310472: [X86][Ms-InlineAsm] Extend MS Dot operator to accept
"this" + struct/class… (authored by coby).
Changed prior to commit:
https://reviews.llvm.org/D36450?vs=110145=110377#toc
Repository:
rL
coby added inline comments.
Comment at: lib/Sema/SemaStmtAsm.cpp:702-705
+ // MS InlineAsm often uses struct pointer aliases as a base
+ const QualType QT = TD->getUnderlyingType();
+ RT = isa(QT) ? QT->getPointeeType()->getAs() :
+
coby created this revision.
Herald added a subscriber: eraman.
MS InlineAsm Dot operator accepts "Bases" such as "this" (cpp) and class/struct
pointer typedef.
This patch enhance its implementation with this behavior.
Repository:
rL LLVM
https://reviews.llvm.org/D36450
Files:
coby created this revision.
This patch is intended to enable the use of basic double letter constraints
used in GCC extended inline asm {Yi Y2 Yz Y0 Ym Yt}.
Supersedes https://reviews.llvm.org/D32505
llvm counterpart: https://reviews.llvm.org/D36369
Repository:
rL LLVM
coby created this revision.
Herald added a subscriber: eraman.
Currently, only non-negative immediate is allowed prior to a brac expression
(memory reference).
MASM / GAS does not have any problem cope with the left side of the real line,
so we should be able to as well.
llvm:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309672: [x86][inline-asm]Allow a pack of Control Debug to be
properly picked (authored by coby).
Changed prior to commit:
https://reviews.llvm.org/D36074?vs=108872=109073#toc
Repository:
rL LLVM
coby created this revision.
Herald added a subscriber: eraman.
Allows the incorporation of legit (x86) Debug Regs within inline asm stataements
Repository:
rL LLVM
https://reviews.llvm.org/D36074
Files:
lib/Basic/Targets/X86.cpp
test/CodeGen/ms-inline-asm.c
Index:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309508: [x86][inline-asm]Allow a pack of Control Regs to be
properly picked (authored by coby).
Changed prior to commit:
https://reviews.llvm.org/D35903?vs=108317=108825#toc
Repository:
rL LLVM
coby created this revision.
Herald added a subscriber: eraman.
Allows the incorporation of legit (x86) Control Regs within inline asm
stataements
Repository:
rL LLVM
https://reviews.llvm.org/D35903
Files:
lib/Basic/Targets/X86.cpp
test/CodeGen/ms-inline-asm.c
Index:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308867: [X86][InlineAsm][Ms Compatibility]Prefer variable
name over a register when the… (authored by coby).
Changed prior to commit:
https://reviews.llvm.org/D34740?vs=104352=107851#toc
Repository:
coby abandoned this revision.
coby added a comment.
superseded by https://reviews.llvm.org/rL302179
Repository:
rL LLVM
https://reviews.llvm.org/D26587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
coby created this revision.
Herald added a subscriber: eraman.
Extend support for expressions which represent a variable access in ms-style
inline-asm, to allow the incorporation of both registers and variables.
Currently, expression such as '//__asm mov eax, [var + eax]//' would have been
coby created this revision.
Herald added a subscriber: eraman.
On MS-style, the following snippet:
int eax;
__asm mov eax, ebx
should yield loading of ebx, into the location pointed by the variable eax
This patch sees to it.
Currently, a reg-to-reg move would have been invoked.
llvm:
coby added inline comments.
Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:1310
}
-
-bool X86AsmParser::ParseIntelExpression(IntelExprStateMachine , SMLoc )
{
+bool X86AsmParser::ParseIntelExpression(IntelExprStateMachine , SMLoc ,
+
coby abandoned this revision.
coby added a comment.
superseded by https://reviews.llvm.org/rL302179
Repository:
rL LLVM
https://reviews.llvm.org/D32638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
coby created this revision.
This is an extension of the work being carried by the following change:
https://reviews.llvm.org/D26586
This commit handles cases where the size qualifier of an indirect memory
reference operand in Intel syntax is missing (e.g. "vaddps xmm1, xmm2, [a]").
GCC will
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299454: [X86][inline-asm] Add support for MS 'EVEN'
directive (authored by coby).
Changed prior to commit:
https://reviews.llvm.org/D27418?vs=80280=94095#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298426: [X86][MS-compatability][clang] allow MS
TYPE/SIZE/LENGTH operators as a part of… (authored by coby).
Changed prior to commit:
https://reviews.llvm.org/D31174?vs=92437=92529#toc
Repository:
coby created this revision.
This patch introduces X86AsmParser with the ability to handle the
aforementioned ops within compound "MS" arithmetical expressions. Currently -
only supported as a stand alone Operand, e.g.:
"TYPE X"
now allowed :
"4 + TYPE X * 128"
LLVM side:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL294120: [X86][MS]Adjacent comments within multi-line inline
assembly statement (authored by coby).
Changed prior to commit:
https://reviews.llvm.org/D28989?vs=85276=87135#toc
Repository:
rL LLVM
coby added a comment.
Ping
Repository:
rL LLVM
https://reviews.llvm.org/D28989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
coby abandoned this revision.
coby added a comment.
deprecated
Repository:
rL LLVM
https://reviews.llvm.org/D25717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
64 matches
Mail list logo
