[PATCH] D108451: [Sema] Avoid crash in CheckEnumConstant with contains-error expressions

2021-08-24 Thread guopeilin via Phabricator via cfe-commits
guopeilin added a comment. Hi, @sammccall thanks for the patch. The precommit checks suggest that some test cases failing, could you please fix them. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108451/new/

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

2021-08-22 Thread guopeilin via Phabricator via cfe-commits
guopeilin added a comment. In D82657#2956851 , @sammccall wrote: > In D82657#2956751 , @guopeilin wrote: > >> Hi @hokein , I encounter a bug when clang parses enum and I have been >> recorded in

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

2021-08-20 Thread guopeilin via Phabricator via cfe-commits
guopeilin added a comment. Hi @hokein , I encounter a bug when clang parses enum and I have been recorded in https://bugs.llvm.org/show_bug.cgi?id=51554. The source code like the following: enum E { e = E() }; int main() { return 0; } Some error message are expected like the