[PATCH] D108421: Mark openmp internal global dso_local

kamleshbhalui added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108421/new/ https://reviews.llvm.org/D108421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108421: Mark openmp internal global dso_local

kamleshbhalui added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108421/new/ https://reviews.llvm.org/D108421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108421: Mark openmp internal global dso_local

kamleshbhalui updated this revision to Diff 370837. kamleshbhalui added a comment. mark dso_local only when non-pic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108421/new/ https://reviews.llvm.org/D108421 Files:

[PATCH] D108421: Mark openmp internal global dso_local

kamleshbhalui added a comment. In D108421#2958848 , @MaskRay wrote: > If you read the comment in TargetMachine::shouldAssumeDSOLocal: this is the > wrong direction. dso_local is assumed to be marked by the frontend. > > Direct accesses and GOT accesses

[PATCH] D108421: Mark openmp internal global dso_local

kamleshbhalui updated this revision to Diff 368261. kamleshbhalui added a comment. updated test and make changes local to auto generated global vars for lock. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108421/new/

[PATCH] D108421: Mark openmp internal global dso_local

kamleshbhalui added a comment. In D108421#2958745 , @lebedev.ri wrote: > In D108421#2958742 , @kamleshbhalui > wrote: > >> assume dso local if relocation model static > > I think these are two separate fixes.

[PATCH] D108421: Mark openmp internal global dso_local

kamleshbhalui updated this revision to Diff 367954. kamleshbhalui added a comment. assume dso local if relocation model static Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108421/new/ https://reviews.llvm.org/D108421 Files:

[PATCH] D108421: Mark openmp internal global dso_local

kamleshbhalui updated this revision to Diff 367953. kamleshbhalui added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. updated test and make changes local to auto generated global vars for lock. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D108421: Mark openmp internal global dso_local

kamleshbhalui updated this revision to Diff 367700. kamleshbhalui added a comment. clang formatted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108421/new/ https://reviews.llvm.org/D108421 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp Index:

[PATCH] D108421: Mark openmp internal global dso_local

kamleshbhalui created this revision. kamleshbhalui added reviewers: MaskRay, pengfei. kamleshbhalui added a project: OpenMP. Herald added subscribers: guansong, yaxunl. kamleshbhalui requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits,

[PATCH] D103131: support debug info for alias variable

kamleshbhalui added a comment. In D103131#2835909 , @dblaikie wrote: > In D103131#2835702 , @kamleshbhalui > wrote: > >> Here is what we get when we replace int with float. >> >> $lldb-11 ./a.out >> (lldb)

[PATCH] D103131: support debug info for alias variable

kamleshbhalui added a comment. Here is what we get when we replace int with float. $lldb-11 ./a.out (lldb) target create "./a.out" Current executable set to '/folk/kkumar/tcllvm/llvm-build-lldb-rel/bin/a.out' (x86_64). (lldb) b main Breakpoint 1: where = a.out`main + 4 at

[PATCH] D103131: support debug info for alias variable

kamleshbhalui added a comment. In D103131#2834744 , @dblaikie wrote: > Huh, that surprises me - guess gdb favors checking the symbol first. I guess > maybe it is using something that determines that that symbol comes from the > file with debug info -

[PATCH] D103131: support debug info for alias variable

kamleshbhalui added a comment. In D103131#2815386 , @probinson wrote: >>> 0x002a: DW_TAG_variable >>> DW_AT_name ("oldname") >>> DW_AT_type (0x003f "int") >>> DW_AT_external

[PATCH] D103131: support debug info for alias variable

kamleshbhalui added a comment. In D103131#2814015 , @dblaikie wrote: > In D103131#2811969 , @kamleshbhalui > wrote: > >> In D103131#2811220 , @dblaikie >> wrote: >> >>>

[PATCH] D103131: support debug info for alias variable

kamleshbhalui added a comment. In D103131#2811220 , @dblaikie wrote: > Any idea if the GDB test suite covers this functionality? I'd hope so, but > maybe it doesn't. > > But yeah, at the moment I don't have any great reason to avoid the imported >

[PATCH] D103131: support debug info for alias variable

kamleshbhalui added a comment. In D103131#2791881 , @dblaikie wrote: > In D103131#2789493 , @probinson > wrote: > >>> Mixed feelings - somewhat in favor of "do the thing that's probably already >>> fairly

[PATCH] D103131: support debug info for alias variable

kamleshbhalui added a comment. $cat test.h int oldname; $cat test.c #include "test.h" int oldname; __asm__ ( "movq oldname, %rsp\n\t" ); extern int newname __attribute__((alias("oldname"))); debug info from gcc: test.o: file format elf64-x86-64 .debug_info contents: 0x: Compile

[PATCH] D103131: support debug info for alias variable

kamleshbhalui updated this revision to Diff 348501. kamleshbhalui added a comment. matching gcc behavior Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103131/new/ https://reviews.llvm.org/D103131 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D103131: support debug info for alias variable

kamleshbhalui updated this revision to Diff 348160. kamleshbhalui added a comment. match gcc behavior Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103131/new/ https://reviews.llvm.org/D103131 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D103131: support debug info for alias variable

kamleshbhalui updated this revision to Diff 347883. kamleshbhalui retitled this revision from "support debug info for alias variable " to "support debug info for alias variable". kamleshbhalui added a comment. removed unnecessary code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D103131: support debug info for alias variable

kamleshbhalui added a comment. In D103131#2780997 , @dblaikie wrote: > Looks like GCC emits aliases as a `DW_TAG_variable` without a location, not > as a `DW_TAG_imported_declaration` - what gave you the inspiration to do it > in this way? (I think

[PATCH] D103131: support debug info for alias variable

kamleshbhalui created this revision. kamleshbhalui added reviewers: dblaikie, aprantl, probinson. kamleshbhalui added a project: LLVM. Herald added a subscriber: jeroen.dobbelaere. kamleshbhalui requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui updated this revision to Diff 336057. kamleshbhalui added a comment. Making changes effective only for windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/ https://reviews.llvm.org/D99580 Files:

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui added a reviewer: rnk. kamleshbhalui added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/ https://reviews.llvm.org/D99580 ___ cfe-commits mailing list

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui updated this revision to Diff 334952. kamleshbhalui added a comment. Making changes effective only for windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/ https://reviews.llvm.org/D99580 Files:

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui updated this revision to Diff 334359. kamleshbhalui added a comment. updated patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/ https://reviews.llvm.org/D99580 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui updated this revision to Diff 334356. kamleshbhalui added a comment. clang formatting the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/ https://reviews.llvm.org/D99580 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui updated this revision to Diff 334338. kamleshbhalui added a comment. Marked failed tests as unsupported on windows system Because now clang emits native path for DIFile. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui added a comment. In D99580#2659352 , @dblaikie wrote: > @rnk @akhuang - I think we touched on this before maybe in some other > thread/patch/discussion? > > Ah, @probinson mentioned in the linked thread: > >> Is this

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui added a comment. In D99580#2659858 , @amccarth wrote: > Another possible issue is that llvm::sys::path and other functions try to map > Windows filesystem concepts to Posix ones. There are many cases where there > isn't a perfect mapping.

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui created this revision. kamleshbhalui added reviewers: dblaikie, aprantl. kamleshbhalui added a project: LLVM. Herald added a subscriber: mstorsjo. kamleshbhalui requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang emits

[PATCH] D82446: [clang] Fix duplicate warning

kamleshbhalui marked an inline comment as done. kamleshbhalui added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2273 ParseSpecifierQualifierList(DS, AS_none, DeclSpecContext::DSC_type_specifier); - DS.Finish(Actions,

[PATCH] D82446: [clang] Fix duplicate warning

kamleshbhalui created this revision. kamleshbhalui added reviewers: rsmith, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes duplicate warning emitted by clang when char16_t/char32_t is used in the catch block. Fixes this

[PATCH] D79504: [Clang] Wrong return type of atomic_is_lock_free

kamleshbhalui added a comment. In D79504#2029267 , @ldionne wrote: > What name and email do you want this committed with? Kamlesh Kumar kamleshbha...@gmail.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79504/new/

[PATCH] D79504: [Clang] Wrong return type of atomic_is_lock_free

kamleshbhalui added a comment. I do not have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79504/new/ https://reviews.llvm.org/D79504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79504: [Clang] Wrong return type of atomic_is_lock_free

kamleshbhalui updated this revision to Diff 262518. kamleshbhalui added a comment. Addressed @rsmith concerns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79504/new/ https://reviews.llvm.org/D79504 Files: clang/include/clang/Basic/Builtins.def clang/test/CodeGen/atomic-ops.c

[PATCH] D79504: [Clang] Wrong return type of atomic_is_lock_free

kamleshbhalui created this revision. kamleshbhalui added reviewers: aaron.ballman, rsmith. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. kamleshbhalui added a reviewer: rnk. Fixing the return type of atomic_is_lock_free as per

[PATCH] D75805: Make malign-double effective only for x86

kamleshbhalui updated this revision to Diff 249054. kamleshbhalui added a reviewer: MaskRay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75805/new/ https://reviews.llvm.org/D75805 Files: clang/lib/Frontend/CompilerInvocation.cpp Index: clang/lib/Frontend/CompilerInvocation.cpp

[PATCH] D75805: Make malign-double effective only for x86

kamleshbhalui created this revision. kamleshbhalui added a reviewer: rnk. kamleshbhalui added a project: clang. Herald added a subscriber: cfe-commits. Making -malign-double effective only for x86. Fixes. https://bugs.llvm.org/show_bug.cgi?id=45136 Repository: rG LLVM Github Monorepo

[PATCH] D72565: adding __has_feature support for left c++ type_traits

kamleshbhalui abandoned this revision. kamleshbhalui added a comment. not an issue since __has_builtin does the work. i.e. __has_builtin(__is_same) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72565/new/ https://reviews.llvm.org/D72565

[PATCH] D72565: adding __has_feature support for left c++ type_traits

kamleshbhalui created this revision. kamleshbhalui added reviewers: rsmith, aaron.ballman, dblaikie, ldionne. kamleshbhalui added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. adding __has_feature support for left c++ type_traits. fixes this

[PATCH] D71619: [CLANG] Alignment specifier not applied to anonymous structure or union

kamleshbhalui updated this revision to Diff 234796. kamleshbhalui added a comment. removed c++11 from the test. I do not have commit access, Can someone commit this for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71619/new/ https://reviews.llvm.org/D71619 Files:

[PATCH] D71619: [CLANG] Alignment specifier not applied to anonymous structure or union

kamleshbhalui updated this revision to Diff 234652. kamleshbhalui added a comment. added assert. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71619/new/ https://reviews.llvm.org/D71619 Files: clang/lib/Sema/SemaDecl.cpp clang/test/AST/pr43983.cpp Index:

[PATCH] D71619: [CLANG] Alignment specifier not applied to anonymous structure or union

kamleshbhalui created this revision. kamleshbhalui added reviewers: rsmith, aaron.ballman, dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. Apply attributes on anonymous records. This Fixes https://bugs.llvm.org/show_bug.cgi?id=43983. Repository: rG LLVM Github

[PATCH] D71508: [DebugInfo] Duplicate file names in debug info

kamleshbhalui added a comment. In D71508#1786799 , @aprantl wrote: > Are we sure we want to canonicalize *before* applying -fdebug-prefix-map in > `remapDIPath()`? Honest question, the answer could be yes :-) it canonicalizes before apply

[PATCH] D71508: [DebugInfo] Duplicate file names in debug info

kamleshbhalui added a comment. In D71508#1786804 , @dblaikie wrote: > In D71508#1786212 , @kamleshbhalui > wrote: > > > In D71508#1786148 , @probinson > > wrote: > > > > >

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

kamleshbhalui added a comment. In D69893#1786202 , @steven_wu wrote: > The fix LGTM. Do you have a reproducer that can be used as a test case? We > should really add more tests for libunwind. I currently do not have a reproducer test case for this.

[PATCH] D71508: [DebugInfo] Duplicate file names in debug info

kamleshbhalui added a comment. In D71508#1786148 , @probinson wrote: > In D71508#1786122 , @kamleshbhalui > wrote: > > > In D71508#1785767 , @probinson > > wrote: > > > >

[PATCH] D71508: [DebugInfo] Duplicate file names in debug info

kamleshbhalui added a comment. In D71508#1785767 , @probinson wrote: > Do we have a similar problem if the filespec has an embedded ./ or ../ in it? problems occur only when filespec starts with ./ otherwise it's fine. Repository: rG LLVM Github

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

kamleshbhalui updated this revision to Diff 233919. kamleshbhalui added a comment. added validation check in testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70537/new/ https://reviews.llvm.org/D70537 Files:

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

kamleshbhalui added a comment. ping? can someone commit this for me? Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69893/new/ https://reviews.llvm.org/D69893 ___ cfe-commits mailing list

[PATCH] D71508: [DebugInfo] Duplicate file names in debug info

kamleshbhalui created this revision. kamleshbhalui added reviewers: probinson, dblaikie, vsk, labath. kamleshbhalui added a project: debug-info. Herald added subscribers: cfe-commits, aprantl. Herald added a project: clang. strip/remove the dot slash before creating files for debug info. This

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

kamleshbhalui added a comment. In D70537#1769458 , @dblaikie wrote: > I feel like there's something missing about this bug/issue - is there a good > explanation/understanding for why does the bug only occur with the two levels > of static member inline

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

kamleshbhalui added a comment. In D70537#1765607 , @probinson wrote: > I guess first I'm confused about why the type would be undeduced in the first > place, given that it is actually instantiated. > And if undeduced is correct, wouldn't we rather emit

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

kamleshbhalui updated this revision to Diff 230747. kamleshbhalui added a comment. Thanks, @vsk for reviewing. I have incorporated your suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70537/new/ https://reviews.llvm.org/D70537 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

kamleshbhalui updated this revision to Diff 230569. kamleshbhalui added a comment. Added a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70537/new/ https://reviews.llvm.org/D70537 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/pr42710.cpp Index:

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

kamleshbhalui added a comment. @ldionne Can you please commit this for me. I do not have commit access. Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69893/new/ https://reviews.llvm.org/D69893 ___ cfe-commits

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

kamleshbhalui updated this revision to Diff 230444. kamleshbhalui added a comment. formatted the diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70537/new/ https://reviews.llvm.org/D70537 Files: clang/lib/CodeGen/CGDebugInfo.cpp Index: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

kamleshbhalui created this revision. kamleshbhalui added reviewers: rsmith, dblaikie, vsk. kamleshbhalui added a project: debug-info. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes this assert failure. Which occured due to deduction of auto type of templated

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

kamleshbhalui added a comment. Yes, Tested All tests passes. Testing Time: 0.95s Expected Passes: 4 Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69893/new/ https://reviews.llvm.org/D69893 ___

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

kamleshbhalui added a comment. `I do not have a test related to libunwind ,but I do simulated this behavior in c and got segfault. --- int main(){ int stack[10]={0}; int* sp=stack;

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

kamleshbhalui created this revision. kamleshbhalui added a reviewer: phosek. Herald added subscribers: libcxx-commits, ldionne, christof. kamleshbhalui edited the summary of this revision. reg is unsigned type and used here for getting array element from the end by negating it. negation of