[PATCH] D103313: [RISCV][Clang] Add support for Zmmul extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3198364e6e49: [RISCV][Clang] Add support for Zmmul extension (authored by ksyx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103313: [RISCV][Clang] Add support for Zmmul extension

ksyx updated this revision to Diff 445461. ksyx marked an inline comment as done. ksyx added a comment. Update zmmul version & rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 Files: clang/lib/Basic/Targets/RISCV.cpp

[PATCH] D103313: [RISCV][Clang] Add support for Zmmul extension

ksyx updated this revision to Diff 445332. ksyx added a comment. Rebase and update use of M extension existence check to include Zmmul whenever needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 Files:

[PATCH] D103313: [RISCV][Clang] Add support for Zmmul extension

ksyx added a comment. ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D103313: [RISCV][Clang] Add support for Zmmul extension

ksyx updated this revision to Diff 440075. ksyx marked an inline comment as done. ksyx added a comment. Make Zmmul extension independent instead of implied by M extension for backward ELF attribute compatibility. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/

[PATCH] D103313: [RISCV][Clang] Add support for Zmmul extension

ksyx updated this revision to Diff 440017. ksyx retitled this revision from "[RISCV][Clang] Implement support for zmmul-experimental" to "[RISCV][Clang] Add support for Zmmul extension". ksyx edited the summary of this revision. ksyx added a comment. Herald added subscribers: sunshaoce,

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

ksyx accepted this revision. ksyx added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123676/new/ https://reviews.llvm.org/D123676 ___ cfe-commits mailing list

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

ksyx added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.h:117-120 + struct MacroTokenInfo { +TokenType Type; +bool Finalized; + }; curdeius wrote: > ksyx wrote: > > Would making constructor of `struct MacroTokenInfo` having default >

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

ksyx added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.h:117-120 + struct MacroTokenInfo { +TokenType Type; +bool Finalized; + }; Would making constructor of `struct MacroTokenInfo` having default parameter or overloading it help

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx updated this revision to Diff 413212. ksyx added a comment. Fix patch apply failed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/riscv-arch.c

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx updated this revision to Diff 413211. ksyx added a comment. Herald added a subscriber: jdoerfert. Rebase and adapt to new ISAInfo module. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 Files: clang/lib/Basic/Targets/RISCV.cpp

[PATCH] D118869: [clang-format] Non-latin comment prefix whitespace

ksyx added a comment. In D118869#3359439 , @krasimir wrote: > It appears that this caused a regression by adding an additional space of > indentation to line comments in some cases: > > % cat test.cc # (before) > // Comment > int i; > %

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx added a comment. In D103313#3359310 , @JiahaoChenConor wrote: > Hi, do you still continue working on this patch? In fact, not pretty sure what else I need to improve on this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/

[PATCH] D119067: [clang-format] Fix DefinitionBlockSeparator extra empty lines

This revision was automatically updated to reflect the committed changes. Closed by commit rGa70549ae43df: [clang-format] Fix DefSeparator empty line issues (authored by ksyx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119067/new/

[PATCH] D119067: [clang-format] Fix DefinitionBlockSeparator extra empty lines

ksyx marked an inline comment as done. ksyx added inline comments. Comment at: clang/unittests/Format/DefinitionBlockSeparatorTest.cpp:305 " int r = j / k;\n" + " if (struct S = getS()) {\n" + "// if

[PATCH] D119067: [clang-format] Fix DefinitionBlockSeparator extra empty lines

ksyx updated this revision to Diff 406309. ksyx added a comment. Use for loop to go through tokens in a line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119067/new/ https://reviews.llvm.org/D119067 Files: clang/lib/Format/DefinitionBlockSeparator.cpp

[PATCH] D119067: [clang-format] Fix DefinitionBlockSeparator extra empty lines

ksyx updated this revision to Diff 406271. ksyx added a comment. - Remove return after else CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119067/new/ https://reviews.llvm.org/D119067 Files: clang/lib/Format/DefinitionBlockSeparator.cpp

[PATCH] D119067: [clang-format] Fix DefinitionBlockSeparator extra empty lines

ksyx updated this revision to Diff 406245. ksyx marked 3 inline comments as done. ksyx edited the summary of this revision. ksyx added a comment. - Add or remove empty lines surrounding `union`s. - Move new test location. - Remove else immediately above return. CHANGES SINCE LAST ACTION

[PATCH] D119067: [clang-format] Fix DefinitionBlockSeparator extra empty lines

ksyx created this revision. ksyx added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. ksyx added a project: clang-format. ksyx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This commit fixes

[PATCH] D118869: [clang-format] Non-latin comment prefix whitespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88e4e6be16ea: [clang-format] Use wider comment prefix space rule (authored by ksyx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D118869: [clang-format] Non-latin comment prefix whitespace

ksyx added subscribers: byronhe, CoelacanthusHex. ksyx added a comment. Related discussion: https://reviews.llvm.org/D92257#3252060 Proposed by @byronhe cc @CoelacanthusHex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118869/new/

[PATCH] D118869: [clang-format] Non-latin comment prefix whitespace

ksyx created this revision. ksyx added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius. ksyx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This commit changes the condition of requiring comment to start with alphabet characters

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

This revision was automatically updated to reflect the committed changes. ksyx marked 2 inline comments as done. Closed by commit rG5e5efd8a91f2: [clang-format] Fix SeparateDefinitionBlocks issues (authored by ksyx). Changed prior to commit:

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx marked 2 inline comments as done. ksyx added a comment. In D117520#3263403 , @MyDeveloperDay wrote: > maybe slightly related https://github.com/llvm/llvm-project/issues/53183 in > that this is also impacted by the 5 character >

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:134 + OperateIndex + 1 < Lines.size()) { +// UnwrappedLineParser's recognition of free-standing macro like +// Q_OBJECT may also recognize some uppercased type names

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx updated this revision to Diff 402078. ksyx marked an inline comment as done. ksyx added a comment. Apply review suggestions of renaming. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117520/new/ https://reviews.llvm.org/D117520 Files:

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx marked an inline comment as done. ksyx added inline comments. Comment at: clang/unittests/Format/DefinitionBlockSeparatorTest.cpp:47 llvm::StringRef ExpectedCode = "") { ::testing::ScopedTrace t(File, Line, ::testing::Message() <<

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx updated this revision to Diff 402006. ksyx edited the summary of this revision. ksyx added a comment. Add token type `FunctionLikeOrFreestandingMacro` and use it to replace duplicated check with UnwrappedLineParser CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117520/new/

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx added a comment. In D117520#3260443 , @curdeius wrote: > In D117520#3258454 , > @MyDeveloperDay wrote: > >> I think its been fixed, in the last but one diff. >> >> Generally speaking we simply cannot have

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx updated this revision to Diff 401659. ksyx added a comment. Add unit test for formatting conflict CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117520/new/ https://reviews.llvm.org/D117520 Files: clang/lib/Format/DefinitionBlockSeparator.cpp

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx updated this revision to Diff 401460. ksyx added a comment. Apply suggestion from clangfmt CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117520/new/ https://reviews.llvm.org/D117520 Files: clang/lib/Format/DefinitionBlockSeparator.cpp

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx updated this revision to Diff 401445. ksyx marked an inline comment as done. ksyx added a comment. - Apply suggestions from clangfmt - Split assertion conditions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117520/new/ https://reviews.llvm.org/D117520 Files:

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:134 + OperateIndex + 1 < Lines.size()) { +// UnwrappedLineParser's recognition of free-standing macro like +// Q_OBJECT may also recognize some uppercased type names

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx updated this revision to Diff 401293. ksyx edited the summary of this revision. ksyx added a comment. Recognize long (len>=5) uppercased name taking a single line as return type and fix the problem of adding newline below it: void afunc(int x) { return; } TYPENAME func(int x,

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx updated this revision to Diff 401062. ksyx marked 2 inline comments as done. ksyx edited the summary of this revision. ksyx added a comment. - Resolves formatting conflict with options `EmptyLineAfterAccessModifier` and `EmptyLineBeforeAccessModifier` (prompts with `--dry-run` (`-n`) or

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:80 return; Whitespaces.replaceWhitespace(*TargetToken, NewlineToInsert, +TargetToken->OriginalColumn, HazardyKnusperkeks

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx added a comment. In D117520#3251425 , @MyDeveloperDay wrote: > For > > class Test > { > public: > static void foo() > { > } > }; > > F21703157: image.png > > $ clang-format -n

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx added a comment. In D117520#3251376 , @MyDeveloperDay wrote: > I'm getting some sort of seemingly empty replacements going on, after > `public:` I can't quite put my finger on what's happening. Not so sure what empty means here. Is it removing

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx updated this revision to Diff 400821. ksyx marked 3 inline comments as done. ksyx edited the summary of this revision. ksyx added a comment. - Use function keyword for JavaScript instead of comparing strings - Apply review suggestions CHANGES SINCE LAST ACTION

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx updated this revision to Diff 400667. ksyx added a comment. Apply clangfmt's suggestion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117520/new/ https://reviews.llvm.org/D117520 Files: clang/lib/Format/DefinitionBlockSeparator.cpp

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx created this revision. ksyx added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. ksyx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Fixes https://github.com/llvm/llvm-project/issues/53227 that wrongly indents multiline

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

ksyx added a comment. In D92257#3004563 , @HazardyKnusperkeks wrote: > In D92257#3003281 , @byronhe wrote: > >> Hi guys，i found `SpacesInLineCommentPrefix` does not support other encoding >> such as utf8 ， >> I

[PATCH] D116663: [clang-format] Fix SeparateDefinitionBlocks issues

This revision was automatically updated to reflect the committed changes. Closed by commit rGee25a327aac0: [clang-format] Fix SeparateDefinitionBlocks issues (authored by ksyx). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx added a comment. In D116314#3221488 , @MyDeveloperDay wrote: > @ksyx > > Did you see this issue https://github.com/llvm/llvm-project/issues/52976 > > In its current form, this patch causes huge amounts of flux in projects > that document code like

[PATCH] D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ...

ksyx accepted this revision. ksyx added a comment. This revision is now accepted and ready to land. Thanks for the fix! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116557/new/ https://reviews.llvm.org/D116557 ___ cfe-commits mailing list

[PATCH] D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ...

ksyx added a comment. Thanks for the fix :) Comment at: clang/docs/ReleaseNotes.rst:300 - Option ``SeparateDefinitionBlocks`` has been added to insert or remove empty lines between definition blocks including functions, classes, structs, enums, The

[PATCH] D116314: [clang-format] Add style to separate definition blocks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f6f88ffdae1: [clang-format] Style to separate definition blocks (authored by ksyx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396926. ksyx added a comment. Add release note entry. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3398 +**SeparateDefinitionBlocks** (``SeparateDefinitionStyle``) :versionbadge:`clang-format 14` + Specifies the use of empty lines to separate definition blocks, including classes,

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396835. ksyx marked 3 inline comments as done. ksyx added a comment. Change the `SDS_Leave` style check to be assert not having this style. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 Files:

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx marked an inline comment as done. ksyx added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:25 +FormatTokenLexer ) { + if (Style.SeparateDefinitionBlocks == FormatStyle::SDS_Leave) +return {{}, 0}; HazardyKnusperkeks

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396826. ksyx added a comment. Use `reformat` method instead of calling the single method only. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D116351: Update Bug report URL to Github Issues

ksyx added inline comments. Comment at: libcxx/docs/index.rst:220 * `libc++abi Homepage `_ -* `LLVM Bugzilla `_ +* `LLVM Issues `_ * `libcxx-commits Mailing List`_

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:25 +FormatTokenLexer ) { + if (Style.SeparateDefinitionBlocks == FormatStyle::SDS_Leave) +return {{}, 0}; HazardyKnusperkeks wrote: > Better, but I still think we

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396782. ksyx added a comment. Change lambda variable names' leading letter to uppercase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396781. ksyx marked 5 inline comments as done. ksyx added a comment. Change lambda variable names' leading letter to uppercase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 Files:

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx added inline comments. Comment at: clang/include/clang/Format/Format.h:4097 + ArrayRef Ranges, + StringRef FileName = ""); + HazardyKnusperkeks wrote: > The only use

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396727. ksyx marked 9 inline comments as done. ksyx added a comment. - Apply review suggestions. - Assert the style is not `SDS_Leave` in private method, while return no change in public method if so. - Rename loop variable `Line` to `CurrentLine` CHANGES

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396709. ksyx marked 2 inline comments as done. ksyx added a comment. minor fixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396577. ksyx added a comment. Apply suggestion from clangfmt CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396575. ksyx added a comment. Apply clangfmt's suggestions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396574. ksyx marked 9 inline comments as done. ksyx edited the summary of this revision. ksyx added a comment. - Improve compatibility to other languages - Improve unit test by test format stability, inverse result, and generate some input from expected output

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396430. ksyx added a comment. Fix typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/CMakeLists.txt

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396428. ksyx marked 5 inline comments as done. ksyx added a comment. - Apply suggestions from clangfmt - Add missing period of comments - Fix namespace ending comment - Add comment for notes on return value of WhitespaceManager's method CHANGES SINCE LAST

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx marked an inline comment as done. ksyx added inline comments. Comment at: clang/lib/Format/Format.cpp:2114 + if (Result.add(R)) +return; + } HazardyKnusperkeks wrote: > Why only add the first replacement? This worked well as the `Error` class

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396421. ksyx marked 4 inline comments as done. ksyx added a comment. Herald added a subscriber: mgorny. - Change version from 15 to 14 - Add option `SDS_Never`, rename `SDS_Between` => `SDS_Always` - Add unit tests - Separate class into new file CHANGES SINCE

[PATCH] D116314: [Clangfmt] Add style to separate definition blocks

ksyx updated this revision to Diff 396358. ksyx marked an inline comment as done. ksyx added a comment. - Change bool type of the option to enum type - Generate empty line for enum block Testfile: // test.cpp #include #include #include struct Foo { int a,b,c; }; namespace

[PATCH] D116314: [Clangfmt] Add style to separate definition blocks

ksyx updated this revision to Diff 396344. ksyx added a comment. Fix missing colon in sample/test code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[PATCH] D116314: [Clangfmt] Add style to separate definition blocks

ksyx added inline comments. Comment at: clang/lib/Format/Format.cpp:1197 LLVMStyle.ReferenceAlignment = FormatStyle::RAS_Pointer; + LLVMStyle.SeparateDefinitionBlocks = true; LLVMStyle.ShortNamespaceLines = 1; ksyx wrote: > Not so sure about this as it

[PATCH] D116314: [Clangfmt] Add style to separate definition blocks

ksyx added inline comments. Comment at: clang/lib/Format/Format.cpp:1197 LLVMStyle.ReferenceAlignment = FormatStyle::RAS_Pointer; + LLVMStyle.SeparateDefinitionBlocks = true; LLVMStyle.ShortNamespaceLines = 1; Not so sure about this as it would break some

[PATCH] D116314: [Clangfmt] Add style to separate definition blocks

ksyx updated this revision to Diff 396321. ksyx added a comment. Apply clang-format suggestions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[PATCH] D116314: [Clangfmt] Add style to separate definition blocks

ksyx added a comment. Test code: // test.cpp #include #include #include struct Foo { int a,b,c; }; namespace Ns { class Bar { public: struct Foobar { int a; int b; }; private: int t; int method1() { // Intentional test for

[PATCH] D116314: [Clangfmt] Add style to separate definition blocks

ksyx created this revision. ksyx added a reviewer: MyDeveloperDay. ksyx added projects: clang-format, clang. ksyx requested review of this revision. Herald added a subscriber: cfe-commits. This commit resolves GitHub issue #45895 (Bugzilla

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx updated this revision to Diff 351083. ksyx added a comment. add: zmmul arch string test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 Files: clang/lib/Basic/Targets/RISCV.cpp clang/lib/Basic/Targets/RISCV.h

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:38 bool HasStdExtM = false; + bool HasStdExtZmmul = false; bool HasStdExtA = false; ksyx wrote: > jrtc27 wrote: > > Ditto > The pattern here seems to be that Z* extensions is

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx added a comment. I have took a look into `ELFObjectFile.cpp` but I am not sure what work I need to do there since it seems other Z* extensions are not being handled there. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:38 bool HasStdExtM = false; + bool

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx updated this revision to Diff 348608. ksyx marked an inline comment as done. ksyx added a comment. - Move down zmmul lines to fit the ordering - Add Zmmul into parseDirectiveAttribute CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313

[PATCH] D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division

ksyx updated this revision to Diff 348525. ksyx added a comment. split `Zmmul` implementation and `-mno-div` implementation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102839/new/ https://reviews.llvm.org/D102839 Files: clang/include/clang/Driver/Options.td

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx created this revision. ksyx added reviewers: asb, craig.topper, luismarques, jrtc27, kito-cheng, rsmith, shiva0217. Herald added subscribers: vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division

ksyx added a comment. In D102839#2784297 , @luismarques wrote: > In D102839#2784275 , @ksyx wrote: > >> Thanks for mentioning that! Now, I changed the effect of `no-div` option >> into choosing a proper

[PATCH] D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division

ksyx added a comment. In D102839#2784197 , @luismarques wrote: > In D102839#2783636 , @ksyx wrote: > >> So it seems the better way to do this would definitely by adding a >> subextension as the spec had

[PATCH] D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division

ksyx updated this revision to Diff 348206. ksyx marked an inline comment as done. ksyx edited the summary of this revision. ksyx added a comment. Implemented Zmmul subextension, and let `no-div` to be using this subextension instead of M itself. CHANGES SINCE LAST ACTION

[PATCH] D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division

ksyx added a comment. So it seems the better way to do this would definitely by adding a subextension as the spec had changed. But I'd like also to ask how will GCC deal with this option, and should we make this option an alias to turn off M extension and turn on ZMMul extension? CHANGES

[PATCH] D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division

ksyx updated this revision to Diff 347637. ksyx added a comment. fix: indent CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102839/new/ https://reviews.llvm.org/D102839 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Targets/RISCV.cpp clang/lib/Basic/Targets/RISCV.h

[PATCH] D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division

ksyx updated this revision to Diff 347603. ksyx marked 2 inline comments as done. ksyx retitled this revision from "[RISCV][Clang] Add -mno-idiv option to disable hardware int division" to "[RISCV][Clang] Add -mno-div option to disable hardware int division". ksyx edited the summary of this

[PATCH] D102839: [RISCV][Clang] Add -mno-idiv option to disable hardware int division

ksyx added a comment. In D102839#2775732 , @craig.topper wrote: > Isn't the gcc name for this -mno-div? Should we be consistent? I am not sure whether using `-mno-div` might bring in some confusion since from the name `no-div` itself it expresses a

[PATCH] D102839: [RISCV][Clang] Add -mno-idiv option to disable hardware int division

ksyx created this revision. ksyx added reviewers: asb, rsmith, shiva0217. Herald added subscribers: vkmr, frasercrmck, dang, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27,