[PATCH] D159361: [Driver] Do not generate error about unsupported target specific options when there is no compiler jobs

2023-09-11 Thread mgabka via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9272aa9d08cb: [Driver] Do not generate error about unsupported target specific options when… (authored by mgabka). Herald added a project: clang.

[PATCH] D150553: [SVE ACLE] Change the lowering of SVE integer mla_u/mls_u builtins

2023-05-15 Thread mgabka via Phabricator via cfe-commits
mgabka added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1665 def int_aarch64_sve_mla_lane : AdvSIMD_3VectorArgIndexed_Intrinsic; +def int_aarch64_sve_mla_u : AdvSIMD_Pred3VectorArg_Intrinsic; def int_aarch64_sve_mls:

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

2023-03-03 Thread mgabka via Phabricator via cfe-commits
mgabka added a comment. In D144179#4146599 , @MaskRay wrote: > This looks like introducing a footgun (when something behaves differently > from an upstream Clang, it would be difficult for toolchain maintainers to > know why). > Why can't your user

[PATCH] D131580: [clang][SVE] Undefine preprocessor macro defined in

2022-08-11 Thread mgabka via Phabricator via cfe-commits
mgabka marked an inline comment as done. mgabka added a comment. It is a fix for https://github.com/llvm/llvm-project/issues/57083 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131580/new/ https://reviews.llvm.org/D131580

[PATCH] D131580: [clang][SVE] Undefine preprocessor macro defined in

2022-08-11 Thread mgabka via Phabricator via cfe-commits
mgabka marked an inline comment as done. mgabka added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:1285 OS << "#endif\n\n"; + OS << "#undef __ai\n\n"; OS << "#endif /*__ARM_FEATURE_SVE */\n\n"; paulwalker-arm wrote: > Can you also do

[PATCH] D131580: [clang][SVE] Undefine preprocessor macro defined in

2022-08-11 Thread mgabka via Phabricator via cfe-commits
mgabka updated this revision to Diff 451791. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131580/new/ https://reviews.llvm.org/D131580 Files: clang/utils/TableGen/SveEmitter.cpp Index: clang/utils/TableGen/SveEmitter.cpp

[PATCH] D131580: [clang][SVE] Undefine preprocessor macro defined in

2022-08-10 Thread mgabka via Phabricator via cfe-commits
mgabka created this revision. mgabka added a reviewer: paulwalker-arm. Herald added subscribers: ctetreau, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. mgabka requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

2022-08-02 Thread mgabka via Phabricator via cfe-commits
mgabka added a comment. In D127803#3693700 , @jyu2 wrote: > In D127803#3693660 , @ABataev wrote: > >> In D127803#3693655 , @jyu2 wrote: >> >>> In D127803#3693301

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

2022-08-02 Thread mgabka via Phabricator via cfe-commits
mgabka added a comment. I noticed that this patch is causing now an assertion failure for cases like : class A{ void a() { #pragma omp parallel a(b); } }; The failed assertion is: "const clang::ValueDecl* getCanonicalDecl(const clang::ValueDecl*): Assertion `FD' failed." while

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

2022-05-30 Thread mgabka via Phabricator via cfe-commits
mgabka added inline comments. Comment at: clang/test/CodeGen/aarch64-attr-mode-complex.c:11 +// CHECK: define{{.*}} { half, half } @c16_test([2 x half] noundef [[C16A:%.*]]) +// CHECK-NEXT: entry: +// CHECK-NEXT: [[C16B:%.*]] = extractvalue [2 x half] [[C16A]], 0

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

2021-11-15 Thread mgabka via Phabricator via cfe-commits
mgabka added inline comments. Comment at: clang/test/Driver/aarch64-implied-sve-features.c:28 + +// RUN: %clang -target aarch64-linux-gnu -march=armv8-a+nosve2-bitperm %s -### |& FileCheck %s --check-prefix=NOSVE2-BITPERM +// NOSVE2-BITPERM-NOT: "-target-feature"