[PATCH] D56429: fix python3 compability issue

2019-01-22 Thread rox via Phabricator via cfe-commits
roxma added a comment. Yes please. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56429/new/ https://reviews.llvm.org/D56429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56429: fix python3 compability issue

2019-01-14 Thread rox via Phabricator via cfe-commits
roxma marked an inline comment as done. roxma added inline comments. Comment at: bindings/python/clang/cindex.py:2998 +for i,(name,contents) in enumerate(unsaved_files): +if hasattr(contents, "read"): +contents = contents.read()

[PATCH] D56429: fix python3 compability issue

2019-01-08 Thread rox via Phabricator via cfe-commits
roxma created this revision. roxma added reviewers: ilya-biryukov, mgorny. Herald added subscribers: cfe-commits, arphaman. Herald added a reviewer: serge-sans-paille. The file contents could be of str type. Should use byte length instead of str length, otherwise utf-8 encoded files may not get