[PATCH] D93453: [flang][driver] Add support for `-I`

sameeranjoshi added inline comments. Comment at: flang/test/Flang-Driver/include-header.f90:38 +!- +! EXPECTED OUTPUT FOR /Inputs/ FOLDER SPECIFIED FIRST +!-

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

sameeranjoshi added inline comments. Comment at: flang/test/Flang-Driver/driver-help.f90:22 ! HELP-NEXT: -### Print (but do not run) the commands to run for this compilation +! HELP-NEXT: -D = Define to (or 1 if omitted) ! HELP-NEXT: -E

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

sameeranjoshi accepted this revision. sameeranjoshi added a comment. This revision is now accepted and ready to land. Looks good from my end. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92854/new/ https://reviews.llvm.org/D92854

[PATCH] D93027: [clang] Remove `-triple` from the invocations of `flang-new -fc1`

sameeranjoshi accepted this revision. sameeranjoshi added a comment. This revision is now accepted and ready to land. Thanks for extracting it from D92854 . I think the tests in D92854 were failing for the same reason. LGTM.

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

sameeranjoshi added a comment. Thanks for patch, a few queries below. Are the tests in clang which are related to flang failing at https://reviews.llvm.org/B81474? Comment at: flang/include/flang/Frontend/FrontendActions.h:29 +class SyntaxOnlyAction : public FrontendAction

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

sameeranjoshi added a comment. Looks good, I would wait for a couple of more days for someone to review from community may be from Nvidia's side if someone would verify the initial design. Thank you. Comment at: flang/include/flang/Frontend/CompilerInvocation.h:12 #include

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

sameeranjoshi added a comment. A few `nits:` and mostly style comments inline: Comment at: flang/include/flang/Frontend/CompilerInvocation.h:12 #include "flang/Frontend/FrontendOptions.h" +#include "flang/Parser/parsing.h" #include "clang/Basic/Diagnostic.h"

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

sameeranjoshi added a comment. Thank you, this patch looks easy to understand as it's clearly separated from(`D87989`) the infrastructure changes needed for frontend actions. A few comments inline. Comment at: flang/include/flang/Frontend/CompilerInstance.h:85 + /// Return

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

sameeranjoshi accepted this revision. sameeranjoshi added a comment. Thanks for patch. Looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.llvm.org/D87774 ___

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

sameeranjoshi added inline comments. Comment at: flang/lib/Frontend/TextDiagnosticPrinter.cpp:37 + // this later as we print out the diagnostic to the terminal. + SmallString<100> outStr; + info.FormatDiagnostic(outStr); awarzynski wrote: > awarzynski wrote:

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

sameeranjoshi added a comment. In D87774#2292034 , @awarzynski wrote: > @sameeranjoshi Apologies, I missed some of your comments. > > In D87774#2287927 , @sameeranjoshi > wrote: > >> Thanks for working on it. >>

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

sameeranjoshi added inline comments. Comment at: flang/lib/Frontend/TextDiagnostic.cpp:26 +static const enum llvm::raw_ostream::Colors savedColor = +llvm::raw_ostream::SAVEDCOLOR; + awarzynski wrote: > sameeranjoshi wrote: > > Unless Flang is not changing

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

sameeranjoshi added a comment. Thanks for working on it. Few comments inline: 1. For an out-of-tree build, I see `check-flang` target failing with /unittests/Frontend/CompilerInstanceTest.cpp:17:10: fatal error: filesystem: No such file or directory #include ^~~~ I

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

sameeranjoshi accepted this revision. sameeranjoshi added a comment. Thank you for changes. I was able to build successfully out-of-tree. Please update the `README.md` with the necessary changes. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

sameeranjoshi requested changes to this revision. sameeranjoshi added a comment. Thanks for working on it. A few review comments/questions on changes in `flang` part from the patch. Comment at: flang/include/flang/Frontend/CompilerInstance.h:93 + + static

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

sameeranjoshi added a comment. Thanks for the work. A couple of comments on `clang/` related changes: An `out-of-tree` build with this patch fails for me: Here's what I did: I initially used `ENABLE_PROJECTS="clang;mlir"` to build `llvm-project`, I didn't build `flang` during this run. Then I