[PATCH] D118169: [NFC][CodeGen] Use llvm::DenseMap for DeferredDecls

serge-sans-paille added a comment. The change looks fine to me. I've started a set of benchmark to make sure it provides the expected speedup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118169/new/ https://reviews.llvm.org/D118169

[PATCH] D117296: Document several clang-supported builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6cacd420a1d7: Document several clang-supported builtins (authored by serge-sans-paille). Changed prior to commit:

[PATCH] D117296: Document several clang-supported builtins

serge-sans-paille updated this revision to Diff 400080. serge-sans-paille marked 8 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117296/new/ https://reviews.llvm.org/D117296 Files: clang/docs/LanguageExtensions.rst Index: clang/docs/LanguageExtensions.rst

[PATCH] D117296: Document several clang-supported builtins

serge-sans-paille created this revision. serge-sans-paille added reviewers: aaron.ballman, rsmith. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Namely __builtin_alloca __builtin_alloca_with_align

[PATCH] D112913: Misleading bidirectional detection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35cca45b09b8: Misleading bidirectional detection (authored by serge-sans-paille). Changed prior to commit:

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille added a comment. In D112913#3233699 , @upsuper wrote: > I'd like to clarify that what I think is correct now is the algorithm to > detect unclosed explicit formatting scopes in a given string. Thanks for confirming. This check only

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille added a comment. @MaskRay any blocker on that new version now that it recieved a green light from @upsuper? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 ___ cfe-commits mailing

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2cc6c2d0c2f: Use a sorted array instead of a map to store AttrBuilder string attributes (authored by serge-sans-paille). Herald added a subscriber:

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille updated this revision to Diff 398195. serge-sans-paille added a comment. rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille added a comment. Note that if there's a consensus on it, I can implement LRM character support. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 ___ cfe-commits mailing list

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille added a comment. @aaron.ballman unfortunately I don't know any of those. If I recall correctly we found no software in the RedHat collection actually using those control characters :-/ My understanding is that we are inline with the document you mention, except the fact that

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille added a comment. Thanks @upsuper! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille updated this revision to Diff 397885. serge-sans-paille added a comment. rebased on main branch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

serge-sans-paille updated this revision to Diff 397831. serge-sans-paille added a comment. Minor updates CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116599/new/ https://reviews.llvm.org/D116599 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille updated this revision to Diff 397813. serge-sans-paille added a comment. Fix some parts of the bidi algorithm, and add extra test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 Files:

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille added a comment. @upsuper I've not added extra test cases yet, but does it looks it's heading in the right direction? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 ___

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille updated this revision to Diff 397597. serge-sans-paille added a comment. Update bidi algorithm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

serge-sans-paille updated this revision to Diff 397486. serge-sans-paille added a comment. Take advice into account CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116599/new/ https://reviews.llvm.org/D116599 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D116598: Document __builtin_trap and __builtin_debugtrap

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG491984c4e60c: Document __builtin_trap and __builtin_debugtrap (authored by serge-sans-paille). Herald added a project: clang. Herald added a

[PATCH] D115798: Provide SmallAttrBuilder as a lightweight alternative to AttrBuilder

serge-sans-paille abandoned this revision. serge-sans-paille added a comment. Obsoleted by https://reviews.llvm.org/D116599 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115798/new/ https://reviews.llvm.org/D115798 ___ cfe-commits mailing

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

serge-sans-paille updated this revision to Diff 397298. serge-sans-paille added a comment. upload correct patch version CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116599/new/ https://reviews.llvm.org/D116599 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

serge-sans-paille created this revision. serge-sans-paille added reviewers: nikic, rnk, dexonsmith. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, ormris, dcaballe, cota, teijeong, rdzhabarov, tatianashp, jdoerfert, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb,

[PATCH] D116110: Introduce the AttributeMask class

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9290ccc3c1a1: Introduce the AttributeMask class (authored by serge-sans-paille). Changed prior to commit:

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille updated this revision to Diff 397225. serge-sans-paille added a comment. rebased on main branch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/ https://reviews.llvm.org/D116110 Files: clang/lib/CodeGen/CodeGenModule.cpp llvm/include/llvm/IR/Argument.h

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille updated this revision to Diff 395713. serge-sans-paille added a comment. Remove `empty()` method and only keep `hasAttributes` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/ https://reviews.llvm.org/D116110 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments. Comment at: llvm/include/llvm/IR/Attributes.h:993 + + bool empty() const { return Attrs.none(); } + bool hasAttributes() const { return TargetDepAttrs.empty() && Attrs.none(); }

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille updated this revision to Diff 395694. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/ https://reviews.llvm.org/D116110 Files: clang/lib/CodeGen/CodeGenModule.cpp llvm/include/llvm/IR/Argument.h llvm/include/llvm/IR/Attributes.h

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille updated this revision to Diff 395692. serge-sans-paille added a comment. Herald added subscribers: foad, kerbowa, nhaehnle, jvesely, arsenm. remvove useless assert, update comment, fix build CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille updated this revision to Diff 395677. serge-sans-paille added a comment. Minor nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/ https://reviews.llvm.org/D116110 Files: clang/lib/CodeGen/CodeGenModule.cpp llvm/include/llvm/IR/Argument.h

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille created this revision. serge-sans-paille added reviewers: nikic, rnk. Herald added subscribers: ormris, dexonsmith, jdoerfert, hiraditya. serge-sans-paille requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D115798: Provide SmallAttrBuilder as a lightweight alternative to AttrBuilder

serge-sans-paille added inline comments. Comment at: llvm/include/llvm/IR/Attributes.h:974 + SmallVector EnumAttrs; + SmallVector StringAttrs; + using iterator = typename SmallVector::iterator; nikic wrote: > Just wondering if storing both in one vector would

[PATCH] D115798: Provide SmallAttrBuilder as a lightweight alternative to AttrBuilder

serge-sans-paille added a comment. Actual benchmarks: https://llvm-compile-time-tracker.com/compare.php?from=7d97678df7f514c14b7611447dad02e9cc5168c9=f39a39e09e8f4f3b7dc94e4d23d9acfbf36ab2e5=instructions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115798/new/

[PATCH] D115798: Provide SmallAttrBuilder as a lightweight alternative to AttrBuilder

serge-sans-paille updated this revision to Diff 394542. serge-sans-paille added a comment. Leverage the fact that AttributeSet nodes are already sorted CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115798/new/ https://reviews.llvm.org/D115798 Files:

[PATCH] D115798: Provide SmallAttrBuilder as a lightweight alternative to AttrBuilder

serge-sans-paille added a comment. My plan mid-term plan would be to rename `AttrBuilder` into `AttrQuery` at some point, and use `SmallAttrBuilder` as the actual `AttrBuilder` in most places. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille added a comment. Update: the strategy used by ``AttrBuilder`` might not be the best way to build new attributes. I've proposed an alternative implementation in https://reviews.llvm.org/D115798. This is somehow orthogonal to that patch, but it removes the need for temporary

[PATCH] D115798: Provide SmallAttrBuilder as a lightweight alternative to AttrBuilder

serge-sans-paille created this revision. serge-sans-paille added reviewers: nikic, dblaikie, rnk. Herald added subscribers: dexonsmith, jdoerfert, mgrang, hiraditya. serge-sans-paille requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille updated this revision to Diff 393058. serge-sans-paille added a comment. Use a DenseSet instead of a DenseMap to store the StringPool. Some benchmark feedback (using a release build compiled with LTO), in number of instructions | | sqlite3.c -c -O0 | sqlite3.c -S

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille added a comment. *comment removed, I've been doing more detailed benchmark that imply a rework of the patch* CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114394/new/ https://reviews.llvm.org/D114394 ___ cfe-commits

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille added a comment. > Frontends not written in C++ will always be going through the > AttributeKey::get() API, which will be slower than the initial state (I think > -- we still have to calculate the hash dynamically, but now we also need to > intern an AttributeKey by

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille added a comment. Gentle ping :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114394/new/ https://reviews.llvm.org/D114394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114082: [WIP] Normalize String Attributes

serge-sans-paille added a comment. In D114082#3149631 , @rnk wrote: >> it is possible to list all internal keys in one place > > I think one of the original goals of adding support for string attributes > (maybe @void will give some input) was

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille marked an inline comment as done. serge-sans-paille added inline comments. Comment at: llvm/include/llvm/IR/Attributes.h:79 + bool operator<(AttributeKey const ) const { +return strcmp(value_, other.value_) < 0; + } JonChesterfield wrote:

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille updated this revision to Diff 389463. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114394/new/ https://reviews.llvm.org/D114394 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille updated this revision to Diff 389437. serge-sans-paille marked 6 inline comments as done. serge-sans-paille added a comment. Use CachedHashStringRef as suggested by @MaskRay CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114394/new/ https://reviews.llvm.org/D114394

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille updated this revision to Diff 389187. serge-sans-paille added a comment. Remove static Dict and replace it by a dict attached to LLVMContext. Some early benchmarks, on the SQLite amalgamation, through ` valgrind --tool=callgrind ./bin/clang -c -o/dev/null sqlite3.c`

[PATCH] D114082: [WIP] Normalize String Attributes

serge-sans-paille added a comment. This diff is indeed very large. I reworked it in https://reviews.llvm.org/D114394 to capture the essence of it, on which we could then rebase this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114082/new/

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille created this revision. serge-sans-paille added reviewers: dblaikie, nikic. Herald added subscribers: ormris, dexonsmith, wenlei, okura, jdoerfert, kuter, haicheng, hiraditya, eraman. serge-sans-paille requested review of this revision. Herald added a reviewer: jdoerfert. Herald

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille added a comment. Gentle ping @MaskRay and/or @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114229: [clang][driver] Always add LTO options when using GNU toolchain

serge-sans-paille added subscribers: rsmith, serge-sans-paille. serge-sans-paille added a comment. Gentle ping @MaskRay and/or @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114229/new/ https://reviews.llvm.org/D114229

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille updated this revision to Diff 388425. serge-sans-paille added a comment. Nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille added a comment. Patch rebased on main, all comments addressed. Looks good? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille updated this revision to Diff 388424. serge-sans-paille added a comment. Rebase on main branch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D114082: [WIP] Normalize String Attributes

serge-sans-paille added a comment. This is a WIP, to start the discussion. I've only turned on the X86 backend. Otherwise should be functional. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114082/new/ https://reviews.llvm.org/D114082

[PATCH] D112914: Misleading identifier detection

serge-sans-paille added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-misleading-identifier.cpp:3 + +#include + RKSimon wrote: > @serge-sans-paille Any chance you can remove the include and just forward > declare printf()? Sure,

[PATCH] D112914: Misleading identifier detection

serge-sans-paille added a comment. In D112914#3119704 , @thakis wrote: > The test seems to trigger an assert: http://45.33.8.238/linux/60293/step_9.txt > > Please take a look! It's getting late here: Reverted, I'll have a look tomorrow. Repository:

[PATCH] D112914: Misleading identifier detection

serge-sans-paille added a comment. Yep, I'm currently validating locally, I somehow messed up a rebase :-/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914 ___

[PATCH] D112914: Misleading identifier detection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG299aa4dfa1d8: Misleading unicode identifier detection pass (authored by serge-sans-paille). Changed prior to commit:

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille updated this revision to Diff 384854. serge-sans-paille added a comment. Portable `confusable.txt` parsing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https://reviews.llvm.org/D112916 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille updated this revision to Diff 384694. serge-sans-paille added a comment. Update doc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https://reviews.llvm.org/D112916 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille updated this revision to Diff 384687. serge-sans-paille added a comment. - Add documentation and changelog entry - Formatting / renaming nits - Some extra test cases - Check scope intersection in both orders CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.cpp:59 +// If conversion fails, utf-8 is designed so that we can just try next char. +if (Result != llvm::conversionOK) { + ++CurPtr;

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille added a comment. In D112916#3102767 , @serge-sans-paille wrote: > @tonic / @tstellar as members of the LLVM fundation board, can you tell us if > it's okay to ship the `confusables.txt` file from >

[PATCH] D112914: Misleading identifier detection

serge-sans-paille updated this revision to Diff 384381. serge-sans-paille added a comment. Fix comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D112914: Misleading identifier detection

serge-sans-paille updated this revision to Diff 384118. serge-sans-paille added a comment. Minor typos CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille updated this revision to Diff 384111. serge-sans-paille added a comment. - recover from failed utf8 decoding - doc and release note updated - clang-formatting - more examples / testing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/

[PATCH] D112914: Misleading identifier detection

serge-sans-paille added a comment. In D112914#3102728 , @carlosgalvezp wrote: > Ok! I don't really know what applies when you take //part// of a file, so > I'll leave that up to people who know. I don't know how to remove the > "Requested changes"

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille added subscribers: tonic, tstellar. serge-sans-paille added a comment. @tonic / @tstellar as members of the LLVM fundation board, can you tell us if it's okay to ship the `confusables.txt` file from https://www.unicode.org/Public/security/latest/confusables.txt and what are

[PATCH] D112914: Misleading identifier detection

serge-sans-paille added a comment. AKAIU, the licensing issue doesn't impact that particular review, only the one on confusable identifiers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914 ___

[PATCH] D112914: Misleading identifier detection

serge-sans-paille updated this revision to Diff 384020. serge-sans-paille added a comment. Update release note too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D112914: Misleading identifier detection

serge-sans-paille updated this revision to Diff 384017. serge-sans-paille added a comment. Also update clang-tidy doc index CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D112914: Misleading identifier detection

serge-sans-paille updated this revision to Diff 384006. serge-sans-paille added a comment. - fix formatting - added documentation - *not* doing the extra work wrt. unicode error recovery CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914 Files:

[PATCH] D112059: Fix inline builtin handling in case of redefinition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6bfc85c217e4: Fix inline builtin handling in case of redefinition (authored by serge-sans-paille). Changed prior to commit:

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille created this revision. Herald added subscribers: carlosgalvezp, mgrang, mgorny. serge-sans-paille requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This patch implements detection of confusable identifiers

[PATCH] D112914: Misleading identifier detection

serge-sans-paille created this revision. Herald added subscribers: carlosgalvezp, mgorny. serge-sans-paille requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Detect identifiers with right-to-left ordering through clang-tidy. It

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille created this revision. Herald added subscribers: carlosgalvezp, mgorny. serge-sans-paille requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This patch implements detection of incomplete bidirectional sequence

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille updated this revision to Diff 383241. serge-sans-paille added a comment. Re-uploading previous version that walks redef, with a slight change in the walking algorithm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112059/new/ https://reviews.llvm.org/D112059 Files:

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille added a comment. I second @aaron.ballman there. I compiled the sqlite3.c amalgamation, -O0, with both approach, measuring the number of instructions as gathered by `valgrind --tool=callgrind` - when walking redecls:9001630039 instructions, I changed the

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

serge-sans-paille added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3822 +def DiagnoseAs : InheritableAttr { + let Spellings = [Clang<"diagnose_as">]; + let Args = [ExprArgument<"Function">, aaron.ballman wrote: > george.burgess.iv wrote: >

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille added inline comments. Comment at: clang/test/CodeGen/user-func-gnu-inline-redecl.c:20 + return some_size(s); +} nickdesaulniers wrote: > this test passes before this patch is applied; I wonder if we have existing > coverage in tree for this

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille updated this revision to Diff 382671. serge-sans-paille added a comment. - Use a FunctionDecl Attribute to store the shadowed inline redecl status CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112059/new/ https://reviews.llvm.org/D112059 Files:

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille updated this revision to Diff 382344. serge-sans-paille added a comment. Formatting nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112059/new/ https://reviews.llvm.org/D112059 Files: clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille updated this revision to Diff 382337. serge-sans-paille added a comment. - Add a test case to ensure we keep the right behavior for non-intrinsic gnu inline - walk the redecl chain before doing an extra string alloc CHANGES SINCE LAST ACTION

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille updated this revision to Diff 381014. serge-sans-paille added a comment. Avoid walking redecls CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112059/new/ https://reviews.llvm.org/D112059 Files: clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille updated this revision to Diff 381011. serge-sans-paille added a comment. Reduce the number of time we would walk redecls. Simplify test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112059/new/ https://reviews.llvm.org/D112059 Files:

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

serge-sans-paille added a comment. https://reviews.llvm.org/D112059 should address the issue pointed by @manojgupta and @nickdesaulniers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111009/new/ https://reviews.llvm.org/D111009

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille created this revision. serge-sans-paille added reviewers: nickdesaulniers, manojgupta. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Basically, inline builtin definition are shadowed by externally

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. In D109967#3044464 , @rnk wrote: > Thanks for doing this, this approach looks like it incorporated my feedback > on the previous approach. Yeah, listened to the wise men... and struggled a lot doing so ;-)

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f0e31cf511d: Update inline builtin handling to honor gnu inline attribute (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D111009?vs=376812=377023#toc Repository:

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

serge-sans-paille updated this revision to Diff 376812. serge-sans-paille added a comment. + extra test case + use internal linkage instead of available_externally linkage for generated clone CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111009/new/ https://reviews.llvm.org/D111009

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

serge-sans-paille updated this revision to Diff 376794. serge-sans-paille added a comment. + fix linkage of generated function CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111009/new/ https://reviews.llvm.org/D111009 Files: clang/lib/AST/Decl.cpp clang/lib/CodeGen/CGExpr.cpp

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

serge-sans-paille updated this revision to Diff 376790. serge-sans-paille added a comment. + extra test case + avoid Playing with Twines + fix storage of external declaration of inline builtins + minor nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111009/new/

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

serge-sans-paille created this revision. serge-sans-paille added reviewers: kees, nickdesaulniers. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per the GCC info page: If the function is declared 'extern', then this

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. And on Windows: http://45.33.8.238/win/46077/summary.html ! Thanks for pointing those. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/ https://reviews.llvm.org/D109967

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @thakis: fine on OSX: http://45.33.8.238/macm1/18808/summary.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/ https://reviews.llvm.org/D109967 ___

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @thakis if rG1ecb1bc3e214 doesn't work, I'll revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @kda : thanks for the builbot reference. The issue you're pointing at occurs *before* bd379915de38a9af3d65e19075a6a64ebbb8d6db which specifically fixes the issue spotted by the buildbot.

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. for the record: I had to apply that extra patch: bd379915de38a9af3d65e19075a6a64ebbb8d6db which enforces the `always_inline` attribute Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @kees great, thanks for confirming - I just landed the patch. Can you share a pointer to the missing pieces? I'm interested in implemented the missing parts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109967: Simplify handling of builtin with inline redefinition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d6f49a56995: Simplify handling of builtin with inline redefinition (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D110521: Make analyze-cc path discovery sensible to symlinks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe45f67f31e22: Make analyze-cc path discovery sensible to symlinks (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES

<    1   2   3   4   5   6   7   8   9   >