[PATCH] D82767: clang-format: Explicitly use python3

serge-sans-paille added a comment. >> My understanding is that explicitly requiring python3 may make sense if the >> script is not backward-compatible with python2, while requiring python means >> the version is not important. >> At the end-of-year, we should be able to harmonize shebangs to

[PATCH] D82767: clang-format: Explicitly use python3

serge-sans-paille added a comment. In D82767#2132903 , @MyDeveloperDay wrote: > We may not be consistent across all of LLVM > > $ find . -name '*.py' -print -exec /usr/bin/head -2 {} \; | grep "#!" | > sort | uniq -c > 6 #! /usr/bin/env python

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

serge-sans-paille added inline comments. Comment at: compiler-rt/test/profile/Inputs/instrprof-dlopen-dlclose-main.c:49 dlerror(); - void (*gcov_flush1)() = (void (*)())dlsym(f1_handle, "__gcov_flush"); - if (gcov_flush1 == NULL) { -fprintf(stderr, "unable to find

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

serge-sans-paille added a comment. Some nit-picking, lgtm otherwise. Please wait for @calixte review though :-) Comment at: compiler-rt/test/profile/Inputs/instrprof-dlopen-dlclose-main.c:49 dlerror(); - void (*gcov_flush1)() = (void (*)())dlsym(f1_handle, "__gcov_flush");

[PATCH] D82291: Make it possible for client code to consume CLANG_LINK_CLANG_DYLIB

This revision was automatically updated to reflect the committed changes. Closed by commit rG05c479491c1d: Make it possible for client code to consume CLANG_LINK_CLANG_DYLIB (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. In D79961#2065605 , @alanphipps wrote: > It looks like clang/test/Profile/Inputs/c-general.profdata.v5 is being read > as v6 rather than v5. Can you double check? Thanks for spotting the issue. Should be fixed by

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. In D79961#2065605 , @alanphipps wrote: > It looks like clang/test/Profile/Inputs/c-general.profdata.v5 is being read > as v6 rather than v5. Can you double check? Yep, I'll have a look. Repository: rG LLVM Github

[PATCH] D79961: [PGO] Fix computation of fuction Hash

This revision was automatically updated to reflect the committed changes. Closed by commit rGde02a75e3984: [PGO] Fix computation of function Hash (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D79961?vs=266188=266441#toc Repository: rG LLVM Github

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 266188. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Update version bump parts CHANGES SINCE LAST ACTION

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 266184. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/CodeGenPGO.cpp clang/test/Profile/Inputs/c-counter-overflows.proftext

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. @hans updated! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 266133. serge-sans-paille added a comment. With v3 version + Make cast explicit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 Files: clang/docs/ReleaseNotes.rst

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 266072. serge-sans-paille added a comment. Bump the version number to be compatible with existing profdata, in a similar fashion to v1/v2 transition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. @hans/ @MaskRay I'm starting to wonder if I should bump the version number of the hash function, so that clang could still read profile data generated before that patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 266064. serge-sans-paille added a comment. Update profile data hash entries due to hash function update, unless the version used is V1, in which case we keep the buggy behavior for backward compatibility. CHANGES SINCE LAST ACTION

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille reopened this revision. serge-sans-paille added a subscriber: bkramer. serge-sans-paille added a comment. This revision is now accepted and ready to land. @bkramer rightfully reverted this, faster than I could patch it :-) Here is the patch though, with the updated test case.

[PATCH] D79961: [PGO] Fix computation of fuction Hash

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c298c104bfe: [PGO] Fix computation of function Hash (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. Up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. > May I ask how you found this? This was a long (and painful) quest when tracking https://bugzilla.redhat.com/show_bug.cgi?id=1827282 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 264552. serge-sans-paille edited the summary of this revision. serge-sans-paille added a comment. Updated summary + removed namespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 264084. serge-sans-paille added a comment. Update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 Files: clang/lib/CodeGen/CodeGenPGO.cpp

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille created this revision. serge-sans-paille added reviewers: dexonsmith, zturner. serge-sans-paille added a project: clang. Herald added a subscriber: cfe-commits. Previous implementation was incorrectly passing an integer, that got converted to a pointer, to finalize the hash

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille added a comment. The patch landed without much errors, only added the patchset e307eeba0137700e75893089cf0de03383d851ca Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78477: [profile] Don't crash when forking in several threads

serge-sans-paille added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp:697 +Builder.CreateCall(WriteoutF); +if (NextInst != Parent->end()) { + DebugLoc Loc = E->getDebugLoc(); I'm puzzled by this test. ``F`` is a

[PATCH] D78192: Support compiler extensions as a normal component

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f766e382b77: Update compiler extension integration into the build system (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D78192?vs=259495=259827#toc Repository:

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille updated this revision to Diff 259495. serge-sans-paille added a comment. Fix dependency order for extension libraries, as spotted by @Meinersbur CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78192/new/ https://reviews.llvm.org/D78192 Files:

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille added a comment. In D78192#1997698 , @Meinersbur wrote: > Is this ready to try out? It is! > > > In D78192#1996859 , > @serge-sans-paille wrote: > >> Note that this should solve in an

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille added a comment. Note that this should solve in an elegant (?) way the multiple link errors found when linking clang with LLVM_DYLIB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78192/new/ https://reviews.llvm.org/D78192

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille added a comment. @Meinersbur with the latest updat, it should also be compatible with https://github.com/intel/opencl-clang/blob/83837744ef076c1285ed2ee9349febc2208d3252/CMakeLists.txt#L266 as all contains the `Extensions` component. Repository: rG LLVM Github Monorepo

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille updated this revision to Diff 259284. serge-sans-paille added a comment. Herald added subscribers: cfe-commits, dang, dexonsmith, steven_wu, hiraditya. Herald added a project: clang. Instead of linking all compiler extensions to the different possible tagets (clang, opt lto

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille added a comment. In D71082#1958597 , @manojgupta wrote: > Yes, it'd be nice if all of the FORTIFY handling can be improved. For a > simple call like memcpy of 8 bytes in the example, there is no reason to emit > all these stack/range

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille added a comment. @manojgupta prior to this patch, clang was using its version of `memcpy` and not the one provided inline. I slightly modified your reproducer to showcase that aspect: https://godbolt.org/z/NmxC0v Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration

serge-sans-paille added a comment. @modocache: fixed by 8d019cda851a1031fbce3c50be0975438147f11d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75579/new/

[PATCH] D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration

serge-sans-paille added a comment. @modocache : thanks for the heads up, I'm investigating the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75579/new/ https://reviews.llvm.org/D75579 ___

[PATCH] D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration

This revision was automatically updated to reflect the committed changes. Closed by commit rGac1d23ed7de0: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime… (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D75579?vs=250631=250747#toc

[PATCH] D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration

serge-sans-paille updated this revision to Diff 250631. serge-sans-paille added a comment. Renamed registration constructor to use a more llvm-ish name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75579/new/ https://reviews.llvm.org/D75579

[PATCH] D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration

serge-sans-paille added a comment. @MaskRay no longer a WIP ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75579/new/ https://reviews.llvm.org/D75579 ___ cfe-commits mailing list

[PATCH] D75579: [WIP] Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries

serge-sans-paille added a comment. @MaskRay gentle up :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75579/new/ https://reviews.llvm.org/D75579 ___ cfe-commits mailing list

[PATCH] D75579: [WIP] Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries

serge-sans-paille added a comment. @MaskRay are you ok with that version? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75579/new/ https://reviews.llvm.org/D75579 ___ cfe-commits mailing list

[PATCH] D75579: [WIP] Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries

serge-sans-paille added a comment. @MaskRay > because that will cause duplicate registration of llvm::cl::opt flags. Not with this setup, if I'm not mistaken: the static registration is triggered by the static variables inside the constructor call, and if I'm not mistaken, initialization of

[PATCH] D75579: [WIP] Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries

serge-sans-paille updated this revision to Diff 249378. serge-sans-paille added a comment. Cleaned up code, using a few macros to avoid duplication. No longer a WIP Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75579/new/

[PATCH] D75579: [WIP] Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries

serge-sans-paille updated this revision to Diff 249109. serge-sans-paille added a comment. @MaskRay The library version prooved to be a bad path: we wanted clang-cpp to always link to a shared library, which interacts in ungraceful ways with BUILD_SHARED_LIBS. This is another attempt that

[PATCH] D75579: [WIP] Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries

serge-sans-paille updated this revision to Diff 248328. serge-sans-paille added a comment. This passes the following configurations: -DLLVM_ENABLE_PROJECTS='clang;clang-tools-extra;lld' -DBUILD_SHARED_LIBS=on -DLLVM_LINK_LLVM_DYLIB=off -DCLANG_LINK_CLANG_DYLIB=off

[PATCH] D75579: [WIP] Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries

serge-sans-paille updated this revision to Diff 248130. serge-sans-paille added a comment. Fix lto-test bugs + convert more files, still not ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75579/new/ https://reviews.llvm.org/D75579

[PATCH] D75579: [WIP] Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries

serge-sans-paille created this revision. serge-sans-paille added reviewers: MaskRay, tstellar. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, gbedwell, aheejin, hiraditya, mgorny, dschuff. Herald added a reviewer: JDevlieghere. Herald added a reviewer: andreadb.

[PATCH] D75057: Syndicate, test and fix base64 implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a1958f2673f: Syndicate, test and fix base64 implementation (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille marked 3 inline comments as done. serge-sans-paille added inline comments. Comment at: llvm/unittests/Support/Base64Test.cpp:30 + // from: https://tools.ietf.org/html/rfc4648#section-10 + TestBase64("", ""); + TestBase64("f", "Zg=="); hokein

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille updated this revision to Diff 247039. serge-sans-paille added a comment. Add a test case that exhibits the overflow in previous implementation + minor nits from @hokein Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille added a comment. In D75057#1895550 , @hokein wrote: > thanks for doing this! didn't look into details yet. Could you explain what > was the bug in the previous code? Yeah, the code was using + operator instead of | to combine the

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille added a comment. Up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

serge-sans-paille abandoned this revision. serge-sans-paille added a comment. Obsoleted by https://reviews.llvm.org/D74878 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74871/new/ https://reviews.llvm.org/D74871

[PATCH] D74704: Support -fuse-ld=lld for riscv

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGe058667a2e01: Support -fuse-ld=lld for riscv (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

serge-sans-paille added a comment. Nice work, LGTM too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/ https://reviews.llvm.org/D74878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille updated this revision to Diff 246290. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp compiler-rt/lib/fuzzer/FuzzerUtil.cpp

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille updated this revision to Diff 246279. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp compiler-rt/lib/fuzzer/FuzzerUtil.cpp

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille updated this revision to Diff 246248. serge-sans-paille added a comment. Other copy/paste typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files:

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille removed a reviewer: lebedev.ri. serge-sans-paille added a comment. As a side note, pre-reserving the buffer size gives interesting speedup, see http://quick-bench.com/Lp6OwO2etW1YEmJayVWn3U8JDiY Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille updated this revision to Diff 246243. serge-sans-paille added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files:

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille updated this revision to Diff 246240. serge-sans-paille added a comment. Restore duplication, fix the bug in two separate locations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files:

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

serge-sans-paille added a comment. In D74878#1889460 , @jeroen.dobbelaere wrote: > Will this also give a warning when passing a .ll file to a release clang, > without explicitly passing the '-fdiscard-value-names' ? Is this what we > want it to be ?

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille created this revision. serge-sans-paille added reviewers: jvikstrom, george.karpenkov. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, usaxena95, kadircet, arphaman, jkorous, mgorny. Herald added projects: clang, Sanitizers, LLVM. As an answer to

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

serge-sans-paille added a comment. Let's go that way then. @xur I leave it to you to add the appropriate warning at least on the clang side? Feel free to just use the code from https://reviews.llvm.org/D74871?id=245594. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille updated this revision to Diff 245805. serge-sans-paille added a comment. Add a configure feature test to filter out tests that depend on platform linker, as hinted by @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille added a comment. For the record: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4749/steps/test-check-clang/logs/FAIL%3A%20Clang%3A%3Ariscv64-toolchain.c fails Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

serge-sans-paille added a comment. @lebedev.ri maybe we should at least warn the user if there was a flag at clang level to force discarding? That's what I've been doing in https://reviews.llvm.org/D74871?id=245594 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

serge-sans-paille updated this revision to Diff 245606. serge-sans-paille added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Other approach to the problem: modify `Value::SetNameImpl` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

serge-sans-paille updated this revision to Diff 245594. serge-sans-paille added a comment. Finally, the test case :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74871/new/ https://reviews.llvm.org/D74871 Files:

[PATCH] D74757: Fix compiler extension in standalone mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a0f6e699bb6: Fix compiler extension in standalone mode (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74757/new/

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

serge-sans-paille added a comment. In D74871#1883884 , @EricWF wrote: > Why is this not a bug in w/e is handling the IR? It may totally be. Consider this review as a way to start the discussion. The problem, as it appears, is triggered when some value

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

serge-sans-paille updated this revision to Diff 245578. serge-sans-paille added a comment. Added test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74871/new/ https://reviews.llvm.org/D74871 Files:

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

serge-sans-paille created this revision. serge-sans-paille added reviewers: EricWF, mehdi_amini. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without that patch, the test case associated to this patch segfaults in Release mode. This also makes the llvm-test-suite build

[PATCH] D74757: Fix compiler extension in standalone mode

serge-sans-paille updated this revision to Diff 245327. serge-sans-paille added a comment. Take @Meinersbur review into account. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74757/new/ https://reviews.llvm.org/D74757 Files:

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille added a comment. Reverted through b8bea9346af4f2644c9a1bd29710c5e3efbbd7d3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/new/

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille added a comment. I'll revert and propose an updated patch then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/new/ https://reviews.llvm.org/D74704 ___ cfe-commits mailing list

[PATCH] D74757: Fix compiler extension in standalone mode

serge-sans-paille added a comment. Tested without standalone build with polly linked statically and dynamically with success. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74757/new/ https://reviews.llvm.org/D74757

[PATCH] D74757: Fix compiler extension in standalone mode

serge-sans-paille added a comment. I still need to test many configurations, I'll report here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74757/new/ https://reviews.llvm.org/D74757 ___ cfe-commits

[PATCH] D74757: Fix compiler extension in standalone mode

serge-sans-paille created this revision. serge-sans-paille added reviewers: Meinersbur, Keruspe. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. serge-sans-paille added a comment. I still need to test many configurations, I'll report here. Use a

[PATCH] D74704: Support -fuse-ld=lld for riscv

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd230142d8a0: Support -fuse-ld=lld for riscv (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/new/

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille updated this revision to Diff 244943. serge-sans-paille added a comment. Add test case. This test fails with current master, see https://bugzilla.redhat.com/show_bug.cgi?id=1803698 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille created this revision. serge-sans-paille added a reviewer: asb. Herald added subscribers: cfe-commits, evandro, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng,

[PATCH] D74602: Fix standalone build interaction with compiler extension

This revision was automatically updated to reflect the committed changes. Closed by commit rG87dac7da68ea: Fix standalone build interaction with compiler extension (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74602: Fix standalone build interaction with compiler extension

serge-sans-paille created this revision. serge-sans-paille added reviewers: Keruspe, hans, Meinersbur. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. As suggested in https://github.com/llvm/llvm-project/issues/120, don't try to generate the

[PATCH] D74464: Fix integration of pass plugins with llvm dylib

This revision was automatically updated to reflect the committed changes. Closed by commit rGd21664cce1db: Fix integration of pass plugins with llvm dylib (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74464/new/

[PATCH] D74385: [ARCMT][NFC] Reduce #include dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit rG53fba65d2204: [ARCMT][NFC] Reduce #include dependencies (authored by nicolas17, committed by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74385: [ARCMT][NFC] Reduce #include dependencies

serge-sans-paille added a comment. In D74385#1869876 , @nicolas17 wrote: > I don't have commit access, can someone push this for me? Sure, can you just confirm that you're this guy: https://github.com/nicolas17 (I need that for proper email

[PATCH] D74464: Fix integration of pass plugins with llvm dylib

serge-sans-paille updated this revision to Diff 244150. serge-sans-paille edited the summary of this revision. serge-sans-paille added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Totally different, and much cleaner approach of the issue. Repository: rG

[PATCH] D74385: [ARCMT][NFC] Reduce #include dependencies

serge-sans-paille added a comment. LGTM, as long as it builds fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74385/new/ https://reviews.llvm.org/D74385 ___ cfe-commits mailing list

[PATCH] D73865: [CodeGenModule] Assume dso_local for -fpic -fno-semantic-interposition

serge-sans-paille added inline comments. Herald added a subscriber: miyuki. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:871 if (!Var->isThreadLocal() && -(RM == llvm::Reloc::Static || CGOpts.PIECopyRelocations)) +(RM == llvm::Reloc::Static || (LOpts.PIE

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. For the record: tests have been updated, option handling cleaned up and expansive check failure fixed in commit e67cbac81211d40332a79d98c9d5953624cc1202 . Repository: rG LLVM Github

[PATCH] D74129: Prefer __vector over vector keyword for altivec use

This revision was automatically updated to reflect the committed changes. Closed by commit rG3185c30c54d0: Prefer __vector over vector keyword for altivec (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D74129?vs=242902=243641#toc Repository: rG LLVM

[PATCH] D74129: Prefer __vector over vector keyword for altivec use

serge-sans-paille added a comment. > Do you know why it's started failing now? Not quite, probably a gcc update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74129/new/ https://reviews.llvm.org/D74129

[PATCH] D68720: Support -fstack-clash-protection for x86

This revision was automatically updated to reflect the committed changes. Closed by commit rG39f50da2a357: Support -fstack-clash-protection for x86 (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D68720?vs=240844=243101#toc Repository: rG LLVM Github

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a subscriber: hans. serge-sans-paille added a comment. I would love too, @hans what do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720

[PATCH] D74129: Prefer __vector over vector keyword for altivec use

serge-sans-paille created this revision. serge-sans-paille added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. serge-sans-paille added a subscriber: hans. serge-sans-paille added a comment. serge-sans-paille added a reviewer: hans. @hans : clang

[PATCH] D74129: Prefer __vector over vector keyword for altivec use

serge-sans-paille added a subscriber: hans. serge-sans-paille added a comment. @hans : clang 10.0.0rc1 doesn't build on ppc64le in Fedora without that patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74129/new/

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. @craig.topper up :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72829: Implement -fsemantic-interposition

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd09f12f32f5: Implement -fsemantic-interposition (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 241351. serge-sans-paille added a comment. Fix documentation ordering, thank goes to @arichardson for spotting that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 241254. serge-sans-paille added a comment. take @sfertile review into account. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files:

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille added a comment. > As this is user-facing documentation I feel like there should be a slightly > longer explaning what the option does. done! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/

<    1   2   3   4   5   6   7   8   9   >