sbaranga updated this revision to Diff 78541.
sbaranga added a comment.
Update regression tests.
https://reviews.llvm.org/D26858
Files:
docs/UsersManual.rst
lib/Driver/Tools.cpp
test/Driver/aarch64-mgeneral_regs_only.c
Index: lib/Driver/Tools.cpp
sbaranga created this revision.
sbaranga added reviewers: jmolloy, rengolin, t.p.northover.
sbaranga added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
We use the neonasm, cryptoasm, fp-armv8asm and fullfp16asm features
to enable the assembling of instructions that were disabled
sbaranga added a comment.
Thanks, r268047!
Cheers,
Silviu
http://reviews.llvm.org/D19665
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sbaranga added inline comments.
Comment at: include/clang/Basic/arm_neon.td:710-711
@@ -709,2 +709,4 @@
+ def VCVT_F32_F16 : SInst<"vcvt_f32_f16", "wd", "h">;
+}
def VCVT_S32 : SInst<"vcvt_s32", "xd", "fQf">;
Thanks for catching this!
http://reviews.llv
sbaranga updated this revision to Diff 5.
sbaranga added a comment.
Don't change the AArch64 intrinsics and move the test to Sema.
http://reviews.llvm.org/D19665
Files:
include/clang/Basic/arm_neon.td
test/Sema/arm-no-fp16.c
Index: include/clang/Basic/arm_neon.td
==
sbaranga created this revision.
sbaranga added a reviewer: rengolin.
sbaranga added subscribers: t.p.northover, cfe-commits.
Herald added subscribers: rengolin, aemerson.
Conversions between float and half are only available when the
taraget has the half-precision extension. Guard these intrinsics
sbaranga added a comment.
Thanks, r267869!
-Silviu
http://reviews.llvm.org/D18963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sbaranga added inline comments.
Comment at: test/Sema/arm_vfma.c:1
@@ -1,2 +1,2 @@
-// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon
-fsyntax-only -verify %s
+// RUN: %clang_cc1 -triple thumbv7-none-eabi -target-feature +neon
-target-feature +vfp4 -fsyntax-
sbaranga updated this revision to Diff 55018.
sbaranga added a comment.
Address the latest review comments (which means rolling back to the last
change).
http://reviews.llvm.org/D18963
Files:
lib/Basic/Targets.cpp
test/CodeGen/arm-neon-fma.c
test/Preprocessor/arm-acle-6.5.c
test/Sema/a
sbaranga added inline comments.
Comment at: lib/Basic/Targets.cpp:4710
@@ -4709,1 +4709,3 @@
const std::vector &FeaturesVec) const override {
+if (CPU == "")
+ CPU = "generic";
rengolin wrote:
> This change is unrelated and may bring sid
sbaranga added a comment.
A gentle ping?
Cheers,
Silviu
http://reviews.llvm.org/D18963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sbaranga added a comment.
I've updated the patch to fix the defaults when the cpu is not specified.
Renato, Tim, could you have a look at this again please?
Thanks,
Silviu
http://reviews.llvm.org/D18963
___
cfe-commits mailing list
cfe-commits@lis
sbaranga updated this revision to Diff 53409.
sbaranga added a comment.
If no cpu has been passed to the command line, use the generic cpu when
selecting
features/FPU, instead of using an empty string (which is not recognized by the
TargetParser).
http://reviews.llvm.org/D18963
Files:
lib/Ba
sbaranga added inline comments.
Comment at: test/Sema/arm_vfma.c:1
@@ -1,2 +1,2 @@
-// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon
-fsyntax-only -verify %s
+// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon
-target-feature +vfp4 -fsyn
sbaranga updated this revision to Diff 53254.
sbaranga added a comment.
Apply review comments from Renato:
- simplify condition for enabling __ARM_FEATURE_FMA
- use cortex-a7 instead of cortex-a8 for testing since this is a real use case.
http://reviews.llvm.org/D18963
Files:
lib/Basic/Targe
sbaranga added inline comments.
Comment at: lib/Basic/Targets.cpp:4931
@@ -4931,1 +4930,3 @@
+if (ArchVersion >= 7 && (CPUProfile != "M" || CPUAttr == "7EM") &&
+(FPU & VFP4FPU))
Builder.defineMacro("__ARM_FEATURE_FMA", "1");
rengolin wrote:
> I
sbaranga created this revision.
sbaranga added a reviewer: t.p.northover.
sbaranga added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
According to the ACLE spec, "__ARM_FEATURE_FMA is defined to 1 if
the hardware floating-point architecture supports fused floating-point
sbaranga accepted this revision.
sbaranga added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
18 matches
Mail list logo
