[clang] [llvm] [clang][CodeGen][AA] Introduce `!llvm.errno.tbaa` for errno alias disambiguation (PR #125258)

2025-05-29 Thread Nikita Popov via cfe-commits
https://github.com/nikic commented: * The metadata should be documented in LangRef. * We should test linking of two modules with the metadata. Both the case where they match and where they don't (e.g. mixing C and C++). IRLinker::linkNamedMDNodes should be the relevant code. (I do wonder whethe

[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-29 Thread Samarth Narang via cfe-commits
@@ -284,10 +284,7 @@ Example usage for a project using a compile commands database: {UserStylesheets.begin(), UserStylesheets.end()}}; if (Format == "html") { -if (auto Err = getHtmlAssetFiles(argv[0], CDCtx)) { - llvm::errs() << toString(std::move(Err)) << "

[clang] [UBSan][NFC] Move type:*=sanitize handling. (PR #142006)

2025-05-29 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao converted_to_draft https://github.com/llvm/llvm-project/pull/142006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][RootSignature] Metadata generation of RootFlags, RootConstants, RootDescriptors (PR #142010)

2025-05-29 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/142010 >From 34733d6f150360984a01b69ac22313f3bdf4b373 Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Mon, 26 May 2025 21:51:36 + Subject: [PATCH 1/5] nfc: rename matches --- clang/test/CodeGenHLSL/RootSignatur

[clang] [llvm] [HLSL][RootSignature] Metadata generation of RootFlags, RootConstants, RootDescriptors (PR #142010)

2025-05-29 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h

[clang] [llvm] [HLSL][RootSignature] Metadata generation of RootFlags, RootConstants, RootDescriptors (PR #142010)

2025-05-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Finn Plummer (inbelic) Changes Implements metadata generation of a Root Signature from its in-memory representation. This pr handles RootFlags, RootConstants and RootDescriptors. The metadata follows the format described [here](https://g

[clang] 4de69f7 - [OpenACC] Implement ignoring of extension clauses

2025-05-29 Thread via cfe-commits
Author: erichkeane Date: 2025-05-29T11:41:02-07:00 New Revision: 4de69f786e207f3b5269c37df888d23eace674f7 URL: https://github.com/llvm/llvm-project/commit/4de69f786e207f3b5269c37df888d23eace674f7 DIFF: https://github.com/llvm/llvm-project/commit/4de69f786e207f3b5269c37df888d23eace674f7.diff LO

[clang] [llvm] [HLSL][RootSignature] Metadata generation of RootFlags, RootConstants, RootDescriptors (PR #142010)

2025-05-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Finn Plummer (inbelic) Changes Implements metadata generation of a Root Signature from its in-memory representation. This pr handles RootFlags, RootConstants and RootDescriptors. The metadata follows the format described [here](https://

[clang] [llvm] [HLSL][RootSignature] Metadata generation of RootFlags, RootConstants, RootDescriptors (PR #142010)

2025-05-29 Thread Finn Plummer via cfe-commits
https://github.com/inbelic created https://github.com/llvm/llvm-project/pull/142010 Implements metadata generation of a Root Signature from its in-memory representation. This pr handles RootFlags, RootConstants and RootDescriptors. The metadata follows the format described [here](https://git

[clang] [llvm] [HLSL][RootSiganture] Add parsing of new number params in StaticSampler (PR #140291)

2025-05-29 Thread Finn Plummer via cfe-commits
https://github.com/inbelic edited https://github.com/llvm/llvm-project/pull/140291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a926c61 - [HLSL][RootSignature] Add parsing of floats for StaticSampler (#140181)

2025-05-29 Thread via cfe-commits
Author: Finn Plummer Date: 2025-05-29T10:18:07-07:00 New Revision: a926c61cc005a5a37bcb62f0dbd2c18c0baf91d3 URL: https://github.com/llvm/llvm-project/commit/a926c61cc005a5a37bcb62f0dbd2c18c0baf91d3 DIFF: https://github.com/llvm/llvm-project/commit/a926c61cc005a5a37bcb62f0dbd2c18c0baf91d3.diff

[clang] NFCI: [clang][deps] Simplify handling of main TU context hash (PR #141966)

2025-05-29 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida approved this pull request. Makes sense to me. https://github.com/llvm/llvm-project/pull/141966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSan][NFC] Move type:*=sanitize handling. (PR #142006)

2025-05-29 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao edited https://github.com/llvm/llvm-project/pull/142006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSan][NFC] Move type:*=sanitize handling. (PR #142006)

2025-05-29 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao updated https://github.com/llvm/llvm-project/pull/142006 >From c19361a169b18fada7702579cdadde99e4962e83 Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Thu, 29 May 2025 18:19:07 + Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UT

[clang] d93788f - Revert "[Clang][LoongArch] Support target attribute for function" (#141998)

2025-05-29 Thread via cfe-commits
Author: Paul Kirth Date: 2025-05-29T11:26:44-07:00 New Revision: d93788fcbf585e7cd3866b514bad972765b17e8d URL: https://github.com/llvm/llvm-project/commit/d93788fcbf585e7cd3866b514bad972765b17e8d DIFF: https://github.com/llvm/llvm-project/commit/d93788fcbf585e7cd3866b514bad972765b17e8d.diff LO

[clang] [llvm] Revert "[Clang][LoongArch] Support target attribute for function" (PR #141998)

2025-05-29 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/141998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [mlir] [flang] Add support for -mprefer-vector-width= (PR #141380)

2025-05-29 Thread Tarun Prabhu via cfe-commits
tarunprabhu wrote: > Seems ok now: "Changes can be cleanly merged." > > If it's still not available, I may have messed something up on my side. I'll > review the GitHub docs to see if I missed something... It's probably fine, but I'd like to give the buildkites a chance to finish before I mer

[clang] [flang] [mlir] [flang] Add support for -mprefer-vector-width= (PR #141380)

2025-05-29 Thread Cameron McInally via cfe-commits
mcinally wrote: Seems ok now: "Changes can be cleanly merged." If it's still not available, I may have messed something up on my side. I'll review the GitHub docs to see if I missed something... https://github.com/llvm/llvm-project/pull/141380 ___ cf

[clang] [UBSan][NFC] Move =sanitize handling. (PR #142006)

2025-05-29 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao edited https://github.com/llvm/llvm-project/pull/142006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSan][NFC] Move =sanitize handling. (PR #142006)

2025-05-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Qinkun Bao (qinkunbao) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/142006.diff 2 Files Affected: - (modified) clang/lib/AST/ASTContext.cpp (+1-2) - (modified) clang/lib/Basic/NoSanitizeList.cpp (+5-1) `

[clang] [llvm] [clang][CodeGen][AA] Introduce `!llvm.errno.tbaa` for errno alias disambiguation (PR #125258)

2025-05-29 Thread John McCall via cfe-commits
https://github.com/rjmccall edited https://github.com/llvm/llvm-project/pull/125258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSan][NFC] Move =sanitize handling. (PR #142006)

2025-05-29 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao created https://github.com/llvm/llvm-project/pull/142006 None >From c19361a169b18fada7702579cdadde99e4962e83 Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Thu, 29 May 2025 18:19:07 + Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=

[clang] [llvm] [clang][CodeGen][AA] Introduce `!llvm.errno.tbaa` for errno alias disambiguation (PR #125258)

2025-05-29 Thread John McCall via cfe-commits
@@ -1467,6 +1468,17 @@ void CodeGenModule::Release() { } } } + + // Emit `!llvm.errno.tbaa`, a module-level metadata that specifies the TBAA + // for an integer access. rjmccall wrote: ```suggestion // for an int access. This allows LLVM to rea

[clang] [llvm] [clang][CodeGen][AA] Introduce `!llvm.errno.tbaa` for errno alias disambiguation (PR #125258)

2025-05-29 Thread John McCall via cfe-commits
https://github.com/rjmccall requested changes to this pull request. Functionality LGTM. I have a somewhat annoying request for the tests, but it should make things a lot easier for the next person. https://github.com/llvm/llvm-project/pull/125258 ___

[clang] [llvm] [clang][CodeGen][AA] Introduce `!llvm.errno.tbaa` for errno alias disambiguation (PR #125258)

2025-05-29 Thread John McCall via cfe-commits
@@ -32,9 +32,9 @@ struct X f(void); // C11-O2-NEXT:[[A:%.*]] = getelementptr inbounds nuw [[STRUCT_X]], ptr [[REF_TMP]], i32 0, i32 0 // C11-O2-NEXT:[[ARRAYDECAY:%.*]] = getelementptr inbounds [5 x i32], ptr [[A]], i64 0, i64 0 // C11-O2-NEXT:call void @llvm.lifet

[clang] 8f4fd86 - Revert "[clang][Dependency Scanning] Report What a Module Exports during Scanning (#137421)" (#140820)

2025-05-29 Thread via cfe-commits
Author: Qiongsi Wu Date: 2025-05-29T11:11:31-07:00 New Revision: 8f4fd864033601aad99a10c2b878769b84df7537 URL: https://github.com/llvm/llvm-project/commit/8f4fd864033601aad99a10c2b878769b84df7537 DIFF: https://github.com/llvm/llvm-project/commit/8f4fd864033601aad99a10c2b878769b84df7537.diff LO

[clang-tools-extra] [clang-doc] fix FileCheck for conversion function HTML test (PR #141976)

2025-05-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Erick Velez (evelez7) Changes The HTML FileCheck was missing the RUN command. Fixing that revealed an error in the HTML check. --- Full diff: https://github.com/llvm/llvm-project/pull/141976.diff 1 Files Affected: - (modifi

[clang] [clang][modules][deps]Remove -F option from test for clang-scan-deps (PR #141614)

2025-05-29 Thread Jamie Schmeiser via cfe-commits
jamieschmeiser wrote: Our legacy products had different functionality for -F than the current Clang -F functionality. See https://www.ibm.com/docs/en/xl-c-and-cpp-aix/16.1.0?topic=ixcod-f, in particular the note that states that this functionality is different from GCC -F (and therefore diff

[clang] cb065a5 - [NFCI][ubsan] Add/update deprecation TODOs

2025-05-29 Thread Thurston Dang via cfe-commits
Author: Thurston Dang Date: 2025-05-29T18:13:47Z New Revision: cb065a578a9d152603c2ea66a616c1cbbc702d63 URL: https://github.com/llvm/llvm-project/commit/cb065a578a9d152603c2ea66a616c1cbbc702d63 DIFF: https://github.com/llvm/llvm-project/commit/cb065a578a9d152603c2ea66a616c1cbbc702d63.diff LOG:

[clang] [llvm] Revert "[Clang][LoongArch] Support target attribute for function" (PR #141998)

2025-05-29 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/141998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang][Dependency Scanning] Report What a Module Exports during Scanning (#137421)" (PR #140820)

2025-05-29 Thread Qiongsi Wu via cfe-commits
https://github.com/qiongsiwu closed https://github.com/llvm/llvm-project/pull/140820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b411f70 - [clang][bytecode] Make some builtins no-ops (#141952)

2025-05-29 Thread via cfe-commits
Author: Timm Baeder Date: 2025-05-29T20:02:37+02:00 New Revision: b411f70c3b83b0b25eee67d666d42cf50f78a6b8 URL: https://github.com/llvm/llvm-project/commit/b411f70c3b83b0b25eee67d666d42cf50f78a6b8 DIFF: https://github.com/llvm/llvm-project/commit/b411f70c3b83b0b25eee67d666d42cf50f78a6b8.diff L

[clang] [llvm] Revert "[Clang][LoongArch] Support target attribute for function" (PR #141998)

2025-05-29 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/141998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][RootSiganture] Add parsing of new number params in StaticSampler (PR #140291)

2025-05-29 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/140291 >From 4002195ce0dad1d292efc73530c7584edc1ecf7f Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Fri, 16 May 2025 16:08:36 + Subject: [PATCH 1/9] pre-req: add keywords --- clang/include/clang/Lex/HLSLRootS

[clang-tools-extra] [clang-doc] fix FileCheck for conversion function HTML test (PR #141976)

2025-05-29 Thread Erick Velez via cfe-commits
https://github.com/evelez7 closed https://github.com/llvm/llvm-project/pull/141976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Follow style configuration in clangd when inserting missing includes (PR #140594)

2025-05-29 Thread via cfe-commits
@@ -151,6 +164,11 @@ std::vector generateMissingIncludeDiagnostics( if (!Replacement.has_value()) continue; +if (Angled && Spelling.front() == '\"') { Harald-R wrote: @kadircet you are right. Forgot to update the spelling fix when I changed the

[clang] [clang][bytecode] Make some builtins no-ops (PR #141952)

2025-05-29 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/141952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Follow style configuration in clangd when inserting missing includes (PR #140594)

2025-05-29 Thread via cfe-commits
https://github.com/Harald-R updated https://github.com/llvm/llvm-project/pull/140594 >From 2e261ba9fa08f7c482f9c9e11385d0975468b76f Mon Sep 17 00:00:00 2001 From: Harald-R Date: Sun, 18 May 2025 19:07:59 +0300 Subject: [PATCH 1/8] Follow style configuration in clangd include cleaner --- clang

[clang] [llvm] Revert "[Clang][LoongArch] Support target attribute for function" (PR #141998)

2025-05-29 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/141998 Reverts llvm/llvm-project#140700 This breaks bots both in buildbot and downstream CI: - https://lab.llvm.org/buildbot/#/builders/11/builds/16173 - https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/cla

[clang-tools-extra] 260836d - [clang-doc] fix FileCheck for conversion function HTML test (#141976)

2025-05-29 Thread via cfe-commits
Author: Erick Velez Date: 2025-05-29T17:56:17Z New Revision: 260836d91713f1b6dfeff532120aa3e4ef7b8285 URL: https://github.com/llvm/llvm-project/commit/260836d91713f1b6dfeff532120aa3e4ef7b8285 DIFF: https://github.com/llvm/llvm-project/commit/260836d91713f1b6dfeff532120aa3e4ef7b8285.diff LOG: [

[clang] [flang] [mlir] [flang] Add support for -mprefer-vector-width= (PR #141380)

2025-05-29 Thread Cameron McInally via cfe-commits
mcinally wrote: @tarunprabhu Would you mind mashing the "Merge" button? It looks like getting commit access approval is taking longer than expected. https://github.com/llvm/llvm-project/pull/141380 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang-tools-extra] [clang-doc] fix FileCheck for conversion function HTML test (PR #141976)

2025-05-29 Thread Erick Velez via cfe-commits
evelez7 wrote: CI passed besides the Linux test. Identical to what was discussed in #138065 https://github.com/llvm/llvm-project/pull/141976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [llvm] Revert "[Clang][LoongArch] Support target attribute for function" (PR #141998)

2025-05-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-loongarch Author: Paul Kirth (ilovepi) Changes Reverts llvm/llvm-project#140700 This breaks bots both in buildbot and downstream CI: - https://lab.llvm.org/buildbot/#/builders/11/builds/16173 - https://ci.chromium.org/ui/p/fuchsia/builders/too

[clang] [Clang] Improve infrastructure for libstdc++ workarounds (PR #141977)

2025-05-29 Thread Erich Keane via cfe-commits
@@ -979,3 +979,48 @@ Preprocessor::EvaluateDirectiveExpression(IdentifierInfo *&IfNDefMacro, return EvaluateDirectiveExpression(IfNDefMacro, Tok, EvaluatedDefined, CheckForEoD); } + +static std::optional +getCXXStandardLibraryVersion(Prep

[clang] [Clang] Improve infrastructure for libstdc++ workarounds (PR #141977)

2025-05-29 Thread via cfe-commits
@@ -979,3 +979,48 @@ Preprocessor::EvaluateDirectiveExpression(IdentifierInfo *&IfNDefMacro, return EvaluateDirectiveExpression(IfNDefMacro, Tok, EvaluatedDefined, CheckForEoD); } + +static std::optional +getCXXStandardLibraryVersion(Prep

[clang] [Modules] Don't fail when an unused textual header is missing. (PR #138227)

2025-05-29 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: We reviewed this thread today at the Clang Area Team meeting and it seems like y'all have perhaps found a solution everyone is happy with. However, if you'd like a meeting or if there's some other way we can support you, we're definitely happy to help! > Please let me know

[clang] [flang] [mlir] [flang] Add support for -mprefer-vector-width= (PR #141380)

2025-05-29 Thread Tarun Prabhu via cfe-commits
tarunprabhu wrote: > @tarunprabhu Would you mind mashing the "Merge" button? It looks like getting > commit access approval is taking longer than expected. You may need to rebase before I can merge. https://github.com/llvm/llvm-project/pull/141380 __

[clang] [ubsan] Add more -fsanitize-annotate-debug-info checks (PR #141997)

2025-05-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-codegen Author: Thurston Dang (thurstond) Changes This extends https://github.com/llvm/llvm-project/pull/138577 to more UBSan checks, by changing SanitizerScope to add annotations if enabled for the specified ordinals.

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-29 Thread Erick Velez via cfe-commits
https://github.com/evelez7 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/141139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [mlir] [flang] Add support for -mprefer-vector-width= (PR #141380)

2025-05-29 Thread Cameron McInally via cfe-commits
https://github.com/mcinally updated https://github.com/llvm/llvm-project/pull/141380 >From 9f8619cb54a3a11e4c90af7f5156141ddc59e4d4 Mon Sep 17 00:00:00 2001 From: Cameron McInally Date: Sat, 24 May 2025 13:35:13 -0700 Subject: [PATCH 1/3] [flang] Add support for -mprefer-vector-width= This pat

[clang] [flang] [mlir] [flang] Add support for -mprefer-vector-width= (PR #141380)

2025-05-29 Thread Tarun Prabhu via cfe-commits
@@ -126,6 +127,8 @@ struct MLIRToLLVMPassPipelineConfig : public FlangEPCallBacks { bool NoSignedZerosFPMath = false; ///< Set no-signed-zeros-fp-math attribute for functions. bool UnsafeFPMath = false; ///< Set unsafe-fp-math attribute for functions. + std::string

[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-29 Thread Paul Kirth via cfe-commits
ilovepi wrote: > @ilovepi, thanks for the patience and taking out the time to give detailed > reviews. I will work on addresing your comments. One word on the tests: I was > trying to test some of the other fail conditions but seems like a lot of the > error conditions are caught by the parsin

[clang] Revert "[clang][Sema] Declare builtins used in #pragma intrinsic" (PR #141994)

2025-05-29 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/141994 Reverts llvm/llvm-project#138205 Breaks Chrome. >From fb79103e3dca8a2a0f5732aefbc9cf71b967d357 Mon Sep 17 00:00:00 2001 From: Nick Sarnie Date: Thu, 29 May 2025 17:33:04 + Subject: [PATCH] Revert "[clang][S

[clang] [clang][Sema] Declare builtins used in #pragma intrinsic (PR #138205)

2025-05-29 Thread Nick Sarnie via cfe-commits
sarnex wrote: Chrome requested I revert https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-29 Thread Paul Kirth via cfe-commits
ilovepi wrote: > Also, from the CI test run, I see the Linux build failing. This seems > unrelated, right? Does it warrant a rerun? > > ``` > /home/gha/actions-runner/_work/llvm-project/llvm-project/libc/test/src/math/smoke/HypotTest.h:31: > FAILURE > Failed to match aNaN against LIBC_NAMESPAC

[clang] [flang] [mlir] [flang] Add support for -mprefer-vector-width= (PR #141380)

2025-05-29 Thread Cameron McInally via cfe-commits
@@ -126,6 +127,8 @@ struct MLIRToLLVMPassPipelineConfig : public FlangEPCallBacks { bool NoSignedZerosFPMath = false; ///< Set no-signed-zeros-fp-math attribute for functions. bool UnsafeFPMath = false; ///< Set unsafe-fp-math attribute for functions. + std::string

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-29 Thread Erick Velez via cfe-commits
evelez7 wrote: Sorry about that I was trying to get the PR changes via Github CLI... https://github.com/llvm/llvm-project/pull/141139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-29 Thread Erick Velez via cfe-commits
https://github.com/evelez7 updated https://github.com/llvm/llvm-project/pull/141139 >From 7f346f476e89bc97c5d1780ef9f12246ebc4f86d Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 21 May 2025 09:50:32 -0700 Subject: [PATCH] [clang-doc] Reenable time trace support This patch re-enables -fti

[clang-tools-extra] [clang-tidy] Added check 'bugprone-function-visibility-change' (PR #140086)

2025-05-29 Thread via cfe-commits
___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cf04592 - [clang][docs] Remove reference to deleted line in sanitizer doc (#141921)

2025-05-29 Thread via cfe-commits
Author: David Spickett Date: 2025-05-29T17:43:46+01:00 New Revision: cf045929b2c9786b0773d46f03c424610e240a78 URL: https://github.com/llvm/llvm-project/commit/cf045929b2c9786b0773d46f03c424610e240a78 DIFF: https://github.com/llvm/llvm-project/commit/cf045929b2c9786b0773d46f03c424610e240a78.diff

[clang] [llvm] [HLSL] Diagnose overlapping resource bindings (PR #140982)

2025-05-29 Thread Helena Kotas via cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/140982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Fix assertions error in Serialize.cpp (PR #141990)

2025-05-29 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- clang-tools-extra/clang-doc/Serialize.cpp ``

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-29 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/141139 >From 7f346f476e89bc97c5d1780ef9f12246ebc4f86d Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 21 May 2025 09:50:32 -0700 Subject: [PATCH] [clang-doc] Reenable time trace support This patch re-enables -fti

[clang] [llvm] [HLSL][RootSignature] Add parsing of floats for StaticSampler (PR #140181)

2025-05-29 Thread Finn Plummer via cfe-commits
https://github.com/inbelic closed https://github.com/llvm/llvm-project/pull/140181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-29 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/141139 >From 41c65c1ec8f0329d8265d12856cc0b4e33bb502e Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 21 May 2025 09:50:32 -0700 Subject: [PATCH] [clang-doc] Reenable time trace support This patch re-enables -fti

[clang-tools-extra] [clang-doc] Fix assertions error in Serialize.cpp (PR #141990)

2025-05-29 Thread Paul Kirth via cfe-commits
ilovepi wrote: * **#141990** https://app.graphite.dev/github/pr/llvm/llvm-project/141990?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/1419

[clang-tools-extra] [clang-doc] Fix assertions error in Serialize.cpp (PR #141990)

2025-05-29 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/141990 We can only print and use a default arg, if it is instantiated. I was unable to reduce the test case for this to something of reasonable size, but this is easily hit by running clang-doc to generate clang's docum

[clang] [HLSL] Make implicit binding warning off by default (PR #141879)

2025-05-29 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/141879 >From 4ee791419132d8e3717a81418fe34a3e0bc4e727 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Wed, 28 May 2025 16:29:17 -0700 Subject: [PATCH] [HLSL] Make implicit binding warning off by default --- .../clan

[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-29 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/141699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-29 Thread Samarth Narang via cfe-commits
@@ -0,0 +1,12 @@ +// Test: Invalid output path (%t is a file, not a directory) +// RUN: rm -rf %t && echo "not a dir" > %t +// RUN: not clang-doc %s -output=%t/subdir 2>&1 | FileCheck --check-prefix=BAD-OUTPUT %s + +// BAD-OUTPUT: clang-doc error: +// BAD-OUTPUT: {{(Not a directo

[clang] [Clang] Fix an out of bound access in -verify comment parsing (PR #141940)

2025-05-29 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/141940 >From ca2ea7359ac2f0f0ea41396990847479b5a3e2b7 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Thu, 29 May 2025 15:14:55 +0200 Subject: [PATCH 1/2] [Clang] Fix an out of bound access in -verify comment par

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-29 Thread Erick Velez via cfe-commits
@@ -13,7 +13,9 @@ #include "clang/Index/USRGeneration.h" #include "llvm/ADT/StringExtras.h" #include "llvm/ADT/StringSet.h" +#include "llvm/Support/Error.h" evelez7 wrote: Error is already included via TimeProfiler.h https://github.com/llvm/llvm-project/pull/

[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-29 Thread Samarth Narang via cfe-commits
@@ -371,22 +368,15 @@ Example usage for a project using a compile commands database: sortUsrToInfo(USRToInfo); // Ensure the root output directory exists. - if (std::error_code Err = llvm::sys::fs::create_directories(OutDirectory); - Err != std::error_code()) { -

[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-29 Thread Samarth Narang via cfe-commits
@@ -0,0 +1,12 @@ +// Test: Invalid output path (%t is a file, not a directory) +// RUN: rm -rf %t && echo "not a dir" > %t +// RUN: not clang-doc %s -output=%t/subdir 2>&1 | FileCheck --check-prefix=BAD-OUTPUT %s + +// BAD-OUTPUT: clang-doc error: +// BAD-OUTPUT: {{(Not a directo

[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-29 Thread Samarth Narang via cfe-commits
@@ -0,0 +1,12 @@ +// Test: Invalid output path (%t is a file, not a directory) snarang181 wrote: Thanks for the pointer. https://github.com/llvm/llvm-project/pull/141699 ___ cfe-commits mailing list cfe-commits@lists.

[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-29 Thread Samarth Narang via cfe-commits
https://github.com/snarang181 edited https://github.com/llvm/llvm-project/pull/141699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] fix FileCheck for conversion function HTML test (PR #141976)

2025-05-29 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. https://github.com/llvm/llvm-project/pull/141976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] fix FileCheck for conversion function HTML test (PR #141976)

2025-05-29 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/141976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] fix FileCheck for conversion function HTML test (PR #141976)

2025-05-29 Thread Paul Kirth via cfe-commits
ilovepi wrote: Jeez. We're so disciplined ... LGTM Assuming CI passes. https://github.com/llvm/llvm-project/pull/141976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-29 Thread Samarth Narang via cfe-commits
@@ -300,7 +297,7 @@ Example usage for a project using a compile commands database: "these files and continue:\n" << toString(std::move(Err)) << "\n"; else { - llvm::errs() << toString(std::move(Err)) << "\n"; s

[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-29 Thread Samarth Narang via cfe-commits
snarang181 wrote: Also, from the CI test run, I see the Linux build failing. This seems unrelated, right? Does it warrant a rerun? ``` /home/gha/actions-runner/_work/llvm-project/llvm-project/libc/test/src/math/smoke/HypotTest.h:31: FAILURE Failed to match aNaN against LIBC_NAMESPACE::testing:

[clang] [Clang] Improve infrastructure for libstdc++ workarounds (PR #141977)

2025-05-29 Thread Erich Keane via cfe-commits
@@ -129,6 +129,12 @@ enum class EmbedResult { Empty = 2,// Corresponds to __STDC_EMBED_EMPTY__ }; +struct CXXStandardLibraryVersionInfo { + enum Library { Unknow, LibStdCXX }; erichkeane wrote: ```suggestion enum Library { Unknown, LibStdCXX }; ```

[clang] [Clang] Improve infrastructure for libstdc++ workarounds (PR #141977)

2025-05-29 Thread Erich Keane via cfe-commits
@@ -129,6 +129,12 @@ enum class EmbedResult { Empty = 2,// Corresponds to __STDC_EMBED_EMPTY__ }; +struct CXXStandardLibraryVersionInfo { + enum Library { Unknow, LibStdCXX }; + Library Lib; + unsigned Version; erichkeane wrote: IIRC there is an llvm

[clang] [Clang] Improve infrastructure for libstdc++ workarounds (PR #141977)

2025-05-29 Thread Erich Keane via cfe-commits
@@ -979,3 +979,48 @@ Preprocessor::EvaluateDirectiveExpression(IdentifierInfo *&IfNDefMacro, return EvaluateDirectiveExpression(IfNDefMacro, Tok, EvaluatedDefined, CheckForEoD); } + +static std::optional +getCXXStandardLibraryVersion(Prep

[clang] [clang][Sema] Refine unused-member-function diagnostic message for constructors (PR #84515)

2025-05-29 Thread via cfe-commits
https://github.com/guillem-bartrina-sonarsource edited https://github.com/llvm/llvm-project/pull/84515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][RootSignature] Add parsing of floats for StaticSampler (PR #140181)

2025-05-29 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/140181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Refine unused-member-function diagnostic message for constructors (PR #84515)

2025-05-29 Thread via cfe-commits
https://github.com/guillem-bartrina-sonarsource edited https://github.com/llvm/llvm-project/pull/84515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Refine unused-member-function diagnostic message for constructors (PR #84515)

2025-05-29 Thread via cfe-commits
@@ -402,7 +402,7 @@ def warn_unused_function : Warning<"unused function %0">, InGroup, DefaultIgnore; def warn_unused_template : Warning<"unused %select{function|variable}0 template %1">, InGroup, DefaultIgnore; -def warn_unused_member_function : Warning<"unused member fun

[clang] [clang][docs] Remove reference to deleted line in sanitizer doc (PR #141921)

2025-05-29 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/141921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Improve infrastructure for libstdc++ workarounds (PR #141977)

2025-05-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes This introduces a way detect the libstdc++ version, use that to enable workarounds. The version is cached. This should make it easier in the future to find and remove these hacks. I did not find the need for e

[clang] [Clang] Improve infrastructure for libstdc++ workarounds (PR #141977)

2025-05-29 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/141977 This introduces a way detect the libstdc++ version, use that to enable workarounds. The version is cached. This should make it easier in the future to find and remove these hacks. I did not find the need for

[clang] [Clang] Fix an out of bound access in -verify comment parsing (PR #141940)

2025-05-29 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/141940 >From ca2ea7359ac2f0f0ea41396990847479b5a3e2b7 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Thu, 29 May 2025 15:14:55 +0200 Subject: [PATCH] [Clang] Fix an out of bound access in -verify comment parsing

[clang] [clang] Implement address sanitizer on AIX (PR #129925)

2025-05-29 Thread David Tenty via cfe-commits
@@ -256,6 +256,8 @@ def err_drv_malformed_sanitizer_metadata_ignorelist : Error< "malformed sanitizer metadata ignorelist: '%0'">; def err_drv_unsupported_static_sanitizer_darwin : Error< daltenty wrote: Maybe just make static/shared a parameter as well? htt

[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-29 Thread Samarth Narang via cfe-commits
snarang181 wrote: @ilovepi, thanks for the patience and taking out the time to give detailed reviews. I will work on addresing your comments. One word on the tests: I was trying to test some of the other fail conditions but seems like a lot of the error conditions are caught by the parsing ear

[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-29 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,12 @@ +// Test: Invalid output path (%t is a file, not a directory) +// RUN: rm -rf %t && echo "not a dir" > %t +// RUN: not clang-doc %s -output=%t/subdir 2>&1 | FileCheck --check-prefix=BAD-OUTPUT %s + +// BAD-OUTPUT: clang-doc error: +// BAD-OUTPUT: {{(Not a directo

[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-29 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,12 @@ +// Test: Invalid output path (%t is a file, not a directory) +// RUN: rm -rf %t && echo "not a dir" > %t +// RUN: not clang-doc %s -output=%t/subdir 2>&1 | FileCheck --check-prefix=BAD-OUTPUT %s + +// BAD-OUTPUT: clang-doc error: +// BAD-OUTPUT: {{(Not a directo

[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-29 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,12 @@ +// Test: Invalid output path (%t is a file, not a directory) +// RUN: rm -rf %t && echo "not a dir" > %t +// RUN: not clang-doc %s -output=%t/subdir 2>&1 | FileCheck --check-prefix=BAD-OUTPUT %s + +// BAD-OUTPUT: clang-doc error: +// BAD-OUTPUT: {{(Not a directo

[clang] [flang] [flang][driver] Introduce FCC_OVERRIDE_OPTIONS. (PR #140556)

2025-05-29 Thread Abid Qadeer via cfe-commits
@@ -614,3 +614,28 @@ nvfortran defines `-fast` as - `-Mcache_align`: there is no equivalent flag in Flang or Clang. - `-Mflushz`: flush-to-zero mode - when `-ffast-math` is specified, Flang will link to `crtfastmath.o` to ensure denormal numbers are flushed to zero. + + +#

[clang] [flang] [flang][driver] Introduce FCC_OVERRIDE_OPTIONS. (PR #140556)

2025-05-29 Thread Abid Qadeer via cfe-commits
https://github.com/abidh updated https://github.com/llvm/llvm-project/pull/140556 >From 5d20af48673adebc2ab3e1a6c8442f67d84f1847 Mon Sep 17 00:00:00 2001 From: Abid Qadeer Date: Mon, 19 May 2025 15:21:25 +0100 Subject: [PATCH 1/3] [flang][driver] Introduce FCC_OVERRIDE_OPTIONS. This PR add fun

[clang-tools-extra] [clang-tidy] Added check 'bugprone-function-visibility-change' (PR #140086)

2025-05-29 Thread Balázs Kéri via cfe-commits
https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/140086 From 65d44a4eb9621e49a96f1ac43e5a1bbd6691dc13 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Thu, 15 May 2025 17:41:16 +0200 Subject: [PATCH 1/5] [clang-tidy] Added check 'bugprone-fu

  1   2   3   4   5   6   7   8   9   10   >