https://github.com/zygoloid approved this pull request.
Looks good. Do we also need to worry about overwriting tail padding here?
https://github.com/llvm/llvm-project/pull/93115
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Eli Friedman (efriedma-quic)
Changes
If a class is empty, don't store it to memory: the store might overwrite useful
data.
(See also d60c3d08.)
Fixes #93040.
---
Full diff: https://github.com/llvm/llvm-project/pull/93115.diff
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Eli Friedman (efriedma-quic)
Changes
If a class is empty, don't store it to memory: the store might overwrite useful
data.
(See also d60c3d08.)
Fixes #93040.
---
Full diff: https://github.com/llvm/llvm-project/pull/93115.diff
2 Files
https://github.com/efriedma-quic created
https://github.com/llvm/llvm-project/pull/93115
If a class is empty, don't store it to memory: the store might overwrite useful
data.
(See also d60c3d08.)
Fixes #93040.
>From bdfcc729c309fc5b1092b67d7c3c803c852ae251 Mon Sep 17 00:00:00 2001
From: Eli
@@ -801,7 +801,7 @@ static OutputDesc
*addInputSec(StringMap> ,
auto *firstIsec = cast(
cast(sec->commands[0])->sectionBases[0]);
OutputSection *firstIsecOut =
- firstIsec->flags & SHF_LINK_ORDER
MaskRay wrote:
A CppCheck issue
https://github.com/yronglin closed
https://github.com/llvm/llvm-project/pull/92527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: yronglin
Date: 2024-05-23T07:59:46+08:00
New Revision: f049d72ac2bcc40fd91d4e95148658021fb24bf1
URL:
https://github.com/llvm/llvm-project/commit/f049d72ac2bcc40fd91d4e95148658021fb24bf1
DIFF:
https://github.com/llvm/llvm-project/commit/f049d72ac2bcc40fd91d4e95148658021fb24bf1.diff
yronglin wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/92527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Nikolas Klauser (philnik777)
Changes
This changes `__is_trivially_equality_comparable` to do overload resolution
instead, which fixes a couple of false-positives (and a false-negative as a
drive-by).
Fixes #89293
---
Full diff:
https://github.com/philnik777 ready_for_review
https://github.com/llvm/llvm-project/pull/93113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/93113
>From 31e334643e7b4fa4a87c8d15efab4036306d Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Thu, 23 May 2024 01:48:06 +0200
Subject: [PATCH] [Clang] Fix __is_trivially_equality_comparable returning
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 465bfd41fa27383d93521a31458e6496ebfc590d
53b52a07f8720db4495b93099d3e1874453f6950 --
https://github.com/philnik777 created
https://github.com/llvm/llvm-project/pull/93113
This changes `__is_trivially_equality_comparable` to do overload resolution
instead, which fixes a couple of false-positives (and a false-negative as a
drive-by).
Fixes #89293
>From
HendrikHuebner wrote:
Alright, I implemented the changes you suggested. There may have been an easier
way to modify the diagnostic though.
https://github.com/llvm/llvm-project/pull/91057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/HendrikHuebner updated
https://github.com/llvm/llvm-project/pull/91057
From c6a28f1ca3fe64deee892abdf2d3646e9ccf0a87 Mon Sep 17 00:00:00 2001
From: hhuebner
Date: Sat, 4 May 2024 13:49:38 +0200
Subject: [PATCH] [Clang] Throw error when calling atomic with pointer to zero
@@ -1793,6 +1793,37 @@ void ItaniumCXXABI::EmitDestructorCall(CodeGenFunction
,
ThisTy, VTT, VTTTy, nullptr);
}
+// Check if any non-inline method has the specified attribute.
+template
+static bool CXXRecordNonInlineHasAttr(const CXXRecordDecl
antangelo wrote:
Friendly ping
https://github.com/llvm/llvm-project/pull/91046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HendrikHuebner updated
https://github.com/llvm/llvm-project/pull/91057
From 9a0cb155e9d05043b31736080cb355ae73e16860 Mon Sep 17 00:00:00 2001
From: hhuebner
Date: Sat, 4 May 2024 13:49:38 +0200
Subject: [PATCH] [Clang] Throw error when calling atomic with pointer to zero
https://github.com/HendrikHuebner updated
https://github.com/llvm/llvm-project/pull/91057
From d1013726315209ba2517ecd767daa067b4b34143 Mon Sep 17 00:00:00 2001
From: hhuebner
Date: Sat, 4 May 2024 13:49:38 +0200
Subject: [PATCH] gClang] Throw error when calling atomic with pointer to zero
https://github.com/goldsteinn updated
https://github.com/llvm/llvm-project/pull/91101
>From 0f04281f4c064d0c873abf0c95c54b53fa3deafd Mon Sep 17 00:00:00 2001
From: Noah Goldstein
Date: Sat, 4 May 2024 18:12:34 -0500
Subject: [PATCH 1/3] [Inliner] Add tests for propagating more parameter
@@ -1427,8 +1429,17 @@ static void AddParamAndFnBasicAttributes(const CallBase
,
ValidExactParamAttrs[ArgNo].getAlignment().valueOrOne())
AL = AL.removeParamAttribute(Context, I, Attribute::Alignment);
+ auto ExistingRange =
@@ -339,8 +365,18 @@ class CoverageMappingBuilder {
llvm::SmallSet Visited;
SmallVector, 8> FileLocs;
-for (const auto : SourceRegions) {
+for (auto : SourceRegions) {
SourceLocation Loc = Region.getBeginLoc();
+
+ // Replace Region with its
@@ -292,10 +292,36 @@ class CoverageMappingBuilder {
return SM.getLocForEndOfFile(SM.getFileID(Loc));
}
- /// Find out where the current file is included or macro is expanded.
- SourceLocation getIncludeOrExpansionLoc(SourceLocation Loc) {
-return Loc.isMacroID()
jasonmolenda wrote:
fwiw if you have access to a mac, I don't think it's hard to build lldb+clang?
I have swig, cmake, and ninja installed on my mac via homebrew.
```
lldb/scripts/macos-setup-codesign.sh
mkdir build
cd build
cmake ../llvm -G Ninja -DLLDB_ENABLE_SWIFT_SUPPORT=0
mysterymath wrote:
This still exhibits the same issue:
https://luci-milo.appspot.com/raw/build/logs.chromium.org/fuchsia/led/dthorn_google.com/0d77d2b0963e18ad11cb83db0680c2382ed7f8df95cf733f42fcdbd1dda8a7ec/+/build.proto
https://github.com/AtariDreams updated
https://github.com/llvm/llvm-project/pull/85316
>From cf9b776ff6fd59fc9488eedf45b9344f711ee155 Mon Sep 17 00:00:00 2001
From: Rose
Date: Thu, 14 Mar 2024 17:34:16 -0400
Subject: [PATCH] Resolve FIXME: Use class method when receiver is reference to
class
https://github.com/AtariDreams edited
https://github.com/llvm/llvm-project/pull/85316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AtariDreams updated
https://github.com/llvm/llvm-project/pull/85316
>From 3a1cc2ba9c3b5f5bd290eda890287f3f87803e61 Mon Sep 17 00:00:00 2001
From: Rose
Date: Thu, 14 Mar 2024 17:34:16 -0400
Subject: [PATCH] Resolve FIXME: Use class method when receiver is reference to
class
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92953
>From 66e05ac24613435dbe774d49684d8ff9d119c4c3 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Tue, 21 May 2024 21:41:24 +0300
Subject: [PATCH 1/3] Remove some `try_compile` CMake checks for compiler
@@ -1427,8 +1429,17 @@ static void AddParamAndFnBasicAttributes(const CallBase
,
ValidExactParamAttrs[ArgNo].getAlignment().valueOrOne())
AL = AL.removeParamAttribute(Context, I, Attribute::Alignment);
+ auto ExistingRange =
https://github.com/AtariDreams converted_to_draft
https://github.com/llvm/llvm-project/pull/79174
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/goldsteinn updated
https://github.com/llvm/llvm-project/pull/91101
>From 0f04281f4c064d0c873abf0c95c54b53fa3deafd Mon Sep 17 00:00:00 2001
From: Noah Goldstein
Date: Sat, 4 May 2024 18:12:34 -0500
Subject: [PATCH 1/3] [Inliner] Add tests for propagating more parameter
@@ -1427,8 +1429,20 @@ static void AddParamAndFnBasicAttributes(const CallBase
,
ValidExactParamAttrs[ArgNo].getAlignment().valueOrOne())
AL = AL.removeParamAttribute(Context, I, Attribute::Alignment);
+ auto ExistingRange =
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Author: Vlad Serebrennikov (Endilll)
Changes
This patch moves `Sema` functions that are specific for x86 into the new
`SemaX86` class. This continues previous efforts to split `Sema` up. Additional
context can be found in #84184 and
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/93098
This patch moves `Sema` functions that are specific for x86 into the new
`SemaX86` class. This continues previous efforts to split `Sema` up. Additional
context can be found in #84184 and #92682.
>From
@@ -339,8 +365,18 @@ class CoverageMappingBuilder {
llvm::SmallSet Visited;
SmallVector, 8> FileLocs;
-for (const auto : SourceRegions) {
+for (auto : SourceRegions) {
SourceLocation Loc = Region.getBeginLoc();
+
+ // Replace Region with its
@@ -0,0 +1,29 @@
+; RUN: llc -mtriple=x86_64-- -O0 < %s | FileCheck %s
+; RUN: llc -mtriple=x86_64-- -O1 < %s | FileCheck %s
+; RUN: llc -mtriple=x86_64-- -O2 < %s | FileCheck %s
+
+; The codegen should insert post-inlining instrumentation calls and should not
+; insert
@@ -0,0 +1,44 @@
+; RUN: opt -passes="default" -S < %s | FileCheck -check-prefix=PRELTO %s
+; RUN: opt -passes="default" -S < %s | FileCheck -check-prefix=PRELTO %s
+; RUN: opt -passes="thinlto-pre-link,thinlto" -S < %s | FileCheck
-check-prefix=PRELTO %s
+; RUN: opt
@@ -1,41 +0,0 @@
-// REQUIRES: arm-registered-target,aarch64-registered-target
-
-// RUN: %clang -target armv7-unknown-none-eabi -pg -S -emit-llvm -o - %s |
FileCheck %s -check-prefixes=CHECK,UNSUPPORTED
-// RUN: %clang -target armv7-unknown-none-eabi -pg -meabi gnu -S
@@ -0,0 +1,44 @@
+; RUN: opt -passes="default" -S < %s | FileCheck -check-prefix=PRELTO %s
aeubanks wrote:
`PRELTO` isn't quite accurate since we also instrument in the default
pipelines, I'd use `INSTRUMENT`/`NOINSTRUMENT` or even just `YES`/`NO` :)
@@ -0,0 +1,44 @@
+; RUN: opt -passes="default" -S < %s | FileCheck -check-prefix=PRELTO %s
+; RUN: opt -passes="default" -S < %s | FileCheck -check-prefix=PRELTO %s
+; RUN: opt -passes="thinlto-pre-link,thinlto" -S < %s | FileCheck
-check-prefix=PRELTO %s
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Oleksandr T. (a-tarasyuk)
Changes
Fixes #93002
---
Full diff: https://github.com/llvm/llvm-project/pull/93093.diff
1 Files Affected:
- (modified) clang/lib/Sema/SemaOpenMP.cpp (+1-1)
``diff
diff --git
https://github.com/a-tarasyuk created
https://github.com/llvm/llvm-project/pull/93093
Fixes #93002
>From 19c54263be42fea58403d30030af76da0355ef1e Mon Sep 17 00:00:00 2001
From: Oleksandr T
Date: Wed, 22 May 2024 23:47:19 +0300
Subject: [PATCH] fix(93002): switch & to && for boolean values
https://github.com/robincaloudis closed
https://github.com/llvm/llvm-project/pull/92741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
robincaloudis wrote:
Thanks @owenca, @mydeveloperday and @HazardyKnusperkeks for the explanation and
insights! I'm closing this issue as @owenca found a much better solution.
https://github.com/llvm/llvm-project/pull/92741
___
cfe-commits mailing
https://github.com/shiltian updated
https://github.com/llvm/llvm-project/pull/93064
>From 6096d6a7a672786807173f2cbe3c08beb1b9ad74 Mon Sep 17 00:00:00 2001
From: Shilei Tian
Date: Wed, 22 May 2024 16:11:04 -0400
Subject: [PATCH] [AMDGPU][Clang] Add check of size for
https://github.com/shiltian updated
https://github.com/llvm/llvm-project/pull/93064
>From cc1b4f7ac1a4c0a827e843068547aa5c9748ca3e Mon Sep 17 00:00:00 2001
From: Shilei Tian
Date: Wed, 22 May 2024 16:09:53 -0400
Subject: [PATCH] [AMDGPU][Clang] Add check of size for
https://github.com/shiltian updated
https://github.com/llvm/llvm-project/pull/93064
>From 0ac36053bada98dc0f9e5eb2f3b215acc06b07a5 Mon Sep 17 00:00:00 2001
From: Shilei Tian
Date: Wed, 22 May 2024 16:06:51 -0400
Subject: [PATCH] [AMDGPU][Clang] Add check of size for
ajwock wrote:
The problem that this solves is related to binary size. In situations where a
large C API is in generated code but a small part of the API is used, the size
of __llvm_prf_names and __llvm_cov_fun sections can be prohibitively large.
This flag offers a way to reduce binary size
@@ -1427,8 +1429,20 @@ static void AddParamAndFnBasicAttributes(const CallBase
,
ValidExactParamAttrs[ArgNo].getAlignment().valueOrOne())
AL = AL.removeParamAttribute(Context, I, Attribute::Alignment);
+ auto ExistingRange =
@@ -1793,6 +1793,37 @@ void ItaniumCXXABI::EmitDestructorCall(CodeGenFunction
,
ThisTy, VTT, VTTTy, nullptr);
}
+// Check if any non-inline method has the specified attribute.
+template
+static bool CXXRecordNonInlineHasAttr(const CXXRecordDecl
@@ -2537,6 +2537,47 @@ static RValue
EmitHipStdParUnsupportedBuiltin(CodeGenFunction *CGF,
return RValue::get(CGF->Builder.CreateCall(UBF, Args));
}
+static void buildInstrinsicCallArgs(CodeGenFunction , const CallExpr *E,
shiltian wrote:
Yeah, no need of
https://github.com/kparzysz updated
https://github.com/llvm/llvm-project/pull/90754
>From 94d79223a5c1daab292157576e8e84bb3280f22d Mon Sep 17 00:00:00 2001
From: Krzysztof Parzyszek
Date: Wed, 1 May 2024 12:21:51 -0500
Subject: [PATCH 1/3] [Frontend][OpenMP] Remove `reduction` from allowed
klensy wrote:
`fatal error C1060: compiler is out of heap space` Looks unrelated, should i
rerun CI?
https://github.com/llvm/llvm-project/pull/92231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -11868,8 +11868,10 @@ static bool CheckMultiVersionFunction(Sema ,
FunctionDecl *NewFD,
return false;
if (!OldDecl || !OldDecl->getAsFunction() ||
- OldDecl->getDeclContext()->getRedeclContext() !=
- NewFD->getDeclContext()->getRedeclContext()) {
+
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/90803
>From 4871a82495e0056483759fa207ffbecd63b1e2f8 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 1 May 2024 18:10:07 -0600
Subject: [PATCH] [libc++][WIP] Move the libc++ test format to Lit
This allows the
@@ -0,0 +1,355 @@
+#
===--===##
+#
+# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+# See https://llvm.org/LICENSE.txt for license information.
+# SPDX-License-Identifier:
https://github.com/tstellar milestoned
https://github.com/llvm/llvm-project/pull/90138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar milestoned
https://github.com/llvm/llvm-project/pull/92591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,31 @@
+; RUN: opt -passes="default" -S < %s | FileCheck %s
pasko wrote:
Done, I think, but it is evening, and I might be missing something.
https://github.com/llvm/llvm-project/pull/92171
___
cfe-commits
https://github.com/pasko updated https://github.com/llvm/llvm-project/pull/92171
>From df3f8dfc47cd8d7b220ed712dc7c2cab1c563f50 Mon Sep 17 00:00:00 2001
From: Egor Pasko
Date: Mon, 6 May 2024 19:48:59 +0200
Subject: [PATCH 1/7] wip: Move instrumentation passes
This change is not ready for
efriedma-quic wrote:
Looks fine.
https://github.com/llvm/llvm-project/pull/93086
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pasko updated https://github.com/llvm/llvm-project/pull/92171
>From df3f8dfc47cd8d7b220ed712dc7c2cab1c563f50 Mon Sep 17 00:00:00 2001
From: Egor Pasko
Date: Mon, 6 May 2024 19:48:59 +0200
Subject: [PATCH 1/6] wip: Move instrumentation passes
This change is not ready for
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/92855
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Matheus Izvekov
Date: 2024-05-22T15:59:55-03:00
New Revision: ff3f41deb04c03ba57658776e4e0dc26ef01187d
URL:
https://github.com/llvm/llvm-project/commit/ff3f41deb04c03ba57658776e4e0dc26ef01187d
DIFF:
@@ -0,0 +1,9 @@
+// RUN: %clang_cc1 -cl-std=CL2.0 -O0 -triple amdgcn-unknown-unknown
-target-cpu gfx940 -S -verify -o - %s
+// REQUIRES: amdgpu-registered-target
+
+typedef unsigned int u32;
+
+void test_global_load_lds_unsupported_size(global u32* src, local u32 *dst,
u32
@@ -2537,6 +2537,47 @@ static RValue
EmitHipStdParUnsupportedBuiltin(CodeGenFunction *CGF,
return RValue::get(CGF->Builder.CreateCall(UBF, Args));
}
+static void buildInstrinsicCallArgs(CodeGenFunction , const CallExpr *E,
arsenm wrote:
Shouldn't need any
@@ -19040,6 +19040,48 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned
BuiltinID,
CGM.getIntrinsic(Intrinsic::amdgcn_s_sendmsg_rtn, {ResultType});
return Builder.CreateCall(F, {Arg});
}
+ case AMDGPU::BI__builtin_amdgcn_global_load_lds: {
+
vgvassilev wrote:
Ok, maybe I can you test this patch for a temporary fix until we figure out
what's going wrong.
```diff
diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp
index 7f6921ea22be..d771a060f305 100644
--- a/clang/lib/Sema/SemaDecl.cpp
+++
https://github.com/kparzysz updated
https://github.com/llvm/llvm-project/pull/90754
>From 94d79223a5c1daab292157576e8e84bb3280f22d Mon Sep 17 00:00:00 2001
From: Krzysztof Parzyszek
Date: Wed, 1 May 2024 12:21:51 -0500
Subject: [PATCH 1/2] [Frontend][OpenMP] Remove `reduction` from allowed
mysterymath wrote:
I did have a means to reproduce this locally, but it's been a long time since
I've used it. I should be able to recreate the setup. I'll get back to you with
the details when I can; this whole afternoon is booked through pretty solid
with meetings for me I'm afraid.
vgvassilev wrote:
> I was able to verify that the revert fixed the tests at least.
I am pretty sure that the failure ha to do with the incremental processing
if-stmt in SemaDecl. I can provide a fix that does not trigger this for lldb
but that would be a workaround. I suspect that change
vgvassilev wrote:
> > @jasonmolenda, I am stuck. I could not find how the bot configures llvm and
> > lldb. I built lldb and ran `make check-lldb` but did not fail in the same
> > way. Can you provide a recipe to reproduce the failure?
>
> For some reason it only fails on our Mac LLDB
@@ -11298,8 +11298,9 @@ static void DiagnoseBadConversion(Sema ,
OverloadCandidate *Cand,
Expr *FromExpr = Conv.Bad.FromExpr;
QualType FromTy = Conv.Bad.getFromType();
QualType ToTy = Conv.Bad.getToType();
- SourceRange ToParamRange =
- !isObjectArgument ?
ZequanWu wrote:
I think the main purpose for emitting coverage mapping for un-emitted functions
is to tell llvm-cov that those functions are not executed at all, so it shows
execution count 0 for them instead of not-covered.
https://github.com/llvm/llvm-project/pull/92582
https://github.com/MitalAshok updated
https://github.com/llvm/llvm-project/pull/78112
>From 92f8720e3d21521b589d5291f086a2f32b87bfe0 Mon Sep 17 00:00:00 2001
From: Mital Ashok
Date: Sun, 14 Jan 2024 19:52:31 +
Subject: [PATCH 1/2] [clang] [SemaCXX] Implement CWG2627 Bit-fields and
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/93044
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11298,8 +11298,9 @@ static void DiagnoseBadConversion(Sema ,
OverloadCandidate *Cand,
Expr *FromExpr = Conv.Bad.FromExpr;
QualType FromTy = Conv.Bad.getFromType();
QualType ToTy = Conv.Bad.getToType();
- SourceRange ToParamRange =
- !isObjectArgument ?
Sirraide wrote:
It seems that a parameter to `getAddress()` that wasn’t being used has been
removed, which caused builds to break after I merged this. My bad; I’ve already
pushed a fix for this: #93086. I didn’t wait for CI this time because it was
passing before (except for an unrelated
@@ -4693,6 +4694,17 @@ LValue CodeGenFunction::EmitLValueForLambdaField(const
FieldDecl *Field,
else
LambdaLV = MakeAddrLValue(AddrOfExplicitObject,
D->getType().getNonReferenceType());
+
+// Make sure we have an lvalue to the
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Daniel Thornburgh (mysterymath)
Changes
Reverts llvm/llvm-project#92885 due to LLDB CI breakages.
---
Patch is 91.88 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/93087.diff
40
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-llvm-analysis
Author: Daniel Thornburgh (mysterymath)
Changes
Reverts llvm/llvm-project#92885 due to LLDB CI breakages.
---
Patch is 91.88 KiB, truncated to 20.00 KiB below, full version:
@@ -4693,6 +4694,17 @@ LValue CodeGenFunction::EmitLValueForLambdaField(const
FieldDecl *Field,
else
LambdaLV = MakeAddrLValue(AddrOfExplicitObject,
D->getType().getNonReferenceType());
+
+// Make sure we have an lvalue to the
Author: Daniel Thornburgh
Date: 2024-05-22T11:27:55-07:00
New Revision: 8baf96f3060bc26a308b3614feed4117e5299d3c
URL:
https://github.com/llvm/llvm-project/commit/8baf96f3060bc26a308b3614feed4117e5299d3c
DIFF:
https://github.com/mysterymath closed
https://github.com/llvm/llvm-project/pull/93087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mysterymath edited
https://github.com/llvm/llvm-project/pull/93087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (Sirraide)
Changes
The parameter of `getAddress()` was not being used, as I recall, and seems to
have been removed in the meantime. Merging this w/o review since this is
breaking builds.
---
Full diff:
https://github.com/mysterymath created
https://github.com/llvm/llvm-project/pull/93087
Reverts llvm/llvm-project#92885
>From bf19260fe0d348aee801f4446c4f8666740c8896 Mon Sep 17 00:00:00 2001
From: Daniel Thornburgh
Date: Wed, 22 May 2024 11:27:27 -0700
Subject: [PATCH] Revert "[IR] Avoid
https://github.com/Sirraide closed
https://github.com/llvm/llvm-project/pull/93086
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Sirraide
Date: 2024-05-22T20:27:26+02:00
New Revision: da88e7fbd74cef33411bb5115f20e4b474d2d8b1
URL:
https://github.com/llvm/llvm-project/commit/da88e7fbd74cef33411bb5115f20e4b474d2d8b1
DIFF:
https://github.com/llvm/llvm-project/commit/da88e7fbd74cef33411bb5115f20e4b474d2d8b1.diff
https://github.com/Sirraide created
https://github.com/llvm/llvm-project/pull/93086
The parameter of `getAddress()` was not being used, as I recall, and seems to
have been removed in the meantime. Merging this w/o review since this is
breaking builds.
>From
ajwock wrote:
cc @ZequanWu @ellishg for review
https://github.com/llvm/llvm-project/pull/92582
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mysterymath wrote:
This broke the Mac LLDB builders for Fuchsia as well. I'm going to revert to
unblock CI.
https://github.com/llvm/llvm-project/pull/92885
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -4693,6 +4694,17 @@ LValue CodeGenFunction::EmitLValueForLambdaField(const
FieldDecl *Field,
else
LambdaLV = MakeAddrLValue(AddrOfExplicitObject,
D->getType().getNonReferenceType());
+
+// Make sure we have an lvalue to the
https://github.com/kparzysz updated
https://github.com/llvm/llvm-project/pull/90754
>From 94d79223a5c1daab292157576e8e84bb3280f22d Mon Sep 17 00:00:00 2001
From: Krzysztof Parzyszek
Date: Wed, 1 May 2024 12:21:51 -0500
Subject: [PATCH] [Frontend][OpenMP] Remove `reduction` from allowed clauses
@@ -4693,6 +4694,17 @@ LValue CodeGenFunction::EmitLValueForLambdaField(const
FieldDecl *Field,
else
LambdaLV = MakeAddrLValue(AddrOfExplicitObject,
D->getType().getNonReferenceType());
+
+// Make sure we have an lvalue to the
shafik wrote:
Can you also confirm this fixes:
https://github.com/llvm/llvm-project/issues/70191
https://github.com/llvm/llvm-project/pull/93079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
JDevlieghere wrote:
The LLDB bots are still failing:
https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/as-lldb-cmake/4342/
https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/lldb-cmake/2244/
https://github.com/llvm/llvm-project/pull/92885
https://github.com/shafik approved this pull request.
Thank you for the fix. Can you please a little more details to your summary so
that folks reading git log have more context.
This also needs a release note.
Please also add that this also fixes:
https://github.com/Sirraide closed
https://github.com/llvm/llvm-project/pull/89828
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 432956 matches
Mail list logo
