[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer 1/2

victorkingi updated this revision to Diff 555074. victorkingi added a comment. Moved function implementations from llvm directory to clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158507/new/ https://reviews.llvm.org/D158507 Files:

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi abandoned this revision. victorkingi added a comment. Replaced by a series of patches already merged on github, starting from https://reviews.llvm.org/D157410 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer 1/2

victorkingi updated this revision to Diff 552390. victorkingi added a comment. Removed mframe_pointer_eq update in Options.td, not required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158507/new/ https://reviews.llvm.org/D158507 Files:

[PATCH] D158521: [Flang][Driver] Add visibility for Flang for m64 option

victorkingi created this revision. Herald added a reviewer: sscalpone. Herald added a project: All. victorkingi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158521 Files:

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer 1/2

victorkingi updated this revision to Diff 552381. victorkingi added a comment. revert addition of m64 visibility in Options.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158507/new/ https://reviews.llvm.org/D158507 Files:

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer 1/2

victorkingi updated this revision to Diff 552375. victorkingi added a comment. Added m64 visibility to flang in Options.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158507/new/ https://reviews.llvm.org/D158507 Files:

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer 1/2

victorkingi added inline comments. Comment at: clang/include/clang/Driver/Options.td:7236-7240 +def mframe_pointer_EQ : Joined<["-"], "mframe-pointer=">, + HelpText<"Specify which frame pointers to retain.">, Values<"all,non-leaf,none">, +

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer 1/2

victorkingi updated this revision to Diff 552330. victorkingi added a comment. Minimalized patch to only have update to Options.td as well as tests accompanying the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158507/new/

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer 1/2

victorkingi added a comment. In D158507#4606498 , @awarzynski wrote: >> Temporary fix for unknown argument error '-fomit-frame-pointer' when running >> flang tests > > I don't follow - there's quite a lot going on here. More than the summary >

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer

victorkingi created this revision. Herald added subscribers: abrachet, phosek, s.egerton, simoncook, asb, fedor.sergeev, dschuff. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. victorkingi requested review of this revision. Herald added

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi added a comment. In D156320#4594584 , @awarzynski wrote: > Victor, this is proving quite tricky to review. There's already been a lot of > updates and many of them are summarized as either "code refactor" or > "clean-up". Please reduce

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:1032-1043 +case llvm::DK_MachineOptimizationRemark: + optimizationRemarkHandler( + llvm::cast(di)); + break; +case llvm::DK_MachineOptimizationRemarkMissed: +

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 550800. victorkingi added a comment. added support for backend remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files:

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi added inline comments. Comment at: flang/test/Driver/optimization-remark.f90:7 +! RUN: %flang_fc1 %s -O1 -Rpass -emit-llvm -o - 2>&1 | FileCheck %s --check-prefix=CHECK-REMARKS +! RUN: %flang_fc1 %s -O1 -Rpass -Rno-pass -emit-llvm -o - 2>&1 | FileCheck %s

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi added inline comments. Comment at: flang/include/flang/Frontend/CodeGenOptions.h:76-81 +RK_Missing,// Remark argument not present on the command line. +RK_Enabled,// Remark enabled via '-Rgroup'. +RK_EnabledEverything, // Remark

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 550725. victorkingi added a comment. code refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: flang/include/flang/Frontend/CodeGenOptions.h

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 550719. victorkingi marked 9 inline comments as done. victorkingi added a comment. code refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files:

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 550345. victorkingi added a comment. rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: flang/include/flang/Frontend/CodeGenOptions.h

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 550320. victorkingi added a comment. rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: flang/include/flang/Frontend/CodeGenOptions.h

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:976-1011 + void + optimizationRemarkHandler(const llvm::DiagnosticInfoOptimizationBase ) { +if (d.isPassed()) { + // Optimization remarks are active only if the -Rpass flag has a

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 550288. victorkingi added a comment. code refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: flang/include/flang/Frontend/CodeGenOptions.h

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 550280. victorkingi marked 4 inline comments as done. victorkingi added a comment. code refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files:

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 550232. victorkingi marked 5 inline comments as done. victorkingi added a comment. code refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files:

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi marked 6 inline comments as done. victorkingi added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:927 +class StandaloneBackendConsumer : public llvm::DiagnosticHandler { + awarzynski wrote: > Why `StandaloneBackendConsumer`?

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi added inline comments. Comment at: flang/lib/FrontendTool/ExecuteCompilerInvocation.cpp:169-171 + clang::ProcessWarningOptions(flang->getDiagnostics(), + flang->getDiagnosticOpts()); + victorkingi wrote: > awarzynski

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:156-158 +/// Parse a remark command line argument. It may be missing, disabled/enabled by +/// '-R[no-]group' or specified with a regular expression by '-Rgroup=regexp'. +/// On top of

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 549887. victorkingi added a comment. added comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: flang/include/flang/Frontend/CodeGenOptions.h

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 549882. victorkingi added a comment. added tests for "no" variants of Rpass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files:

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 549879. victorkingi marked 6 inline comments as done. victorkingi added a comment. code refactoring in reference to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 549367. victorkingi marked an inline comment as done. victorkingi added a comment. addressing comments with code refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 549000. victorkingi added a comment. Added warning tests in optimization-remark.f90 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files:

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 548950. victorkingi added a comment. Removed false argument to ProcessWarningOption function to allow warning printing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 548941. victorkingi added a comment. rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: flang/include/flang/Frontend/CodeGenOptions.h

[PATCH] D157410: [Flang][Driver] Enable Rpass and other R family options.

victorkingi updated this revision to Diff 548675. victorkingi added a comment. refactoring Options.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157410/new/ https://reviews.llvm.org/D157410 Files: clang/include/clang/Driver/Options.td

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi marked an inline comment as done. victorkingi added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:786 parseShowColorsArgs(args, /*defaultDiagColor=*/false); + res.getDiagnosticOpts().ShowColors = res.getFrontendOpts().showColors;

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 548664. victorkingi edited the summary of this revision. victorkingi added a comment. Added remark error test and color printing for remark errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 548589. victorkingi added a comment. split the patch into 2. This is the implementation patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files:

[PATCH] D157410: [Flang][Driver] Enable Rpass and other R family options.

victorkingi updated this revision to Diff 548530. victorkingi added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157410/new/ https://reviews.llvm.org/D157410 Files: clang/include/clang/Driver/Options.td

[PATCH] D157410: [Flang] Enable Rpass flag

victorkingi updated this revision to Diff 548517. victorkingi added a comment. fixed comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157410/new/ https://reviews.llvm.org/D157410 Files: clang/include/clang/Driver/Options.td

[PATCH] D157410: [Flang] Enable Rpass flag

victorkingi created this revision. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. victorkingi requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert, MaskRay. Herald added a project: clang. This patch allows

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi added a comment. In D156320#4559248 , @kiranchandramohan wrote: >> rpass flag now prints remarks when requested but does not display >> the passName used, i.e [-Rpass=inline] > > I think the location information is also not printed. Please

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 548175. victorkingi added a comment. changed enum to enum class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/Driver/Options.td

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 548148. victorkingi added a comment. from CamelCase to camelCase variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files:

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 548142. victorkingi added a comment. fixing failing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/Driver/Options.td

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi added a comment. In D156320#4560839 , @awarzynski wrote: > Hey @victorkingi , thank you for working on this :) > > There's quite a lot going on here and I am thinking that it might be good to > split this into a few patches? Also, please

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 547817. victorkingi added a comment. code cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/Driver/Options.td

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 547816. victorkingi added a comment. removed unnecessary code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/Driver/Options.td

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 547813. victorkingi added a comment. Herald added a subscriber: wangpc. added extraction of absolute file path in TextDiagnosticPrinter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 546831. victorkingi added a comment. removed unused header includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files:

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 546826. victorkingi added a comment. added frontend forwarding test for Rpass flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files:

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 546819. victorkingi added a comment. added test file optimization-remark.f90 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files:

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 546798. victorkingi added a comment. rpass flag now prints remarks when requested but does not display the passName used, i.e [-Rpass=inline] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi created this revision. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added a subscriber: sunshaoce. Herald added projects: Flang, All. victorkingi requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert, MaskRay. Herald

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 544277. victorkingi added a comment. rebasing no changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://reviews.llvm.org/D155452 Files: clang/include/clang/Driver/Options.td

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi added inline comments. Comment at: flang/test/Driver/frontend-forwarding.f90:26 +! RUN: %flang -### %s 2>&1 \ +! RUN: -foptimization-record-file=%t.opt.yaml \ awarzynski wrote: > victorkingi wrote: > > awarzynski wrote: > > > Is a dedicated

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 543945. victorkingi added a comment. moved opt_record flags generation test from frontend-forwarding.f90 to fsave-optimization-record.f90 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:166-171 + clang::driver::options::OPT_fno_stack_arrays, false)) opts.StackArrays = 1; - } + if (args.hasFlag(clang::driver::options::OPT_floop_versioning, -

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 543571. victorkingi marked 3 inline comments as done. victorkingi added a comment. minor cleanup - dropped braces on single line if statements - moved opt_record options into [CC1Option, FC1Option, NoDriverOption] Group in

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 543424. victorkingi added a comment. no changes rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://reviews.llvm.org/D155452 Files: clang/include/clang/Driver/Options.td

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 542838. victorkingi added a comment. No changes rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://reviews.llvm.org/D155452 Files: clang/include/clang/Driver/Options.td

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 542407. victorkingi added a comment. Addressed kiranchandramohan comment on fsave-optimization-record.f90 test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 542404. victorkingi added a comment. Attempt to fix failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://reviews.llvm.org/D155452 Files: clang/include/clang/Driver/Options.td

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 541930. victorkingi marked an inline comment as done. victorkingi added a comment. Fixed failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://reviews.llvm.org/D155452 Files:

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi marked 4 inline comments as done. victorkingi added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:398 + if (const Arg *A = Args.getLastArg(options::OPT_fsave_optimization_record_EQ)) +Format = A->getValue(); + tblah wrote:

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 541563. victorkingi added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://reviews.llvm.org/D155452 Files: clang/include/clang/Driver/Options.td

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi created this revision. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added a subscriber: sunshaoce. Herald added projects: Flang, All. victorkingi requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert, MaskRay. Herald