[PATCH] D149709: Fix a typo in head comment of CurPPLexer

zhouyizhou added a comment. In D149709#4314390 , @vsapsai wrote: > Thanks for the fix! Don't see any other places in the file to fix. Thanks for review my patch ;-) I have no write access to LLVM project, can you commit it for me ? Thanks in Advance

[PATCH] D149709: Fix a typo in head comment of CurPPLexer

zhouyizhou created this revision. zhouyizhou added reviewers: vsapsai, zequanwu, ChuanqiXu, MaskRay, pengfei. Herald added a project: All. zhouyizhou requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In head comment of CurPPLexer field of

[PATCH] D144157: Add 128-bit integer support to enum element

zhouyizhou updated this revision to Diff 508350. zhouyizhou added a comment. Add 128-bit integer support to enum element like GCC extension do. Also test coverage around _BitInt which can be arbitrarily large depending on the target. Also leave room for improvements to C2X because C2x made

[PATCH] D144157: Add 128-bit integer support to enum element

zhouyizhou marked an inline comment as done. zhouyizhou added a comment. Thank you all for your guidance! Now I am starting to learn C2X N2997, this is a fruitful process of learning for me ;-) Cheers Zhouyi Comment at: clang/lib/Sema/SemaDecl.cpp:19571-19573 - // TODO: If

[PATCH] D144157: Add 128-bit integer support to enum element

zhouyizhou updated this revision to Diff 498571. zhouyizhou added a comment. delete the trailing blank line Thank you all ;-) I have no access write to LLVM, could you commit it for me when you are not busy? Thanks a lot Cheers Zhouyi Zhouyi Zhou CHANGES SINCE LAST ACTION

[PATCH] D144157: Add 128-bit integer support to enum element

zhouyizhou updated this revision to Diff 498557. zhouyizhou added a comment. make test case even better according to MaskRay's guidance CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144157/new/ https://reviews.llvm.org/D144157 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D144157: Add 128-bit integer support to enum element

zhouyizhou updated this revision to Diff 498520. zhouyizhou added a comment. Add CodeGen Test following MaskRay(Fangrui Song)'s Advice, I learned a lot during this process, to be honest ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144157/new/ https://reviews.llvm.org/D144157

[PATCH] D144157: Add 128-bit integer support to enum element

zhouyizhou updated this revision to Diff 497893. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144157/new/ https://reviews.llvm.org/D144157 Files: clang/lib/Sema/SemaDecl.cpp clang/test/Sema/enum.c Index: clang/test/Sema/enum.c

[PATCH] D144157: Add 128-bit integer support to enum element

zhouyizhou updated this revision to Diff 497889. zhouyizhou added a comment. reformat the patch according to Chuanqi's Advice CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144157/new/ https://reviews.llvm.org/D144157 Files: clang/lib/Sema/SemaDecl.cpp clang/test/Sema/enum.c

[PATCH] D144157: Add 128-bit integer support to enum element

zhouyizhou added a comment. In D144157#4131103 , @ChuanqiXu wrote: >> debian build bot won't let me pass, so I clang-formatted the function >> ActOnEnumBody > > You can try `git diff -U0 --no-color --relative HEAD^ | >

[PATCH] D144157: Add 128-bit integer support to enum element

zhouyizhou updated this revision to Diff 497884. zhouyizhou added a comment. debian build bot won't me pass, so I clang-formatted the function ActOnEnumBody CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144157/new/ https://reviews.llvm.org/D144157 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D144157: Add 128-bit integer support to enum element

zhouyizhou updated this revision to Diff 497874. zhouyizhou added a comment. add assertion for int128 support CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144157/new/ https://reviews.llvm.org/D144157 Files: clang/lib/Sema/SemaDecl.cpp clang/test/Sema/enum.c Index:

[PATCH] D144157: Add 128-bit integer support to enum element

zhouyizhou created this revision. zhouyizhou added reviewers: aaron.ballman, doug.gregor, eddy-geek, rjmccall, MaskRay, ChuanqiXu, pengfei. Herald added a project: All. zhouyizhou requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

zhouyizhou updated this revision to Diff 473509. zhouyizhou added a comment. Thank Ray for your guidance! I achieved a lot in the process ;-) Thanks Zhouyi CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137263/new/ https://reviews.llvm.org/D137263 Files:

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

zhouyizhou updated this revision to Diff 473495. zhouyizhou added a comment. add a test case thank you ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137263/new/ https://reviews.llvm.org/D137263 Files: clang/include/clang/AST/ASTUnresolvedSet.h

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

zhouyizhou added a comment. In D137263#3909722 , @MaskRay wrote: > I find that if I comment out ` > cast(Shadow->getDeclContext())->removeConversion(Shadow);` in > `Sema::HideUsingShadowDecl`, no test fails... So we have a missing coverage > issue.

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

zhouyizhou added a comment. In D137263#3909722 , @MaskRay wrote: > Thank Ray for your guidance! > We need a regression test. See `clang/test/SemaCXX/using-decl*` for some > other using declaration tests. Study some tests, find a file which is >

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

zhouyizhou added a comment. Thank Ray for editing the summary for me ;-) I learned to use fenced code blocks now from your example. Thank you both! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137263/new/ https://reviews.llvm.org/D137263

[PATCH] D119493: Fixing surplus assert condition in EvaluateTemporary

zhouyizhou added a comment. In D119493#3403458 , @efriedma wrote: > Thank Eli for your comment and guidance and sorry to have carelessly neglected your comment for 7 months! > I'm not sure this is the right fix. If we were handling the

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

zhouyizhou added a comment. In D137263#3904184 , @MaskRay wrote: > The summary and comments use Markdown. You comment is currently formatted > strangely because you did not use fenced code blocks :) > (The commit message does not necessarily use

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

zhouyizhou added a comment. In D137263#3903845 , @rjmccall wrote: > Good catch! Easy to see how this escaped notice for a decade, but still, > it'll be good to fix. > > LGTM with a minor improvement. Thank John for your encouragement and guidance! I

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

zhouyizhou added a comment. Following is the back trace when the assertion fires before my fix: #6 0x77960e96 in __GI___assert_fail (assertion=0x656ed285 "Begin + idx < End", file=0x656ed240 "/tmp/llvm-test/llvm-project.save/clang/include/clang/AST/ASTVector.h", line=112,

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

zhouyizhou updated this revision to Diff 472642. zhouyizhou added a comment. We should also consider the situation of erasing the size - 1th element CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137263/new/ https://reviews.llvm.org/D137263 Files:

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

zhouyizhou created this revision. zhouyizhou added reviewers: chandlerc, aprantl, rsmith, rjmccall. Herald added a project: All. zhouyizhou requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When compile following code with clang (Debug

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

zhouyizhou added a comment. In D133066#3846907 , @aaron.ballman wrote: > In D133066#3845136 , @zhouyizhou > wrote: > >> After 4 weeks' study, I think the comment didn't need to be changed, sorry >> to have

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

zhouyizhou added a comment. After 4 weeks' study, I think the comment didn't need to be changed, sorry to have bring your so much trouble. During this valuable process of studying, I grow up a lot. I learned to read the C++ standard, and compare the standard to its implementation. In my case,

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

zhouyizhou added a comment. my current progress - succesfully build commit cba72b1f620fd on debian6: 1. git checkout cba72b1f620fd 2. download debian-6.0.10-amd64-DVD-1.iso and use it to create a debian6 virtual machine 3. debian6/llvm-project>cp -fr clang llvm/tools 4. modifiy

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

zhouyizhou added a comment. In D133066#3780900 , @aaron.ballman wrote: > In D133066#3768091 , @zhouyizhou > wrote: > >> In D133066#3767146 , >> @aaron.ballman wrote:

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

zhouyizhou added a comment. In D133066#3767146 , @aaron.ballman wrote: > In D133066#3765503 , @zhouyizhou > wrote: > >> In D133066#3764384 , >> @aaron.ballman wrote:

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

zhouyizhou added a comment. In D133066#3764384 , @aaron.ballman wrote: > The existing comment is correct according to my copy of the C++11 standard, > but the standard has changed since C++11 and those words no longer appear in >

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

zhouyizhou created this revision. zhouyizhou added reviewers: MikeStump, riccibruno, rsmith. Herald added a project: All. zhouyizhou requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi I think the comment above the condition expression

[PATCH] D129953: [PATCH] [clang-tidy] NFC: add preposition "of" to code annotation of ElseAfterReturnCheck

zhouyizhou added a comment. Hi, I have no write access to LLVM, could you commit for me at your convenience ;-) Many thanks Zhouyi Zhou Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129953/new/ https://reviews.llvm.org/D129953

[PATCH] D129953: [PATCH] [clang-tidy] NFC: add preposition "of" to code annotation of ElseAfterReturnCheck

zhouyizhou added a comment. In D129953#3657920 , @njames93 wrote: > While you're here could you also put full stops( or periods ) at the end of > the sentences. Thank Nathan for reviewing my patch I am here, and am very happy to make further

[PATCH] D129953: [PATCH] [clang-tidy] NFC: add preposition "of" to code annotation of ElseAfterReturnCheck

zhouyizhou created this revision. zhouyizhou added reviewers: njames93, nridge, alexfh_, stephenkelly. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. zhouyizhou requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D119493: Fixing surplus assert condition in EvaluateTemporary

zhouyizhou updated this revision to Diff 416636. zhouyizhou edited the summary of this revision. zhouyizhou added reviewers: mizvekov, eli.friedman, EricWF, faisalv. Herald added a project: All. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119493/new/ https://reviews.llvm.org/D119493

[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

zhouyizhou added a comment. In D121498#3385896 , @erichkeane wrote: > LGTM! Let me know if you need me to commit this for you (and if so, what > name/email address you'd like it committed under). Thank you for your guidance! I do need you to commit

[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

zhouyizhou updated this revision to Diff 415805. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121498/new/ https://reviews.llvm.org/D121498 Files: clang/lib/AST/Type.cpp clang/test/SemaTemplate/class-template-noexcept.cpp Index: clang/test/SemaTemplate/class-template-noexcept.cpp

[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

zhouyizhou updated this revision to Diff 415677. zhouyizhou edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121498/new/ https://reviews.llvm.org/D121498 Files: clang/lib/AST/Type.cpp clang/test/SemaTemplate/class-template-noexcept.cpp Index:

[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

zhouyizhou updated this revision to Diff 415655. zhouyizhou edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121498/new/ https://reviews.llvm.org/D121498 Files: clang/lib/AST/Type.cpp clang/test/SemaTemplate/class-template-deduction.cpp Index:

[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

zhouyizhou updated this revision to Diff 415601. zhouyizhou edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121498/new/ https://reviews.llvm.org/D121498 Files: clang/lib/AST/Type.cpp clang/test/SemaTemplate/class-template-deduction.cpp Index:

[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

zhouyizhou added a comment. In D121498#3379222 , @erichkeane wrote: > This seems reasonable to me, but can you please add a lit test and fix the > format of the code in your commit message? Thank you for reviewing the patch for me ;-) I am a

[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

zhouyizhou created this revision. zhouyizhou added reviewers: rsmith, erichkeane, CornedBee. Herald added a project: All. zhouyizhou requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When compile following code without -std=c++17, clang will

[PATCH] D119493: Fixing surplus assert condition in EvaluateTemporary

zhouyizhou created this revision. zhouyizhou added reviewers: rsmith, hokein. zhouyizhou requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In LLVM/Clang Debug build, following code will trigger the assert to fire: typedef int I; void foo() {

[PATCH] D115014: [clang] RFC: NFC: simplify macro tokens assignment

zhouyizhou added a comment. In D115014#3169444 , @simon_tatham wrote: > Ah, now I see what you mean – I didn't look far enough! > > I don't know this code well (in fact I'm not sure why you picked me as a > reviewer), but off the top of my head: the

[PATCH] D115014: [clang] RFC: NFC: simplify macro tokens assignment

zhouyizhou added a comment. In D115014#3169400 , @simon_tatham wrote: > I don't think so, I'm afraid. If you look at the definition of > `MacroInfo::tokens_begin()` in `clang/include/clang/Lex/MacroInfo.h`, you see > that it doesn't return a raw

[PATCH] D115014: [clang] RFC: NFC: simplify macro tokens assignment

zhouyizhou created this revision. zhouyizhou added reviewers: lattner, rnk, MaskRay, simon_tatham. zhouyizhou requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I think we could simplify Tokens = &*Macro->tokens_begin() in

[PATCH] D112050: [clang] NFC: return void in an alternative expression after call to void function.

zhouyizhou added a comment. ping Just a ping, to see if there are any comments :-P Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112050/new/ https://reviews.llvm.org/D112050 ___ cfe-commits mailing

[PATCH] D112050: [clang] NFC: return void in an alternative expression after call to void function.

zhouyizhou added a comment. I create this patch because I am also a Linux hobbyist, in Linux kernel, return statement in a void function is always standalone. For example in kernel/event/core.c: static void perf_event_exit_event(struct perf_event *child_event, struct perf_event_context

[PATCH] D112050: [clang] NFC: return void in an alternative expression after call to void function.

zhouyizhou created this revision. zhouyizhou added a reviewer: clang. zhouyizhou requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It is better to return void in an alternative expression after call to void function. Also, I processed

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

zhouyizhou added a comment. In D109408#3018830 , @ldionne wrote: > In D109408#2996128 , @zhouyizhou > wrote: > >> In D109408#2996092 , @Quuxplusone >> wrote: >> >>> I

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

zhouyizhou added a comment. In D109408#2996092 , @Quuxplusone wrote: > I was going to land this just now, but then realized that I've lost the > thread of why we're doing most of this. Why are we touching > clang/test/SemaCXX/? So I'm going to land

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

zhouyizhou added a comment. Hi, I have no write access to LLVM, can you commit D109408 for me? Thanks a lot Zhouyi Zhou Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109408/new/ https://reviews.llvm.org/D109408

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

zhouyizhou added a comment. In D109408#2988417 , @ldionne wrote: > FWIW, I dislike that we don't indent stuff at all inside namespaces -- often > I find it useful to indent things inside short-lived namespaces. But let's go > for simplicity and

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

zhouyizhou added a comment. In D109408#2988417 , @ldionne wrote: > FWIW, I dislike that we don't indent stuff at all inside namespaces -- often > I find it useful to indent things inside short-lived namespaces. But let's go > for simplicity and

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

zhouyizhou created this revision. zhouyizhou added a reviewer: libcxx-commits. zhouyizhou requested review of this revision. Herald added projects: clang, libc++abi. Herald added a subscriber: cfe-commits. Herald added a reviewer: libc++abi. Some functions in cxa_exception_storage.cpp have

[PATCH] D108609: [clang] NFC: remove superfluous braces

zhouyizhou added a comment. Thanks for reviewing I don't have the write access to LLVM, could you please commit this patch for me? Signed-off-by: Zhouyi Zhou Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108609/new/

[PATCH] D108609: [clang] NFC: remove superfluous braces

zhouyizhou created this revision. zhouyizhou added reviewers: pengfei, rsmith, rjmccall, doug.gregor, sepavloff, craig.topper, klimek. zhouyizhou requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang.

[PATCH] D104604: [clang] NFC: add line break at the end of if expressions

zhouyizhou added a comment. In D104604#2849676 , @xgupta wrote: > It seems you need someone to commit this patch? If so you need to share your > name and email address. So that someone with commit access can commit it for > you. Thank you very much, I

[PATCH] D104604: [clang] NFC: add line break at the end of if expressions

zhouyizhou created this revision. zhouyizhou added reviewers: pengfei, rsmith, rjmccall, doug.gregor, sepavloff, craig.topper, klimek. zhouyizhou requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi, In function TransformTemplateArgument,

[PATCH] D102577: NFC: TreeTransform.h: make the switch case more beautiful

zhouyizhou updated this revision to Diff 345792. zhouyizhou retitled this revision from "TreeTransform.h: make the switch case more beautiful " to "NFC: TreeTransform.h: make the switch case more beautiful ". zhouyizhou added a comment. use clang-format to fix the function

[PATCH] D102577: TreeTransform.h: make the switch case more beautiful

zhouyizhou added a comment. I do some "grep" in clang/lib directory: llvm-project/clang/lib#find . -name "*.*"|xargs grep -n -B 2 "break;"|grep -A 2 "}" my patch also seems to match the coding style of other parts of clang. Thanks again CHANGES SINCE LAST ACTION

[PATCH] D102577: TreeTransform.h: make the switch case more beautiful

zhouyizhou updated this revision to Diff 345710. zhouyizhou added a comment. I use git diff -U9 instead CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102577/new/ https://reviews.llvm.org/D102577 Files: clang/lib/Sema/TreeTransform.h Index: clang/lib/Sema/TreeTransform.h

[PATCH] D102577: TreeTransform.h: make the switch case more beautiful

zhouyizhou created this revision. zhouyizhou added reviewers: sepavloff, craig.topper, rsmith, klimek, doug.gregor. Herald added a subscriber: pengfei. zhouyizhou requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi,