This revision was automatically updated to reflect the committed changes.
Closed by commit rGee3e01627ff8: [Clang][ARM] Define __VFP_FP__ macro
unconditionally (authored by vhscampos).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100372/new/
rengolin accepted this revision.
rengolin added a comment.
It's a weird flag, for sure, but if that's the semantics of it, than this
change LGTM. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100372/new/
https://reviews.llvm.org/D100372
vhscampos added a comment.
Thanks Peter. Since one week has passed, I plan to commit these changes by the
end of the day if nothing surfaces.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100372/new/
https://reviews.llvm.org/D100372
vhscampos updated this revision to Diff 337723.
vhscampos added a comment.
Add a clarifying comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100372/new/
https://reviews.llvm.org/D100372
Files:
clang/lib/Basic/Targets/ARM.cpp
peter.smith accepted this revision.
peter.smith added reviewers: compnerd, rengolin.
peter.smith added a comment.
This revision is now accepted and ready to land.
I think this is the right thing to do. GCC changed to unconditionally set the
macro with
vhscampos created this revision.
Herald added subscribers: danielkiss, kristof.beyls.
vhscampos requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Clang only defines __VFP_FP__ when the FPU is enabled. However, gcc
defines it unconditionally.
