[PATCH] D101317: hurd: Fix i386 research path

2021-04-27 Thread Fangrui Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9c552d27ee03: hurd: Fix i386 research path (authored by sthibaul, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101317/new/

[PATCH] D101317: hurd: Fix i386 research path

2021-04-27 Thread Samuel Thibault via Phabricator via cfe-commits
sthibaul added inline comments. Comment at: clang/test/Driver/hurd.c:2 // RUN: %clang -no-canonical-prefixes %s -### 2>&1 \ // RUN: --target=i386-pc-gnu \ // RUN: --sysroot=%S/Inputs/basic_hurd_tree \ MaskRay wrote: > While we currently detects

[PATCH] D101317: hurd: Fix i386 research path

2021-04-27 Thread Samuel Thibault via Phabricator via cfe-commits
sthibaul updated this revision to Diff 340875. sthibaul marked an inline comment as done. sthibaul added a comment. Fix triplet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101317/new/ https://reviews.llvm.org/D101317 Files:

[PATCH] D101317: hurd: Fix i386 research path

2021-04-27 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. `i386-gnu` no longer exists? That's great. Comment at: clang/test/Driver/hurd.c:2 // RUN: %clang -no-canonical-prefixes %s -### 2>&1 \ // RUN: --target=i386-pc-gnu \

[PATCH] D101317: hurd: Fix i386 research path

2021-04-27 Thread Samuel Thibault via Phabricator via cfe-commits
sthibaul added a comment. @MaskRay could you review this one as well? Most others are based on it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101317/new/ https://reviews.llvm.org/D101317 ___

[PATCH] D101317: hurd: Fix i386 research path

2021-04-27 Thread Samuel Thibault via Phabricator via cfe-commits
sthibaul updated this revision to Diff 340751. sthibaul added a comment. Retrigger buildable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101317/new/ https://reviews.llvm.org/D101317 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D101317: hurd: Fix i386 research path

2021-04-27 Thread Samuel Thibault via Phabricator via cfe-commits
sthibaul updated this revision to Diff 340749. sthibaul added a comment. Retrigger buildable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101317/new/ https://reviews.llvm.org/D101317 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D101317: hurd: Fix i386 research path

2021-04-26 Thread Samuel Thibault via Phabricator via cfe-commits
sthibaul created this revision. sthibaul requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. f26341840253 ("[Driver] Gnu.cpp: remove obsoleted i386 triple detection from