[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaefbfbcbd776: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion (authored by nickdesaulniers). Repository: rG LLVM

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

xbolva00 accepted this revision. xbolva00 added a comment. LG in the current state. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387 ___ cfe-commits mailing

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

xbolva00 added inline comments. Comment at: clang/test/Driver/stack-protector-guard.c:38 // CHECK-GS: "-cc1" {{.*}}"-mstack-protector-guard-reg=gs" -// INVALID-REG: error: invalid value {{.*}} in 'mstack-protector-guard-reg=','for X86, valid arguments to

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers marked 7 inline comments as done. nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:279 "-fembed-bitcode is not supported on versions of iOS prior to 6.0">; +def err_drv_negative_columns : Error< +

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

xbolva00 added a comment. Looks better now, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers updated this revision to Diff 342475. nickdesaulniers added a comment. - "expected one of: ..." Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387 Files:

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:279 "-fembed-bitcode is not supported on versions of iOS prior to 6.0">; +def err_drv_negative_columns : Error< +"invalid value '%1' in '%0', value must be 'none' or a

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:279 "-fembed-bitcode is not supported on versions of iOS prior to 6.0">; +def err_drv_negative_columns : Error< +"invalid value '%1' in '%0', value must be 'none' or a positive

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

xbolva00 added inline comments. Comment at: clang/test/Driver/stack-protector-guard.c:38 // CHECK-GS: "-cc1" {{.*}}"-mstack-protector-guard-reg=gs" -// INVALID-REG: error: invalid value {{.*}} in 'mstack-protector-guard-reg=','for X86, valid arguments to

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

xbolva00 added inline comments. Comment at: clang/test/Driver/stack-protector-guard.c:38 // CHECK-GS: "-cc1" {{.*}}"-mstack-protector-guard-reg=gs" -// INVALID-REG: error: invalid value {{.*}} in 'mstack-protector-guard-reg=','for X86, valid arguments to

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. One last nit. Perhaps leave it open for two days in case other reviewers have further comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:279

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers added inline comments. Comment at: clang/test/Driver/stack-protector-guard.c:38 // CHECK-GS: "-cc1" {{.*}}"-mstack-protector-guard-reg=gs" -// INVALID-REG: error: invalid value {{.*}} in 'mstack-protector-guard-reg=','for X86, valid arguments to

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers added inline comments. Comment at: clang/test/Driver/stack-protector-guard.c:38 // CHECK-GS: "-cc1" {{.*}}"-mstack-protector-guard-reg=gs" -// INVALID-REG: error: invalid value {{.*}} in 'mstack-protector-guard-reg=','for X86, valid arguments to

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

xbolva00 added inline comments. Comment at: clang/test/Driver/stack-protector-guard.c:38 // CHECK-GS: "-cc1" {{.*}}"-mstack-protector-guard-reg=gs" -// INVALID-REG: error: invalid value {{.*}} in 'mstack-protector-guard-reg=','for X86, valid arguments to

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers added a comment. In D101387#2731436 , @awarzynski wrote: > In D101387#2730043 , > @nickdesaulniers wrote: > >> @FarisRehman when I run `llvm-lit -vv >> flang/test/Driver/fixed-line-length.f90`

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers updated this revision to Diff 342470. nickdesaulniers added a comment. - trim diag as per @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387 Files:

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

MaskRay added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:218 +def err_drv_invalid_value_with_suggestion : Error< +"invalid value '%1' in '%0', valid values to '%0' are: %2">; def err_drv_invalid_remap_file : Error< Note

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

awarzynski added a comment. In D101387#2730043 , @nickdesaulniers wrote: > @FarisRehman when I run `llvm-lit -vv > flang/test/Driver/fixed-line-length.f90` I see: > > UNSUPPORTED: Flang :: Driver/fixed-line-length.f90 (1 of 1) > > This is with

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:280 +def err_drv_small_columns : Error< +"invalid value '%1' in '%0', expected '%1' to be '%2' or greater">; nickdesaulniers wrote: > xbolva00 wrote: > >

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers added a comment. @FarisRehman when I run `llvm-lit -vv flang/test/Driver/fixed-line-length.f90` I see: UNSUPPORTED: Flang :: Driver/fixed-line-length.f90 (1 of 1) This is with `-DLLVM_ENABLE_PROJECTS="clang;lld;compiler-rt;flang"` used, and a `flang` binary produced. Does

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. Ready for rereview. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:280 +def err_drv_small_columns : Error< +"invalid value '%1' in '%0', expected '%1' to be '%2' or

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:280 +def err_drv_small_columns : Error< +"invalid value '%1' in '%0', expected '%1' to be '%2' or greater">; nickdesaulniers wrote: > xbolva00 wrote: > >

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers marked 4 inline comments as done. nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:280 +def err_drv_small_columns : Error< +"invalid value '%1' in '%0', expected '%1' to be '%2' or greater">;

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers updated this revision to Diff 341742. nickdesaulniers added a comment. - remove extra whitespace, use xbolva00's sugguestion text Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387 Files:

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

rsmith added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3115 D.Diag(diag::err_drv_invalid_value_with_suggestion) - << A->getOption().getName() << Value - << "valid arguments to '-mstack-protector-guard=' are:tls global"; + <<

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:280 +def err_drv_small_columns : Error< +"invalid value '%1' in '%0', expected '%1' to be '%2' or greater">; nickdesaulniers wrote: > xbolva00 wrote: > > invalid

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:280 +def err_drv_small_columns : Error< +"invalid value '%1' in '%0', expected '%1' to be '%2' or greater">; xbolva00 wrote: > invalid value '%1' in '%0',

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:280 +def err_drv_small_columns : Error< +"invalid value '%1' in '%0', expected '%1' to be '%2' or greater">; invalid value '%1' in '%0', value must be '%2' or

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers added a comment. While I appreciate the flexibility afforded by %select; I find the suggestions unreadable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers updated this revision to Diff 341711. nickdesaulniers added a comment. - fix flang diag placeholders Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387 Files: