This revision was automatically updated to reflect the committed changes.
Closed by commit rG13a86c2bb465: [Sema] Preserve invalid CXXCtorInitializers
using RecoveryExpr in initializer (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D101641?vs=364846&id=365457#toc
Re
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4475
// name that denotes that base class type.
- bool Dependent = BaseType->isDependentType() || Init->isTypeDependent()
sammccall added a comment.
Doh, I forgot this never landed :-(
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4475
// name that denotes that base class type.
- bool Dependent = BaseType->isDependentType() || Init->isTypeDependent();
+ bool Dependent = CurContext->isDependent
sammccall updated this revision to Diff 364846.
sammccall added a comment.
Rebase and add clarifying comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101641/new/
https://reviews.llvm.org/D101641
Files:
clang/lib/Sema/SemaDeclCXX.cpp
clang
hokein added a comment.
thanks, this code looks pretty solid, just a question.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4475
// name that denotes that base class type.
- bool Dependent = BaseType->isDependentType() || Init->isTypeDependent();
+ bool Dependent = CurCont
sammccall created this revision.
sammccall added a reviewer: hokein.
sammccall requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Before this patch, CXXCtorInitializers that don't typecheck get discarded in
most cases. In particular:
- typos
