[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

dblaikie added a comment. In D101684#2737868 , @tlively wrote: > In D101684#2737842 , @penzn wrote: > >> I think there is another dimension to this aside from project composition - >> intrinsics have a tendency

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

tlively added a comment. In D101684#2737842 , @penzn wrote: > I think there is another dimension to this aside from project composition - > intrinsics have a tendency to "interact" with their surroundings, and it > better to capture the IR rather than

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

penzn added a comment. I think there is another dimension to this aside from project composition - intrinsics have a tendency to "interact" with their surroundings, and it better to capture the IR rather than the end result. Even if we can verify that simple calls produce instructions we

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

tlively added a comment. I chatted with @dblaikie offline about this just now, and we both think it makes sense to turn this particular test into a C->IR test, then later potentially add a C->Wasm end-to-end test to the cross-project-tests directory created in this WIP stack of diffs:

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

dblaikie added a comment. I thought maybe /some/ of the other targets used end-to-end clang tests to test intrinsics, but I can't seem to find any (they seem to be a small minority, if there are any): grep -r -l intrin.h clang/test/ | xargs grep -L emit-llvm.*FileCheck | xargs grep RUN |

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

aheejin added a comment. In D101684#2732551 , @dblaikie wrote: > In D101684#2732522 , @aheejin wrote: > >> I think there's a clear upside on keeping this within clang/. >> >> 1. As @tlively said, there are many

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

dblaikie added a comment. In D101684#2732522 , @aheejin wrote: > I think there's a clear upside on keeping this within clang/. > > 1. As @tlively said, there are many number of instructions to test and > keeping "C function - LLVM intrinsic" and "LLVM

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

aheejin added a comment. I think there's a clear upside on keeping this within clang/. 1. As @tlively said, there are many number of instructions to test and keeping "C function - LLVM intrinsic" and "LLVM intrinsic - Wasm instruction" tests in sync without autogeneration will be hard and

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

dblaikie added a comment. In D101684#2732408 , @tlively wrote: > In D101684#2732395 , @dblaikie > wrote: > >> In D101684#2732366 , @tlively >> wrote: >> >>> In order to

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

tlively added a comment. In D101684#2732395 , @dblaikie wrote: > In D101684#2732366 , @tlively wrote: > >> In order to get the benefit of this end-to-end test from split tests like >> that, the LLVM test would

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

dblaikie added a comment. In D101684#2732366 , @tlively wrote: > In D101684#2732310 , @dblaikie > wrote: > >>> Assembly tests are generally discouraged in clang, but in this case we >>> actually care about the

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

tlively added a comment. In D101684#2732310 , @dblaikie wrote: >> Assembly tests are generally discouraged in clang, but in this case we >> actually care about the specific instruction being generated from the >> intrinsics. > > I don't think this is a

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

dblaikie added a comment. > Assembly tests are generally discouraged in clang, but in this case we > actually care about the specific instruction being generated from the > intrinsics. I don't think this is a sound reason to add an end-to-end test in clang. The same is true of all clang

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. Wow these are really a lot of instructions! Comment at: clang/test/Headers/wasm.c:2 +// REQUIRES: webassembly-registered-target // expected-no-diagnostics

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

tlively updated this revision to Diff 342121. tlively added a comment. - squash to include all changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101684/new/ https://reviews.llvm.org/D101684 Files: clang/lib/Headers/wasm_simd128.h

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.