[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fd0a010a1ed: [git-clang-format] Do not apply clang-format to symlinks (authored by pirama). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama updated this revision to Diff 343194. pirama added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https://reviews.llvm.org/D101878 Files: clang/docs/ReleaseNotes.rst clang/tools/clang-format/git-cl

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

curdeius added a comment. Oh, I forgot, please add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https://reviews.llvm.org/D101878 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama marked an inline comment as done. pirama added a comment. In D101878#2740133 , @curdeius wrote: > LGTM but let's wait a day or two before landing, so that others can chime in. > Btw, do you have commit rights? If no, please provide "Name " for > c

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM but let's wait a day or two before landing, so that others can chime in. Btw, do you have commit rights? If no, please provide "Name " for commit attribution. Comme

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama marked an inline comment as done. pirama added inline comments. Comment at: clang/tools/clang-format/git-clang-format:345 + for filename in list(dictionary.keys()): +print(os.getcwd()) +if os.path.islink(filename): curdeius wrote: > Is this print

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama updated this revision to Diff 343171. pirama added a comment. Remove debug print(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https://reviews.llvm.org/D101878 Files: clang/tools/clang-format/git-clang-format Index: clang

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

curdeius added inline comments. Comment at: clang/tools/clang-format/git-clang-format:345 + for filename in list(dictionary.keys()): +print(os.getcwd()) +if os.path.islink(filename): Is this print supposed to stay or is it a remnant of print-debugging?

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

HazardyKnusperkeks added a comment. I have not a great knowledge about python, but it looks okay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https://reviews.llvm.org/D101878 ___ cfe-commit

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama updated this revision to Diff 342927. pirama added a comment. Leave two empty lines after filter_symlinks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https://reviews.llvm.org/D101878 Files: clang/tools/clang-format/git-clan

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama created this revision. pirama added reviewers: MyDeveloperDay, srhines. pirama requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes PR46992. Git stores symlinks as text files and we should not format them even if they have one