[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2d0c16e91f3: [clang] p1099 using enum part 2 (authored by urnathan). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 349635. urnathan added a comment. Rebasing again. Please review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241 Files: clang-tools-extra/clangd/FindTarget.cpp clang/include/clang/AST/ASTContext.h

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 349045. urnathan added a comment. rebase and fix conflict CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241 Files: clang-tools-extra/clangd/FindTarget.cpp clang/include/clang/AST/ASTContext.h

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 347406. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241 Files: clang-tools-extra/clangd/FindTarget.cpp clang/include/clang/AST/ASTContext.h clang/include/clang/AST/DeclCXX.h

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 347405. urnathan added a comment. Address davrec's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241 Files: clang-tools-extra/clangd/FindTarget.cpp clang/include/clang/AST/ASTContext.h

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

davrec added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:520-523 + /// Like InstantiatedFromUsingDecl, but for using-enum declarations. Maps + /// from the instantiated using-enum to the templated decl from whence it + /// came. + llvm::DenseMap

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

davrec added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:520-523 + /// Like InstantiatedFromUsingDecl, but for using-enum declarations. Maps + /// from the instantiated using-enum to the templated decl from whence it + /// came. + llvm::DenseMap

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 346985. urnathan added a comment. Fix nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241 Files: clang-tools-extra/clangd/FindTarget.cpp clang/include/clang/AST/ASTContext.h

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan marked an inline comment as done. urnathan added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11632 + // As with enum-decls, we ignore attributes for now. + + auto *Enum = cast(DS.getRepAsDecl()); bruno wrote: > Remove this empty line.

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

bruno accepted this revision. bruno added a reviewer: rsmith. bruno added a comment. This revision is now accepted and ready to land. Thanks for adding the tests. LGTM after some remaining nitpick. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11632 + // As with enum-decls, we

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 346421. urnathan added a comment. Added ASTmatchers for UsingEnumDecl along with unit-tests (both of which I was previously unaware of) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241 Files:

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:4654 + + return ImportUsingShadowDecls(D, ToUsingEnum); } martong wrote: > Could it work if you imported the shadow declarations **before** creating the > `UsingEnumDecl`? I yes, then

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 346107. urnathan added a comment. updating to reset dependency graph and coax build bot into working CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:4654 + + return ImportUsingShadowDecls(D, ToUsingEnum); } Could it work if you imported the shadow declarations **before** creating the `UsingEnumDecl`? I yes, then that would be the

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 345960. urnathan added a comment. rebased, trying to resolve bot failure, again CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 345848. urnathan added a comment. Add serialization test and fix bug so found (thanks Bruno!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 345522. urnathan added a comment. force bot rebuild CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241 Files: clang-tools-extra/clangd/FindTarget.cpp clang/include/clang/AST/ASTContext.h

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan added a comment. I don't understand why the build bot is failing to apply the precursor D101777 diff. that diff is marked as ok by the build bot. How can I find the actual error the build bot is encountering? CHANGES SINCE LAST ACTION

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 345500. urnathan added a comment. Let's try again. Logically this is separate from patch 3, but because that and this touch adjacent lines in the diagnostics file, we need to say patch 3 is a dependency, otherwise we get a conflict. CHANGES SINCE LAST

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 345491. urnathan added a comment. Herald added subscribers: cfe-commits, usaxena95, kadircet. Herald added a project: clang-tools-extra. reupload diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241