This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2db090a2ebd7: [llvm][AsmPrinter] Restore source location to
register clobber warning (authored by DavidSpickett).
Repository:
rG LLVM Github
ychen accepted this revision.
ychen added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102244/new/
https://reviews.llvm.org/D102244
DavidSpickett updated this revision to Diff 345073.
DavidSpickett added a comment.
- Use diagnose instead of adding methods to LLVMContext
- clang-format the test file
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102244/new/
ychen added a comment.
Looks good except for one suggestion and the patch need rebasing on an upstream
commit.
Comment at: llvm/include/llvm/IR/LLVMContext.h:300
+ /// with "warning: " and should not end with a ".".
+ void emitWarning(unsigned LocCookie, const Twine );
+
DavidSpickett updated this revision to Diff 344821.
DavidSpickett added a comment.
Herald added a subscriber: dexonsmith.
- Report via LLVMContext
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102244/new/
https://reviews.llvm.org/D102244
Files:
ychen added inline comments.
Comment at: clang/test/Misc/inline-asm-clobber-warning.c:26
+// CHECK-NEXT: nop
+// CHECK-NEXT: ^
DavidSpickett wrote:
> I think this `^` is wrong because we don't/can't account for the asm printer
> tabbing in the
DavidSpickett added a reviewer: ychen.
DavidSpickett added a comment.
This works as expected, let me know if this is the intended use relative to the
changes you made.
The existing test in llvm `llvm/test/CodeGen/AArch64/inline-asm-clobber.ll`
never reported the location in the .ll file so I
DavidSpickett created this revision.
Herald added a subscriber: hiraditya.
DavidSpickett requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
Since 5de2d189e6ad466a1f0616195e8c524a4eb3cbc0
