[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1af97c9d0b02: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda… (authored by AbbasSabra, committed by vsavchenko).

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added a comment. In D102273#2866532 , @vsavchenko wrote: > Great! Thanks for addressing all of the comments! Thank you for the review! Can you take care of merging it? I don't have the required permission. Repository: rG LLVM Github

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Great! Thanks for addressing all of the comments! Comment at: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp:185-186 + return

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added a comment. @vsavchenko any update on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102273/new/ https://reviews.llvm.org/D102273 ___ cfe-commits mailing list

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102273/new/ https://reviews.llvm.org/D102273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102273/new/ https://reviews.llvm.org/D102273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added a comment. Note: I don't have the right to re-run the failed build/test. I assume that it is not related to my change since the test compile and runs omp code(Static analyzer doesn't run on that test) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added a comment. Herald added a subscriber: manas. In D102273#2766531 , @NoQ wrote: > I've just been patching up clang-tidy's infinite loop checker and the problem > sounds s similar. Maybe we should move clang-tidy's alias analysis into

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

NoQ added a comment. I've just been patching up clang-tidy's infinite loop checker and the problem sounds s similar. Maybe we should move clang-tidy's alias analysis into `libAnalysis` and re-use it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra updated this revision to Diff 345482. AbbasSabra added a comment. Updating D102273 : [analyzer] Update comments + fix typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102273/new/

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp:185-186 + return FD->getType()->isReferenceType(); +} else { + assert(false && "Unknown captured variable"); +} vsavchenko wrote: > AbbasSabra wrote:

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra updated this revision to Diff 345471. AbbasSabra marked 7 inline comments as done. AbbasSabra added a comment. Updating D102273 : [analyzer] Apply code review part 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp:185-186 + return FD->getType()->isReferenceType(); +} else { + assert(false && "Unknown captured variable"); +} AbbasSabra wrote: > vsavchenko wrote:

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

vsavchenko added a comment. Thanks for addressing my comments! I still have some left though Comment at: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp:171 + const Decl *D = LocCtxt->getDecl(); + const auto *MD = dyn_cast_or_null(D); + assert(MD &&

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp:185-186 + return FD->getType()->isReferenceType(); +} else { + assert(false && "Unknown captured variable"); +} vsavchenko wrote: > But actually, it's

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra updated this revision to Diff 345435. AbbasSabra marked 4 inline comments as done. AbbasSabra added a comment. Updating D102273 : [analyzer] Apply code review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

steakhal added a comment. By checking the line coverage of the `LoopUnrolling.cpp` test file, looks like all lines are covered you touched. There are only two return statements uncovered though: L200, L251. We should consider extending this test file to cover them as well in a follow-up patch.

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

vsavchenko added a comment. Great job on the patch! Thanks! Comment at: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp:166-167 -static bool isPossiblyEscaped(const VarDecl *VD, ExplodedNode *N) { +static bool isCapturedByReference(const VarDecl *VD, ExplodedNode *N, +

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

steakhal added reviewers: NoQ, vsavchenko, steakhal. steakhal added a comment. I'm gonna have a look at this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102273/new/ https://reviews.llvm.org/D102273

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, zzheng, szepet, baloghadamsoftware, xazax.hun. AbbasSabra requested review of this revision. Herald added a project: clang. Herald added a