[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

This revision was automatically updated to reflect the committed changes. Closed by commit rGebcf030efc5e: [analyzer] Engine: fix crash with SEH __leave keyword (authored by AbbasSabra, committed by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra added a comment. In D102280#2762760 , @steakhal wrote: > I think it's good to go. Thank you! Great! can you take care of merging it? I don't have accesss. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I think it's good to go. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102280/new/ https://reviews.llvm.org/D102280

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

steakhal added a comment. In D102280#2760402 , @AbbasSabra wrote: > Is it a requirement for you to build them on Linux? Maybe you can try to > build them on windows with !!clang-cl!!? It is a hard requirement. I'm gonna think more about this in the

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra added a comment. > Well, and how can I build them on Linux xD Ah, I don't think they are meant to be built on Linux :D Especially if they rely on Window specific features like SEH. If they do they will disable these features on Linux build. > How do you use clang exactly? I

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

steakhal added a comment. In D102280#2759480 , @AbbasSabra wrote: > In D102280#2759167 , @steakhal > wrote: > >> Do you have any good (mature, big enough) open-source projects for these >> msvc constructs? > >

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra added a comment. In D102280#2759167 , @steakhal wrote: > Do you have any good (mature, big enough) open-source projects for these msvc > constructs? https://github.com/microsoft/winfile and https://github.com/chakra-core/ChakraCore seem to

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra updated this revision to Diff 345422. AbbasSabra added a comment. Updating D102280 : [analyzer] rename test file + make sure that statements after "__leave" are not reached Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

steakhal added a comment. Do you have any good (mature, big enough) open-source projects for these msvc constructs? Comment at: clang/lib/StaticAnalyzer/Core/CoreEngine.cpp:352 + case Stmt::SEHLeaveStmtClass: case Stmt::ContinueStmtClass:

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra marked 2 inline comments as done. AbbasSabra added a comment. > Please, add these reviewers for your upcoming [analyzer] patches. Thanks, I was planning to add reviewers after making sure that the pre-checks are green. > Nice to see some fixes for visual c++ stuff. Thanks for the

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra updated this revision to Diff 345381. AbbasSabra added a comment. Updating D102280 : [analyzer] Apply code review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102280/new/

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

steakhal added reviewers: NoQ, vsavchenko, steakhal. steakhal added a comment. Please, add these reviewers for your upcoming [analyzer] patches. Inline a couple of nits. Nice to see some fixes for visual c++ stuff. Comment at: clang/lib/StaticAnalyzer/Core/CoreEngine.cpp:352

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. AbbasSabra requested review of this revision. Herald added a project: clang. Herald added a subscriber: