This revision was automatically updated to reflect the committed changes.
Closed by commit rGa5a3efa82a77: [Sema] Always search the full function scope
context if a potential… (authored by logan-5).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
I think this is good to go, I haven't observed any issues with this patch so
far in my testing. LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
logan-5 added a comment.
Thanks very much; I look forward to any feedback!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102338/new/
https://reviews.llvm.org/D102338
___
cfe-commits mailing list
arphaman added a comment.
Thanks for the patch! I think the new checking semantics behavior provided by
this patch are fine and match what the Swift compiler allows in the `if
#available` blocks in Swift. I will do some additional testing tomorrow but I'm
hoping I can approve your patch in the
logan-5 created this revision.
logan-5 added reviewers: erik.pilkington, rsmith, arphaman.
logan-5 added a project: clang.
logan-5 requested review of this revision.
Herald added a subscriber: cfe-commits.
Always search the full function scope context if a potential availability
violation is