[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. saudi marked 2 inline comments as done. Closed by commit rG6052a8a53559: [clang] In DependencyCollector on Windows, ignore case and separators when… (authored by

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Ideally we should avoid the ifdef, but we don't have a good proxy for case sensitivity of the filesystem here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102339/new/

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

thakis added a comment. In D102339#2756726 , @aganea wrote: > In D102339#2755867 , @thakis wrote: > >> We share obj files built on linux and on windows. So that's a goal for us. > > Hello @thakis, I believe you

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

saudi updated this revision to Diff 344947. saudi added a comment. Updated for comments from @rnk, except for the canonicalization part. Are you suggesting that the `DependencyCollector` should be called with the already canonicalized paths? There are a few code paths leading to the

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

aganea added a comment. In D102339#2755867 , @thakis wrote: > We share obj files built on linux and on windows. So that's a goal for us. Hello @thakis, I believe you don't use this codepath to generate the cache key, do you? I thought you had a custom

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

thakis added a comment. We share obj files built on linux and on windows. So that's a goal for us. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102339/new/ https://reviews.llvm.org/D102339 ___

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

aganea added inline comments. Comment at: clang/lib/Frontend/DependencyFile.cpp:145 + StringRef SearchPath; +#ifdef _WIN32 + // Make the search insensitive to case and separators. amccarth wrote: > rnk wrote: > > I feel like this should somehow be a property

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

amccarth added inline comments. Comment at: clang/lib/Frontend/DependencyFile.cpp:145 + StringRef SearchPath; +#ifdef _WIN32 + // Make the search insensitive to case and separators. rnk wrote: > I feel like this should somehow be a property of the input

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

rnk added inline comments. Comment at: clang/lib/Frontend/DependencyFile.cpp:145 + StringRef SearchPath; +#ifdef _WIN32 + // Make the search insensitive to case and separators. I feel like this should somehow be a property of the input virtual filesystem: we

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

saudi created this revision. saudi added reviewers: rnk, thakis, dexonsmith, Bigcheese. saudi added a project: clang. saudi requested review of this revision. Herald added a subscriber: cfe-commits. We noticed that the dependency collectors of `clang` may report duplicate paths under Windows,