[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

This revision was automatically updated to reflect the committed changes. Closed by commit rG633ca3ff2f8f: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing… (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks alright, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102356/new/ https://reviews.llvm.org/D102356

[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

hoy updated this revision to Diff 355012. hoy added a comment. Herald added a subscriber: modimo. Added tests for static ctor/dtor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102356/new/ https://reviews.llvm.org/D102356 Files:

[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

dblaikie added a comment. In D102356#2761010 , @hoy wrote: > In D102356#2760973 , @dblaikie > wrote: > >> In D102356#2758371 , @hoy wrote: >> >>> In D102356#2758179

[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

hoy added a comment. In D102356#2760973 , @dblaikie wrote: > In D102356#2758371 , @hoy wrote: > >> In D102356#2758179 , @dblaikie >> wrote: >> >>> This was previously

[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

dblaikie added a comment. In D102356#2758371 , @hoy wrote: > In D102356#2758179 , @dblaikie > wrote: > >> This was previously crashing, I guess? Testing should validate the behavior >> beyond the crash, though

[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

hoy added a comment. In D102356#2758179 , @dblaikie wrote: > This was previously crashing, I guess? Testing should validate the behavior > beyond the crash, though - (presumably there's some more specific behavior > than "does not crash" that wasn't

[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

dblaikie added a comment. This was previously crashing, I guess? Testing should validate the behavior beyond the crash, though - (presumably there's some more specific behavior than "does not crash" that wasn't being tested for before - that certain names are mangled appropriately or

[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

hoy created this revision. Herald added a subscriber: wenlei. hoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. C++ constructors/destructors need to go through a different constructor to construct a GlobalDecl object in order to