[PATCH] D102495: [clang][deps] Support inferred modules

2021-05-20 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/modules-inferred-explicit-build.m:13-15 +// RUN: %clang @%t.inferred.cc1.rsp -pedantic -Werror +// RUN: %clang @%t.system.cc1.rsp -pedantic -Werror +// RUN: %clang -x objective-c -fsyntax-only

[PATCH] D102495: [clang][deps] Support inferred modules

2021-05-19 Thread Frederik Gossen via Phabricator via cfe-commits
frgossen added inline comments. Comment at: clang/test/ClangScanDeps/modules-inferred-explicit-build.m:13-15 +// RUN: %clang @%t.inferred.cc1.rsp -pedantic -Werror +// RUN: %clang @%t.system.cc1.rsp -pedantic -Werror +// RUN: %clang -x objective-c -fsyntax-only

[PATCH] D102495: [clang][deps] Support inferred modules

2021-05-19 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. Re-landed this in c98833cdaad01787ea70ecdfabb05a7e142a6671 after reproducing and fixing the Windows failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102495: [clang][deps] Support inferred modules

2021-05-17 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. In D102495#2763115 , @thakis wrote: > Did you see my message about the windows breakage? Yes, reverted in ccd485e55424b78c07c2f9520faf00b805f78c9b .

[PATCH] D102495: [clang][deps] Support inferred modules

2021-05-17 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Did you see my message about the windows breakage? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102495/new/ https://reviews.llvm.org/D102495 ___ cfe-commits mailing list

[PATCH] D102495: [clang][deps] Support inferred modules

2021-05-17 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. In D102495#2763080 , @thakis wrote: > Looks like this breaks tests on windows: > http://45.33.8.238/win/38908/step_7.txt Thanks for the heads-up. This might be hitting behavior introduced here:

[PATCH] D102495: [clang][deps] Support inferred modules

2021-05-17 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added inline comments. Comment at: clang/utils/module-deps-to-rsp.py:1 +#!/usr/bin/env python + RKSimon wrote: > @Bigcheese - https://lab.llvm.org/buildbot/#/builders/139/builds/4147 doesn't > like this - should this be python3 ? Thanks, that seems

[PATCH] D102495: [clang][deps] Support inferred modules

2021-05-17 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/38908/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102495/new/ https://reviews.llvm.org/D102495 ___

[PATCH] D102495: [clang][deps] Support inferred modules

2021-05-17 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: clang/utils/module-deps-to-rsp.py:1 +#!/usr/bin/env python + @Bigcheese - https://lab.llvm.org/buildbot/#/builders/139/builds/4147 doesn't like this - should this be python3 ? Repository: rG LLVM Github Monorepo

[PATCH] D102495: [clang][deps] Support inferred modules

2021-05-17 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d9e8e13dd7b: [clang][deps] Support inferred modules (authored by Bigcheese, committed by jansvoboda11). Changed prior to commit:

[PATCH] D102495: [clang][deps] Support inferred modules

2021-05-14 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks for splitting out and moving the tool to clang/utils. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102495/new/

[PATCH] D102495: [clang][deps] Support inferred modules

2021-05-14 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds support for inferred modules to the dependency scanner. Effectively a