[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd29f7f1a7b47: [clang] Fix ternary operator in the second for loop statement (authored by danlark, committed by rsmith). Repository: rG LLVM

[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

danlark added a comment. Failure looks unrelated, please submit on your behalf as I don't have commit rights Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102502/new/ https://reviews.llvm.org/D102502

[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

danlark updated this revision to Diff 345568. danlark added a comment. - Address comment from Richard Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102502/new/ https://reviews.llvm.org/D102502 Files: clang/lib/Parse/ParseExprCXX.cpp

[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2036 FRI->LoopVar = Actions.ActOnDeclStmt(DG, DeclStart, Tok.getLocation()); +assert(FRI->ColonLoc.isValid() &&

[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

danlark added a comment. In D102502#2759900 , @rsmith wrote: > Thanks, nice catch! > > Can we also add an assert when parsing a `for` statement that we actually > find a range if the tentative parse said we were expecting one? Done. Repository: rG

[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

danlark updated this revision to Diff 345561. danlark added a comment. - Add assert of finding a for range declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102502/new/ https://reviews.llvm.org/D102502 Files:

[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

danlark added inline comments. Comment at: clang/test/CodeGenCXX/for-loop-init-ternary-operator-statement.cpp:1 +// RUN: %clang_cc1 -triple i386-unknown-unknown -O3 -emit-llvm -o - %s | FileCheck %s + rsmith wrote: > We don't use `-O3` tests for this kind of

[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

danlark updated this revision to Diff 345536. danlark marked 3 inline comments as done. danlark added a comment. - Add codegen and AST tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102502/new/ https://reviews.llvm.org/D102502 Files: