[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

This revision was automatically updated to reflect the committed changes. Closed by commit rG61d1cce2f835: PR45881: Properly use CXXThisOverride for templated lambda (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ http

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

gulfem added a comment. > I'll commit this by the end of the day if @rsmith wasn't able to take a look. Sounds good, thank you very much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ https://reviews.llvm.org/D102531 _

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

ychen added a comment. In D102531#2987367 , @gulfem wrote: > Any update on this review? Our builds are still broken. I'll commit this by the end of the day if @rsmith wasn't able to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

gulfem added a comment. Any update on this review? Our builds are still broken. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ https://reviews.llvm.org/D102531 ___ cfe-commits mailing list cfe

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please wait a day or so before landing in case @rsmith spots something I've missed (the only change I wasn't 100% certain on was lifting the assert predicate; it seems

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

gulfem added a comment. @aaron.ballman would it be possible for you to review this patch, so we can fix our broken builds? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ https://reviews.llvm.org/D102531

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

gulfem added a comment. We recently enabled assertions in our Fuchsia builds, and our builds started to fail: FAILED: obj/src/lib/storage/vfs/cpp/libcpp.fuchsia_vfs.cc.o ../../../recipe_cleanup/clangLhcV7J/bin/clang++ -MD -MF obj/src/lib/storage/vfs/cpp/libcpp.fuchsia_vfs.cc.o.d -D_LIBCPP_

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

ychen updated this revision to Diff 356796. ychen added a comment. - address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ https://reviews.llvm.org/D102531 Files: clang/lib/Sema/SemaExprCXX.cpp clang/lib/Sema/SemaTemplate.

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

tambre added inline comments. Comment at: clang/test/SemaCXX/cxx2a-lambda-decltype-this.cpp:1-4 +// RUN: %clang_cc1 -std=c++2a -fsyntax-only -fblocks -emit-llvm-only %s +// RUN: %clang_cc1 -std=c++2a -fsyntax-only -fblocks -fdelayed-template-parsing %s +// RUN: %clang_cc1 -std=c

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

ychen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ https://reviews.llvm.org/D102531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

ychen added a comment. ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ https://reviews.llvm.org/D102531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

ychen updated this revision to Diff 346010. ychen added a comment. - Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ https://reviews.llvm.org/D102531 Files: clang/lib/Sema/SemaExprCXX.cpp clang/lib/Sema/SemaTemplate

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

aaron.ballman added a comment. Mostly just superficial comments from me at this point. Comment at: clang/lib/Sema/SemaTemplate.cpp:5094-5095 +bool ForLambdaCallOperator = false; +if (CXXRecordDecl *Rec = +dyn_cast(Template->getDeclContext())) + ForLambd

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

ychen created this revision. ychen added reviewers: rsmith, faisalv, aaron.ballman. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - `this` used in lambda expression parameter declarations needs no capture. - Set up CXXThisOverride f