[PATCH] D102568: [Driver] Delete -mimplicit-it=

mstorsjo added inline comments. Comment at: clang/test/Driver/arm-target-as-mimplicit-it.s:18 /// Test comma separated -Wa,- arguments (latter wins). // RUN: %clang -target arm-linux-gnueabi -### -Wa,-mimplicit-it=never,-mimplicit-it=always %s 2>&1 | FileCheck %s

[PATCH] D102568: [Driver] Delete -mimplicit-it=

MaskRay added a comment. In D102568#2769401 , @dblaikie wrote: > Ah, thanks for the history. Yeah, still not sure those bugs are on equal > footing - if the patch had been in for a few months before musl was fixed (If > they're interested in building

[PATCH] D102568: [Driver] Delete -mimplicit-it=

mstorsjo added a comment. In D102568#2769390 , @MaskRay wrote: > In D102568#2769340 , @mstorsjo > wrote: > >> In the meantime, wouldn't it be possible to detect the presence of the other >> one and check if

[PATCH] D102568: [Driver] Delete -mimplicit-it=

dblaikie added a comment. In D102568#2769395 , @MaskRay wrote: > In D102568#2769389 , @dblaikie > wrote: > >> In D102568#2769341 , @MaskRay >> wrote: >> >>> I think

[PATCH] D102568: [Driver] Delete -mimplicit-it=

MaskRay added a comment. In D102568#2769389 , @dblaikie wrote: > In D102568#2769341 , @MaskRay wrote: > >> I think libvpx's ASFLAGS usage is about GNU as, not the driver option. >> >> In D102568#2769296

[PATCH] D102568: [Driver] Delete -mimplicit-it=

MaskRay added a comment. In D102568#2769340 , @mstorsjo wrote: > In the meantime, wouldn't it be possible to detect the presence of the other > one and check if they match or not, to avoid passing duplicate options to the > backend? I can give that a

[PATCH] D102568: [Driver] Delete -mimplicit-it=

dblaikie added a comment. In D102568#2769341 , @MaskRay wrote: > I think libvpx's ASFLAGS usage is about GNU as, not the driver option. > > In D102568#2769296 , @dblaikie > wrote: > >>> I think "waiting for a

[PATCH] D102568: [Driver] Delete -mimplicit-it=

mstorsjo added a comment. In D102568#2769341 , @MaskRay wrote: > I think libvpx's ASFLAGS usage is about GNU as, not the driver option. It is indeed for calling a GNU as-like tool, but at

[PATCH] D102568: [Driver] Delete -mimplicit-it=

MaskRay added a comment. I think libvpx's ASFLAGS usage is about GNU as, not the driver option. In D102568#2769296 , @dblaikie wrote: >> I think "waiting for a few releases" is too much and doesn't improve things >> (they will notice issues until you

[PATCH] D102568: [Driver] Delete -mimplicit-it=

mstorsjo added a comment. In D102568#2769267 , @MaskRay wrote: > I don't mind reverting this temporarily. > However, reverting this would break musl build. > musl (since 2018-09) detects both options and will add both if available: >

[PATCH] D102568: [Driver] Delete -mimplicit-it=

dblaikie added a comment. > I think "waiting for a few releases" is too much and doesn't improve things > (they will notice issues until you remove the option). I can accept "waiting > for one major release". Having fairly broad windows of not breaking backwards compatibility is a fairly

[PATCH] D102568: [Driver] Delete -mimplicit-it=

MaskRay added a comment. In D102568#2769237 , @mstorsjo wrote: > In D102568#2769053 , > @nickdesaulniers wrote: > >>> But this change did break my build in these places: >>>

[PATCH] D102568: [Driver] Delete -mimplicit-it=

mstorsjo added a comment. In D102568#2769053 , @nickdesaulniers wrote: >> But this change did break my build in these places: >> https://code.videolan.org/videolan/x264/-/blob/b684ebe04a6f80f8207a57940a1fa00e25274f81/configure#L855 >>

[PATCH] D102568: [Driver] Delete -mimplicit-it=

nickdesaulniers added a comment. In D102568#2768224 , @mstorsjo wrote: > I would request that this commit should be reverted. Sure, @MaskRay would you mind reverting? > But this change did break my build in these places: >

[PATCH] D102568: [Driver] Delete -mimplicit-it=

mstorsjo added a comment. I would request that this commit should be reverted. > This is a GNU as This is true > and Clang cc1as option, not a GCC option. Users should specify > -Wa,-mimplicit-it= instead. This is not true if you look at any existing stable release - Clang 12.0 doesn't

[PATCH] D102568: [Driver] Delete -mimplicit-it=

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2919222d8017: [Driver] Delete -mimplicit-it= (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102568: [Driver] Delete -mimplicit-it=

raj.khem accepted this revision. raj.khem added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102568/new/ https://reviews.llvm.org/D102568 ___ cfe-commits mailing list

[PATCH] D102568: [Driver] Delete -mimplicit-it=

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Seems fine to me; the only reference in all of Android that looks problematic might be building libaom for windows:

[PATCH] D102568: [Driver] Delete -mimplicit-it=

MaskRay created this revision. MaskRay added reviewers: nickdesaulniers, ostannard, raj.khem. Herald added subscribers: dang, kristof.beyls. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a GNU as and Clang cc1as option,