rsmith added a comment.
Should we also warn about `inline` variables in anonymous namespaces?
Comment at: clang/lib/Sema/SemaDecl.cpp:7127
<< FixItHint::CreateRemoval(D.getDeclSpec().getInlineSpecLoc());
+} else if (SC == SC_Static && DC->isFileContext() &&
+
serberoth added inline comments.
Comment at: clang/lib/Sema/SemaDecl.cpp:7127
<< FixItHint::CreateRemoval(D.getDeclSpec().getInlineSpecLoc());
+} else if (SC == SC_Static && DC->isFileContext() &&
+ getLangOpts().CPlusPlus17) {
erichkeane added inline comments.
Comment at: clang/lib/Sema/SemaDecl.cpp:7127
<< FixItHint::CreateRemoval(D.getDeclSpec().getInlineSpecLoc());
+} else if (SC == SC_Static && DC->isFileContext() &&
+ getLangOpts().CPlusPlus17) {
First,
serberoth created this revision.
serberoth added reviewers: erik.pilkington, rsmith, TH3CHARLie, fixing bugs in
llvm.
serberoth requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Bug 49633 - Added a warning for global and namespace declared
