[PATCH] D102683: [analyzer] Check the checker name, rather than the ProgramPointTag when silencing a checker

2021-05-19 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko added a comment. Oh, I'm late to the party! Glad to see you back @Szelethus ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102683/new/ https://reviews.llvm.org/D102683 ___ cfe-commits

[PATCH] D102683: [analyzer] Check the checker name, rather than the ProgramPointTag when silencing a checker

2021-05-19 Thread Kristóf Umann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG479ea2a8ed95: [analyzer] Check the checker name, rather than the ProgramPointTag when… (authored by Szelethus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102683: [analyzer] Check the checker name, rather than the ProgramPointTag when silencing a checker

2021-05-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Oof. Accurate! > // Would it be more elegant to create the emitting checkers tag here? Mind > that this is a checker that houses many others. I think the checkers should have a right to attach

[PATCH] D102683: [analyzer] Check the checker name, rather than the ProgramPointTag when silencing a checker

2021-05-18 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. While I still see checker silencing as a solution to a problem that shouldn't exist, I'm unsure about the amount of tedious and invasive work required to make the underlying infrastructure elegant just for the sake of it being elegant. Most notably, checker silencing